)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"31e2fa972a668c8715e281356c651cd831578b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"00fdab2a_fc7d0ea8","updated":"2021-10-28 07:49:59.000000000","message":"Hi Jens, thanks for the review. I resolved all issues. Could you have a look again?","commit_id":"df4cf17e4f07db4bfa62c7c3b2db14d2084abff3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d801be69e40d64f1c8bdb892f82a8dec53da3276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0df06460_44b1baa1","updated":"2021-10-28 10:14:16.000000000","message":"lgtm, thx","commit_id":"df4cf17e4f07db4bfa62c7c3b2db14d2084abff3"}],"ansible/roles/grafana/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa0fb81a4a017c7c2856ac23fb548e3b59fc0ac1","unresolved":true,"context_lines":[{"line_number":93,"context_line":"grafana_smtp_password: \"\""},{"line_number":94,"context_line":"grafana_smtp_cert_file: \"\""},{"line_number":95,"context_line":"grafana_smtp_key_file: \"\""},{"line_number":96,"context_line":"grafana_smtp_skip_verify: \"\""},{"line_number":97,"context_line":"grafana_smtp_from_address: \"admin@grafana.localhost\""},{"line_number":98,"context_line":"grafana_smtp_from_name: \"Grafana\""},{"line_number":99,"context_line":"grafana_smtp_ehlo_identity: \"{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"83e42ef5_d90aec8a","line":96,"updated":"2021-10-27 18:24:14.000000000","message":"The default in Grafana for this is false, so make this \"no\" here?","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"31e2fa972a668c8715e281356c651cd831578b4d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"grafana_smtp_password: \"\""},{"line_number":94,"context_line":"grafana_smtp_cert_file: \"\""},{"line_number":95,"context_line":"grafana_smtp_key_file: \"\""},{"line_number":96,"context_line":"grafana_smtp_skip_verify: \"\""},{"line_number":97,"context_line":"grafana_smtp_from_address: \"admin@grafana.localhost\""},{"line_number":98,"context_line":"grafana_smtp_from_name: \"Grafana\""},{"line_number":99,"context_line":"grafana_smtp_ehlo_identity: \"{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"de5467e8_1f530bc4","line":96,"in_reply_to":"83e42ef5_d90aec8a","updated":"2021-10-28 07:49:59.000000000","message":"Done","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"}],"ansible/roles/grafana/templates/grafana.ini.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"af7f619dbd329f51b12219d66e5a210e291d8542","unresolved":true,"context_lines":[{"line_number":50,"context_line":"[alerting]"},{"line_number":51,"context_line":"enabled \u003d false"},{"line_number":52,"context_line":"{% endif -%}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if grafana_enable_smtp | bool %}"},{"line_number":55,"context_line":"[smtp]"},{"line_number":56,"context_line":"enable \u003d true"},{"line_number":57,"context_line":"host \u003d {{ grafana_smtp_host }}"},{"line_number":58,"context_line":"user \u003d {{ grafana_smtp_user }}"},{"line_number":59,"context_line":"password \u003d {{ grafana_smtp_password }}"},{"line_number":60,"context_line":"cert_file \u003d {{ grafana_smtp_cert_file }}"},{"line_number":61,"context_line":"key_file \u003d {{ grafana_smtp_key_file }}"},{"line_number":62,"context_line":"skip_verify \u003d {{ grafana_smtp_skip_verify | bool }}"},{"line_number":63,"context_line":"from_address \u003d {{ grafana_smtp_from_address }}"},{"line_number":64,"context_line":"from_name \u003d {{ grafana_smtp_from_name }}"},{"line_number":65,"context_line":"ehlo_identity \u003d {{ grafana_smtp_ehlo_identity }}"},{"line_number":66,"context_line":"startTLS_policy \u003d {{ grafana_smtp_starttls_policy }}"},{"line_number":67,"context_line":"{% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1b715c64_83005704","line":67,"range":{"start_line":53,"start_character":0,"end_line":67,"end_character":12},"updated":"2021-12-21 11:12:30.000000000","message":"Wondering if it would be simpler to just handle this via custom service configuration file, /etc/kolla/config/grafana.ini.\n\nSome things to consider:\n* does this cover all of the options that may be necessary? If not, custom config may be required anyway\n* do the defaults provided here work in most cases, therefore saving some effort?","commit_id":"df4cf17e4f07db4bfa62c7c3b2db14d2084abff3"},{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"289e99ae42d5aed0de729bdcb912790586e687e0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"[alerting]"},{"line_number":51,"context_line":"enabled \u003d false"},{"line_number":52,"context_line":"{% endif -%}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if grafana_enable_smtp | bool %}"},{"line_number":55,"context_line":"[smtp]"},{"line_number":56,"context_line":"enable \u003d true"},{"line_number":57,"context_line":"host \u003d {{ grafana_smtp_host }}"},{"line_number":58,"context_line":"user \u003d {{ grafana_smtp_user }}"},{"line_number":59,"context_line":"password \u003d {{ grafana_smtp_password }}"},{"line_number":60,"context_line":"cert_file \u003d {{ grafana_smtp_cert_file }}"},{"line_number":61,"context_line":"key_file \u003d {{ grafana_smtp_key_file }}"},{"line_number":62,"context_line":"skip_verify \u003d {{ grafana_smtp_skip_verify | bool }}"},{"line_number":63,"context_line":"from_address \u003d {{ grafana_smtp_from_address }}"},{"line_number":64,"context_line":"from_name \u003d {{ grafana_smtp_from_name }}"},{"line_number":65,"context_line":"ehlo_identity \u003d {{ grafana_smtp_ehlo_identity }}"},{"line_number":66,"context_line":"startTLS_policy \u003d {{ grafana_smtp_starttls_policy }}"},{"line_number":67,"context_line":"{% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3f708c27_93a4a215","line":67,"range":{"start_line":53,"start_character":0,"end_line":67,"end_character":12},"in_reply_to":"1b715c64_83005704","updated":"2022-01-14 10:24:35.000000000","message":"It does catch most of the configuration options. But surely not all of them. A custom service config file would give the users full control. I can change the PR to include that.","commit_id":"df4cf17e4f07db4bfa62c7c3b2db14d2084abff3"}],"doc/source/reference/logging-and-monitoring/grafana-guide.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa0fb81a4a017c7c2856ac23fb548e3b59fc0ac1","unresolved":true,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   grafana_enable_unified_alerts: \"yes\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If you want to be notified via Email about alerts, modify the configuration"},{"line_number":65,"context_line":"file ``/etc/kolla/globals.yml`` and change the following:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: yaml"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8261f630_213ec4a7","line":65,"range":{"start_line":64,"start_character":51,"end_line":65,"end_character":56},"updated":"2021-10-27 18:24:14.000000000","message":"Repeating the same text as above isn\u0027t necessary IMO, just use \"..., set:\"?","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"31e2fa972a668c8715e281356c651cd831578b4d","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   grafana_enable_unified_alerts: \"yes\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If you want to be notified via Email about alerts, modify the configuration"},{"line_number":65,"context_line":"file ``/etc/kolla/globals.yml`` and change the following:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: yaml"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"897fb5e9_045ce073","line":65,"range":{"start_line":64,"start_character":51,"end_line":65,"end_character":56},"in_reply_to":"8261f630_213ec4a7","updated":"2021-10-28 07:49:59.000000000","message":"Done","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa0fb81a4a017c7c2856ac23fb548e3b59fc0ac1","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: yaml"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"   grafana_enable_smtp: \"yes\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Email recipients and other contact points can be configured in the Grafana web"},{"line_number":72,"context_line":"interface. For more informations about unified alerts, see Grafana"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2d8dd63a_01c44f60","line":69,"updated":"2021-10-27 18:24:14.000000000","message":"Maybe also mention the other grafana_smtp_* options that need to be set? Also a link to https://grafana.com/docs/grafana/latest/administration/configuration/#smtp","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"31e2fa972a668c8715e281356c651cd831578b4d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: yaml"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"   grafana_enable_smtp: \"yes\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Email recipients and other contact points can be configured in the Grafana web"},{"line_number":72,"context_line":"interface. For more informations about unified alerts, see Grafana"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ea02394_d69bb973","line":69,"in_reply_to":"2d8dd63a_01c44f60","updated":"2021-10-28 07:49:59.000000000","message":"Done","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa0fb81a4a017c7c2856ac23fb548e3b59fc0ac1","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Email recipients and other contact points can be configured in the Grafana web"},{"line_number":72,"context_line":"interface. For more informations about unified alerts, see Grafana"},{"line_number":73,"context_line":"documenation:"},{"line_number":74,"context_line":"`Grafana 8 alerts \u003chttps://grafana.com/docs/grafana/latest/alerting/unified-alerting/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"65dd6278_6321618a","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":12},"updated":"2021-10-27 18:24:14.000000000","message":"documentation","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"},{"author":{"_account_id":33710,"name":"Uwe Grawert","email":"grawert@b1-systems.de","username":"ugrawert"},"change_message_id":"31e2fa972a668c8715e281356c651cd831578b4d","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Email recipients and other contact points can be configured in the Grafana web"},{"line_number":72,"context_line":"interface. For more informations about unified alerts, see Grafana"},{"line_number":73,"context_line":"documenation:"},{"line_number":74,"context_line":"`Grafana 8 alerts \u003chttps://grafana.com/docs/grafana/latest/alerting/unified-alerting/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"d38dc968_bb9fcccd","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":12},"in_reply_to":"65dd6278_6321618a","updated":"2021-10-28 07:49:59.000000000","message":"Done","commit_id":"7f04e413af273b04ceee143d3a74d231a75abe7b"}]}