)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"96318bd083a305c6f4f642a1caac043d55c2456a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbf59d11_a4fd2427","updated":"2021-11-04 21:54:03.000000000","message":"recheck","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"77b195e50634939d57e556895d71c35bac033807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22780c35_57e72944","updated":"2021-11-24 18:07:58.000000000","message":"thanks for doing this!","commit_id":"d4a2c1403942107bbc26019b93a896f73361d3c3"}],"tools/kolla-ansible":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"37c85ddf3dbad188b054d9ff632ea1a878efacc8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aa2ac7dd_17a638bb","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"updated":"2021-11-09 10:24:01.000000000","message":"Is this ever called more than once?","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ba2911d63f5d382a77c2ed80c885603b9c5566c5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4ec5ebc7_44607649","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"in_reply_to":"711778a7_91d3cffd","updated":"2021-11-09 13:25:13.000000000","message":"Done","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"ba2911d63f5d382a77c2ed80c885603b9c5566c5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"82120d7e_9114b619","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"in_reply_to":"711778a7_91d3cffd","updated":"2021-11-09 13:25:13.000000000","message":"Done","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22cbf9e95fd36dd96c75c5e2a621141db6bf5d6b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cc10a271_74f1ca73","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"in_reply_to":"82120d7e_9114b619","updated":"2021-11-11 09:13:59.000000000","message":"I would say this caching is unnecessary optimisation for only the --version argument, but never mind.","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"f940380e5cce32c0ae45025782980096ee4de66a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"711778a7_91d3cffd","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"in_reply_to":"aa2ac7dd_17a638bb","updated":"2021-11-09 10:32:36.000000000","message":"The function is called from two places below.\nI\u0027m also avoiding direct global var usage with this function and also\nthe dilema: is this global var alreay initialized?","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"cc65c0658ca4e7f09ba5fb8a407f3ac01f68c53f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# do not use _PYTHON_BIN directly, use $(get_python_bin) instead"},{"line_number":6,"context_line":"_PYTHON_BIN\u003d\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function get_python_bin {"},{"line_number":9,"context_line":"    if [ -n \"$_PYTHON_BIN\" ]; then"},{"line_number":10,"context_line":"      echo -n \"$_PYTHON_BIN\""},{"line_number":11,"context_line":"      return"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ffc51ef5_73ffdc65","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":23},"in_reply_to":"cc10a271_74f1ca73","updated":"2021-11-11 12:57:17.000000000","message":"Well, it\u0027s called twice and could be more in the future. So this small caching optimization won\u0027t hurt and code is also pretty clean. Thanks.","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ec1701c79adc95259aeab3a7963eb0df8c56e78","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    --vault-password-file \u003cpath\u003e       Specify password file for vault decrypt"},{"line_number":156,"context_line":"    --check, -C                        Don\u0027t make any changes and try to predict some of the changes that may occur instead"},{"line_number":157,"context_line":"    --diff, -D                         Show differences in ansible-playbook changed tasks"},{"line_number":158,"context_line":"    --version                          Show version"},{"line_number":159,"context_line":"    --verbose, -v                      Increase verbosity of ansible-playbook"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Environment variables:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c33ac902_6dd32077","line":158,"updated":"2021-11-15 11:22:28.000000000","message":"put this after \"--verbose\" for consistency with the list below and local ordering?","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"679a1fb1181368c032449280016191e0da10fc26","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    --vault-password-file \u003cpath\u003e       Specify password file for vault decrypt"},{"line_number":156,"context_line":"    --check, -C                        Don\u0027t make any changes and try to predict some of the changes that may occur instead"},{"line_number":157,"context_line":"    --diff, -D                         Show differences in ansible-playbook changed tasks"},{"line_number":158,"context_line":"    --version                          Show version"},{"line_number":159,"context_line":"    --verbose, -v                      Increase verbosity of ansible-playbook"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Environment variables:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c3a93e52_af094c3a","line":158,"in_reply_to":"c33ac902_6dd32077","updated":"2021-11-15 11:38:06.000000000","message":"sure","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ec1701c79adc95259aeab3a7963eb0df8c56e78","unresolved":true,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    local version"},{"line_number":245,"context_line":"    version\u003d$($python_bin -c \u0027from kolla_ansible.version import version_info; print(version_info)\u0027)"},{"line_number":246,"context_line":"    echo \"$version\""},{"line_number":247,"context_line":"}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"check_environment_coherence"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"76c6fc23_2582bbf3","line":246,"updated":"2021-11-15 11:22:28.000000000","message":"why do you save the output into a variable just to echo it again?\nsimply running \"$python_bin -c ...\" should be fine","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"679a1fb1181368c032449280016191e0da10fc26","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    local version"},{"line_number":245,"context_line":"    version\u003d$($python_bin -c \u0027from kolla_ansible.version import version_info; print(version_info)\u0027)"},{"line_number":246,"context_line":"    echo \"$version\""},{"line_number":247,"context_line":"}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"check_environment_coherence"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"18db1ce1_c652aaff","line":246,"in_reply_to":"76c6fc23_2582bbf3","updated":"2021-11-15 11:38:06.000000000","message":"Variable assignment is normally used just for code clarity. But here the function is short enough that it\u0027s indeed obvious.","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ec1701c79adc95259aeab3a7963eb0df8c56e78","unresolved":true,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    (--version)"},{"line_number":388,"context_line":"            version"},{"line_number":389,"context_line":"            shift"},{"line_number":390,"context_line":"            exit 0"},{"line_number":391,"context_line":"            ;;"},{"line_number":392,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"743cc66a_f5e68587","line":389,"updated":"2021-11-15 11:22:28.000000000","message":"--help does the same thing below, but does it really have any effect to shift right before exiting?","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"},{"author":{"_account_id":29880,"name":"Adrian Andreias","email":"adrian@fleio.com","username":"adrian-fleio"},"change_message_id":"679a1fb1181368c032449280016191e0da10fc26","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    (--version)"},{"line_number":388,"context_line":"            version"},{"line_number":389,"context_line":"            shift"},{"line_number":390,"context_line":"            exit 0"},{"line_number":391,"context_line":"            ;;"},{"line_number":392,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d506b3a7_ad321315","line":389,"in_reply_to":"743cc66a_f5e68587","updated":"2021-11-15 11:38:06.000000000","message":"indeed","commit_id":"eb6de7b1d1202102746ed448ff0a3174673bcf96"}]}