)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6519fa1ae5585b649378689cc088bfa642ff3056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc19d1bc_fa2a587a","updated":"2021-11-19 08:22:45.000000000","message":"Since it\u0027s a bug - we\u0027re missing a reno.\nDocs also need to be updated (Neutron guide - ML2/OVN section).","commit_id":"a6ab00ae1788d3effa29dfb1915c503d431e3ec1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"27ca756f65e8dc2d38743e4c8466d234837cb465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa9b4c5a_788c1044","updated":"2021-11-18 20:42:13.000000000","message":"recheck centos mirror fixed","commit_id":"a6ab00ae1788d3effa29dfb1915c503d431e3ec1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"88283b6ad1de52d6833c070167632ea295255073","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12bcadc0_af81917d","updated":"2022-01-03 17:34:18.000000000","message":"Wait a moment, what happened with going with the same approach as we have in ML2/OVS?\n\nWe\u0027re setting dnsmasq_dns_servers \u003d {{ neutron_dnsmasq_dns_servers }} in dhcp-agent.ini - so why not just define a variable neutron_dns_servers, update neutron_dnsmasq_dns_servers to point to the new variable - and use a common default for both ML2/OVS and ML2/OVN?","commit_id":"d546a8b2d26f35ad55025d3c8b75199066122018"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e356d6ca9ff4511cf71e65650f05c7fa5e13a0ae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d6f814de_daca09f5","in_reply_to":"12bcadc0_af81917d","updated":"2022-01-03 17:36:58.000000000","message":"Good point.","commit_id":"d546a8b2d26f35ad55025d3c8b75199066122018"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2cda927f65b56d3bbec06f86aa11d9d5a7ace8c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c2b1ecef_e8a66a71","in_reply_to":"27ea580d_608b578b","updated":"2022-01-07 17:50:56.000000000","message":"I think I agree with frickler more. It is best users tinkering with networking actually understand what they are doing.","commit_id":"d546a8b2d26f35ad55025d3c8b75199066122018"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"10d94e241b5e406b9ba7ba936df45f4499cd94d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"27ea580d_608b578b","in_reply_to":"d6f814de_daca09f5","updated":"2022-01-03 18:42:31.000000000","message":"I considered that, but the use is really quite different. neutron_dnsmasq_dns_servers is what the Neutron DHCP-Agent uses as forwarders while responding to instances from its own addresses, so tenants never see those addresses.\n\nIn contrast, neutron_ovn_dns_servers are the addresses that OVN tells the instances to use as DNS servers via the DHCP response.\n\nIf you tell me: \"Bah, nobody cares about those details, DNS is DNS\", you might be able to convince me, but I\u0027d really prefer to keep the patch like it is now.","commit_id":"d546a8b2d26f35ad55025d3c8b75199066122018"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f0f75ff7516362b9cfe83b695f9dde84c4ecc603","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"04c3be41_5e7e2fe8","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"updated":"2021-11-22 11:24:48.000000000","message":"what\u0027s that default? For neutron_dnsmasq_dns_servers we have \"1.1.1.1,8.8.8.8,8.8.4.4\" - shouldn\u0027t we have the same defaults?","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"70360190b0bce5191b1c1ad1a9a3476ee37fa1a9","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c998111a_43718341","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"0015d929_2e422240","updated":"2022-01-27 06:46:27.000000000","message":"Well then either we default to empty variable and | length \u003e 0 in the template, or we start with a sensible default (similar to ML2/OVS one) with a proper reno and docs entry (for those that will break). Which one is it?","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76ed2fb1592c1d69645f2a94dafc69c801fa821a","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ca64dbf_675bed93","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"04c3be41_5e7e2fe8","updated":"2021-11-22 13:05:19.000000000","message":"I took the default from the neutron docs https://docs.openstack.org/neutron/latest/admin/config-dns-res.html , I wasn\u0027t aware that kolla has other defaults, I will adapt those instead. Or should we rather use the same default as neutron? I\u0027m not sure that defaulting to Cloudflare and Google is a very reasonable choice.","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3cd37fad6c182339b431b174161d7e1ddb09f464","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d70c91b7_3bfd65ac","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"1ca64dbf_675bed93","updated":"2021-11-22 13:09:38.000000000","message":"Let\u0027s do the same what we have for ML2/OVS - defaulting to non working DNS (203.0.113.8 is Test-Net-3 for documentation purposes) probably won\u0027t help either ;-)","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7351908ec8c92727e400a560ad9c39a5170e4141","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0015d929_2e422240","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"4187b761_e4b9a316","updated":"2022-01-25 10:15:00.000000000","message":"It\u0027s broken in some cases, in others maybe the correct internal DNS config is used already and this change would break them.","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fea77395e3b50bd81f3c91a251f5f0c4630d5d1b","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4187b761_e4b9a316","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"64178e52_ba83cd48","updated":"2022-01-25 09:59:05.000000000","message":"Well the reason to set this by default is that the old default is broken, see the linked bug. I\u0027d prefer to have a working deployment by default instead of just documenting how to make it work.","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ce3034238a2df3b02d4ff7dd0e683fc1bc255d55","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9045af2a_cdccf6cf","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"c998111a_43718341","updated":"2022-01-27 08:27:15.000000000","message":"Let\u0027s go with not adding this variable at all and just documenting the OVN\u0027s behaviour properly (so that operators get to know this detail and how to control it), i.e., show that config override can be used here (it\u0027s what we have it for).","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5119dbf0c65b5ef589ddaeeb6488b429769138b6","unresolved":true,"context_lines":[{"line_number":740,"context_line":"# OVN"},{"line_number":741,"context_line":"######################"},{"line_number":742,"context_line":"neutron_ovn_dhcp_agent: \"no\""},{"line_number":743,"context_line":"neutron_ovn_dns_servers: \"203.0.113.8, 198.51.100.53\""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"####################"},{"line_number":746,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"64178e52_ba83cd48","line":743,"range":{"start_line":743,"start_character":0,"end_line":743,"end_character":53},"in_reply_to":"d70c91b7_3bfd65ac","updated":"2022-01-25 09:40:28.000000000","message":"There is a difference between dns_servers for OVN and dnsmasq_dns_servers for OVS. The former gets passed to instances via DHCP options, whereas the latter is used by the DHCP agent to proxy DNS requests.\n\nShould we even set a default here? Or just document that you may want to set the option?","commit_id":"5020cfca0521431c05a8a8ce158565e3f88981b9"}],"ansible/roles/neutron/templates/ml2_conf.ini.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ea9ab53b6fc3e9f9e4274e0f8901d64c1f575b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"max_header_size \u003d 38"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ovn]"},{"line_number":39,"context_line":"dns_servers \u003d {{ neutron_ovn_dns_servers | default(omit) }}"},{"line_number":40,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":41,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":42,"context_line":"ovn_metadata_enabled \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"815f452e_b1fb969c","line":39,"range":{"start_line":39,"start_character":41,"end_line":39,"end_character":56},"updated":"2022-01-01 15:51:04.000000000","message":"this will not work; first of all, it will not be triggered as the variable is always defined; secondly, \"omit\" only works as ansible module argument - outside of that scope the magic string is not interpreted and would confuse neutron","commit_id":"8dab91e577af6849c6a13b1fa7a6f7a83fd61513"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f51dd8826f76d8e90c2c9f8a2e6c1bab82e663d2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"max_header_size \u003d 38"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ovn]"},{"line_number":39,"context_line":"dns_servers \u003d {{ neutron_ovn_dns_servers | default(omit) }}"},{"line_number":40,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":41,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":42,"context_line":"ovn_metadata_enabled \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f76f062a_df046604","line":39,"range":{"start_line":39,"start_character":41,"end_line":39,"end_character":56},"in_reply_to":"6f33a7c5_f9406c4f","updated":"2022-01-03 08:12:14.000000000","message":"Let\u0027s use \"if\", it will be safer (I hope).\n\n\"default\" will work like you said if and only if you set its second argument to \"true\" (then it will consider falsey values as undefined and change them to the default).","commit_id":"8dab91e577af6849c6a13b1fa7a6f7a83fd61513"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9f5ba0f9925f38b6ef4ca4280b2098ebe78b60c7","unresolved":true,"context_lines":[{"line_number":36,"context_line":"max_header_size \u003d 38"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ovn]"},{"line_number":39,"context_line":"dns_servers \u003d {{ neutron_ovn_dns_servers | default(omit) }}"},{"line_number":40,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":41,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":42,"context_line":"ovn_metadata_enabled \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6f33a7c5_f9406c4f","line":39,"range":{"start_line":39,"start_character":41,"end_line":39,"end_character":56},"in_reply_to":"815f452e_b1fb969c","updated":"2022-01-03 07:37:10.000000000","message":"Hmm, o.k., so should I wrap this in another \"if\" block instead? Or are you fine with always setting this variable?\n\nAlso, according to ansible docs, \"default(omit)\" should also work if the variable is defined but empty. But I agree that this is the wrong scope here.","commit_id":"8dab91e577af6849c6a13b1fa7a6f7a83fd61513"}],"doc/source/reference/networking/neutron.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a57f6b6283c923e7650eba2cbaa7a0d9a9848acd","unresolved":true,"context_lines":[{"line_number":141,"context_line":"used as a compute service. Currently OVN is not able to answer DHCP"},{"line_number":142,"context_line":"queries on port type external, this is where Neutron agent helps."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Since OVN can not use the host\u0027s networking in order to forward DNS"},{"line_number":145,"context_line":"queries from instances, there is a special setting indicating which"},{"line_number":146,"context_line":"nameservers should be announced to instances via DHCP:"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"923ddbb6_1df93afe","line":144,"range":{"start_line":144,"start_character":10,"end_line":144,"end_character":17},"updated":"2021-12-31 09:09:27.000000000","message":"nit: \"cannot\"","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9ce282fb33c4ef2f831988dbf0322304dfb41c1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"used as a compute service. Currently OVN is not able to answer DHCP"},{"line_number":142,"context_line":"queries on port type external, this is where Neutron agent helps."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Since OVN can not use the host\u0027s networking in order to forward DNS"},{"line_number":145,"context_line":"queries from instances, there is a special setting indicating which"},{"line_number":146,"context_line":"nameservers should be announced to instances via DHCP:"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a94fc76_2571446f","line":144,"range":{"start_line":144,"start_character":10,"end_line":144,"end_character":17},"in_reply_to":"923ddbb6_1df93afe","updated":"2022-01-01 14:25:14.000000000","message":"Done","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"}],"releasenotes/notes/neutron_ovn_dns_servers-da20288fe5664162.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a57f6b6283c923e7650eba2cbaa7a0d9a9848acd","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    backend."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    When using OVN as network backend, name resolution on instances was broken"},{"line_number":10,"context_line":"    unless a subnet explicitly specified working resolver addresses. This was"},{"line_number":11,"context_line":"    fixed by adding a config option ``neutron_ovn_dns_servers`` that specifies"},{"line_number":12,"context_line":"    which nameservers should be used by instances. See"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e1d296e5_7491853b","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":72},"updated":"2021-12-31 09:09:27.000000000","message":"could be","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9ce282fb33c4ef2f831988dbf0322304dfb41c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    backend."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    When using OVN as network backend, name resolution on instances was broken"},{"line_number":10,"context_line":"    unless a subnet explicitly specified working resolver addresses. This was"},{"line_number":11,"context_line":"    fixed by adding a config option ``neutron_ovn_dns_servers`` that specifies"},{"line_number":12,"context_line":"    which nameservers should be used by instances. See"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"62ae7971_7a0817c3","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":72},"in_reply_to":"e1d296e5_7491853b","updated":"2022-01-01 14:25:14.000000000","message":"Done","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a57f6b6283c923e7650eba2cbaa7a0d9a9848acd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9921fa4_3adc7c7e","line":15,"updated":"2021-12-31 09:09:27.000000000","message":"let\u0027s also add an \"upgrade\" section as this changes the behaviour; for some folks the previous default could be worky (i.e., they did not have loopback in resolv.conf)","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ea9ab53b6fc3e9f9e4274e0f8901d64c1f575b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51bba8a7_35b8ab5c","line":15,"in_reply_to":"494f0cd1_60d0ce78","updated":"2022-01-01 15:51:04.000000000","message":"I commented on \"default(omit)\" above.","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9ce282fb33c4ef2f831988dbf0322304dfb41c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"494f0cd1_60d0ce78","line":15,"in_reply_to":"c9921fa4_3adc7c7e","updated":"2022-01-01 14:25:14.000000000","message":"Good point, done, also added the \"default(omit)\" filter to allow deployers to actually keep the old default.","commit_id":"1c7553df23d0fb54c6872bfe8ac04f0b1362045f"}]}