)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"894dc57f69085d8d43e7412b73165c1fc2b907b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cfa794c9_10529755","updated":"2022-02-21 14:24:56.000000000","message":"It didn\u0027t like type\u003ddir:\n\nERROR! Failed to find the collection dir deps: The collection galaxy.yml path \u0027file:///home/zuul/src/opendev.org/openstack/ansible-collection-kolla/galaxy.yml\u0027 does not exist.\nERROR: Failed to install Ansible Galaxy dependencies","commit_id":"d7a606d0177ab96167729f88fba7cb0bd327f82f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e6dde7817b00844424fa0f81efe66ea4bfe4488d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"81f37a2a_59485f6e","updated":"2022-02-21 11:45:45.000000000","message":"thanks, lgtm","commit_id":"d7a606d0177ab96167729f88fba7cb0bd327f82f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d822a1793b38ab89ab5d0a70857feb675c176a9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"defd768f_ac780f3f","in_reply_to":"cfa794c9_10529755","updated":"2022-02-21 14:27:41.000000000","message":"Local testing suggests I need to drop the file:// prefix when type\u003ddir.","commit_id":"d7a606d0177ab96167729f88fba7cb0bd327f82f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3da23ec98b8f1971f3ea87474813c5865cfac6b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6e228cef_54fd75c6","updated":"2022-02-21 19:10:34.000000000","message":"recheck\n\nduh!","commit_id":"f63f1f3082ab38e88e4c933409f8c83c3da01999"}],"requirements.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"collections:"},{"line_number":3,"context_line":"  - name: https://opendev.org/openstack/ansible-collection-kolla"},{"line_number":4,"context_line":"    type: git"},{"line_number":5,"context_line":"    version: master"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3494a2b5_f4e08a7a","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"updated":"2022-02-17 12:36:03.000000000","message":"need to document that we need to update this on branching","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"collections:"},{"line_number":3,"context_line":"  - name: https://opendev.org/openstack/ansible-collection-kolla"},{"line_number":4,"context_line":"    type: git"},{"line_number":5,"context_line":"    version: master"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"34db84a0_92b07173","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"in_reply_to":"3494a2b5_f4e08a7a","updated":"2022-02-21 11:41:18.000000000","message":"I\u0027ll propose a patch to kolla.","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"}],"tests/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fdfb3c6202a2a8a9ab38dfd277e57c8522228093","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      set_fact:"},{"line_number":73,"context_line":"        need_build_image: true"},{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name !\u003d \"kolla-ansible\""},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # NOTE(yoctozepto): required to template template_overrides.j2 for Zuul"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d0df1f4a_4fac5abe","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":52},"updated":"2021-12-20 16:57:07.000000000","message":"Check should include ansible-collection-kolla and kayobe.","commit_id":"267ddde0c1898b90e74fe94957b1a9d91730753f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bedf4618fd1cf55bbcca87ee365e114c3230db48","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      set_fact:"},{"line_number":73,"context_line":"        need_build_image: true"},{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"792e6965_df2f3710","line":75,"updated":"2022-02-17 09:27:58.000000000","message":"amend the comment accordingly?","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      set_fact:"},{"line_number":73,"context_line":"        need_build_image: true"},{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bdaa16cb_88baae05","line":75,"in_reply_to":"792e6965_df2f3710","updated":"2022-02-17 12:36:03.000000000","message":"++","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      set_fact:"},{"line_number":73,"context_line":"        need_build_image: true"},{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"58aad8ca_8cc8c22f","line":75,"in_reply_to":"bdaa16cb_88baae05","updated":"2022-02-21 11:41:18.000000000","message":"Done","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # NOTE(yoctozepto): required to template template_overrides.j2 for Zuul"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1cbc7e09_ca206c09","line":77,"range":{"start_line":77,"start_character":71,"end_line":77,"end_character":77},"updated":"2022-02-17 12:36:03.000000000","message":"not that it would be the case in the current config but ok","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # NOTE(yoctozepto): required to template template_overrides.j2 for Zuul"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3c262459_b25d3e9c","line":77,"range":{"start_line":77,"start_character":71,"end_line":77,"end_character":77},"in_reply_to":"1cbc7e09_ca206c09","updated":"2022-02-21 11:41:18.000000000","message":"If a kolla-ansible patch depends-on a kayobe patch, it will end up in items.","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9b1d093db7e2e1f9f16ce131dc87c9f7d727a5b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      when:"},{"line_number":75,"context_line":"        # NOTE(yoctozepto): if there is any tested change that does not belong to kolla-ansible,"},{"line_number":76,"context_line":"        # then kolla images should be built"},{"line_number":77,"context_line":"        - item.project.short_name not in [\"ansible-collection-kolla\", \"kayobe\", \"kolla-ansible\"]"},{"line_number":78,"context_line":"      with_items: \"{{ zuul[\u0027items\u0027] }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # NOTE(yoctozepto): required to template template_overrides.j2 for Zuul"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"abcf1156_6ed23b8a","line":77,"range":{"start_line":77,"start_character":71,"end_line":77,"end_character":77},"in_reply_to":"3c262459_b25d3e9c","updated":"2022-02-21 11:44:39.000000000","message":"Yeah, the point is there is currently nothing in k-a depending on kayobe but I guess that may change with the common collection (as some intergate fixes could be needed). Anyhow, I\u0027m fine with this. 😊","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            old_requirements: \"{{ requirements_yml.content | b64decode | from_yaml }}\""},{"line_number":215,"context_line":"            new_requirement:"},{"line_number":216,"context_line":"              name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":217,"context_line":"              type: git"},{"line_number":218,"context_line":"              version: \"{{ \u0027stable/\u0027 ~ previous_release if is_upgrade else zuul.branch }}\""},{"line_number":219,"context_line":"            new_requirements:"},{"line_number":220,"context_line":"              collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":221,"context_line":"      when: not is_upgrade or previous_release !\u003d \u0027xena\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"38fa78e5_95891f6b","line":218,"range":{"start_line":217,"start_character":14,"end_line":218,"end_character":90},"updated":"2022-02-17 12:36:03.000000000","message":"we don\u0027t need to manipulate the checkout (again) so just use\n\n    type: dir","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            old_requirements: \"{{ requirements_yml.content | b64decode | from_yaml }}\""},{"line_number":215,"context_line":"            new_requirement:"},{"line_number":216,"context_line":"              name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":217,"context_line":"              type: git"},{"line_number":218,"context_line":"              version: \"{{ \u0027stable/\u0027 ~ previous_release if is_upgrade else zuul.branch }}\""},{"line_number":219,"context_line":"            new_requirements:"},{"line_number":220,"context_line":"              collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":221,"context_line":"      when: not is_upgrade or previous_release !\u003d \u0027xena\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ba0d4850_d79feb67","line":218,"range":{"start_line":217,"start_character":14,"end_line":218,"end_character":90},"in_reply_to":"38fa78e5_95891f6b","updated":"2022-02-21 11:41:18.000000000","message":"Done","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":250,"context_line":"    - name: install Ansible collections"},{"line_number":251,"context_line":"      command: \u003e-"},{"line_number":252,"context_line":"        kolla-ansible install-deps"},{"line_number":253,"context_line":"      when: not is_upgrade or previous_release !\u003d \u0027xena\u0027"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    - name: get ARA callback plugin path"},{"line_number":256,"context_line":"      command: \"python3 -m ara.setup.callback_plugins\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3cc8d106_a69aa77e","line":253,"updated":"2022-02-17 12:36:03.000000000","message":"missing todo comment","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    - name: install Ansible collections"},{"line_number":251,"context_line":"      command: \u003e-"},{"line_number":252,"context_line":"        kolla-ansible install-deps"},{"line_number":253,"context_line":"      when: not is_upgrade or previous_release !\u003d \u0027xena\u0027"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    - name: get ARA callback plugin path"},{"line_number":256,"context_line":"      command: \"python3 -m ara.setup.callback_plugins\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ed38aa6d_678466b1","line":253,"in_reply_to":"3cc8d106_a69aa77e","updated":"2022-02-21 11:41:18.000000000","message":"Done","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f59ea163be74ae85f985351dc74307ee8b6ae1f","unresolved":true,"context_lines":[{"line_number":599,"context_line":"            old_requirements: \"{{ requirements_yml.content | b64decode | from_yaml }}\""},{"line_number":600,"context_line":"            new_requirement:"},{"line_number":601,"context_line":"              name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":602,"context_line":"              type: git"},{"line_number":603,"context_line":"              version: \"{{ zuul.branch }}\""},{"line_number":604,"context_line":"            new_requirements:"},{"line_number":605,"context_line":"              collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":606,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"cae42ae7_e445a82d","line":603,"range":{"start_line":602,"start_character":14,"end_line":603,"end_character":42},"updated":"2022-02-17 12:36:03.000000000","message":"ditto on type","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"badf0283b6f04f093610a0b9b712dba5f90b7da4","unresolved":false,"context_lines":[{"line_number":599,"context_line":"            old_requirements: \"{{ requirements_yml.content | b64decode | from_yaml }}\""},{"line_number":600,"context_line":"            new_requirement:"},{"line_number":601,"context_line":"              name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":602,"context_line":"              type: git"},{"line_number":603,"context_line":"              version: \"{{ zuul.branch }}\""},{"line_number":604,"context_line":"            new_requirements:"},{"line_number":605,"context_line":"              collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":606,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"a77a1f45_698b8bdf","line":603,"range":{"start_line":602,"start_character":14,"end_line":603,"end_character":42},"in_reply_to":"cae42ae7_e445a82d","updated":"2022-02-21 11:41:18.000000000","message":"Done","commit_id":"47574a9d616befd3e6345b69449a5ec64a9fe50d"}]}