)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"\"enable_prometheus is no\", rabbitmq role will disable prometheus plugins"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1885106"},{"line_number":14,"context_line":"Closes-Bug: #1810763"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4d694d6224c813285d228d6bc7eece5731db1078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4ac2f617_f4915c65","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2021-12-29 10:55:15.000000000","message":"it seems to be a different bug, let\u0027s not touch it","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\"enable_prometheus is no\", rabbitmq role will disable prometheus plugins"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1885106"},{"line_number":14,"context_line":"Closes-Bug: #1810763"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4d694d6224c813285d228d6bc7eece5731db1078"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"b1629cda_ca18b671","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"4ac2f617_f4915c65","updated":"2021-12-29 11:58:43.000000000","message":"Done","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"44af8172e01c4c04018bc7d313e6aabec071fc15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e40c813_745e68b4","updated":"2021-12-16 01:28:55.000000000","message":"Please review this patch if you have time, thanks everyone","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"89b701679093d8a2132d0bd853955b826cebef77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ffc0764e_b298a1b9","updated":"2021-12-21 09:31:11.000000000","message":"recheck","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcb364b571f99f913b2a0e9bc03030ba8d3aef72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72e28c0c_df585409","updated":"2021-12-22 11:00:29.000000000","message":"Thanks","commit_id":"16427df1cb7bcae961b4496ea6bc3eb55936365f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a3171d4a645f4dc5e65e875564d41b060599e581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aa3de04e_daf1ba57","updated":"2021-12-29 13:21:42.000000000","message":"thanks, I\u0027ve noticed some more issues","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7edfbdec629824e22ef58855a791c1dbd4ecfbc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"df5483b3_94b9fad6","updated":"2021-12-31 08:06:50.000000000","message":"thanks","commit_id":"cab37b58ff3559862f32119de3b1c6ebb1d7c936"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e15e412cd63d1375f7812f0582a6f4076bc98667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"47f26593_3dc78e10","updated":"2022-01-10 20:22:53.000000000","message":"I suggest we backport this as this is a nice fix but I don\u0027t have a strong opinion. Feedback welcome.","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7867a642df6dfe8917081fc4e89922858be27612","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"05e14707_8a17476f","updated":"2022-01-11 09:11:14.000000000","message":"Small follow up: https://review.opendev.org/c/openstack/kolla-ansible/+/824101","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"019b7ed587603307929e337e8ac26385f558b025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"521f29e6_d77d8ea5","updated":"2022-01-10 15:47:35.000000000","message":"recheck","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"28978f8f7e7dffd6e605519f8ecc6db0458cf3e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"48b1be2f_e8969290","updated":"2022-01-09 20:01:51.000000000","message":"thanks","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"6deed2284bf607ae7061be8c48851df2f7a46881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fd377a9e_6a5c52ac","in_reply_to":"47f26593_3dc78e10","updated":"2022-01-11 01:29:00.000000000","message":"Agree, kolla installs \u0027rabbitmq-server-3.8.*\u0027 by default after Ussuri version.\nhttps://opendev.org/openstack/kolla/src/branch/stable/ussuri/docker/rabbitmq/Dockerfile.j2#L29","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c63aab8d510f252ac6df2d48d97c33aca6f151e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e26ba04b_284e2e49","in_reply_to":"8cf4440e_b33f6928","updated":"2022-01-11 08:25:48.000000000","message":"Sorry, /me blind. Thanks for proposing them already.","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c6e72c299c79e89ce6afb6a0f7945eaacb01a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8cf4440e_b33f6928","in_reply_to":"fd377a9e_6a5c52ac","updated":"2022-01-11 08:25:01.000000000","message":"Would you mind proposing backports?","commit_id":"1f3dcce5ac84414174f066dc20735e02ffebf041"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e96ba64bb7a84411d7d387f03fbaa2775901506","unresolved":true,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool }}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"604277ea_306f5726","line":805,"range":{"start_line":805,"start_character":8,"end_line":805,"end_character":57},"updated":"2021-12-21 10:11:18.000000000","message":"I think you need an \u0027else None\u0027 here","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"0006c89ea262c1a596323ac42f6b387aec9ffad3","unresolved":false,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool }}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b006d6db_2187405c","line":805,"range":{"start_line":805,"start_character":8,"end_line":805,"end_character":57},"in_reply_to":"604277ea_306f5726","updated":"2021-12-21 16:15:24.000000000","message":"Done","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":800,"context_line":"rabbitmq_enable_tls: \"no\""},{"line_number":801,"context_line":"# CA certificate bundle in RabbitMQ container."},{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool else None }}\""},{"line_number":806,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b425522c_345267df","line":803,"range":{"start_line":803,"start_character":0,"end_line":803,"end_character":16},"updated":"2021-12-29 10:55:15.000000000","message":"rabbitmq_enabled_plugins","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":800,"context_line":"rabbitmq_enable_tls: \"no\""},{"line_number":801,"context_line":"# CA certificate bundle in RabbitMQ container."},{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool else None }}\""},{"line_number":806,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"981d80b2_280c6e23","line":803,"range":{"start_line":803,"start_character":0,"end_line":803,"end_character":16},"in_reply_to":"b425522c_345267df","updated":"2021-12-29 11:58:43.000000000","message":"Done","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool else None }}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"74718034_ad2174ee","line":805,"range":{"start_line":805,"start_character":4,"end_line":805,"end_character":70},"updated":"2021-12-29 10:55:15.000000000","message":"\"{% if enable_prometheus | bool %}rabbitmq_prometheus{% endif %}\"","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{{ \u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool else None }}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ecb1d33_9ca745fe","line":805,"range":{"start_line":805,"start_character":4,"end_line":805,"end_character":70},"in_reply_to":"74718034_ad2174ee","updated":"2021-12-29 11:58:43.000000000","message":"Done","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a3171d4a645f4dc5e65e875564d41b060599e581","unresolved":true,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_enabled_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{% if enable_prometheus | bool %}rabbitmq_prometheus{% endif %}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"24ae2c5d_bb5b4757","line":805,"range":{"start_line":805,"start_character":11,"end_line":805,"end_character":29},"updated":"2021-12-29 13:21:42.000000000","message":"one more thought - let\u0027s add a variable \"rabbitmq_enable_prometheus_plugin\" which will default to \"enable_prometheus\" - this way users can still run this plugin without kolla\u0027s prometheus deployment if they wish to","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"38abe544b159f782756827fc49cc1414b3331d02","unresolved":false,"context_lines":[{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_enabled_plugins:"},{"line_number":804,"context_line":"  - \"rabbitmq_management\""},{"line_number":805,"context_line":"  - \"{% if enable_prometheus | bool %}rabbitmq_prometheus{% endif %}\""},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"####################"},{"line_number":808,"context_line":"# Qdrouterd options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"915f5247_85a5eece","line":805,"range":{"start_line":805,"start_character":11,"end_line":805,"end_character":29},"in_reply_to":"24ae2c5d_bb5b4757","updated":"2021-12-30 11:03:36.000000000","message":"Done","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"10f00190a8ee4753002612d8cd8945872e72eb96","unresolved":true,"context_lines":[{"line_number":801,"context_line":"# CA certificate bundle in RabbitMQ container."},{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_enable_prometheus_plugin: \"{{ enable_prometheus }}\""},{"line_number":804,"context_line":"rabbitmq_enabled_plugins:"},{"line_number":805,"context_line":"  - \"rabbitmq_management\""},{"line_number":806,"context_line":"  - \"{% if rabbitmq_enable_prometheus_plugin | bool %}rabbitmq_prometheus{% endif %}\""},{"line_number":807,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8becb2a0_52c12d14","line":804,"updated":"2022-01-05 14:02:31.000000000","message":"It has occurred to me we might want to prefer to modify this to follow the pattern we have with *_notification_topics and *_enabled_notification_topics. It\u0027s not absolutely necessary but it would be nice.","commit_id":"cab37b58ff3559862f32119de3b1c6ebb1d7c936"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"c64fd8ea6d9341d244fc82612cb73f3170a9fcbd","unresolved":false,"context_lines":[{"line_number":801,"context_line":"# CA certificate bundle in RabbitMQ container."},{"line_number":802,"context_line":"rabbitmq_cacert: \"/etc/ssl/certs/{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":803,"context_line":"rabbitmq_enable_prometheus_plugin: \"{{ enable_prometheus }}\""},{"line_number":804,"context_line":"rabbitmq_enabled_plugins:"},{"line_number":805,"context_line":"  - \"rabbitmq_management\""},{"line_number":806,"context_line":"  - \"{% if rabbitmq_enable_prometheus_plugin | bool %}rabbitmq_prometheus{% endif %}\""},{"line_number":807,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"82e06d51_854d59ea","line":804,"in_reply_to":"8becb2a0_52c12d14","updated":"2022-01-08 09:27:40.000000000","message":"yep","commit_id":"cab37b58ff3559862f32119de3b1c6ebb1d7c936"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e498beed3000323720c039bd3b63c0555b331a1a","unresolved":true,"context_lines":[{"line_number":804,"context_line":"  - name: \"rabbitmq_management\""},{"line_number":805,"context_line":"    enabled: True"},{"line_number":806,"context_line":"  - name: \"rabbitmq_prometheus\""},{"line_number":807,"context_line":"    enabled: \"{% if rabbitmq_enable_prometheus_plugin | bool %}True{% endif %}\""},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"rabbitmq_enabled_plugins: \"{{ rabbitmq_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":810,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e111282d_3628593e","line":807,"range":{"start_line":807,"start_character":14,"end_line":807,"end_character":78},"updated":"2022-01-08 15:11:09.000000000","message":"just do:\n  \n  {{ rabbitmq_enable_prometheus_plugin | bool }}","commit_id":"b38d89e2b0243768398e3478ae1162e7dfebc242"}],"ansible/roles/rabbitmq/tasks/set_rabbitmq_prometheus_plugins.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed181352f2f3c5d69d82e1d2c49bced79683317a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Settings enable or disable prometheus plugins"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"docker exec -u 0 {{ project_name }} bash rabbitmq-plugins {{ rabbitmq_prometheus_plugins }} rabbitmq_prometheus\""},{"line_number":5,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"de8b79a1_0b60d6d3","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":124},"updated":"2021-12-20 10:19:17.000000000","message":"Can we use a config file instead?\n\nhttps://www.rabbitmq.com/plugins.html#enabled-plugins-file","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"72bfde35ab2fcefb8e5226dd731c4be05b73251e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Settings enable or disable prometheus plugins"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"docker exec -u 0 {{ project_name }} bash rabbitmq-plugins {{ rabbitmq_prometheus_plugins }} rabbitmq_prometheus\""},{"line_number":5,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8b649906_84c45c32","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":124},"in_reply_to":"de8b79a1_0b60d6d3","updated":"2021-12-21 07:37:12.000000000","message":"Yes, your way is better","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"}],"ansible/roles/rabbitmq/templates/enabled_plugins.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e96ba64bb7a84411d7d387f03fbaa2775901506","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[{% for plugins in rabbitmq_plugins %}{% if plugins in [\u0027rabbitmq_management\u0027, \u0027rabbitmq_prometheus\u0027] %}{{ plugins }}{% if not loop.last %},{% endif %}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"12b2a51a_d5e904e5","line":1,"range":{"start_line":1,"start_character":55,"end_line":1,"end_character":99},"updated":"2021-12-21 10:11:18.000000000","message":"Why restrict only to these? Probably we just need \u0027if plugin\u0027","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e96ba64bb7a84411d7d387f03fbaa2775901506","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[{% for plugins in rabbitmq_plugins %}{% if plugins in [\u0027rabbitmq_management\u0027, \u0027rabbitmq_prometheus\u0027] %}{{ plugins }}{% if not loop.last %},{% endif %}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"e87d2d20_9faefc25","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":15},"updated":"2021-12-21 10:11:18.000000000","message":"nit: plugin","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"0006c89ea262c1a596323ac42f6b387aec9ffad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{% for plugins in rabbitmq_plugins %}{% if plugins in [\u0027rabbitmq_management\u0027, \u0027rabbitmq_prometheus\u0027] %}{{ plugins }}{% if not loop.last %},{% endif %}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9879b05c_81c78703","line":1,"range":{"start_line":1,"start_character":55,"end_line":1,"end_character":99},"in_reply_to":"12b2a51a_d5e904e5","updated":"2021-12-21 16:15:24.000000000","message":"I tried it at first, I used the following list style\nrabbitmq_plugins:\n   -\"rabbitmq_management\"\n   -\"{{\u0027rabbitmq_prometheus\u0027 if enable_prometheus | bool else None }}\"\nI always get \",\" unexpectedly after templates are generated\n[rabbitmq_prometheus,rabbitmq_management,].\nAnd the style I want is because the extra \",\" will affect the rabbitmq service\n[rabbitmq_prometheus,rabbitmq_management].\nLater I found out that if you don’t put the reference parameter at the end of the rabbitmq_plugins list, you won’t get the extra \",\"","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"0006c89ea262c1a596323ac42f6b387aec9ffad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{% for plugins in rabbitmq_plugins %}{% if plugins in [\u0027rabbitmq_management\u0027, \u0027rabbitmq_prometheus\u0027] %}{{ plugins }}{% if not loop.last %},{% endif %}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"520ffb81_33507e5a","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":15},"in_reply_to":"e87d2d20_9faefc25","updated":"2021-12-21 16:15:24.000000000","message":"Done","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[{% for plugin in rabbitmq_plugins %}{% if plugin %}{% if not loop.first and rabbitmq_plugins[loop.index-2]%},{% endif %}{{ plugin }}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"cf87460d_d63698a8","line":1,"range":{"start_line":1,"start_character":77,"end_line":1,"end_character":109},"updated":"2021-12-29 10:55:15.000000000","message":"this breaks if we have an intermediate, empty plugin entry (see my comment above on proper filtering); instead, just do {{ rabbitmq_enabled_plugins | select | join(\u0027, \u0027) }}","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[{% for plugin in rabbitmq_plugins %}{% if plugin %}{% if not loop.first and rabbitmq_plugins[loop.index-2]%},{% endif %}{{ plugin }}{% endif %}{% endfor %}]."}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3b5146fd_eb562b31","line":1,"range":{"start_line":1,"start_character":77,"end_line":1,"end_character":109},"in_reply_to":"cf87460d_d63698a8","updated":"2021-12-29 11:58:43.000000000","message":"Thanks for the suggestion, your way is more concise","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e498beed3000323720c039bd3b63c0555b331a1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[{{ rabbitmq_enabled_plugins|map(attribute\u003d\u0027name\u0027)|join(\u0027, \u0027) }}]."}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"df87b491_a2bc6649","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":29},"updated":"2022-01-08 15:11:09.000000000","message":"consider spacing","commit_id":"b38d89e2b0243768398e3478ae1162e7dfebc242"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e498beed3000323720c039bd3b63c0555b331a1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[{{ rabbitmq_enabled_plugins|map(attribute\u003d\u0027name\u0027)|join(\u0027, \u0027) }}]."}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"4264c53e_0c7f244e","line":1,"range":{"start_line":1,"start_character":50,"end_line":1,"end_character":51},"updated":"2022-01-08 15:11:09.000000000","message":"ditto","commit_id":"b38d89e2b0243768398e3478ae1162e7dfebc242"}],"ansible/roles/rabbitmq/templates/rabbitmq.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e96ba64bb7a84411d7d387f03fbaa2775901506","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{% endfor %}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":30,"context_line":"prometheus.tcp.ip \u003d {{ api_interface_address }}"},{"line_number":31,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"040b70f0_3849f3d1","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":33},"updated":"2021-12-21 10:11:18.000000000","message":"Probably a better condition would be\n\nif \u0027rabbitmq_prometheus\u0027 in rabbitmq_plugins","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"0006c89ea262c1a596323ac42f6b387aec9ffad3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{% endfor %}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":30,"context_line":"prometheus.tcp.ip \u003d {{ api_interface_address }}"},{"line_number":31,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1472dabc_69f04278","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":33},"in_reply_to":"040b70f0_3849f3d1","updated":"2021-12-21 16:15:24.000000000","message":"agree","commit_id":"a849e443a5a9364a7160987c584dcdff6d866a22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e498beed3000323720c039bd3b63c0555b331a1a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{% endfor %}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if \u0027rabbitmq_prometheus\u0027 in rabbitmq_enabled_plugins|map(attribute\u003d\u0027name\u0027)|join(\u0027, \u0027) %}"},{"line_number":30,"context_line":"prometheus.tcp.ip \u003d {{ api_interface_address }}"},{"line_number":31,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"b097396f_58da3138","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":56},"updated":"2022-01-08 15:11:09.000000000","message":"consider spacing","commit_id":"b38d89e2b0243768398e3478ae1162e7dfebc242"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e498beed3000323720c039bd3b63c0555b331a1a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{% endfor %}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if \u0027rabbitmq_prometheus\u0027 in rabbitmq_enabled_plugins|map(attribute\u003d\u0027name\u0027)|join(\u0027, \u0027) %}"},{"line_number":30,"context_line":"prometheus.tcp.ip \u003d {{ api_interface_address }}"},{"line_number":31,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"0ecaf511_9bbc6453","line":29,"range":{"start_line":29,"start_character":77,"end_line":29,"end_character":88},"updated":"2022-01-08 15:11:09.000000000","message":"without this","commit_id":"b38d89e2b0243768398e3478ae1162e7dfebc242"}],"ansible/roles/rabbitmq/templates/rabbitmq.json.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38b9552c35d7dd190f2f2baa0ca7bf7f35d6de3f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"source\": \"{{ container_config_directory }}/enabled_plugins\","},{"line_number":30,"context_line":"            \"dest\": \"/etc/rabbitmq/enabled_plugins\","},{"line_number":31,"context_line":"            \"owner\": \"root:rabbitmq\","},{"line_number":32,"context_line":"            \"perm\": \"0644\""},{"line_number":33,"context_line":"        }{% if rabbitmq_enable_tls | bool %},"},{"line_number":34,"context_line":"        {"},{"line_number":35,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1e0d19c1_4bc65690","line":32,"range":{"start_line":31,"start_character":12,"end_line":32,"end_character":26},"updated":"2021-12-21 07:30:42.000000000","message":"Why would this be different from all the other config files?","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"7f0da2d8be509f00eb309f117b53665199f6e8e0","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"source\": \"{{ container_config_directory }}/enabled_plugins\","},{"line_number":30,"context_line":"            \"dest\": \"/etc/rabbitmq/enabled_plugins\","},{"line_number":31,"context_line":"            \"owner\": \"root:rabbitmq\","},{"line_number":32,"context_line":"            \"perm\": \"0644\""},{"line_number":33,"context_line":"        }{% if rabbitmq_enable_tls | bool %},"},{"line_number":34,"context_line":"        {"},{"line_number":35,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"4b8d1329_ec89907e","line":32,"range":{"start_line":31,"start_character":12,"end_line":32,"end_character":26},"in_reply_to":"1e0d19c1_4bc65690","updated":"2021-12-21 07:49:49.000000000","message":"Thank you for your reminder, they should be the same","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"85c6e700e941233682f3250d1efa0daf6914aafd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"source\": \"{{ container_config_directory }}/enabled_plugins\","},{"line_number":30,"context_line":"            \"dest\": \"/etc/rabbitmq/enabled_plugins\","},{"line_number":31,"context_line":"            \"owner\": \"root:rabbitmq\","},{"line_number":32,"context_line":"            \"perm\": \"0644\""},{"line_number":33,"context_line":"        }{% if rabbitmq_enable_tls | bool %},"},{"line_number":34,"context_line":"        {"},{"line_number":35,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"d9f5021c_f219a54c","line":32,"range":{"start_line":31,"start_character":12,"end_line":32,"end_character":26},"in_reply_to":"4b8d1329_ec89907e","updated":"2021-12-24 02:58:30.000000000","message":"Done","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"}],"ansible/roles/rabbitmq/templates/rabbitmq_prometheus.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed181352f2f3c5d69d82e1d2c49bced79683317a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":2,"context_line":"prometheus.tcp.ip \u003d 0.0.0.0"},{"line_number":3,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4bbc6d23_452037cf","line":2,"range":{"start_line":2,"start_character":20,"end_line":2,"end_character":27},"updated":"2021-12-20 10:19:17.000000000","message":"This should be the internal IP","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"72bfde35ab2fcefb8e5226dd731c4be05b73251e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":2,"context_line":"prometheus.tcp.ip \u003d 0.0.0.0"},{"line_number":3,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"aa85344a_c7dcbbd8","line":2,"range":{"start_line":2,"start_character":20,"end_line":2,"end_character":27},"in_reply_to":"4bbc6d23_452037cf","updated":"2021-12-21 07:37:12.000000000","message":"Done","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed181352f2f3c5d69d82e1d2c49bced79683317a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":2,"context_line":"prometheus.tcp.ip \u003d 0.0.0.0"},{"line_number":3,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fbdb0cd_5b7b83d9","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":11},"updated":"2021-12-20 10:19:17.000000000","message":"Why not just include this in rabbitmq.conf.j2?","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"72bfde35ab2fcefb8e5226dd731c4be05b73251e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if enable_prometheus | bool %}"},{"line_number":2,"context_line":"prometheus.tcp.ip \u003d 0.0.0.0"},{"line_number":3,"context_line":"prometheus.tcp.port \u003d {{ role_rabbitmq_prometheus_port }}"},{"line_number":4,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3244c72e_58a4a3b6","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":11},"in_reply_to":"3fbdb0cd_5b7b83d9","updated":"2021-12-21 07:37:12.000000000","message":"Done","commit_id":"d05a3a5cf2be2fc81ece880aacd17c9203c7e846"}],"ansible/site.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38b9552c35d7dd190f2f2baa0ca7bf7f35d6de3f","unresolved":true,"context_lines":[{"line_number":476,"context_line":"        role_rabbitmq_cluster_cookie: \u0027{{ rabbitmq_cluster_cookie }}\u0027,"},{"line_number":477,"context_line":"        role_rabbitmq_cluster_port: \u0027{{ rabbitmq_cluster_port }}\u0027,"},{"line_number":478,"context_line":"        role_rabbitmq_epmd_port: \u0027{{ rabbitmq_epmd_port }}\u0027,"},{"line_number":479,"context_line":"        role_rabbitmq_prometheus_port: \u0027{{ rabbitmq_prometheus_port }}\u0027,"},{"line_number":480,"context_line":"        role_rabbitmq_groups: rabbitmq,"},{"line_number":481,"context_line":"        role_rabbitmq_management_port: \u0027{{ rabbitmq_management_port }}\u0027,"},{"line_number":482,"context_line":"        role_rabbitmq_monitoring_password: \u0027{{ rabbitmq_monitoring_password }}\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a9a7f79_ee171f48","line":479,"updated":"2021-12-21 07:30:42.000000000","message":"Can we keep alphabetic ordering here?","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"7f0da2d8be509f00eb309f117b53665199f6e8e0","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        role_rabbitmq_cluster_cookie: \u0027{{ rabbitmq_cluster_cookie }}\u0027,"},{"line_number":477,"context_line":"        role_rabbitmq_cluster_port: \u0027{{ rabbitmq_cluster_port }}\u0027,"},{"line_number":478,"context_line":"        role_rabbitmq_epmd_port: \u0027{{ rabbitmq_epmd_port }}\u0027,"},{"line_number":479,"context_line":"        role_rabbitmq_prometheus_port: \u0027{{ rabbitmq_prometheus_port }}\u0027,"},{"line_number":480,"context_line":"        role_rabbitmq_groups: rabbitmq,"},{"line_number":481,"context_line":"        role_rabbitmq_management_port: \u0027{{ rabbitmq_management_port }}\u0027,"},{"line_number":482,"context_line":"        role_rabbitmq_monitoring_password: \u0027{{ rabbitmq_monitoring_password }}\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e25396a5_471b95bb","line":479,"in_reply_to":"3a9a7f79_ee171f48","updated":"2021-12-21 07:49:49.000000000","message":"Ack","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"38b9552c35d7dd190f2f2baa0ca7bf7f35d6de3f","unresolved":true,"context_lines":[{"line_number":498,"context_line":"        role_rabbitmq_cluster_cookie: \u0027{{ outward_rabbitmq_cluster_cookie }}\u0027,"},{"line_number":499,"context_line":"        role_rabbitmq_cluster_port: \u0027{{ outward_rabbitmq_cluster_port }}\u0027,"},{"line_number":500,"context_line":"        role_rabbitmq_epmd_port: \u0027{{ outward_rabbitmq_epmd_port }}\u0027,"},{"line_number":501,"context_line":"        role_rabbitmq_prometheus_port: \u0027{{ outward_rabbitmq_prometheus_port }}\u0027,"},{"line_number":502,"context_line":"        role_rabbitmq_groups: outward-rabbitmq,"},{"line_number":503,"context_line":"        role_rabbitmq_management_port: \u0027{{ outward_rabbitmq_management_port }}\u0027,"},{"line_number":504,"context_line":"        role_rabbitmq_password: \u0027{{ outward_rabbitmq_password }}\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"be4f6188_4c195dc0","line":501,"updated":"2021-12-21 07:30:42.000000000","message":"dito","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"7f0da2d8be509f00eb309f117b53665199f6e8e0","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        role_rabbitmq_cluster_cookie: \u0027{{ outward_rabbitmq_cluster_cookie }}\u0027,"},{"line_number":499,"context_line":"        role_rabbitmq_cluster_port: \u0027{{ outward_rabbitmq_cluster_port }}\u0027,"},{"line_number":500,"context_line":"        role_rabbitmq_epmd_port: \u0027{{ outward_rabbitmq_epmd_port }}\u0027,"},{"line_number":501,"context_line":"        role_rabbitmq_prometheus_port: \u0027{{ outward_rabbitmq_prometheus_port }}\u0027,"},{"line_number":502,"context_line":"        role_rabbitmq_groups: outward-rabbitmq,"},{"line_number":503,"context_line":"        role_rabbitmq_management_port: \u0027{{ outward_rabbitmq_management_port }}\u0027,"},{"line_number":504,"context_line":"        role_rabbitmq_password: \u0027{{ outward_rabbitmq_password }}\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3d5e985f_9cec161e","line":501,"in_reply_to":"be4f6188_4c195dc0","updated":"2021-12-21 07:49:49.000000000","message":"Ack","commit_id":"fb8385758ffffc27cf7d1256da8ddfae3cd651c9"}],"releasenotes/notes/bug-1885106-2347d7458a8f9cb0.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1885106  \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s \"prometheus.tcp.port\"."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bb0c92aa_04e7341c","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":75},"updated":"2021-12-29 10:55:15.000000000","message":"please use `LP #...` format at the end of the message","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1885106  \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s \"prometheus.tcp.port\"."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b567d46b_92ba87c5","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":75},"in_reply_to":"bb0c92aa_04e7341c","updated":"2021-12-29 11:58:43.000000000","message":"Done","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2e7d092d8efdc53b148071c4667fa19a31e11aa","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1885106  \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s \"prometheus.tcp.port\"."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dfc0dae6_0cc90c92","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":61},"updated":"2021-12-29 10:55:15.000000000","message":"enclose in `` `` instead","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"b942715cbb5affa7546d103e52f1f885139fdf81","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1885106  \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s \"prometheus.tcp.port\"."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"40e46e2a_c92ebd42","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":61},"in_reply_to":"dfc0dae6_0cc90c92","updated":"2021-12-29 11:58:43.000000000","message":"Done","commit_id":"d093d2d87ec119f4038e0ea65e517047d15c29d8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a3171d4a645f4dc5e65e875564d41b060599e581","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `LP #1885106 \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s ``prometheus.tcp.port``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"84a73f51_e9384a5c","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":57},"updated":"2021-12-29 13:21:42.000000000","message":"and it\u0027s kolla-ansible, not manila 😄","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a3171d4a645f4dc5e65e875564d41b060599e581","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `LP #1885106 \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s ``prometheus.tcp.port``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0f0aa1b2_2e690d33","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":73},"updated":"2021-12-29 13:21:42.000000000","message":"put this (and only this) at the end of the message (see other examples)","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"38abe544b159f782756827fc49cc1414b3331d02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `LP #1885106 \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s ``prometheus.tcp.port``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c4c5d3b3_66588ded","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":73},"in_reply_to":"0f0aa1b2_2e690d33","updated":"2021-12-30 11:03:36.000000000","message":"Done","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"38abe544b159f782756827fc49cc1414b3331d02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `LP #1885106 \u003chttps://bugs.launchpad.net/manila/+bug/1885106\u003e`_"},{"line_number":5,"context_line":"    Fixed the deployment failure of outward_rabbitmq by resolving port"},{"line_number":6,"context_line":"    conflicts by customizing RabbitMQ\u0027s ``prometheus.tcp.port``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d56aba68_73113ca4","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":57},"in_reply_to":"84a73f51_e9384a5c","updated":"2021-12-30 11:03:36.000000000","message":"^v^","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a3171d4a645f4dc5e65e875564d41b060599e581","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"28635dcb_4f288ece","line":7,"updated":"2021-12-29 13:21:42.000000000","message":"let\u0027s also add an upgrade note that users must turn on \"rabbitmq_enable_prometheus_plugin\" to get old behaviour in case they don\u0027t rely on kolla\u0027s prometheus but an external one","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"38abe544b159f782756827fc49cc1414b3331d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"97dcaf71_0faad440","line":7,"in_reply_to":"28635dcb_4f288ece","updated":"2021-12-30 11:03:36.000000000","message":"Done","commit_id":"bdc73b8cf47b3e6170dbb471a33e14da6ec79ae0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d6b5221cfdee86d6f6fb153042f58fd2eca96323","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    If external Prometheus is used, you need to turn on"},{"line_number":11,"context_line":"    ``rabbitmq_enable_prometheus_plugin`` to get old behaviour."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7dc2bfee_293c2944","line":10,"updated":"2021-12-30 13:53:06.000000000","message":"Let\u0027s add more context to the note, start with: \"RabbitMQ\u0027s Prometheus plugin is no longer enabled by default if Prometheus is not deployed.\"","commit_id":"3bbafde3dc6d3df11c27f8c10486631c67c539fe"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"e4a58592f8ea40facfde35c77b26b5fece289c12","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    If external Prometheus is used, you need to turn on"},{"line_number":11,"context_line":"    ``rabbitmq_enable_prometheus_plugin`` to get old behaviour."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"42cea332_8880cd99","line":10,"in_reply_to":"7dc2bfee_293c2944","updated":"2021-12-30 15:02:48.000000000","message":"Thanks, it seems clearer","commit_id":"3bbafde3dc6d3df11c27f8c10486631c67c539fe"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7d46e70608373e873f290e66aeaa07c903e543be","unresolved":true,"context_lines":[{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    RabbitMQ\u0027s Prometheus plugin is no longer enabled by default"},{"line_number":11,"context_line":"    if Prometheus is not deployed. if external Prometheus is used,"},{"line_number":12,"context_line":"    you need to turn on ``rabbitmq_enable_prometheus_plugin``"},{"line_number":13,"context_line":"    to get old behaviour."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9724147b_e9de8d73","line":11,"range":{"start_line":11,"start_character":35,"end_line":11,"end_character":36},"updated":"2021-12-30 16:00:23.000000000","message":"I","commit_id":"afca1e1741358e389f8460b9b69b713ce8c4589a"},{"author":{"_account_id":31506,"name":"Lin PeiWen","email":"591171850@qq.com","username":"LinPeiWen"},"change_message_id":"d2accc2310f69d1baaf92c6f7683cbb9217ffa48","unresolved":false,"context_lines":[{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    RabbitMQ\u0027s Prometheus plugin is no longer enabled by default"},{"line_number":11,"context_line":"    if Prometheus is not deployed. if external Prometheus is used,"},{"line_number":12,"context_line":"    you need to turn on ``rabbitmq_enable_prometheus_plugin``"},{"line_number":13,"context_line":"    to get old behaviour."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"75f80d6f_3ce5d2fd","line":11,"range":{"start_line":11,"start_character":35,"end_line":11,"end_character":36},"in_reply_to":"9724147b_e9de8d73","updated":"2021-12-31 01:11:32.000000000","message":"Done","commit_id":"afca1e1741358e389f8460b9b69b713ce8c4589a"}]}