)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c5f21f49af105c1fc63c3f59ee247f8b320d71f9","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"There is a second issue in that it takes some time for the upgraded"},{"line_number":20,"context_line":"services to update the cinder services database table with their new"},{"line_number":21,"context_line":"version. We need to wait until all cinder-compute services have done this"},{"line_number":22,"context_line":"before the restart is performed, otherwise the RPC version cap will"},{"line_number":23,"context_line":"remain in place. There is currently no interface in cinder available for"},{"line_number":24,"context_line":"checking these versions, so as a workaround we use a configurable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2fe691e6_b61c89f6","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":58},"updated":"2021-12-16 10:57:55.000000000","message":"s/cinder-compute/cinder/\n\nLine was too long anyway ;-)","commit_id":"ec20d34bcaf735b9d65f7aae539804fe52743d3a"}],"ansible/roles/cinder/tasks/reload.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"31fb7df57d857f584dc906906132a24ed7b70b7c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Reload cinder services to remove RPC version pin"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service: \"{{ item.value }}\""},{"line_number":5,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7adfe74f_37efa147","line":2,"updated":"2021-12-31 10:55:55.000000000","message":"why not in handlers? then we would not be bouncing services that were not restarted","commit_id":"80a32c3c74cad4d46671faff067b274ffed74bba"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e2edead66756c81a7b2e9f7d05512813fceea8e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Reload cinder services to remove RPC version pin"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service: \"{{ item.value }}\""},{"line_number":5,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7071cee7_c80a64b1","line":2,"in_reply_to":"11f90904_aadd45ed","updated":"2022-01-10 17:49:06.000000000","message":"You right, me approve.","commit_id":"80a32c3c74cad4d46671faff067b274ffed74bba"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8273c56000fd708b87dd461a76f4bce3802cb326","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Reload cinder services to remove RPC version pin"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service: \"{{ item.value }}\""},{"line_number":5,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"11f90904_aadd45ed","line":2,"in_reply_to":"7adfe74f_37efa147","updated":"2022-01-06 14:11:15.000000000","message":"We only do this on upgrade, so I don\u0027t think there\u0027s much to optimise. For nova, we initially did it in handlers but had to change since nova-compute handlers would not be triggered on controllers. I figured we may as well use the same pattern here.","commit_id":"80a32c3c74cad4d46671faff067b274ffed74bba"}]}