)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cc36952f8bb7f42bf92d0ff17a540d02cc3298be","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Crees \u003cmattc@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-07 09:57:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tune RabbitMQ HA for availability over consistency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default ha-promote-on-shutdown\u003dwhen-synced. However we are seeing"},{"line_number":10,"context_line":"issues with RabbitMQ automatically recovering when nodes are restarted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a3ebc5c4_29a98170","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2023-02-09 13:29:56.000000000","message":"rabbitmq: Support setting ha-promote-on-shutdown","commit_id":"d109f72f95aefe0334bfed992933e4628a28563f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"96266c39d049c844548b7cc6678d79e349a036cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Crees \u003cmattc@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-07 09:57:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tune RabbitMQ HA for availability over consistency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default ha-promote-on-shutdown\u003dwhen-synced. However we are seeing"},{"line_number":10,"context_line":"issues with RabbitMQ automatically recovering when nodes are restarted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"6a74b987_082ad921","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"in_reply_to":"a3ebc5c4_29a98170","updated":"2023-02-09 13:49:19.000000000","message":"Done","commit_id":"d109f72f95aefe0334bfed992933e4628a28563f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c1020178dc8ae4371738751781abb5de4be82244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53e59ace_9200b9d7","updated":"2022-01-10 17:42:26.000000000","message":"Given this bug report (again): https://github.com/rabbitmq/rabbitmq-server/issues/2045 should we wait until we have made all transient queues HA?","commit_id":"cbfdbe78feed0b46b0c193431ced67db2b0500a6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d0cc73f4a496bbf1094dbee1d9a561fcebcdb8a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"daca3de1_e9f871d0","updated":"2021-12-31 10:18:06.000000000","message":"since it\u0027s the current default, maybe let\u0027s not add this config var? (as we advocate not changing it in the first place ;-) )","commit_id":"cbfdbe78feed0b46b0c193431ced67db2b0500a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01618624acdb7c15440feb6d563a912b8deef84c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02729e97_8307641f","in_reply_to":"53e59ace_9200b9d7","updated":"2022-01-10 17:43:58.000000000","message":"doh, what I meant was all transient queues *not HA*","commit_id":"cbfdbe78feed0b46b0c193431ced67db2b0500a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7d7102cc36591d21832596563ffe4b47df91fd04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d419cf6b_28bb5009","updated":"2023-02-06 11:07:29.000000000","message":"Thanks Matt for updating this.","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"20d149cf9ed2e9fba9acd5912785713cd55ff35f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c734d1ed_f7bfd3c5","updated":"2023-02-06 15:05:15.000000000","message":"Looks good, waiting for CI run with it enabled (and HA queues)","commit_id":"22b340487bea3d89e1421b82952a644a4b6f2661"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9c47376b01dae1f3c74fb1259fb7fbac90a5704","unresolved":true,"context_lines":[{"line_number":84,"context_line":"rabbitmq_tls_options: {}"},{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"# For conistency use \"when-synced\", for availability use \"always\""},{"line_number":88,"context_line":"# The rabbitmq default for ha queues is \"when-synced\""},{"line_number":89,"context_line":"# More details see:"},{"line_number":90,"context_line":"# https://www.rabbitmq.com/ha.html#promoting-unsynchronised-mirrors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ea6e2ef9_a157174e","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":16},"updated":"2023-01-31 15:10:28.000000000","message":"nit: consistency","commit_id":"857ad89c03fc4f8e780e64cc67b38d78b66a5d31"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"75d790ab8780eeb2c9e2c7654b4b75ca60a8c0eb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"rabbitmq_tls_options: {}"},{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"# For conistency use \"when-synced\", for availability use \"always\""},{"line_number":88,"context_line":"# The rabbitmq default for ha queues is \"when-synced\""},{"line_number":89,"context_line":"# More details see:"},{"line_number":90,"context_line":"# https://www.rabbitmq.com/ha.html#promoting-unsynchronised-mirrors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a308a280_beabdd27","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":16},"in_reply_to":"ea6e2ef9_a157174e","updated":"2023-02-01 09:29:57.000000000","message":"Done","commit_id":"857ad89c03fc4f8e780e64cc67b38d78b66a5d31"}],"releasenotes/notes/rabbitmq-ha-promote-on-shutdown-9099c6643f2d0cce.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7d7102cc36591d21832596563ffe4b47df91fd04","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"be37f3ca_e17ee29c","line":6,"updated":"2023-02-06 11:07:29.000000000","message":"nit: s/reccomend/recommend","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5d3c2a20d247c529337d8cdf3c2e4082b50582e1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b33f2dfa_36ec16da","line":6,"in_reply_to":"be37f3ca_e17ee29c","updated":"2023-02-06 14:32:03.000000000","message":"Done","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7d7102cc36591d21832596563ffe4b47df91fd04","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d4fcbe20_429be2c0","line":7,"updated":"2023-02-06 11:07:29.000000000","message":"Given that the messaging HA policy is now behind a flag, should we set `always` as the default when this policy is enabled?\n\nSome related discussion here: https://bugs.launchpad.net/charm-rabbitmq-server/+bug/1943929","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"20d149cf9ed2e9fba9acd5912785713cd55ff35f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba243db7_58e5141c","line":7,"in_reply_to":"8aba0380_53a7d081","updated":"2023-02-06 15:05:15.000000000","message":"Thanks! In the child patch, please could you temporarily enable ha-queues and set it to when-synced? I\u0027d like to see the CI write out the Rabbit definitions.json to be certain Rabbit is happy with it (since I don\u0027t think we have test coverage currently).","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ca864e37ada369246a013efbeed7a69b76454a94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","}],"source_content_type":"text/x-yaml","patch_set":8,"id":"03807587_83c5dd25","line":7,"in_reply_to":"ba243db7_58e5141c","updated":"2023-02-07 09:59:20.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/872863/1","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5d3c2a20d247c529337d8cdf3c2e4082b50582e1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The config option `rabbitmq_ha_promote_on_shutdown` has been added, which"},{"line_number":5,"context_line":"    allows changing the RabbitMQ definition `ha-promote-on-shutdown`. By"},{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8aba0380_53a7d081","line":7,"in_reply_to":"d4fcbe20_429be2c0","updated":"2023-02-06 14:32:03.000000000","message":"It does look worth doing, I\u0027ll create a child patch to change the default.","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7d7102cc36591d21832596563ffe4b47df91fd04","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","},{"line_number":11,"context_line":"    will cause RabbitMQ to be restarted on the next deploy."},{"line_number":12,"context_line":"    For more details please see:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fe891c3d_0c9853e5","line":9,"updated":"2023-02-06 11:07:29.000000000","message":"nit s/relevent/relevant","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5d3c2a20d247c529337d8cdf3c2e4082b50582e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    default `ha-promote-on-shutdown` is \"when-synced\". We reccomend changing"},{"line_number":7,"context_line":"    this to be \"always\". This basically means we don\u0027t mind losing some"},{"line_number":8,"context_line":"    messages, instead we give priority to rabbitmq availability. This is most"},{"line_number":9,"context_line":"    relevent when restarting rabbitmq, such as when upgrading. Note that"},{"line_number":10,"context_line":"    setting the value of this flag, even to the default value of \"when-synced\","},{"line_number":11,"context_line":"    will cause RabbitMQ to be restarted on the next deploy."},{"line_number":12,"context_line":"    For more details please see:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"053dc55c_dc67c31c","line":9,"in_reply_to":"fe891c3d_0c9853e5","updated":"2023-02-06 14:32:03.000000000","message":"Done","commit_id":"35c58e4ebbc17c23a0b223d2a8705186e9b81f3b"}]}