)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e9914ce69f79c2b99b4af98c5182b8af04030d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"713d09b5_b72daabc","updated":"2023-02-06 12:17:18.000000000","message":"Thanks for updating - a good step.  Just some questions about how best to communicate the change with users.","commit_id":"b44d4e217a553ae9f573b00919b5e83c2f45ee02"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"121b3bb05960bec15ee36bbeb842ebc96a454ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"623e8146_7e23e000","updated":"2023-02-20 11:02:43.000000000","message":"recheck","commit_id":"6cf22b0cb1f2dc4d8910409284fa5757a7dd67a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3e3b39d01e8749290959064afa8eca3bd6120314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56d51d20_083bb670","updated":"2023-02-21 14:37:08.000000000","message":"recheck\n\nUbuntu failed to ssh to VM","commit_id":"6cf22b0cb1f2dc4d8910409284fa5757a7dd67a1"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":97,"context_line":"rabbitmq_ha_promote_on_shutdown: \"always\""},{"line_number":98,"context_line":"# The number of rabbitmq replicas should follow this advice:"},{"line_number":99,"context_line":"# https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8f95e5ae_ccdc339f","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":13},"updated":"2021-12-31 09:59:38.000000000","message":"nit: comma","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":97,"context_line":"rabbitmq_ha_promote_on_shutdown: \"always\""},{"line_number":98,"context_line":"# The number of rabbitmq replicas should follow this advice:"},{"line_number":99,"context_line":"# https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b69a3fce_c36522cc","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":13},"in_reply_to":"8f95e5ae_ccdc339f","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":98,"context_line":"# The number of rabbitmq replicas should follow this advice:"},{"line_number":99,"context_line":"# https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3289ac52_4494e958","line":101,"range":{"start_line":101,"start_character":29,"end_line":101,"end_character":37},"updated":"2021-12-31 09:59:38.000000000","message":"nit: exchanges","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# The number of rabbitmq replicas should follow this advice:"},{"line_number":99,"context_line":"# https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c0da999e_6d358826","line":101,"range":{"start_line":101,"start_character":29,"end_line":101,"end_character":37},"in_reply_to":"3289ac52_4494e958","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a38d786_461de180","line":103,"range":{"start_line":103,"start_character":55,"end_line":103,"end_character":56},"updated":"2021-12-31 09:59:38.000000000","message":"nit: space","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1647f65d_156e47a8","line":103,"range":{"start_line":103,"start_character":34,"end_line":103,"end_character":44},"updated":"2021-12-31 09:59:38.000000000","message":"role_rabbitmq_groups","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c7969437_a948fd33","line":103,"range":{"start_line":103,"start_character":34,"end_line":103,"end_character":44},"in_reply_to":"1647f65d_156e47a8","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# This means if you have three rabbit nodes, we request two"},{"line_number":101,"context_line":"# replicas of all queues and exhanges."},{"line_number":102,"context_line":"# Note: this assumes an odd number of rabbitmq nodes."},{"line_number":103,"context_line":"rabbitmq_server_count: \"{{ groups[\u0027rabbitmq\u0027] | length  }}\""},{"line_number":104,"context_line":"rabbitmq_ha_replica_count: \"{{ (rabbitmq_server_count // 2 + 1) | int }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c8657acf_691996a7","line":103,"range":{"start_line":103,"start_character":55,"end_line":103,"end_character":56},"in_reply_to":"1a38d786_461de180","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"}],"releasenotes/notes/rabbitmq-ha-improve-performance-8f29c7657d2999dd.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c1f02ed4aacc31adf34ddd248976070d218b23b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8b76935c_58502c1c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2021-12-31 10:02:15.000000000","message":"I\u0027m having a hard time deciding whether it should be a feature/upgrade/other. \"fixes\" seems wrong anyway.","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d10a72f0c967046d41ed2b9039de128a7ad8c9ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8464c3db_227c7a2c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"5e205e50_dda42913","updated":"2023-02-01 14:08:03.000000000","message":"RabbitMQ does need to be restarted for the new `definitions.json` to be used, but once that\u0027s in place Rabbit will handle the number of replicas automatically.","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"684e018d7404a20820bcbbe2d396e230c2b22f6d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee6a043f_902e360e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"83be37c4_b6e36c87","updated":"2023-01-31 15:16:35.000000000","message":"I\u0027ll look into this.\nProbably worth mentioning in an upgrade note too that bringing in this change will cause the RabbitMQ nodes to be restarted on next deploy as it changes the definitions.json file.","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c67ff7401237239c5cff5a3bf9c7f9cfc94fb932","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"83be37c4_b6e36c87","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"8b76935c_58502c1c","updated":"2023-01-31 15:10:20.000000000","message":"Agree, what is the impact on upgrades? Will RMQ magically decrease/increase the number of replicas or the operator should be aware some intervention might be needed?","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c7254ec12945a74cbe7ebb76b7259027739388b2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5e205e50_dda42913","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"ee6a043f_902e360e","updated":"2023-01-31 15:25:26.000000000","message":"Currently we restart the nodes every time on upgrade (but there\u0027s this https://review.opendev.org/c/openstack/kolla-ansible/+/862287 which I need to update).","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7bec11c5_e6bbad3b","line":4,"range":{"start_line":4,"start_character":41,"end_line":4,"end_character":68},"updated":"2021-12-31 09:59:38.000000000","message":"n to (n//2+1) where n is the number of RabbitMQ nodes.","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"867fb3d7_c218ede3","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":13},"updated":"2021-12-31 09:59:38.000000000","message":"nit: RabbitMQ","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"94742770_e1460031","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":24},"updated":"2021-12-31 09:59:38.000000000","message":"replica count","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1c65421b_11667813","line":4,"range":{"start_line":4,"start_character":41,"end_line":4,"end_character":68},"in_reply_to":"7bec11c5_e6bbad3b","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7bdb33e7_b2ae9919","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":13},"in_reply_to":"867fb3d7_c218ede3","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93f78c2a_2906c5ca","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":24},"in_reply_to":"94742770_e1460031","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"43d63354_4c70aaa4","line":5,"range":{"start_line":5,"start_character":11,"end_line":5,"end_character":12},"updated":"2021-12-31 09:59:38.000000000","message":"nit: comma","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1e5432b7_ea7b3ad4","line":5,"range":{"start_line":5,"start_character":11,"end_line":5,"end_character":12},"in_reply_to":"43d63354_4c70aaa4","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c4798c18_21fc15ce","line":6,"range":{"start_line":6,"start_character":66,"end_line":6,"end_character":69},"updated":"2021-12-31 09:59:38.000000000","message":"nit: comma after","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f1382905_0866296f","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":26},"updated":"2021-12-31 09:59:38.000000000","message":"we","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"622291e5_1d855716","line":6,"range":{"start_line":6,"start_character":66,"end_line":6,"end_character":69},"in_reply_to":"c4798c18_21fc15ce","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Rabbitmq replicates has changed from all to n//2 + 1 replication."},{"line_number":5,"context_line":"    That is for a 3 node clusters, we request exactly 2 replicas,"},{"line_number":6,"context_line":"    for a 1 node cluster, request 1 replica, and for a 5 node cluster"},{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b895eafd_a2d4b6a1","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":26},"in_reply_to":"f1382905_0866296f","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2914f20d21ac67349f435b6c269229e1bc9bd92","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":10,"context_line":"    A major motivation is to reduce the load on rabbitmq in larger"},{"line_number":11,"context_line":"    deployments. It is hoped, the improved performance should also"},{"line_number":12,"context_line":"    help rabbitmq recover more quickly from cluster issues."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e1d8e4d4_85cfee9f","line":10,"range":{"start_line":10,"start_character":48,"end_line":10,"end_character":57},"updated":"2021-12-31 09:59:38.000000000","message":"nit: RabbitMQ","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b4ee3ebc4c8857b440ed87520ded86685e039b61","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":10,"context_line":"    A major motivation is to reduce the load on rabbitmq in larger"},{"line_number":11,"context_line":"    deployments. It is hoped, the improved performance should also"},{"line_number":12,"context_line":"    help rabbitmq recover more quickly from cluster issues."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"63d37359_b9e0feff","line":10,"range":{"start_line":10,"start_character":48,"end_line":10,"end_character":57},"in_reply_to":"e1d8e4d4_85cfee9f","updated":"2023-01-31 15:07:42.000000000","message":"Done","commit_id":"9bd170a65a5f2aaa750a8773be5b04d8e0f0c57d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e9914ce69f79c2b99b4af98c5182b8af04030d3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RabbitMQ replica count has changed from n to (n//2+1) where n is the number"},{"line_number":5,"context_line":"    of RabbitMQ nodes. That is, for a 3 node clusters, we request exactly 2"},{"line_number":6,"context_line":"    replicas, for a 1 node cluster, we request 1 replica, and for a 5 node"},{"line_number":7,"context_line":"    cluster, we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d4f90a0e_ed2b21f5","line":4,"updated":"2023-02-06 12:17:18.000000000","message":"Please can we update this in the context of the changes that have happened since? I.e. Only people with `om_enable_rabbitmq_high_availability` set to `True` are affected.","commit_id":"b44d4e217a553ae9f573b00919b5e83c2f45ee02"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2494d79ad2e41c10b29b50df641eff566c5b6dfc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RabbitMQ replica count has changed from n to (n//2+1) where n is the number"},{"line_number":5,"context_line":"    of RabbitMQ nodes. That is, for a 3 node clusters, we request exactly 2"},{"line_number":6,"context_line":"    replicas, for a 1 node cluster, we request 1 replica, and for a 5 node"},{"line_number":7,"context_line":"    cluster, we request 3 replicas."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"31c34522_8339fd29","line":4,"in_reply_to":"d4f90a0e_ed2b21f5","updated":"2023-02-14 10:50:53.000000000","message":"Done","commit_id":"b44d4e217a553ae9f573b00919b5e83c2f45ee02"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6e9914ce69f79c2b99b4af98c5182b8af04030d3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    of RabbitMQ nodes. That is, for a 3 node clusters, we request exactly 2"},{"line_number":6,"context_line":"    replicas, for a 1 node cluster, we request 1 replica, and for a 5 node"},{"line_number":7,"context_line":"    cluster, we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":10,"context_line":"    A major motivation is to reduce the load on RabbitMQ in larger"},{"line_number":11,"context_line":"    deployments. It is hoped, the improved performance should also"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7c8cf339_d59a6229","line":8,"updated":"2023-02-06 12:17:18.000000000","message":"Similar to other changes, will existing queues retain their original settings? I.e. queues with 3 replicas won\u0027t automatically update to 2? If so, please include a note in the upgrade section.","commit_id":"b44d4e217a553ae9f573b00919b5e83c2f45ee02"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2494d79ad2e41c10b29b50df641eff566c5b6dfc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    of RabbitMQ nodes. That is, for a 3 node clusters, we request exactly 2"},{"line_number":6,"context_line":"    replicas, for a 1 node cluster, we request 1 replica, and for a 5 node"},{"line_number":7,"context_line":"    cluster, we request 3 replicas."},{"line_number":8,"context_line":"    This follows the good practice advice here:"},{"line_number":9,"context_line":"    https://www.rabbitmq.com/ha.html#replication-factor"},{"line_number":10,"context_line":"    A major motivation is to reduce the load on RabbitMQ in larger"},{"line_number":11,"context_line":"    deployments. It is hoped, the improved performance should also"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fac75fbc_e48d26b7","line":8,"in_reply_to":"7c8cf339_d59a6229","updated":"2023-02-14 10:50:53.000000000","message":"Done","commit_id":"b44d4e217a553ae9f573b00919b5e83c2f45ee02"}]}