)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1458aaff81f11568d0befa02e3919b1e995b71fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45fdbae8_0931e1b3","updated":"2022-01-10 10:21:43.000000000","message":"I think it\u0027s quite hard to reason about what the podman/docker split should look like before we\u0027ve done the systemd refactor. I\u0027d suggest we do that first.","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f34f89e2626de760b649d6e0367a983c911c85f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c51eec16_14670ef0","updated":"2022-01-10 10:17:33.000000000","message":"Thinking about where this will end up, we\u0027ll have two top level classes for docker and podman, with some common code. In general, we use\n\n* common code for comparisons\n* systemd for container control\n* docker/podman to query container state and manage images","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"13e967583135290f4573fff595c7181f4a443dd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc2ead01_db1e90c2","in_reply_to":"45fdbae8_0931e1b3","updated":"2022-01-11 09:00:16.000000000","message":"Sure but first we should decide on a approach for that (outlined in Ivan\u0027s reply).\nAlso, we have explored the second approach at https://review.opendev.org/c/openstack/kolla-ansible/+/816724.","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"}],"ansible/module_utils/kolla_container_worker.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1458aaff81f11568d0befa02e3919b1e995b71fa","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def compare_ipc_mode(self, container_info):"},{"line_number":64,"context_line":"        new_ipc_mode \u003d self.params.get(\u0027ipc_mode\u0027)"},{"line_number":65,"context_line":"        current_ipc_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027IpcMode\u0027)"},{"line_number":66,"context_line":"        if not current_ipc_mode:"},{"line_number":67,"context_line":"            current_ipc_mode \u003d None"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"16cd42c5_60a1183b","line":65,"range":{"start_line":65,"start_character":43,"end_line":65,"end_character":53},"updated":"2022-01-10 10:21:43.000000000","message":"So we\u0027re going with the docker data structure, and forcing podman to produce the same?","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"13e967583135290f4573fff595c7181f4a443dd3","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def compare_ipc_mode(self, container_info):"},{"line_number":64,"context_line":"        new_ipc_mode \u003d self.params.get(\u0027ipc_mode\u0027)"},{"line_number":65,"context_line":"        current_ipc_mode \u003d container_info[\u0027HostConfig\u0027].get(\u0027IpcMode\u0027)"},{"line_number":66,"context_line":"        if not current_ipc_mode:"},{"line_number":67,"context_line":"            current_ipc_mode \u003d None"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6182748d_69303097","line":65,"range":{"start_line":65,"start_character":43,"end_line":65,"end_character":53},"in_reply_to":"16cd42c5_60a1183b","updated":"2022-01-11 09:00:16.000000000","message":"Yes, the objective was to change original docker functionality as little as possible.","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1458aaff81f11568d0befa02e3919b1e995b71fa","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        pass"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @abstractmethod"},{"line_number":334,"context_line":"    def create_container(self):"},{"line_number":335,"context_line":"        pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbd961df_9912b1dc","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":24},"updated":"2022-01-10 10:21:43.000000000","message":"Not sure if this makes sense in systemd land.","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"},{"author":{"_account_id":33708,"name":"Ivan Halomi","username":"halomiva","inactive":true},"change_message_id":"0dcfa2be240074b99a7974ec1de9928eb2924e94","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        pass"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @abstractmethod"},{"line_number":334,"context_line":"    def create_container(self):"},{"line_number":335,"context_line":"        pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"09f4205e_64e1d70e","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":24},"in_reply_to":"cbd961df_9912b1dc","updated":"2022-01-10 14:43:35.000000000","message":"There are 2 approaches possible with running container with systemd:\n1. creating container with systemd - problem with this is that after machine reboot or service restart it recreates container\n2. creating container with docker/podman in state \"created\" and then starting it with systemd service, which is approach we think is better, more logical and works in the same way as it is now with docker\nSame goes for destroying containers","commit_id":"54b9d3e0e2943e6d03aa22d0e98e405974fe8c91"}]}