)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0399ecf543c489cd4fec0a31196dd8fcccaa89cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c6455864_3794265b","updated":"2022-02-15 11:28:18.000000000","message":"recheck","commit_id":"89807cc890d7097ebba528c48f74441dd62b8fab"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d53f098aa559a41961c034d57342b8c5ca8c6258","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e23d3c9d_7dce1947","updated":"2022-03-18 14:16:15.000000000","message":"Michals, care to replace those +2s?","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e25e7f7e8fce6a56bc03f84380617338277ffdf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2ddb69d4_4d369046","updated":"2022-03-21 12:21:51.000000000","message":"Should we have a CI job for that approach?","commit_id":"4e41acd8f0ccc8dee432f72cfafcca16d01a11b7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"68b0e5829c0317344887f3c7d9e4fb9739e83822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8363c94f_2c2ac817","in_reply_to":"2ddb69d4_4d369046","updated":"2022-03-21 13:24:16.000000000","message":"We will cover it in Kayobe","commit_id":"4e41acd8f0ccc8dee432f72cfafcca16d01a11b7"}],"ansible/roles/ceilometer/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c96ebf0c70a27fcd076a275ba90f573363ed708","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  - \"/run/:/run/:shared\""},{"line_number":135,"context_line":"  - \"ceilometer:/var/lib/ceilometer/\""},{"line_number":136,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":137,"context_line":"  - \"nova_libvirt:/var/lib/libvirt\""},{"line_number":138,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/ceilometer/ceilometer:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/ceilometer\u0027 if ceilometer_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":139,"context_line":"ceilometer_ipmi_default_volumes:"},{"line_number":140,"context_line":"  - \"{{ node_config_directory }}/ceilometer-ipmi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cd009a83_7c15129c","side":"PARENT","line":137,"range":{"start_line":137,"start_character":5,"end_line":137,"end_character":17},"updated":"2022-03-18 15:34:49.000000000","message":"I do wonder how it worked since this volume is actually called libvirtd...","commit_id":"33415ed93ee241e666769b0353dee927552cd4d9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed1f7f27ba9c127181662bedb7aab9e020475dbb","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  - \"/run/:/run/:shared\""},{"line_number":135,"context_line":"  - \"ceilometer:/var/lib/ceilometer/\""},{"line_number":136,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":137,"context_line":"  - \"nova_libvirt:/var/lib/libvirt\""},{"line_number":138,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/ceilometer/ceilometer:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/ceilometer\u0027 if ceilometer_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":139,"context_line":"ceilometer_ipmi_default_volumes:"},{"line_number":140,"context_line":"  - \"{{ node_config_directory }}/ceilometer-ipmi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0a4677c3_55fb7098","side":"PARENT","line":137,"range":{"start_line":137,"start_character":5,"end_line":137,"end_character":17},"in_reply_to":"7a0deb80_0db46bd9","updated":"2022-03-21 14:32:28.000000000","message":"OK","commit_id":"33415ed93ee241e666769b0353dee927552cd4d9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8c2c85c241802cb79292aa82953a3504a1d41b79","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  - \"/run/:/run/:shared\""},{"line_number":135,"context_line":"  - \"ceilometer:/var/lib/ceilometer/\""},{"line_number":136,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":137,"context_line":"  - \"nova_libvirt:/var/lib/libvirt\""},{"line_number":138,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/ceilometer/ceilometer:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/ceilometer\u0027 if ceilometer_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":139,"context_line":"ceilometer_ipmi_default_volumes:"},{"line_number":140,"context_line":"  - \"{{ node_config_directory }}/ceilometer-ipmi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a0deb80_0db46bd9","side":"PARENT","line":137,"range":{"start_line":137,"start_character":5,"end_line":137,"end_character":17},"in_reply_to":"cd009a83_7c15129c","updated":"2022-03-18 17:23:17.000000000","message":"Clearly it was not doing very much. Suggest we keep this change, then drop it in a later one.","commit_id":"33415ed93ee241e666769b0353dee927552cd4d9"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"fa8d36bda657807c44b3bcfbfef847f50093fa45","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    volumes: \"{{ nova_libvirt_default_volumes + nova_libvirt_extra_volumes }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ nova_libvirt_healthcheck }}\""},{"line_number":14,"context_line":"  nova-ssh:"},{"line_number":15,"context_line":"    container_name: \"nova_ssh\""},{"line_number":16,"context_line":"    group: \"{{ nova_cell_compute_group }}\""},{"line_number":17,"context_line":"    image: \"{{ nova_ssh_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dcd3ff2d_1ce08239","line":14,"updated":"2022-01-26 16:15:10.000000000","message":"Is the nova-ssh service still required for cold migrations when disable nova-libvirt and using the libvirt host service?","commit_id":"0c9e191e975efcde2fae58afc7ea409747b30bed"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0db53839fd97023e1398c4613815dac4683b1ace","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    volumes: \"{{ nova_libvirt_default_volumes + nova_libvirt_extra_volumes }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ nova_libvirt_healthcheck }}\""},{"line_number":14,"context_line":"  nova-ssh:"},{"line_number":15,"context_line":"    container_name: \"nova_ssh\""},{"line_number":16,"context_line":"    group: \"{{ nova_cell_compute_group }}\""},{"line_number":17,"context_line":"    image: \"{{ nova_ssh_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b642ec5f_c5d2e5b2","line":14,"in_reply_to":"dcd3ff2d_1ce08239","updated":"2022-01-27 16:46:11.000000000","message":"In theory we could use the host\u0027s SSH service to access /var/lib/nova, however I think there is some value in continuing to use the nova_ssh as a sandboxed environment.","commit_id":"0c9e191e975efcde2fae58afc7ea409747b30bed"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"71584b7e8de41966422fc2355b45db18c462493e","unresolved":true,"context_lines":[{"line_number":429,"context_line":"# Used by bootstrapping containers."},{"line_number":430,"context_line":"nova_cell_bootstrap_extra_volumes: \"{{ nova_extra_volumes }}\""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"nova_libvirt_volume: \"{% if enable_nova_libvirt_container | bool %}libvirtd{% else %}/var/lib/libvirt{% endif %}\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"####################"},{"line_number":435,"context_line":"# HAProxy"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e66bd2af_9d199eb3","line":432,"range":{"start_line":432,"start_character":0,"end_line":432,"end_character":113},"updated":"2022-03-08 17:05:23.000000000","message":"Is here some reason why you used different implementation as before for example in ceilometer ? \n\nceilometer_libvirt_volume: \"{{ \u0027nova_libvirt\u0027 if enable_nova_libvirt_container | bool else \u0027/var/lib/libvirt\u0027 }}\"\n\nI mean that jinja - {% \n\nI think this should be same in all files.","commit_id":"d6d148bb4a7b087fd264ed87e458671d36437f0b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"19946d254aa289de16e7e23ea6e2694185992dac","unresolved":false,"context_lines":[{"line_number":429,"context_line":"# Used by bootstrapping containers."},{"line_number":430,"context_line":"nova_cell_bootstrap_extra_volumes: \"{{ nova_extra_volumes }}\""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"nova_libvirt_volume: \"{% if enable_nova_libvirt_container | bool %}libvirtd{% else %}/var/lib/libvirt{% endif %}\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"####################"},{"line_number":435,"context_line":"# HAProxy"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"24ecb076_fbb536dd","line":432,"range":{"start_line":432,"start_character":0,"end_line":432,"end_character":113},"in_reply_to":"e66bd2af_9d199eb3","updated":"2022-03-10 09:43:05.000000000","message":"Done","commit_id":"d6d148bb4a7b087fd264ed87e458671d36437f0b"}],"ansible/roles/nova-cell/tasks/config-host.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"fa8d36bda657807c44b3bcfbfef847f50093fa45","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cbd3de42_f121f9c7","line":59,"updated":"2022-01-26 16:15:10.000000000","message":"I think at this point it could makes sense to explicitly remove the file/unmask the service. Otherwise we have problems when a host is changed from nova-libvirt to host Libvirt.","commit_id":"0c9e191e975efcde2fae58afc7ea409747b30bed"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0db53839fd97023e1398c4613815dac4683b1ace","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"39bebd74_491eb774","line":59,"in_reply_to":"cbd3de42_f121f9c7","updated":"2022-01-27 16:46:11.000000000","message":"Agreed, however this patch explicitly does not handle migration from nova_libvirt to host libvirt. I\u0027ll look at that separately.","commit_id":"0c9e191e975efcde2fae58afc7ea409747b30bed"}],"ansible/roles/nova-cell/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c96ebf0c70a27fcd076a275ba90f573363ed708","unresolved":true,"context_lines":[{"line_number":94,"context_line":"- name: Copying over libvirt TLS keys"},{"line_number":95,"context_line":"  include_tasks: config-libvirt-tls.yml"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":98,"context_line":"    - libvirt_tls | bool"},{"line_number":99,"context_line":"    - libvirt_tls_manage_certs | bool"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8b85bc44_60238476","line":97,"updated":"2022-03-18 15:34:49.000000000","message":"this seems independent of this change - is it a fix?","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8c2c85c241802cb79292aa82953a3504a1d41b79","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- name: Copying over libvirt TLS keys"},{"line_number":95,"context_line":"  include_tasks: config-libvirt-tls.yml"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":98,"context_line":"    - libvirt_tls | bool"},{"line_number":99,"context_line":"    - libvirt_tls_manage_certs | bool"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ccd2dae6_9a7d3695","line":97,"in_reply_to":"8b85bc44_60238476","updated":"2022-03-18 17:23:17.000000000","message":"I changed this code initially but ended up not needing those changes. Possibly this isn\u0027t required, but it\u0027s a micro optimisation so won\u0027t hurt to keep it.","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed1f7f27ba9c127181662bedb7aab9e020475dbb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- name: Copying over libvirt TLS keys"},{"line_number":95,"context_line":"  include_tasks: config-libvirt-tls.yml"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":98,"context_line":"    - libvirt_tls | bool"},{"line_number":99,"context_line":"    - libvirt_tls_manage_certs | bool"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e441cc5b_9f0c518d","line":97,"in_reply_to":"ccd2dae6_9a7d3695","updated":"2022-03-21 14:32:28.000000000","message":"OK","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"}],"ansible/roles/nova-cell/tasks/external_ceph.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b2c23ad749be8838975bb021aa046dfe5e0b8879","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        dest: \"/etc/ceph/ceph.conf\""},{"line_number":112,"context_line":"        owner: \"root\""},{"line_number":113,"context_line":"        group: \"root\""},{"line_number":114,"context_line":"        mode: \"0644\""},{"line_number":115,"context_line":"      become: true"},{"line_number":116,"context_line":"  when:"},{"line_number":117,"context_line":"    - not enable_nova_libvirt_container | bool"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"37c37c26_f45e07e3","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":19},"updated":"2022-03-10 12:20:12.000000000","message":"Is it on purpose that it is readable by all?","commit_id":"09356ac0e7d5e90a67a571c8e7e00148e51dc0a3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f5cd7a13e2d1bb1d0711a1e0e3b2bb4e52b3b47","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        dest: \"/etc/ceph/ceph.conf\""},{"line_number":112,"context_line":"        owner: \"root\""},{"line_number":113,"context_line":"        group: \"root\""},{"line_number":114,"context_line":"        mode: \"0644\""},{"line_number":115,"context_line":"      become: true"},{"line_number":116,"context_line":"  when:"},{"line_number":117,"context_line":"    - not enable_nova_libvirt_container | bool"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b1df47ce_fe868296","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":19},"in_reply_to":"37c37c26_f45e07e3","updated":"2022-03-10 12:41:24.000000000","message":"This is what you get on a cephadm deployed host.","commit_id":"09356ac0e7d5e90a67a571c8e7e00148e51dc0a3"}],"doc/source/reference/compute/libvirt-guide.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c96ebf0c70a27fcd076a275ba90f573363ed708","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    they can verify that all the certificates being used were signed by the CA"},{"line_number":93,"context_line":"    and should be trusted."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* serverkey.pem (not required when using a host libvirt daemon)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  - This is the private key for the server, and is no different than the"},{"line_number":98,"context_line":"    private key of a TLS certificate. It should be carefully protected, just"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1b25a9cc_6fae4456","line":95,"updated":"2022-03-18 15:34:49.000000000","message":"could use mentioning it will not be set up, not just not required","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8c2c85c241802cb79292aa82953a3504a1d41b79","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    they can verify that all the certificates being used were signed by the CA"},{"line_number":93,"context_line":"    and should be trusted."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* serverkey.pem (not required when using a host libvirt daemon)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  - This is the private key for the server, and is no different than the"},{"line_number":98,"context_line":"    private key of a TLS certificate. It should be carefully protected, just"}],"source_content_type":"text/x-rst","patch_set":11,"id":"495fdb67_d1343c17","line":95,"in_reply_to":"1b25a9cc_6fae4456","updated":"2022-03-18 17:23:17.000000000","message":"Done","commit_id":"cf1b2ea941e746f9fcdf9cfabd85ce0ad0662ea0"}]}