)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dcdd1b89562ae77476fab2b39731cd12aa12a95a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovn: use include tasks to ignore rendering loop items"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use ansible include tasks to ignore rendering loop items for hosts without ovn-controller (like nodes without tunnel interface)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Closes-Bug: #1953367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cd44facf_5928441f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":127},"updated":"2022-01-24 15:09:12.000000000","message":"Nit: wrap commit message lines at 72 characters","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60839edc30279cfa8bb400039fe4e9f5e2004f51","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Use ansible include tasks to ignore rendering loop items for hosts without ovn-controller (like nodes without tunnel interface)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Closes-Bug: #1953367"},{"line_number":13,"context_line":"Change-Id: I2c4a624a3d8323e464ecf93af42937fa269cb929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba942712_2d1c6988","line":12,"updated":"2022-01-23 10:13:26.000000000","message":"That bug is already marked as closed. I think it would be helpful to create a new bug report to describe any remaining issue.","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"}],"ansible/roles/ovn/tasks/bootstrap.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"60839edc30279cfa8bb400039fe4e9f5e2004f51","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap OVN Controller"},{"line_number":13,"context_line":"  include_tasks: ovn-controller-bootstrap.yml"},{"line_number":14,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"812f1341_3914e4e8","line":14,"updated":"2022-01-23 10:13:26.000000000","message":"The whole bootstrap.yml is only being called from deploy.yml when we are on an ovn-controller, so I don\u0027t think thst this when condition is needed at all.\n\nI also don\u0027t understand why the added level of indirection would change anything in how the loop is being evaluated.","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6d3aac3878f2e3fa6ad4e2001d305fa019977916","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap OVN Controller"},{"line_number":13,"context_line":"  include_tasks: ovn-controller-bootstrap.yml"},{"line_number":14,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6dff9ea7_c76d2406","line":14,"in_reply_to":"709a045e_58203604","updated":"2022-01-24 10:15:33.000000000","message":"The inclusion of this tasks file uses import_tasks, rather than the dynamic include_tasks, so I can see how these may get evaluated.\n\nMy preference would be to allow the loop vars to evaluate on non OVN controller hosts. Maybe using the default filter, or something like \u0027tunnel_interface_address if X else None\u0027.\n\nIf we have to use an include_tasks, it should go in deploy.yml.\n\nAgree with Jens on requiring a new bug report or at least some more info on how the previous fix was insufficient.","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"3b90f2ec4937382ae5fc37d9668c9faeb1e3c07e","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap OVN Controller"},{"line_number":13,"context_line":"  include_tasks: ovn-controller-bootstrap.yml"},{"line_number":14,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"91e57b3c_9abd7609","line":14,"in_reply_to":"812f1341_3914e4e8","updated":"2022-01-23 10:19:12.000000000","message":"In nodes that don\u0027t have tunnel interface like control nodes, it wants to configure ovn in ovsdb that it\u0027s not present in control nodes. Now ansible tries to parse the loop items first after that check the when condition so at first it will parse the `tunnel_interface_address` and because the control node doesn\u0027t have the tunnel interface it will fail. I think the solution to include the task on only nodes that have ovn-controller could be the solution. If you have any better solution please let me know.","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3e5702f9160caa6937f7d43e17956e6b78bcd7c5","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap OVN Controller"},{"line_number":13,"context_line":"  include_tasks: ovn-controller-bootstrap.yml"},{"line_number":14,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"709a045e_58203604","line":14,"in_reply_to":"91e57b3c_9abd7609","updated":"2022-01-24 05:47:19.000000000","message":"As I said, this whole playbook should not get executed on those nodes. So if you have failures, please add logs and details in a new bug report, so that we can try to reproduce it.","commit_id":"e651df7e02150b1554afdd9ae41da5faec504713"}]}