)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7d9fbc5471b31aae8fe8843108478a13ee83c871","unresolved":true,"context_lines":[{"line_number":1109,"context_line":"prometheus_openstack_exporter_timeout: \"10s\""},{"line_number":1110,"context_line":"prometheus_elasticsearch_exporter_interval: \"60s\""},{"line_number":1111,"context_line":"prometheus_cmdline_extras:"},{"line_number":1112,"context_line":"prometheus_blackbox_exporter_cmdline_extras:"},{"line_number":1113,"context_line":"prometheus_elasticsearch_exporter_cmdline_extras:"},{"line_number":1114,"context_line":"prometheus_haproxy_exporter_cmdline_extras:"},{"line_number":1115,"context_line":"prometheus_memcached_exporter_cmdline_extras:"},{"line_number":1116,"context_line":"prometheus_mysqld_exporter_cmdline_extras:"},{"line_number":1117,"context_line":"prometheus_node_exporter_cmdline_extras:"},{"line_number":1118,"context_line":"prometheus_openstack_exporter_cmdline_extras:"},{"line_number":1119,"context_line":"prometheus_ceph_mgr_exporter_endpoints: []"},{"line_number":1120,"context_line":"prometheus_openstack_exporter_endpoint_type: \"internal\""},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"52a0e4b6_2e658d2a","line":1118,"range":{"start_line":1112,"start_character":0,"end_line":1118,"end_character":45},"updated":"2022-02-16 16:02:04.000000000","message":"Could they go in role defaults?","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"796b0078e60fe108922d35b5327f0cda051c3928","unresolved":true,"context_lines":[{"line_number":1109,"context_line":"prometheus_openstack_exporter_timeout: \"10s\""},{"line_number":1110,"context_line":"prometheus_elasticsearch_exporter_interval: \"60s\""},{"line_number":1111,"context_line":"prometheus_cmdline_extras:"},{"line_number":1112,"context_line":"prometheus_blackbox_exporter_cmdline_extras:"},{"line_number":1113,"context_line":"prometheus_elasticsearch_exporter_cmdline_extras:"},{"line_number":1114,"context_line":"prometheus_haproxy_exporter_cmdline_extras:"},{"line_number":1115,"context_line":"prometheus_memcached_exporter_cmdline_extras:"},{"line_number":1116,"context_line":"prometheus_mysqld_exporter_cmdline_extras:"},{"line_number":1117,"context_line":"prometheus_node_exporter_cmdline_extras:"},{"line_number":1118,"context_line":"prometheus_openstack_exporter_cmdline_extras:"},{"line_number":1119,"context_line":"prometheus_ceph_mgr_exporter_endpoints: []"},{"line_number":1120,"context_line":"prometheus_openstack_exporter_endpoint_type: \"internal\""},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eacf5ed6_5d253724","line":1118,"range":{"start_line":1112,"start_character":0,"end_line":1118,"end_character":45},"in_reply_to":"52a0e4b6_2e658d2a","updated":"2022-02-16 16:04:08.000000000","message":"They sure could. prometheus_cmdline_extras was already in in group_vars/all.yml, so I followed the same pattern. However prometheus_cadvisor_cmdline_extras is in role defaults. Do you prefer the latter?","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"55dc77acfd1445a92da24d92c34ce1042edf09c2","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"prometheus_openstack_exporter_timeout: \"10s\""},{"line_number":1110,"context_line":"prometheus_elasticsearch_exporter_interval: \"60s\""},{"line_number":1111,"context_line":"prometheus_cmdline_extras:"},{"line_number":1112,"context_line":"prometheus_blackbox_exporter_cmdline_extras:"},{"line_number":1113,"context_line":"prometheus_elasticsearch_exporter_cmdline_extras:"},{"line_number":1114,"context_line":"prometheus_haproxy_exporter_cmdline_extras:"},{"line_number":1115,"context_line":"prometheus_memcached_exporter_cmdline_extras:"},{"line_number":1116,"context_line":"prometheus_mysqld_exporter_cmdline_extras:"},{"line_number":1117,"context_line":"prometheus_node_exporter_cmdline_extras:"},{"line_number":1118,"context_line":"prometheus_openstack_exporter_cmdline_extras:"},{"line_number":1119,"context_line":"prometheus_ceph_mgr_exporter_endpoints: []"},{"line_number":1120,"context_line":"prometheus_openstack_exporter_endpoint_type: \"internal\""},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7546a5df_04ab63e0","line":1118,"range":{"start_line":1112,"start_character":0,"end_line":1118,"end_character":45},"in_reply_to":"bc106c3c_367bbd37","updated":"2022-02-16 21:32:22.000000000","message":"Done","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"11dfc4eb60b7000c1fa575e6648d54c91e533fa4","unresolved":true,"context_lines":[{"line_number":1109,"context_line":"prometheus_openstack_exporter_timeout: \"10s\""},{"line_number":1110,"context_line":"prometheus_elasticsearch_exporter_interval: \"60s\""},{"line_number":1111,"context_line":"prometheus_cmdline_extras:"},{"line_number":1112,"context_line":"prometheus_blackbox_exporter_cmdline_extras:"},{"line_number":1113,"context_line":"prometheus_elasticsearch_exporter_cmdline_extras:"},{"line_number":1114,"context_line":"prometheus_haproxy_exporter_cmdline_extras:"},{"line_number":1115,"context_line":"prometheus_memcached_exporter_cmdline_extras:"},{"line_number":1116,"context_line":"prometheus_mysqld_exporter_cmdline_extras:"},{"line_number":1117,"context_line":"prometheus_node_exporter_cmdline_extras:"},{"line_number":1118,"context_line":"prometheus_openstack_exporter_cmdline_extras:"},{"line_number":1119,"context_line":"prometheus_ceph_mgr_exporter_endpoints: []"},{"line_number":1120,"context_line":"prometheus_openstack_exporter_endpoint_type: \"internal\""},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bc106c3c_367bbd37","line":1118,"range":{"start_line":1112,"start_character":0,"end_line":1118,"end_character":45},"in_reply_to":"eacf5ed6_5d253724","updated":"2022-02-16 16:05:51.000000000","message":"Please move them into role defaults ;-)","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"}],"ansible/roles/prometheus/templates/prometheus-blackbox-exporter.json.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8ff160acff44164100fc15173dcdcd72f9e5558c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/blackbox_exporter/blackbox_exporter --config.file\u003d/etc/prometheus/blackbox.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_blackbox_exporter_port }} --log.level\u003dinfo{% if prometheus_blackbox_exporter_cmdline_extras %} {{ prometheus_blackbox_exporter_cmdline_extras }}{% endif %}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-blackbox-exporter.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"925ebfbf_cfbda13d","line":2,"updated":"2022-02-16 16:11:11.000000000","message":"Is the added \" \" so bad that we need to wrap it in this long conditional? Why not just add the new variable unconditionally?","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"55dc77acfd1445a92da24d92c34ce1042edf09c2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/blackbox_exporter/blackbox_exporter --config.file\u003d/etc/prometheus/blackbox.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_blackbox_exporter_port }} --log.level\u003dinfo{% if prometheus_blackbox_exporter_cmdline_extras %} {{ prometheus_blackbox_exporter_cmdline_extras }}{% endif %}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-blackbox-exporter.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a0110007_16280485","line":2,"in_reply_to":"925ebfbf_cfbda13d","updated":"2022-02-16 21:32:22.000000000","message":"I followed what was done in prometheus-server.json.j2. It has the advantage of not generating a config diff, which many operators could be reviewing when upgrading.\n\nPersonally I dislike the extra space in the generated file, but I will be happy to update if the general consensus is to simplify the code.","commit_id":"0600a2e3a1dd531f2b56ee77baa544b5e2d098ca"}],"ansible/roles/prometheus/templates/prometheus-openstack-exporter.json.j2":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"e14fe22a857ad4d774c958d2ddd8130c24c6a082","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/openstack-exporter/openstack-exporter --endpoint-type\u003d{{ prometheus_openstack_exporter_endpoint_type }} --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }} default {{ prometheus_openstack_exporter_disabled_items }}{% if prometheus_openstack_exporter_cmdline_extras %} {{ prometheus_openstack_exporter_cmdline_extras }}{% endif %}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/clouds.yml\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"08fffebf_d77743b9","line":2,"range":{"start_line":2,"start_character":350,"end_line":2,"end_character":463},"updated":"2022-02-17 15:03:00.000000000","message":"should we keep consistent with prometheus-cadvisor ?\nhttps://github.com/openstack/kolla-ansible/blob/1a4a8c16153543acee7ed03177a0aafbf472598f/ansible/roles/prometheus/templates/prometheus-cadvisor.json.j2#L2 ?","commit_id":"90f7f5c5a0b7cd921b3126f3737a04f451a050db"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b458142d238b91bf85bc0f75b06767751f75ed62","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/openstack-exporter/openstack-exporter --endpoint-type\u003d{{ prometheus_openstack_exporter_endpoint_type }} --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }} default {{ prometheus_openstack_exporter_disabled_items }}{% if prometheus_openstack_exporter_cmdline_extras %} {{ prometheus_openstack_exporter_cmdline_extras }}{% endif %}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/clouds.yml\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"effcb470_af07206e","line":2,"range":{"start_line":2,"start_character":350,"end_line":2,"end_character":463},"in_reply_to":"08fffebf_d77743b9","updated":"2022-02-18 08:10:05.000000000","message":"++","commit_id":"90f7f5c5a0b7cd921b3126f3737a04f451a050db"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7126022f954943185acc4b95ac9c31ce0c3c7a88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/openstack-exporter/openstack-exporter --endpoint-type\u003d{{ prometheus_openstack_exporter_endpoint_type }} --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }} default {{ prometheus_openstack_exporter_disabled_items }}{% if prometheus_openstack_exporter_cmdline_extras %} {{ prometheus_openstack_exporter_cmdline_extras }}{% endif %}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/clouds.yml\","}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1a706c07_3b11c7eb","line":2,"range":{"start_line":2,"start_character":350,"end_line":2,"end_character":463},"in_reply_to":"effcb470_af07206e","updated":"2022-02-18 09:14:33.000000000","message":"Done","commit_id":"90f7f5c5a0b7cd921b3126f3737a04f451a050db"}]}