)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"851ce2374e82fedff8c809ec7fe8d5505fe5fc85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"617357bb_1c6a2160","updated":"2022-02-11 15:59:48.000000000","message":"Waiting for openstack-exporter binaries","commit_id":"d8155655a73ea03bd07400734c28fa1a51fbb0a6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a3a124443175eda45b5be368cf50814f6395e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf9b7e19_04cb9543","updated":"2022-06-21 05:24:52.000000000","message":"Nova changed their API for a good reason. I agree that we should allow operators to keep their old broken data, but we should not do so by default.","commit_id":"23c42d52e1b665676d8cbdb2e0b9622e4ef47fa5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"37b2c994bbd9fd3b9d934500f2c49df5d80b4730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e8f5e017_e247251c","in_reply_to":"8dcfaf06_b3e85d79","updated":"2022-06-22 14:56:42.000000000","message":"I updated my change following the discussion in today\u0027s IRC meeting.","commit_id":"23c42d52e1b665676d8cbdb2e0b9622e4ef47fa5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"08cb72580ba75c89a12d7c208c748ec86d5274b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8dcfaf06_b3e85d79","in_reply_to":"9551d60f_21b14542","updated":"2022-06-21 09:17:21.000000000","message":"Well the flavor_id is only useful if the flavor hasn\u0027t been removed, so it depends on how static the available set of flavors is. Though I admit that in most deployments it likely indeed will not change very often.\n\nI still don\u0027t see how changing the default in AA would be different from changing it now, though. I\u0027d still prefer changing now and adding a fat warning in the reno about it. For backports then we can switch this around and use 2.1 as default.\n\nHappy to be overruled by other reviewers though.","commit_id":"23c42d52e1b665676d8cbdb2e0b9622e4ef47fa5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d94c647504f6cf5127f81d2e06b98bfdc72cec02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9551d60f_21b14542","in_reply_to":"bf9b7e19_04cb9543","updated":"2022-06-21 08:32:35.000000000","message":"In theory I would agree with you, I normally prefer to use defaults. However in practice we have two main issues:\n\n- operators may depend on metrics that were removed, but not realise they become unavailable until after they upgrade. This gives them a chance to adapt. I was thinking we could revert to the default microversion in a future release. The Nova docs say the metrics are \"frequently misleading or outright wrong\", but I have found them useful.\n\n- the flavor_id label of openstack_nova_server_status is incorrect with microversions 2.47 or above. Before: flavor_id\u003d\"1\", after: flavor_id\u003d\"\u003cnil\u003e\" (issue #220 linked in commit message). This will require adding support in openstack-exporter to display flavor information in a new way. Until this is implemented, using microversion 2.1 provides useful data.\n\nUsing the latest microversion mostly removes information. The only actual change is the move from numeric IDs to UUIDs for openstack_nova_agent_state:\n\n-openstack_nova_agent_state{adminState\u003d\"enabled\",disabledReason\u003d\"\",hostname\u003d\"pierre-aio.novalocal\",id\u003d\"1\",service\u003d\"nova-scheduler\",zone\u003d\"internal\"} 1\n+openstack_nova_agent_state{adminState\u003d\"enabled\",disabledReason\u003d\"\",hostname\u003d\"pierre-aio.novalocal\",id\u003d\"063b0a69-e30f-4450-8dfa-6bbf0bc2d0e9\",service\u003d\"nova-scheduler\",zone\u003d\"internal\"} 1\n\nOverall I see more downsides to using the latest microversion, especially without a transition period. What do you think?","commit_id":"23c42d52e1b665676d8cbdb2e0b9622e4ef47fa5"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3cd6d1cfbee3d12fe2e0593805a18f7c3899e4f4","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ba0340b_9ba206d7","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"updated":"2022-06-23 08:33:20.000000000","message":"it does not work the way you think; in the environment we now have a funny value for this variable - we need to construct the dictionary or filter it out","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1003b7f2b874b1f58ffd28ac420a4fe4b6ead662","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2498dc26_3a2a5b9c","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"in_reply_to":"04703971_25adb3de","updated":"2022-06-23 15:11:23.000000000","message":"\"omit\" emits a magic string that only Ansible knows how to handle for the module params. Other places simply get the very weird string. The reason this works is because it gets the empty string and this causes the env var to go empty.","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2e0d4f04ec1c574327306b0ffbe3ff99af942ee9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ac549e40_ffca8689","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"in_reply_to":"2498dc26_3a2a5b9c","updated":"2022-06-23 15:16:47.000000000","message":"Alternative approach in which we always set the environment variable. What do you think?","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"58a7a0ea850226d9a514bb3964231f0a62dcaa14","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"04703971_25adb3de","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"in_reply_to":"59168cee_48477733","updated":"2022-06-23 14:52:23.000000000","message":"I tried with default(omit, true). It works when first setting the environment variable – it won\u0027t define it in the container environment if set to empty string – but it won\u0027t unset it if it has been defined.\n\nI think this might be an issue with kolla_docker itself?","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"142f1d4d4e9fe0fb86f5bfb2b2429184ba4cbd7b","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"59168cee_48477733","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"in_reply_to":"9ba0340b_9ba206d7","updated":"2022-06-23 08:40:49.000000000","message":"Also since the value has a default, this bit would never be used.","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"84df789e9488eea561a18aaaf450b52b6b01bc18","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    group: \"prometheus-openstack-exporter\""},{"line_number":78,"context_line":"    enabled: \"{{ enable_prometheus_openstack_exporter | bool }}\""},{"line_number":79,"context_line":"    environment:"},{"line_number":80,"context_line":"      OS_COMPUTE_API_VERSION: \"{{ prometheus_openstack_exporter_compute_api_version | default(omit) }}\""},{"line_number":81,"context_line":"    image: \"{{ prometheus_openstack_exporter_image_full }}\""},{"line_number":82,"context_line":"    volumes: \"{{ prometheus_openstack_exporter_default_volumes + prometheus_openstack_exporter_extra_volumes }}\""},{"line_number":83,"context_line":"    dimensions: \"{{ prometheus_openstack_exporter_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fb72ae6f_a07badd5","line":80,"range":{"start_line":80,"start_character":86,"end_line":80,"end_character":100},"in_reply_to":"ac549e40_ffca8689","updated":"2022-06-23 15:21:17.000000000","message":"Approved.","commit_id":"cde2cbaf2a3aae55c20f2d77abf71fdf4e16ff1c"}]}