)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4d5af007e7cd800c2d4205d31e4c38c2260fa44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b83ee782_6a288470","updated":"2022-02-15 11:28:28.000000000","message":"recheck","commit_id":"a138f0c1a4e2553da8b77cb9c9790c7d097a1812"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5484524f9001adaf6ecc202150fb179048534bba","unresolved":true,"context_lines":[{"line_number":560,"context_line":"# Whether to fail when there are running VMs."},{"line_number":561,"context_line":"nova_libvirt_cleanup_running_vms_fatal: true"},{"line_number":562,"context_line":"# Whether to remove Docker volumes."},{"line_number":563,"context_line":"nova_libvirt_cleanup_remove_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"66935f27_d5bdaa1b","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":42},"updated":"2022-03-08 16:53:13.000000000","message":"this should be true in defaults - OR change documentation and explain false value.\nDetails in doc comment.","commit_id":"d19284e2c09de1bbff93986db3a8c859c3eb62c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22bd1a1d143963dd374f23909bc6c483c51644c3","unresolved":false,"context_lines":[{"line_number":560,"context_line":"# Whether to fail when there are running VMs."},{"line_number":561,"context_line":"nova_libvirt_cleanup_running_vms_fatal: true"},{"line_number":562,"context_line":"# Whether to remove Docker volumes."},{"line_number":563,"context_line":"nova_libvirt_cleanup_remove_volumes: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6dae8546_f7295cec","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":42},"in_reply_to":"66935f27_d5bdaa1b","updated":"2022-03-10 09:43:16.000000000","message":"Done","commit_id":"d19284e2c09de1bbff93986db3a8c859c3eb62c4"}],"ansible/roles/nova-cell/tasks/libvirt-cleanup.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0c3f769a6fb6da96135debf236ba07816e29a5a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      become: true"},{"line_number":19,"context_line":"      shell:"},{"line_number":20,"context_line":"        cmd: |"},{"line_number":21,"context_line":"          pgrep -l qemu | awk \u0027!/qemu-ga/  \u0026\u0026 !/qemu-img/ {print $1}\u0027"},{"line_number":22,"context_line":"      register: running_vms"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Fail if there are any running VMs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d9d45fd8_3949131b","line":21,"updated":"2022-03-18 15:49:05.000000000","message":"this might want -o pipefail","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f2008fbf5d62ec6caf2558d0002de11feaa37bf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      become: true"},{"line_number":19,"context_line":"      shell:"},{"line_number":20,"context_line":"        cmd: |"},{"line_number":21,"context_line":"          pgrep -l qemu | awk \u0027!/qemu-ga/  \u0026\u0026 !/qemu-img/ {print $1}\u0027"},{"line_number":22,"context_line":"      register: running_vms"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Fail if there are any running VMs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fb0a93bf_3a7ae0d5","line":21,"in_reply_to":"56a018e7_18d32917","updated":"2022-03-30 11:31:32.000000000","message":"Fix: https://review.opendev.org/c/openstack/kolla-ansible/+/835820","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cfe53501f4672c4754455773254618f68fbb6a3d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      become: true"},{"line_number":19,"context_line":"      shell:"},{"line_number":20,"context_line":"        cmd: |"},{"line_number":21,"context_line":"          pgrep -l qemu | awk \u0027!/qemu-ga/  \u0026\u0026 !/qemu-img/ {print $1}\u0027"},{"line_number":22,"context_line":"      register: running_vms"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Fail if there are any running VMs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"56a018e7_18d32917","line":21,"in_reply_to":"a3b87bca_92378658","updated":"2022-03-30 11:27:50.000000000","message":"Turns out this was bad advice - pgrep exiting 1 means there are no matches 😊","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"23a23b7b1d2ddd517f6df85140bf8881a501e45c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      become: true"},{"line_number":19,"context_line":"      shell:"},{"line_number":20,"context_line":"        cmd: |"},{"line_number":21,"context_line":"          pgrep -l qemu | awk \u0027!/qemu-ga/  \u0026\u0026 !/qemu-img/ {print $1}\u0027"},{"line_number":22,"context_line":"      register: running_vms"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Fail if there are any running VMs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a3b87bca_92378658","line":21,"in_reply_to":"d9d45fd8_3949131b","updated":"2022-03-18 17:25:05.000000000","message":"Done","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c7d5ec6feb451f82503b83c84a846ba5488fd86b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      become: true"},{"line_number":19,"context_line":"      shell:"},{"line_number":20,"context_line":"        cmd: |"},{"line_number":21,"context_line":"          pgrep -l qemu | awk \u0027!/qemu-ga/  \u0026\u0026 !/qemu-img/ {print $1}\u0027"},{"line_number":22,"context_line":"      register: running_vms"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Fail if there are any running VMs"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e02849c8_b465db36","line":21,"in_reply_to":"fb0a93bf_3a7ae0d5","updated":"2022-03-30 12:28:26.000000000","message":"Need to fix the pgrep part then.","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"}],"doc/source/reference/compute/libvirt-guide.rst":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5484524f9001adaf6ecc202150fb179048534bba","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Migration from container to host"},{"line_number":39,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The ``kolla-ansible nova-libvirt-cleanup`` command may be used to clean up the"},{"line_number":42,"context_line":"``nova_libvirt`` container, volumes and related items on hosts, once it has"},{"line_number":43,"context_line":"been disabled. This should be run after the compute service has been disabled,"},{"line_number":44,"context_line":"and all active VMs have been migrated away from the host."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"A future extension could support migration of existing VMs, but this is"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c1956f3_f29625b8","line":43,"range":{"start_line":41,"start_character":43,"end_line":43,"end_character":13},"updated":"2022-03-08 16:53:13.000000000","message":"Documentation says that this command will clean up container, volumes and related items - but it\u0027s not true in default configuration because of nova_libvirt_cleanup_remove_volumes: false in defaults.\n\nSo, I think that nova_libvirt_cleanup_remove_volumes default value should be changed to True if it is supposed to work as it is defined in above lines.\n\nOR\n\nChange text of documentation that by default is removed everything exept libvirt kolla volumes, and this behaviour can be changed by override this value in globals.","commit_id":"d19284e2c09de1bbff93986db3a8c859c3eb62c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22bd1a1d143963dd374f23909bc6c483c51644c3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Migration from container to host"},{"line_number":39,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The ``kolla-ansible nova-libvirt-cleanup`` command may be used to clean up the"},{"line_number":42,"context_line":"``nova_libvirt`` container, volumes and related items on hosts, once it has"},{"line_number":43,"context_line":"been disabled. This should be run after the compute service has been disabled,"},{"line_number":44,"context_line":"and all active VMs have been migrated away from the host."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"A future extension could support migration of existing VMs, but this is"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3feac3e2_5c98b084","line":43,"range":{"start_line":41,"start_character":43,"end_line":43,"end_character":13},"in_reply_to":"3c1956f3_f29625b8","updated":"2022-03-10 09:43:16.000000000","message":"Done","commit_id":"d19284e2c09de1bbff93986db3a8c859c3eb62c4"}],"releasenotes/notes/nova-libvirt-cleanup-0d2c3b3156f2f657.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0c3f769a6fb6da96135debf236ba07816e29a5a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a ``kolla-ansible nova-libvirt-cleanup`` command, which may be used to"},{"line_number":5,"context_line":"    clean up the ``nova_libvirt`` container. This may be useful if using a host"},{"line_number":6,"context_line":"    libvirt daemon."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"39736a84_eb552366","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":73},"updated":"2022-03-18 15:49:05.000000000","message":"switching to","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"23a23b7b1d2ddd517f6df85140bf8881a501e45c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a ``kolla-ansible nova-libvirt-cleanup`` command, which may be used to"},{"line_number":5,"context_line":"    clean up the ``nova_libvirt`` container. This may be useful if using a host"},{"line_number":6,"context_line":"    libvirt daemon."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ad47694_b7c2688d","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":73},"in_reply_to":"39736a84_eb552366","updated":"2022-03-18 17:25:05.000000000","message":"Done","commit_id":"385f9d244f3de5c7051c50219282a3e4c835a16e"}]}