)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e21048bf40d69d859462a0d5a8acb4fdf2857afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e23f2bf5_18f1d485","updated":"2022-03-10 07:50:11.000000000","message":"As usual - what happens when somebody has old version of the inventory - without the new group? Will it fail?","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be464c8a0444b2eb46bcf0237003f01c922b474e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68350a13_f7a00968","updated":"2022-03-11 10:27:40.000000000","message":"As you can see in https://50a68c9f12fa1a0c2d14-09748fb7f50c6f484aea83154b0e91bf.ssl.cf5.rackcdn.com/833167/1/check/kolla-ansible-centos8s-source-prometheus-efk/349f1ee/primary/logs/ansible/deploy-prechecks the inventory precheck would fail, alerting the deployer that they need to amend their inventory.\n\nAs this must be a common situation for backports, is there a standard solution for it? IMHO we could add a warning to the upgrade section of the release note, would that be o.k. for you? Or do you think that a solution that does not depend on the existence of this group is required?","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39c32909d19c47f6d9c91c0836ca80b51a0f5563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3e2b52b_e8ae48aa","updated":"2022-03-10 09:52:25.000000000","message":"Glad Michal was on the lookout for troubles. :-)","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9ea6174020ad8563df7accedad847d38e135280f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad9df4f6_94b05564","updated":"2022-03-08 15:25:44.000000000","message":"clean backport","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec5748078ca6a32fafa939abb6300f43ed2a4394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6a42ce5_2c3e0c66","in_reply_to":"68350a13_f7a00968","updated":"2022-03-11 11:19:23.000000000","message":"We could do groups.get(\u0027prometheus-libvirt-exporter\u0027, []) which would return an empty group instead of failing on non-existent group - just like we did for back porting octavia-driver-agent (https://review.opendev.org/c/openstack/kolla-ansible/+/782735/14/ansible/roles/octavia/tasks/check-containers.yml#12).","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e83e41195fac5d8487624e5619f2237d8263ecc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0214652_4d3354ff","in_reply_to":"b5268d07_8d0d4b4f","updated":"2022-03-16 10:30:24.000000000","message":"Used this for the precheck and also made the exporter disabled by default.","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39c32909d19c47f6d9c91c0836ca80b51a0f5563","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19d92550_179594c5","in_reply_to":"e23f2bf5_18f1d485","updated":"2022-03-10 09:52:25.000000000","message":"It will. Also, we should probably change the default to \"no\" so that stable branch users don\u0027t get this by default.","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fa0eadc440ed40a05e38dcb197c551e7dd1019f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5268d07_8d0d4b4f","in_reply_to":"f6a42ce5_2c3e0c66","updated":"2022-03-12 07:43:46.000000000","message":"Note operators may not run prechecks on each redeploy - they are often run on the initial one and then on upgrades.","commit_id":"39238080c3ef68f340c3c143f4b883c660bc8aea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b043c6c73b1165e1a257d3f68564ff3f5be26ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"91dc4a70_c0415202","updated":"2022-03-16 16:17:47.000000000","message":"recheck ansible-lint fix merged","commit_id":"b8b8d84146b343ad88ccd360c2f8ff6ee84fceef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9a2a4a3ba09568d0b0d47af330a09cc5f9554c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fb784899_7456cd46","updated":"2022-03-16 14:43:10.000000000","message":"thanks","commit_id":"b8b8d84146b343ad88ccd360c2f8ff6ee84fceef"}],"ansible/roles/prometheus/tasks/check-containers.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"89e568351b224c72b61c3e12ac8366668a3a6d71","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":14,"context_line":"    - item.value.enabled | bool"},{"line_number":15,"context_line":"  with_dict: \"{{ prometheus_services }}\""},{"line_number":16,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"52a5056b_e89ae0e1","line":13,"updated":"2022-03-16 13:02:19.000000000","message":"this will also fail","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80a3057e239333bd914a38f5e687e3a406d5d290","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    volumes: \"{{ item.value.volumes }}\""},{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":14,"context_line":"    - item.value.enabled | bool"},{"line_number":15,"context_line":"  with_dict: \"{{ prometheus_services }}\""},{"line_number":16,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4bec9c4c_964a21ec","line":13,"in_reply_to":"52a5056b_e89ae0e1","updated":"2022-03-16 14:12:20.000000000","message":"Done","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"}],"ansible/site.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"89e568351b224c72b61c3e12ac8366668a3a6d71","unresolved":true,"context_lines":[{"line_number":435,"context_line":"    - prometheus-openstack-exporter"},{"line_number":436,"context_line":"    - prometheus-elasticsearch-exporter"},{"line_number":437,"context_line":"    - prometheus-blackbox-exporter"},{"line_number":438,"context_line":"    - prometheus-libvirt-exporter"},{"line_number":439,"context_line":"    - \u0027\u0026enable_prometheus_True\u0027"},{"line_number":440,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":441,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"60277dbe_90a3b21b","line":438,"updated":"2022-03-16 13:02:19.000000000","message":"the group might not be found","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80a3057e239333bd914a38f5e687e3a406d5d290","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    - prometheus-openstack-exporter"},{"line_number":436,"context_line":"    - prometheus-elasticsearch-exporter"},{"line_number":437,"context_line":"    - prometheus-blackbox-exporter"},{"line_number":438,"context_line":"    - prometheus-libvirt-exporter"},{"line_number":439,"context_line":"    - \u0027\u0026enable_prometheus_True\u0027"},{"line_number":440,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":441,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83e55de8_ba9e28db","line":438,"in_reply_to":"60277dbe_90a3b21b","updated":"2022-03-16 14:12:20.000000000","message":"IIUC that should only be a warning:\n\n[WARNING]: Could not match supplied host pattern, ignoring: prometheus-libvirt-exporter","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9a2a4a3ba09568d0b0d47af330a09cc5f9554c9e","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    - prometheus-openstack-exporter"},{"line_number":436,"context_line":"    - prometheus-elasticsearch-exporter"},{"line_number":437,"context_line":"    - prometheus-blackbox-exporter"},{"line_number":438,"context_line":"    - prometheus-libvirt-exporter"},{"line_number":439,"context_line":"    - \u0027\u0026enable_prometheus_True\u0027"},{"line_number":440,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":441,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f95b8ad_161a0d4c","line":438,"in_reply_to":"83e55de8_ba9e28db","updated":"2022-03-16 14:43:10.000000000","message":"ack","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"}],"etc/kolla/globals.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"89e568351b224c72b61c3e12ac8366668a3a6d71","unresolved":true,"context_lines":[{"line_number":708,"context_line":"#enable_prometheus_openstack_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":709,"context_line":"#enable_prometheus_elasticsearch_exporter: \"{{ enable_prometheus | bool and enable_elasticsearch | bool }}\""},{"line_number":710,"context_line":"#enable_prometheus_blackbox_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":711,"context_line":"#enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"# List of extra parameters passed to prometheus. You can add as many to the list."},{"line_number":714,"context_line":"#prometheus_cmdline_extras:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"17011707_08408d69","line":711,"range":{"start_line":711,"start_character":38,"end_line":711,"end_character":137},"updated":"2022-03-16 13:02:19.000000000","message":"needs updating","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80a3057e239333bd914a38f5e687e3a406d5d290","unresolved":false,"context_lines":[{"line_number":708,"context_line":"#enable_prometheus_openstack_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":709,"context_line":"#enable_prometheus_elasticsearch_exporter: \"{{ enable_prometheus | bool and enable_elasticsearch | bool }}\""},{"line_number":710,"context_line":"#enable_prometheus_blackbox_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":711,"context_line":"#enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"# List of extra parameters passed to prometheus. You can add as many to the list."},{"line_number":714,"context_line":"#prometheus_cmdline_extras:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b45d09aa_255be161","line":711,"range":{"start_line":711,"start_character":38,"end_line":711,"end_character":137},"in_reply_to":"17011707_08408d69","updated":"2022-03-16 14:12:20.000000000","message":"Done","commit_id":"7682b60d5c61f52c458e784a067524554a94fb69"}]}