)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"30135179670eb3eda7889b318201582baf12e398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d44d2bf5_d50f8c62","updated":"2022-03-05 12:58:45.000000000","message":"TODO: delete old volumes","commit_id":"f6f84a240c180fcd86570b5748598073051ff1d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c298b185961af0a9282802e42ccb0a86574d22b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bbe1ef6d_58b4d382","updated":"2022-03-05 13:43:24.000000000","message":"recheck","commit_id":"f6f84a240c180fcd86570b5748598073051ff1d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"93faeb80e9e09ef82c333ed7c3240c5e24e07ff0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc28ab1b_d2844985","in_reply_to":"d44d2bf5_d50f8c62","updated":"2022-03-05 18:38:00.000000000","message":".","commit_id":"f6f84a240c180fcd86570b5748598073051ff1d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"04c079cd9021ad7d0d7f6d4312edf55f3501e344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27a5e3d9_3bc5dae0","in_reply_to":"dc28ab1b_d2844985","updated":"2022-03-16 14:35:44.000000000","message":"Done","commit_id":"f6f84a240c180fcd86570b5748598073051ff1d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ace633c5a85162f45198cc1e0b9d4712ada5588e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd191886_3075f0ba","updated":"2022-03-05 18:38:21.000000000","message":"(testing plain PXE in the child change)","commit_id":"e41154c617b16a6900a4cb966ce3c2c30ca1a048"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1dc4d4e7c9117c127392112e27299ba883030a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01ca3785_1aea9957","updated":"2022-03-05 20:04:22.000000000","message":"recheck","commit_id":"e41154c617b16a6900a4cb966ce3c2c30ca1a048"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6ba2a95c911538e809f815fd0b7e6daa900c689","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a71be78c_c2c2e846","updated":"2022-03-05 18:35:49.000000000","message":"recheck","commit_id":"e41154c617b16a6900a4cb966ce3c2c30ca1a048"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3113ab70abdf06d22d6ba4ee23fe10739f12643","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aecf2339_0ff235a6","updated":"2022-03-05 18:32:27.000000000","message":"recheck","commit_id":"e41154c617b16a6900a4cb966ce3c2c30ca1a048"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"04c079cd9021ad7d0d7f6d4312edf55f3501e344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"24dbb587_f0947e18","updated":"2022-03-16 14:35:44.000000000","message":"assuming this passes in CI, it\u0027s ready for reviews; https://review.opendev.org/c/openstack/kolla-ansible/+/832134 will be based off of it","commit_id":"7cd220fa5140db5364833f6c936625d69bedf9de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1105d32f979f0bbfa51cdaa8fc50fb8daef9413c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b274b87_7b97d29e","updated":"2022-03-16 16:30:02.000000000","message":"recheck","commit_id":"7cd220fa5140db5364833f6c936625d69bedf9de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ce63e19ecb5b917a9cbb7fd64f8f05f11501a784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"996dffb1_8444879c","updated":"2022-03-16 20:13:14.000000000","message":"recheck","commit_id":"7cd220fa5140db5364833f6c936625d69bedf9de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e7d4b070f24b66bfa8792c0ae8505912b34ad115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ded23ede_66ce7502","updated":"2022-03-17 10:36:26.000000000","message":"recheck","commit_id":"7cd220fa5140db5364833f6c936625d69bedf9de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"51931f109d382d1bcfa3cc98d37aed404b60a5d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9907575b_6d70bd1e","updated":"2022-03-18 16:19:00.000000000","message":"conflict on https://review.opendev.org/c/openstack/kolla-ansible/+/831999","commit_id":"edaaf0fc7dbf86d01a1a3c05c8b80df9322f0e7a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e54c4c5d4b94df6dd1ecc62f163fc088b805cb7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c621cc9d_5f49fb24","updated":"2022-03-17 17:21:39.000000000","message":"recheck","commit_id":"edaaf0fc7dbf86d01a1a3c05c8b80df9322f0e7a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c3447994e391d7663c8e1278901d2fb1bb6cca64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5e9b7ec0_3c28ae66","updated":"2022-03-21 11:39:32.000000000","message":"oopsie, forgot about reno","commit_id":"9d3d18fa3cdb6e6ea233189f6dc72e0801fde87f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8b9178101d0321c0a858fd0edf19aba0ab2dee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ffb784de_5ae05097","updated":"2022-03-21 11:32:20.000000000","message":"upgrade testing in https://review.opendev.org/c/openstack/kolla-ansible/+/834004\n(this actually fixes upgrades as they are normally broken by pxe being \"misconfigured\")","commit_id":"9d3d18fa3cdb6e6ea233189f6dc72e0801fde87f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"630e74263e6bf6dc574a25bed8aa02fc63589af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"901e62ae_7d7e563d","updated":"2022-03-21 20:42:22.000000000","message":"Need to consider in-flight operations during upgrades, which would have their PXE state destroyed by this change. At a minimum, query ironic for nodes in wait states at the start of the upgrade, and bomb out if any are found.","commit_id":"8dcbefe2be93d5329ec4191957c2364d59798365"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1c7eeeb0a20a64532ea85bae67bd7762c920d3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7b2256c4_1a962c43","in_reply_to":"3d1ca36e_14417fd2","updated":"2022-04-11 09:07:22.000000000","message":"Done","commit_id":"8dcbefe2be93d5329ec4191957c2364d59798365"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9fdebda7608877019cf8e6a3f143079317c0d60f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b8e3ecef_c716440e","in_reply_to":"901e62ae_7d7e563d","updated":"2022-03-22 07:36:56.000000000","message":"I will work on it in https://review.opendev.org/c/openstack/kolla-ansible/+/834004 as this one runs too many jobs. Once we are satisfied, I can amend this one here.","commit_id":"8dcbefe2be93d5329ec4191957c2364d59798365"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"128e0042600560466e658e88ae0c310c5751beec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3d1ca36e_14417fd2","in_reply_to":"b8e3ecef_c716440e","updated":"2022-03-22 19:11:10.000000000","message":"The patch is ready, please have a look.","commit_id":"8dcbefe2be93d5329ec4191957c2364d59798365"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cc3e35565ea64fd5753b5ac7eb5df431d8ed25a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"27745ef5_581cef34","updated":"2022-04-01 16:38:46.000000000","message":"Doing some kayobe testing here, but I think it will fail since it won\u0027t build a new image. https://review.opendev.org/c/openstack/kayobe/+/836203","commit_id":"95cf0f5b3c5725b9ba0eebea3d744657d02a34a2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"54e2191f0769aa9575b7f5bdc73a8073362e002a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"816a8b85_fdfa5ca0","updated":"2022-03-30 21:06:19.000000000","message":"IMHO the iPXE is the preferred way to provision nowadays, no need to support old-fashioned PXE way","commit_id":"95cf0f5b3c5725b9ba0eebea3d744657d02a34a2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5597a96c3158cf9f431b5947a02780d1f52b20f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"031a9242_0e7e4d82","in_reply_to":"816a8b85_fdfa5ca0","updated":"2022-03-31 11:50:06.000000000","message":"Well, it\u0027s a general cleanup and it leaves iPXE as the default. This patch allows operators to slowly migrate to iPXE and not just break their PXE deployments when going Yoga.","commit_id":"95cf0f5b3c5725b9ba0eebea3d744657d02a34a2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bc27bb282f40409898d50a3921af59236224d5bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c7b51b8e_84362568","updated":"2022-04-07 07:26:04.000000000","message":"recheck\n\nnew images are there","commit_id":"9503308a8787c136e7351e6801a565c5e00c313c"}],"ansible/roles/ironic/tasks/upgrade.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1c7eeeb0a20a64532ea85bae67bd7762c920d3ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Wait for Ironic nodes not to wait"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    docker exec kolla_toolbox openstack"},{"line_number":6,"context_line":"    --os-interface {{ openstack_interface }}"},{"line_number":7,"context_line":"    --os-auth-url {{ openstack_auth.auth_url }}"},{"line_number":8,"context_line":"    --os-username {{ openstack_auth.username }}"},{"line_number":9,"context_line":"    --os-password {{ openstack_auth.password }}"},{"line_number":10,"context_line":"    --os-identity-api-version 3"},{"line_number":11,"context_line":"    --os-user-domain-name {{ openstack_auth.user_domain_name }}"},{"line_number":12,"context_line":"    --os-system-scope {{ openstack_auth.system_scope }}"},{"line_number":13,"context_line":"    --os-region-name {{ openstack_region_name }}"},{"line_number":14,"context_line":"    {% if openstack_cacert !\u003d \u0027\u0027 %}--os-cacert {{ openstack_cacert }}{% endif %}"},{"line_number":15,"context_line":"    baremetal node list --format json --column \"Provisioning State\""},{"line_number":16,"context_line":"  register: ironic_nodes"},{"line_number":17,"context_line":"  changed_when: false"},{"line_number":18,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5b35e83b_486d2b4a","line":15,"range":{"start_line":4,"start_character":0,"end_line":15,"end_character":67},"updated":"2022-04-11 09:07:22.000000000","message":"potential to move to baremetal_node_info from ansible-collections-openstack - as a followup","commit_id":"9503308a8787c136e7351e6801a565c5e00c313c"}],"ansible/roles/ironic/templates/ironic-pxe.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1c7eeeb0a20a64532ea85bae67bd7762c920d3ec","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set pxe_cfg \u003d \u0027grub.cfg\u0027 if enable_ironic_pxe_uefi | bool else \u0027default\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/in.tftpd --verbose --foreground --user root --address 0.0.0.0:69 --map-file /map-file /var/lib/ironic/tftpboot\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"{% if not enable_ironic_ipxe | bool and groups[\u0027ironic-inspector\u0027] | length \u003e 0 %}"},{"line_number":8,"context_line":"{% if not enable_ironic_pxe_uefi | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"4ddfcc5a_507ac53f","line":5,"range":{"start_line":5,"start_character":80,"end_line":5,"end_character":90},"updated":"2022-04-11 09:07:22.000000000","message":"we could make it more strict - tftpd results as a ,,potential vulnerability\u0027\u0027 in some scanners","commit_id":"9503308a8787c136e7351e6801a565c5e00c313c"}],"ansible/roles/ironic/templates/ironic.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"93faeb80e9e09ef82c333ed7c3240c5e24e07ff0","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"[pxe]"},{"line_number":185,"context_line":"pxe_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,{{ ironic_console_serial_speed }}"},{"line_number":186,"context_line":"{% if enable_ironic_ipxe | bool %}"},{"line_number":187,"context_line":"{# NOTE(mgoddard): iPXE uses the TFTP image cache (tftp_master_path, default"},{"line_number":188,"context_line":"   /tftpboot/master_images), in which images get hard linked to the http_root"},{"line_number":189,"context_line":"   directory (/httpboot). These must be on the same device, but /httpboot and"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"77623036_d7806265","side":"PARENT","line":186,"range":{"start_line":186,"start_character":6,"end_line":186,"end_character":25},"updated":"2022-03-05 18:38:00.000000000","message":"this var is becoming meaningless, except for inspector - let\u0027s make some amendments","commit_id":"68bc4f8f52f3e086efb1e72fd6ccdd36e8d0139a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"04c079cd9021ad7d0d7f6d4312edf55f3501e344","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"[pxe]"},{"line_number":185,"context_line":"pxe_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,{{ ironic_console_serial_speed }}"},{"line_number":186,"context_line":"{% if enable_ironic_ipxe | bool %}"},{"line_number":187,"context_line":"{# NOTE(mgoddard): iPXE uses the TFTP image cache (tftp_master_path, default"},{"line_number":188,"context_line":"   /tftpboot/master_images), in which images get hard linked to the http_root"},{"line_number":189,"context_line":"   directory (/httpboot). These must be on the same device, but /httpboot and"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f04e2fa_5dd8966e","side":"PARENT","line":186,"range":{"start_line":186,"start_character":6,"end_line":186,"end_character":25},"in_reply_to":"77623036_d7806265","updated":"2022-03-16 14:35:44.000000000","message":"this is for followups","commit_id":"68bc4f8f52f3e086efb1e72fd6ccdd36e8d0139a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c384505cfaa845c39c2668c72ba6a37fdd0829b9","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"[pxe]"},{"line_number":185,"context_line":"pxe_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,{{ ironic_console_serial_speed }}"},{"line_number":186,"context_line":"{% if enable_ironic_ipxe | bool %}"},{"line_number":187,"context_line":"{# NOTE(mgoddard): iPXE uses the TFTP image cache (tftp_master_path, default"},{"line_number":188,"context_line":"   /tftpboot/master_images), in which images get hard linked to the http_root"},{"line_number":189,"context_line":"   directory (/httpboot). These must be on the same device, but /httpboot and"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b9cba319_ac0d19c6","side":"PARENT","line":186,"range":{"start_line":186,"start_character":6,"end_line":186,"end_character":25},"in_reply_to":"9f04e2fa_5dd8966e","updated":"2022-03-21 15:58:17.000000000","message":"Done in https://review.opendev.org/c/openstack/kolla-ansible/+/834511","commit_id":"68bc4f8f52f3e086efb1e72fd6ccdd36e8d0139a"}]}