)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a115322fab9c8af72a6354a5f457bae16925c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c29989d_1992aa70","updated":"2022-03-10 13:44:02.000000000","message":"Debian fails creating SASL user. Debugging here: https://review.opendev.org/c/openstack/kolla-ansible/+/833087","commit_id":"7306cec9bfc736dbe21ec52b8e8612db0a8a53e5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"61c9de3b99674c8697a83e4b7636fccd829e539f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd26c257_56922ff6","updated":"2022-03-10 11:05:17.000000000","message":"recheck","commit_id":"7306cec9bfc736dbe21ec52b8e8612db0a8a53e5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d12b8ef945dd0af3983dd91d2b6ba630c4a47070","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1152174_66f9c0aa","in_reply_to":"3c29989d_1992aa70","updated":"2022-03-10 15:11:04.000000000","message":"/bin/sh: 1: set: Illegal option -o pipefail","commit_id":"7306cec9bfc736dbe21ec52b8e8612db0a8a53e5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e690a5ceb2c8ea4013416dff811a209974d4083d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"471841a7_698ee5c8","updated":"2022-03-11 16:24:23.000000000","message":"Will need to wait for images to get published now.","commit_id":"d2d4b53d47df3b1a250c21404a8ec140873d4ce5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d9e2cdabfd5f7c16501ef5992961e237ea821406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f724df8_baca94de","updated":"2022-03-12 13:55:15.000000000","message":"recheck","commit_id":"d2d4b53d47df3b1a250c21404a8ec140873d4ce5"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ac6bc77d3d8fa0fccb648410e4f8c2de45d000f","unresolved":false,"context_lines":[{"line_number":535,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":536,"context_line":"# List of enabled libvirt SASL authentication mechanisms."},{"line_number":537,"context_line":"libvirt_sasl_mech_list:"},{"line_number":538,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"####################"},{"line_number":541,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e1a08cb7_09eb3609","line":538,"range":{"start_line":538,"start_character":8,"end_line":538,"end_character":38},"updated":"2022-03-10 10:51:11.000000000","message":"as I said in the bug report - I don\u0027t think in our setup we need SCRAM with TLS but I\u0027m not opposing - it might be more flexible at minimal cost","commit_id":"08238e46da3e53103b92564e817d1763a8b7c35c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5751a0c2a11dc788166de44465e0b7dd05221a8","unresolved":false,"context_lines":[{"line_number":535,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":536,"context_line":"# List of enabled libvirt SASL authentication mechanisms."},{"line_number":537,"context_line":"libvirt_sasl_mech_list:"},{"line_number":538,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"####################"},{"line_number":541,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ed656443_dd6b74e1","line":538,"range":{"start_line":538,"start_character":8,"end_line":538,"end_character":38},"in_reply_to":"c2f83338_2650d30d","updated":"2022-03-10 11:01:04.000000000","message":"/me guessing this is related to how they process certs or alike. As I said :-) I\u0027m not opposing having this. It\u0027s perfectly fine.","commit_id":"08238e46da3e53103b92564e817d1763a8b7c35c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a73ba8918f3c40b21efa22c8fe0019258568438e","unresolved":true,"context_lines":[{"line_number":535,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":536,"context_line":"# List of enabled libvirt SASL authentication mechanisms."},{"line_number":537,"context_line":"libvirt_sasl_mech_list:"},{"line_number":538,"context_line":"  - \"{{ \u0027SCRAM-SHA-256\u0027 if libvirt_tls | bool else \u0027DIGEST-MD5\u0027 }}\""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"####################"},{"line_number":541,"context_line":"# Kolla"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c2f83338_2650d30d","line":538,"range":{"start_line":538,"start_character":8,"end_line":538,"end_character":38},"in_reply_to":"e1a08cb7_09eb3609","updated":"2022-03-10 10:57:10.000000000","message":"And as I said:\n\nThis bug report suggests libvirt client certs alone are not secure as an authentication method. https://bugzilla.redhat.com/show_bug.cgi?id\u003d1513440. Unfortunately I can\u0027t access the linked bug report, https://bugzilla.redhat.com/show_bug.cgi?id\u003d1510216.\n\nI\u0027d like to see the contents of that bug report. Maybe we can ask someone from RH.","commit_id":"08238e46da3e53103b92564e817d1763a8b7c35c"}],"ansible/roles/nova-cell/handlers/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ac6bc77d3d8fa0fccb648410e4f8c2de45d000f","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    docker exec -i nova_libvirt saslpasswd2 -c -p -a libvirt {{ libvirt_sasl_authname }}"},{"line_number":125,"context_line":"  changed_when: true"},{"line_number":126,"context_line":"  no_log: true"},{"line_number":127,"context_line":"  when:"},{"line_number":128,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"- name: Restart nova-compute container"},{"line_number":131,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e0ef9d26_ee47fc6e","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":30},"updated":"2022-03-10 10:51:11.000000000","message":"nit: not needed","commit_id":"08238e46da3e53103b92564e817d1763a8b7c35c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a73ba8918f3c40b21efa22c8fe0019258568438e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    docker exec -i nova_libvirt saslpasswd2 -c -p -a libvirt {{ libvirt_sasl_authname }}"},{"line_number":125,"context_line":"  changed_when: true"},{"line_number":126,"context_line":"  no_log: true"},{"line_number":127,"context_line":"  when:"},{"line_number":128,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"- name: Restart nova-compute container"},{"line_number":131,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ca5c4d3a_959ea26f","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":30},"in_reply_to":"e0ef9d26_ee47fc6e","updated":"2022-03-10 10:57:10.000000000","message":"Done","commit_id":"08238e46da3e53103b92564e817d1763a8b7c35c"}],"ansible/roles/nova-cell/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1397d1fe0af94e9a38a876a69fb85ed35ebfd552","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  template:"},{"line_number":106,"context_line":"    src: \"{{ item.src }}\""},{"line_number":107,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ item.dest }}\""},{"line_number":108,"context_line":"    mode: \"0660\""},{"line_number":109,"context_line":"  when:"},{"line_number":110,"context_line":"    - libvirt_enable_sasl | bool"},{"line_number":111,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9d51e4e8_3ea57501","line":108,"range":{"start_line":108,"start_character":13,"end_line":108,"end_character":14},"updated":"2022-03-10 21:08:07.000000000","message":"why not 0?","commit_id":"d2d4b53d47df3b1a250c21404a8ec140873d4ce5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a2920d2b7c389eb1303802f9a15688423335c7f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  template:"},{"line_number":106,"context_line":"    src: \"{{ item.src }}\""},{"line_number":107,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ item.dest }}\""},{"line_number":108,"context_line":"    mode: \"0660\""},{"line_number":109,"context_line":"  when:"},{"line_number":110,"context_line":"    - libvirt_enable_sasl | bool"},{"line_number":111,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"03c78f49_20117be2","line":108,"range":{"start_line":108,"start_character":13,"end_line":108,"end_character":14},"in_reply_to":"4f186702_498c2b8e","updated":"2022-03-11 09:58:43.000000000","message":"Ack","commit_id":"d2d4b53d47df3b1a250c21404a8ec140873d4ce5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"964ec8060fec85b4d9a2fc5aa3b96dd839243129","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  template:"},{"line_number":106,"context_line":"    src: \"{{ item.src }}\""},{"line_number":107,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/{{ item.dest }}\""},{"line_number":108,"context_line":"    mode: \"0660\""},{"line_number":109,"context_line":"  when:"},{"line_number":110,"context_line":"    - libvirt_enable_sasl | bool"},{"line_number":111,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4f186702_498c2b8e","line":108,"range":{"start_line":108,"start_character":13,"end_line":108,"end_character":14},"in_reply_to":"9d51e4e8_3ea57501","updated":"2022-03-11 09:31:43.000000000","message":"We use 0660 everywhere, and check for it in check-config.sh. It\u0027s root/root, so shouldn\u0027t make too much difference.","commit_id":"d2d4b53d47df3b1a250c21404a8ec140873d4ce5"}],"doc/source/reference/compute/libvirt-guide.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ac6bc77d3d8fa0fccb648410e4f8c2de45d000f","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. libvirt-tls-guide:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Libvirt - Nova Virtualisation Driver"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8050b0cf_ea37d023","side":"PARENT","line":1,"updated":"2022-03-10 10:51:11.000000000","message":"why remove?","commit_id":"f26b9cd8ada1161c3d422a7633e371ef7fc115ac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5751a0c2a11dc788166de44465e0b7dd05221a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. libvirt-tls-guide:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Libvirt - Nova Virtualisation Driver"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f450c025_24f09a90","side":"PARENT","line":1,"in_reply_to":"410bc72f_5ad6ee9d","updated":"2022-03-10 11:01:04.000000000","message":"Ack, thanks.","commit_id":"f26b9cd8ada1161c3d422a7633e371ef7fc115ac"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a73ba8918f3c40b21efa22c8fe0019258568438e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. libvirt-tls-guide:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Libvirt - Nova Virtualisation Driver"}],"source_content_type":"text/x-rst","patch_set":2,"id":"410bc72f_5ad6ee9d","side":"PARENT","line":1,"in_reply_to":"8050b0cf_ea37d023","updated":"2022-03-10 10:57:10.000000000","message":"It\u0027s not referenced anywhere, and this page isn\u0027t just about TLS any more.","commit_id":"f26b9cd8ada1161c3d422a7633e371ef7fc115ac"}]}