)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"847f420130587a5fff4d0357bf7355dba3ebec43","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-03-15 14:58:39 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid generating haproxy services configs on nodes without appropriate services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change excludes generating haproxy services.d config files"},{"line_number":10,"context_line":"for services which hosted on non control hostgroup"},{"line_number":11,"context_line":"in case of the nodes have their own balancer."},{"line_number":12,"context_line":"We can separate traffic from one input point (control group ) to several points."},{"line_number":13,"context_line":"Control plane can be free from non core services like Elastic etc."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"37be4fdc_2d10b25b","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":45},"updated":"2022-03-15 13:35:32.000000000","message":"We don\u0027t assume that services are colocated with their loadbalancer.\n\nWe can\u0027t assume that if a service isn\u0027t colocated with the loadbalancer, that it has its own loadbalancer.\n\nWe would need some new way to state that a service is load balanced externally, then skip haproxy-config in that case.","commit_id":"cf1c44e486ad036411395e0be356794304b4f92f"},{"author":{"_account_id":34270,"name":"Nikolay Fedorov","email":"jingvar@gmail.com","username":"jingvar"},"change_message_id":"b23f294caa45765073bf5508c3523481db1a9d0c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-03-15 14:58:39 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid generating haproxy services configs on nodes without appropriate services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change excludes generating haproxy services.d config files"},{"line_number":10,"context_line":"for services which hosted on non control hostgroup"},{"line_number":11,"context_line":"in case of the nodes have their own balancer."},{"line_number":12,"context_line":"We can separate traffic from one input point (control group ) to several points."},{"line_number":13,"context_line":"Control plane can be free from non core services like Elastic etc."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d72e342c_45703add","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":45},"in_reply_to":"37be4fdc_2d10b25b","updated":"2022-03-15 14:02:05.000000000","message":"I understand. But I was afraid to bring a lot of changes one time.\nWe have hostgroup_vips in our downstream.\nmonitoring_vip for example.\nCan we discuss it on weekly meeting?","commit_id":"cf1c44e486ad036411395e0be356794304b4f92f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f7e7173a2dd31128b5a1ef284066b971dc9350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a7a07474_de225692","updated":"2022-03-14 09:32:28.000000000","message":"Two problems.\n\n1. HAProxy may not be colocated with the services it load balances\n2. We don\u0027t use the intermediate groups directly. e.g. we use nova-api, but not nova.","commit_id":"cc8b36e825f972ebe859c36c109c0f07eab9a4af"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babccfc63730c6da675867be868f6da9565780c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e4e6677_3496fe59","in_reply_to":"a7a07474_de225692","updated":"2022-03-14 10:28:19.000000000","message":"1. still applies","commit_id":"cc8b36e825f972ebe859c36c109c0f07eab9a4af"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"993bded0110bf8d1282263c2cbead5543a6ef868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"966cd32c_00f39d66","updated":"2022-03-15 09:41:49.000000000","message":"Same comments still apply. Please raise a bug report, describing the issue, then maybe I can help to suggest a solution.","commit_id":"a8b9531c2d1e06b602877815fc335688c782b1e8"}]}