)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e42b721c48b35af597ee35b1842dc27c861bae55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04fa1c0a_73fa9f11","updated":"2022-03-24 14:42:58.000000000","message":"-1 per unresolved comments","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f1276379eac411fd9b09ea08b4f482c4c840749b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c8fd9741_763f1000","updated":"2022-03-21 13:12:31.000000000","message":"Missing venus","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0c341bb0090984696f2556728059e7beb0262bb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d503f5ac_ca35f920","in_reply_to":"c8fd9741_763f1000","updated":"2022-03-24 14:43:22.000000000","message":"(unresolving)","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c1e766e51c0da9c96c422a717f47059804cc97fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b294858_3d6ee13a","in_reply_to":"d503f5ac_ca35f920","updated":"2022-06-09 20:46:29.000000000","message":"Venus has been removed.","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"}],"ansible/roles/aodh/templates/aodh.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab85b7e4ef27c65068f6c0fe959d8372da9fdbd5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"max_pool_size \u003d {{ database_max_pool_size }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[keystone_authtoken]"},{"line_number":19,"context_line":"service_type \u003d alarming"},{"line_number":20,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":21,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":22,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"95ac5228_e5fcaeb0","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":23},"updated":"2022-03-21 17:39:41.000000000","message":"lol, very","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e42b721c48b35af597ee35b1842dc27c861bae55","unresolved":false,"context_lines":[{"line_number":16,"context_line":"max_pool_size \u003d {{ database_max_pool_size }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[keystone_authtoken]"},{"line_number":19,"context_line":"service_type \u003d alarming"},{"line_number":20,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":21,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":22,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d998fc13_6e62ecf3","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":23},"in_reply_to":"95ac5228_e5fcaeb0","updated":"2022-03-24 14:42:58.000000000","message":"😂","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"}],"ansible/roles/magnum/templates/magnum.conf.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c1e766e51c0da9c96c422a717f47059804cc97fd","unresolved":true,"context_lines":[{"line_number":75,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[keystone_authtoken]"},{"line_number":78,"context_line":"server_type \u003d container-infra"},{"line_number":79,"context_line":"auth_version \u003d v3"},{"line_number":80,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}/v3"},{"line_number":81,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ae06ea4f_84c4ff00","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":11},"updated":"2022-06-09 20:46:29.000000000","message":"service_type","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"522dabac04748c28889686962e94a775a7494eea","unresolved":false,"context_lines":[{"line_number":75,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[keystone_authtoken]"},{"line_number":78,"context_line":"server_type \u003d container-infra"},{"line_number":79,"context_line":"auth_version \u003d v3"},{"line_number":80,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}/v3"},{"line_number":81,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b854a56c_eb3be879","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":11},"in_reply_to":"ae06ea4f_84c4ff00","updated":"2022-06-09 20:50:45.000000000","message":"Done","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"}],"ansible/roles/solum/templates/solum.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab85b7e4ef27c65068f6c0fe959d8372da9fdbd5","unresolved":true,"context_lines":[{"line_number":48,"context_line":"max_retries \u003d -1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[keystone_authtoken]"},{"line_number":51,"context_line":"service_type \u003d image_builder"},{"line_number":52,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":54,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"87affe15_83a8a97f","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":28},"updated":"2022-03-21 17:39:41.000000000","message":"application_deployment","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"522dabac04748c28889686962e94a775a7494eea","unresolved":false,"context_lines":[{"line_number":48,"context_line":"max_retries \u003d -1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[keystone_authtoken]"},{"line_number":51,"context_line":"service_type \u003d image_builder"},{"line_number":52,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":54,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"903361b4_ba99e427","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":28},"in_reply_to":"87affe15_83a8a97f","updated":"2022-06-09 20:50:45.000000000","message":"Done","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ba2a62f2927fe69d310af7415ad655170c5ab021","unresolved":true,"context_lines":[{"line_number":48,"context_line":"max_retries \u003d -1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[keystone_authtoken]"},{"line_number":51,"context_line":"service_type \u003d application_deployment"},{"line_number":52,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":54,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f9f33ce_dc93f3dd","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":37},"updated":"2022-06-13 09:56:55.000000000","message":"This is only one service_type which use \u0027_\u0027 and all others use \u0027-\u0027.\n\nCan we use \u0027-\u0027 instead of \u0027_\u0027 to have same naming convention ?","commit_id":"49006e56d99199b696bd762eb3167dbba42237e1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b96cd4f7cfea44882b62cab04e3eebae0fc0cf55","unresolved":true,"context_lines":[{"line_number":48,"context_line":"max_retries \u003d -1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[keystone_authtoken]"},{"line_number":51,"context_line":"service_type \u003d application_deployment"},{"line_number":52,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":54,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c5d9726f_fbd99026","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":37},"in_reply_to":"5f9f33ce_dc93f3dd","updated":"2022-06-13 10:27:24.000000000","message":"I think it should match this: https://opendev.org/openstack/kolla-ansible/src/commit/ddd00ae9f0fd50a3b4ae39e5aa6b92fbddf45d91/ansible/roles/solum/defaults/main.yml#L213","commit_id":"49006e56d99199b696bd762eb3167dbba42237e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eb012957606b0fc225e554fdb995061b00f35c18","unresolved":true,"context_lines":[{"line_number":48,"context_line":"max_retries \u003d -1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[keystone_authtoken]"},{"line_number":51,"context_line":"service_type \u003d application_deployment"},{"line_number":52,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":54,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f198289c_0e00441c","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":37},"in_reply_to":"c5d9726f_fbd99026","updated":"2022-06-13 10:47:24.000000000","message":"Ok, good argumentation :), then it looks good for me.","commit_id":"49006e56d99199b696bd762eb3167dbba42237e1"}],"ansible/roles/zun/templates/zun.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab85b7e4ef27c65068f6c0fe959d8372da9fdbd5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fc23fadc_edb3d62a","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"updated":"2022-03-21 17:39:41.000000000","message":"Probably not required here","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e9bfd626ebec480bebc18dcdbbb0c357f104a00","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"af5fa25e_1c428d3d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"3d764078_02692d7e","updated":"2022-03-24 14:52:43.000000000","message":"Yes, but I expect service_type is required only for keystone_authtoken, not every section with keystone creds.","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"82c56bc7352f9c4e64776a4984974449cbcf89cb","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a32e0b5b_52deeb26","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"83220f43_6484dd32","updated":"2022-03-24 15:00:14.000000000","message":"OK, then remove as it should not be picked up anyway.","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f0c8a3b7d09faa011fab67c1360e9c768df24658","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ac4379ad_7a97c0b7","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"a32e0b5b_52deeb26","updated":"2022-06-09 20:50:33.000000000","message":"Done","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fa41225ed1ce2e098c0067eb69afb0fce39abe1b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"cc1398e0_ea04dfb3","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"af5fa25e_1c428d3d","updated":"2022-03-24 14:54:30.000000000","message":"Well, if you don\u0027t want to dig into Zun internals to see which one is used for app credentials (and if not both - each for different action) then I would not bother and play it safe with the duplicate which aligns with the comment\u0027s declared needs.","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"da721d96350103bf9189eaed92e6d350e5a2492b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"83220f43_6484dd32","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"cc1398e0_ea04dfb3","updated":"2022-03-24 14:56:26.000000000","message":"Option doesn\u0027t exist in keystone_auth: https://docs.openstack.org/zun/latest/configuration/sample-config.html","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e42b721c48b35af597ee35b1842dc27c861bae55","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# keystone_authtoken sections are used and Zun internals may use either -"},{"line_number":32,"context_line":"# - best keep them both in sync"},{"line_number":33,"context_line":"[keystone_auth]"},{"line_number":34,"context_line":"service_type \u003d container"},{"line_number":35,"context_line":"www_authenticate_uri \u003d {{ keystone_internal_url }}"},{"line_number":36,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":37,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3d764078_02692d7e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":24},"in_reply_to":"fc23fadc_edb3d62a","updated":"2022-03-24 14:42:58.000000000","message":"I would keep it per the comment above.","commit_id":"8ca9b40c25689e10201271f081e127a382f357bf"}]}