)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"67ae2ffd9fdf9d5a27934be5e149f47d0ba039aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab51130b_efc54def","updated":"2022-04-05 15:38:44.000000000","message":"Looks like the precheck fails if the group doesn\u0027t exist, even if the service isn\u0027t enabled:\n\nTASK [service-precheck : prometheus | Validate inventory groups] ***************************************************************************\n----------------- SNIP\nfailed: [compute0] (item\u003dprometheus-libvirt-exporter) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": {\"key\": \"prometheus-libvirt-exporter\", \"value\": {\"container_name\": \"prometheus_libvirt_exporter\", \"dimensions\": {}, \"enabled\": false, \"group\": \"prometheus-libvirt-exporter\", \"image\": \"192.168.33.5:4000/openstack.kolla/centos-source-prometheus-libvirt-exporter:xena\", \"volumes\": [\"/etc/kolla/prometheus-libvirt-exporter/:/var/lib/kolla/config_files/:ro\", \"/etc/localtime:/etc/localtime:ro\", \"\", \"/run/libvirt:/run/libvirt:ro\"]}}, \"msg\": \"Ansible inventory does not contain the expected group prometheus-libvirt-exporter for service prometheus-libvirt-exporter in prometheus.\"}\n\nA bit annoying, but at least it\u0027s only a precheck, and it\u0027s quite obvious what to do.","commit_id":"fbb2de815f73a44c5d6cfc6e634ff48da8e55eb9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3e8a7817456b4017ea832fa84cbd600c2960536e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aaee444a_1b2ed927","updated":"2022-03-26 20:00:37.000000000","message":"hmm, are you sure? this is behind a conditional, it should not be evaluated; is jinja dumb again?","commit_id":"fbb2de815f73a44c5d6cfc6e634ff48da8e55eb9"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"13a1dee4f8fef91506b7d10c6ca02f4e418a1cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d302efe2_46f52f51","in_reply_to":"aaee444a_1b2ed927","updated":"2022-03-28 08:07:10.000000000","message":"My mistake, this only happens when enable_prometheus_libvirt_exporter is true but the inventory is missing the group. You can argue that it is a good thing that we fail rather than silently ignoring these metrics.","commit_id":"fbb2de815f73a44c5d6cfc6e634ff48da8e55eb9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9a89d71e2ec8982004dab2eaca19e04b00b73250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"841a162b_a7eba0bc","in_reply_to":"d302efe2_46f52f51","updated":"2022-03-28 08:09:44.000000000","message":"Thanks for confirming.","commit_id":"fbb2de815f73a44c5d6cfc6e634ff48da8e55eb9"}]}