)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5c7c17d7a827a9531ca2de445028d76187a5afc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ed799200_db7a2fc0","updated":"2022-04-07 06:41:34.000000000","message":"this used to be \"CI: cephadm: add disks in one go\"\n\nwhat are you trying to improve here? is there an inherent problem with cephadm shell? is it going away? I am also worried about installing ceph-common on the host machine in CI only to hide some issue that appears without this package installed","commit_id":"0c840dc569f8a8f33787b7767d07af2d9708d7fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b868d5792e5aad5e8af4283c0745a390a5c1b0e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9880d58f_621c2ddc","in_reply_to":"08d2adf0_d6204bba","updated":"2022-04-07 07:22:01.000000000","message":"Option 4: start the cephadm container ourselves, do what we need from it, clean it up.\n\nThat one I prefer.\n\nThanks for elaborating on the issue.","commit_id":"0c840dc569f8a8f33787b7767d07af2d9708d7fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"48f5d172096a31ca26406ecd2f125660824200a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a9d60433_51cf1738","in_reply_to":"9880d58f_621c2ddc","updated":"2022-06-03 12:11:22.000000000","message":"Done","commit_id":"0c840dc569f8a8f33787b7767d07af2d9708d7fd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9e3f240a2e42f3a8573dd3b8bb58e41616d20644","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"08d2adf0_d6204bba","in_reply_to":"ed799200_db7a2fc0","updated":"2022-04-07 07:04:50.000000000","message":"Basically the issue is that \"cephadm shell\" runs a docker container for running the command, the issues we see with cephadm deployment is on ,,looped\u0027\u0027 commands where we add e.g. 3 OSDs. The issue is that we run the second command before cephadm shell is able to clean up after itself.\nOption 1: add delay\nOption 2: do it in one run - but I was struggling with some errors - which probably show up due to the docker run/podman run nature of cephadm shell\nOption 3: install client and do it 5 times faster\n\nWhich one do you prefer? ;-)","commit_id":"0c840dc569f8a8f33787b7767d07af2d9708d7fd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"238b72ba5627f940e801b31a3de525ec826441b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6eab2475_75a8057b","updated":"2022-04-19 10:00:41.000000000","message":"We can even pause for longer, it will not hurt.","commit_id":"9311a5b4035f39cc196aa4b6acd3145a3b6f43a5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"16fe1748da7387ab77affc634989bca6c10b4a51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a5fce121_ae0987c3","in_reply_to":"6eab2475_75a8057b","updated":"2022-04-19 10:05:48.000000000","message":"How much longer? 5 seconds seems like an overkill (given we have a couple of loops)","commit_id":"9311a5b4035f39cc196aa4b6acd3145a3b6f43a5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9c54cbc8e3407a834364f2e56d43f0bc1c94737f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"da1b6f3e_99b57928","in_reply_to":"a5fce121_ae0987c3","updated":"2022-04-19 10:40:41.000000000","message":"We have 3,4,3 loop items which gives us 2,3,2 pauses, 7 pauses in total. Times 5 this is 35 seconds. Times 4 is 28 which sounds very reasonable to spare.\n\nAnyhow, what about pauses between tasks? Is Ansible \"slow enough\" to always \"pause\" for more than a second? If so, we could just replicate the expected \"pause\" of Ansible itself and reuse that in the loop. If we don\u0027t know, we might want to pause outside of the loops as well.\n\nI also came up with Option 5 - template a script to pass to cephadm shell (I think it allows piping with bash) which avoids calling cephadm shell more than once, saving us time and sanity. WDYT?","commit_id":"9311a5b4035f39cc196aa4b6acd3145a3b6f43a5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"48f5d172096a31ca26406ecd2f125660824200a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5d034d60_41238c3b","in_reply_to":"da1b6f3e_99b57928","updated":"2022-06-03 12:11:22.000000000","message":"Done","commit_id":"9311a5b4035f39cc196aa4b6acd3145a3b6f43a5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"62969ba3da89f0570c3268c4dca97d6ea695406f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"b8d0247d_5818cd12","updated":"2022-06-03 12:11:00.000000000","message":"May we get all actions with cephadm in a single task then? This way we would avoid any instance of this issue.","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b863f2a7c73649e38449ff2b33e2537f741400d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"2d2c3b18_47a72249","updated":"2022-06-03 11:02:14.000000000","message":"recheck","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"859bd91117e96ec2e3ad47e21d38a570ed414124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"9ffede08_ca95436a","in_reply_to":"b8d0247d_5818cd12","updated":"2022-06-20 13:02:12.000000000","message":"Done","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"}],"roles/cephadm/tasks/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5169cf41afeba2b38d15fc50c8555b6900b17921","unresolved":true,"context_lines":[{"line_number":101,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027+api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":102,"context_line":"  copy:"},{"line_number":103,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":104,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":105,"context_line":"  become: True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"cf477c0f_749ff36c","line":104,"updated":"2022-05-30 19:38:21.000000000","message":"why did it have to move?","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"56791a3c65e46193b1c327bc0225fc34e257db97","unresolved":true,"context_lines":[{"line_number":101,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027+api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":102,"context_line":"  copy:"},{"line_number":103,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":104,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":105,"context_line":"  become: True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"dc68a82f_12d940ee","line":104,"in_reply_to":"4a0859d8_93ac2479","updated":"2022-06-03 11:02:06.000000000","message":"Probably cephadm is touching that file periodically or something - for now let\u0027s do it this way, and I have fixing merge_configs on my list.","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bf53573ee8e2ac5f167472e0fd81efa04654c631","unresolved":true,"context_lines":[{"line_number":101,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027+api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":102,"context_line":"  copy:"},{"line_number":103,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":104,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":105,"context_line":"  become: True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"e4bfc287_2fea63e2","line":104,"in_reply_to":"cf477c0f_749ff36c","updated":"2022-05-30 19:42:32.000000000","message":"Have no clue, but without moving it - the file was still with tabs…","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"62969ba3da89f0570c3268c4dca97d6ea695406f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027+api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":102,"context_line":"  copy:"},{"line_number":103,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":104,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":105,"context_line":"  become: True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"a3691943_91b4f079","line":104,"in_reply_to":"dc68a82f_12d940ee","updated":"2022-06-03 12:11:00.000000000","message":"Well, it\u0027s all right. I would not bother \"fixing\" this further.","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"788143e8f11b965dcd55cbbe049dcc0e2b96e8b1","unresolved":true,"context_lines":[{"line_number":101,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027+api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":102,"context_line":"  copy:"},{"line_number":103,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":104,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":105,"context_line":"  become: True"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"4a0859d8_93ac2479","line":104,"in_reply_to":"e4bfc287_2fea63e2","updated":"2022-05-30 19:50:32.000000000","message":"Whaaa? 😮","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"}],"tests/run.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5169cf41afeba2b38d15fc50c8555b6900b17921","unresolved":true,"context_lines":[{"line_number":364,"context_line":"        - name: copy ceph.conf to enabled services"},{"line_number":365,"context_line":"          copy:"},{"line_number":366,"context_line":"            remote_src: True"},{"line_number":367,"context_line":"            src: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":368,"context_line":"            dest: \"/etc/kolla/config/{{ item.name }}/ceph.conf\""},{"line_number":369,"context_line":"          with_items: \"{{ cephadm_kolla_ceph_services }}\""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fbf0f309_23d429a0","line":367,"updated":"2022-05-30 19:38:21.000000000","message":"ditto","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"48f5d172096a31ca26406ecd2f125660824200a7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        - name: copy ceph.conf to enabled services"},{"line_number":365,"context_line":"          copy:"},{"line_number":366,"context_line":"            remote_src: True"},{"line_number":367,"context_line":"            src: \"/etc/ceph/ceph.conf.fixed\""},{"line_number":368,"context_line":"            dest: \"/etc/kolla/config/{{ item.name }}/ceph.conf\""},{"line_number":369,"context_line":"          with_items: \"{{ cephadm_kolla_ceph_services }}\""},{"line_number":370,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"96294270_c9e3238a","line":367,"in_reply_to":"fbf0f309_23d429a0","updated":"2022-06-03 12:11:22.000000000","message":"Done","commit_id":"94082efa5e3b6b45e7058689f9ba0d52bda873c5"}]}