)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dcc3aad55c379fb5333a49c13d298dbbe210a254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e2c836a_8097ec8c","updated":"2022-04-07 11:35:13.000000000","message":"but it fails in the CI - need to adapt some of our custom linting it seems...","commit_id":"b7fe2111157b65a04314c2c28622a26c469c97e1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e2aab5e817640501955d26d058cf8e18168d77a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1849ebdb_40e06463","updated":"2022-04-07 11:32:40.000000000","message":"it does what it says","commit_id":"b7fe2111157b65a04314c2c28622a26c469c97e1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1c2ff0f282dbc8b54db9b9e2f00e573f6332e239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af7cc43b_fc50e20c","updated":"2022-04-07 11:42:22.000000000","message":"still good","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"}],"lint-requirements.txt":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"810d783aaf0ba7018247ffbdab921b99c883e841","unresolved":true,"context_lines":[{"line_number":3,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":4,"context_line":"bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":5,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":6,"context_line":"hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":7,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":8,"context_line":"yamllint\u003e\u003d1.22.0 #GPL3"}],"source_content_type":"text/plain","patch_set":3,"id":"8fe7bb13_bbf2426e","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":21},"updated":"2022-04-12 07:38:12.000000000","message":"we should probably unpin this one at some point too","commit_id":"4cfaadec59021c8e3f6a12d790204cfb0c744286"}],"tox.ini":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9892009a587fc50b359723f6de8c13e6faf1ac50","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"allowlist_externals \u003d bash"},{"line_number":99,"context_line":"                      find"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ee369c08_70c7c017","side":"PARENT","line":96,"updated":"2022-04-07 11:37:16.000000000","message":"Seems I need to keep this in order to install ansible","commit_id":"bf30ed621be18a2a9de538167c255c23f2921df7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b54f31c6542b9e76f473eff6610a9a037ab79fb6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"allowlist_externals \u003d bash"},{"line_number":99,"context_line":"                      find"}],"source_content_type":"text/x-properties","patch_set":1,"id":"adfca758_268f2603","side":"PARENT","line":96,"in_reply_to":"45ffcfb5_91969d13","updated":"2022-04-07 12:17:40.000000000","message":"No, no, the way you have done this is nice. We were thinking about this in parallel and got desync a bit. No worries.","commit_id":"bf30ed621be18a2a9de538167c255c23f2921df7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8a32070420562fe41d1ef874660cfd31851f45e7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"allowlist_externals \u003d bash"},{"line_number":99,"context_line":"                      find"}],"source_content_type":"text/x-properties","patch_set":1,"id":"45ffcfb5_91969d13","side":"PARENT","line":96,"in_reply_to":"7d4704bf_055cec46","updated":"2022-04-07 11:43:33.000000000","message":"Really? I spent extra time to split this out and now I shall squash again?\n\nWill do but let\u0027s see test result for this first.","commit_id":"bf30ed621be18a2a9de538167c255c23f2921df7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"16799633e87d94373881390b802f0583746b1c33","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"allowlist_externals \u003d bash"},{"line_number":99,"context_line":"                      find"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7d4704bf_055cec46","side":"PARENT","line":96,"in_reply_to":"ee369c08_70c7c017","updated":"2022-04-07 11:38:21.000000000","message":"looking at the next patch, it seems newer ansible-lint installs a specific ansible - let\u0027s squash the two","commit_id":"bf30ed621be18a2a9de538167c255c23f2921df7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4fb630dc879a1ec2a7a42957c1928da1bcc3ea3c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/x-properties","patch_set":2,"id":"26d40add_58fefb9a","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":37},"updated":"2022-04-07 12:27:00.000000000","message":"Do you still need all dependencies from test-requirements in this case? Maybe just ansible? Same question for doc/requirements.txt.\n\nIt would speed up the job if only required dependencies were installed.","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0263fdf531fde04596efd0bcfc4506e42eb8c4cc","unresolved":true,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/x-properties","patch_set":2,"id":"77fd1462_1381f134","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":37},"in_reply_to":"26d40add_58fefb9a","updated":"2022-04-07 12:33:17.000000000","message":"From what I can see, only ansible and reno are actually needed, but I wanted to avoid duplicating these reqs, in particular with the idea in mind that we are considering to drop using upper constraints and then we would have to be tracking two sets of constraints instead of one. And in terms of job speed I would argue that the time needed to install some extra deps is neglegible compared to the total overhead of a job, unless there are some libs that would take minutes to compile.","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"edbaca7eee9d0eaeca49e00966f2b0051765d91d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  ANSIBLE_FILTER_PLUGINS \u003d {toxinidir}/ansible/filter_plugins"},{"line_number":94,"context_line":"deps \u003d"},{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/x-properties","patch_set":2,"id":"f79ce52f_b827c38b","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":37},"in_reply_to":"77fd1462_1381f134","updated":"2022-04-07 13:00:54.000000000","message":"Fair enough.","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"83212e12b11a79dae89b9aa7ed69330ec64a1a68","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":100,"context_line":"  bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":101,"context_line":"  doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":102,"context_line":"  hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":103,"context_line":"  yamllint\u003e\u003d1.22.0 #GPL3"},{"line_number":104,"context_line":"allowlist_externals \u003d bash"},{"line_number":105,"context_line":"                      find"},{"line_number":106,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"38590310_e312d886","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":24},"updated":"2022-04-11 10:47:28.000000000","message":"Would these be better placed in a lint-requirements.txt?","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"eab63388567fd3e62f6c5d64f941fe7ac5b4a8da","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":100,"context_line":"  bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":101,"context_line":"  doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":102,"context_line":"  hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":103,"context_line":"  yamllint\u003e\u003d1.22.0 #GPL3"},{"line_number":104,"context_line":"allowlist_externals \u003d bash"},{"line_number":105,"context_line":"                      find"},{"line_number":106,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"813eb9b9_f468bc29","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":24},"in_reply_to":"17dbe660_9eeb384c","updated":"2022-04-11 19:43:02.000000000","message":"Duplicate.","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d134cc6b7ae2a4cbb56a872c8109eecf6f9d22b1","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":100,"context_line":"  bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":101,"context_line":"  doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":102,"context_line":"  hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":103,"context_line":"  yamllint\u003e\u003d1.22.0 #GPL3"},{"line_number":104,"context_line":"allowlist_externals \u003d bash"},{"line_number":105,"context_line":"                      find"},{"line_number":106,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"6fa41ea0_61a7e124","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":24},"in_reply_to":"38590310_e312d886","updated":"2022-04-11 10:52:15.000000000","message":"nice idea","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5552f09df823153b644de7d9f41a52dec9b5227c","unresolved":true,"context_lines":[{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":100,"context_line":"  bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":101,"context_line":"  doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":102,"context_line":"  hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":103,"context_line":"  yamllint\u003e\u003d1.22.0 #GPL3"},{"line_number":104,"context_line":"allowlist_externals \u003d bash"},{"line_number":105,"context_line":"                      find"},{"line_number":106,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"17dbe660_9eeb384c","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":24},"in_reply_to":"6fa41ea0_61a7e124","updated":"2022-04-11 19:37:50.000000000","message":"Would you then duplicate ansible and reno into that file, so that we can drop pulling all the other reqs into the linting env? Or just have these 6 deps in it?","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cedf59df008320ff444ba2196ebb44b07113ba60","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":96,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":97,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":98,"context_line":"  ansible-lint\u003e\u003d4.2.0,!\u003d4.3.0,\u003c6.0.0 # MIT"},{"line_number":99,"context_line":"  bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":100,"context_line":"  bashate\u003e\u003d0.5.1 # Apache-2.0"},{"line_number":101,"context_line":"  doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":102,"context_line":"  hacking\u003e\u003d3.0.1,\u003c3.1.0 # Apache-2.0"},{"line_number":103,"context_line":"  yamllint\u003e\u003d1.22.0 #GPL3"},{"line_number":104,"context_line":"allowlist_externals \u003d bash"},{"line_number":105,"context_line":"                      find"},{"line_number":106,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"423a755e_2d5195b0","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":24},"in_reply_to":"813eb9b9_f468bc29","updated":"2022-04-12 06:49:16.000000000","message":"Done","commit_id":"c95e280869a2643e4ee2a5affc50df50db8c6d9a"}]}