)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"8da1fabcf14130bf64b8178c0b7122573d3105c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f50c241_7b290601","updated":"2022-04-07 11:37:53.000000000","message":"At this moment - migration should work, but VMs that was up before migration - cannot be controlled from openstack on podman","commit_id":"c7c485f78d12dc94656c76517472a48af70a894a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fec0889e71be570f2256fdb9c75adea557d64f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"796deefa_10170515","in_reply_to":"1f50c241_7b290601","updated":"2022-04-21 13:01:29.000000000","message":"Interesting, the VMs should be still available as they are outside of docker namespaces. But maybe there is something else at play here. Worth investigating.","commit_id":"c7c485f78d12dc94656c76517472a48af70a894a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fbceba8c727baef1f23c81cd7ff76eea4da748ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"967b76e7_97ab2109","in_reply_to":"42b9372f_c3f9c0bf","updated":"2022-04-21 15:16:08.000000000","message":"Hmmm, thanks. Then surely the current way podman is used configures the container slightly differently - we surely need to dig into it.","commit_id":"c7c485f78d12dc94656c76517472a48af70a894a"},{"author":{"_account_id":34501,"name":"Konstantin Yarovoy","email":"konstantin.yarovoy@tietoevry.com","username":"yarovkon"},"change_message_id":"f1ee4232e35469b28686d57997058e8cc7fbe461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42b9372f_c3f9c0bf","in_reply_to":"796deefa_10170515","updated":"2022-04-21 15:12:47.000000000","message":"I have some notes about that issue, maybe they could help:\n\nState 05/04:\n\nMigration playbook uses kolla-ansible bash script\n\nMigration goes in a way copy volumes -\u003e deploy\n\nAfter migration - VMs are up, but openstack shows their state as shutdown.\n\nIn nova_virtlib command \"virsh list\" shows empty list.\n\nVM can be restored via unplugging VIF and running openstack server start \u003c…\u003e after, but it seems to erase memory of vm (tested by creating files in /home folder and /var folder and checking them after restoration)\n\n \n\nAfter migration - if openstack server start is called on migrated VM - nova-compute logs has error:\n\n\"libvirt.libvirtError: Unable to create tap device tapdb30a2f4-5b: Device or resource busy\"\n\nand state of VM in openstack list doesn\u0027t change. (which is understandable, because VM is actually up and accessible via ssh, so it is still holding resource and cannot be started).\n\n \n\nResetting state of VM (with nova reset-state) doesn\u0027t help, any action after that causes VM to go into ERROR state with error\n\n\"nova.exception.InstanceNotFound: Instance 2f282f93-2388-42ed-ad9f-ebcfb4241d8b could not be found.\"\n\n \nMy assumption is that nova-libvirt after migration for some reason can\u0027t detect working instances even if it has same volume, that it had before migration.\n\n \n\nAlso, one valuable note: same migration but from docker to docker (uninstalling it then installing and deploying on old volumes) - finish successfully without any problems after.","commit_id":"c7c485f78d12dc94656c76517472a48af70a894a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"877503f1c3e8c845351e240b36a605da4971ea18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f49f6d14_efa88efa","updated":"2023-10-19 19:09:27.000000000","message":"rebased","commit_id":"1e634fc7788027294a469e826e53a236ddd71c7e"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"a681daa7fe22acebefb20964bc0b34b293ed0fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"b07b82db_7b700284","updated":"2024-01-16 11:25:17.000000000","message":"recheck","commit_id":"a08343d38db474d74afa8c8e52018274cd3577b2"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"c85e1102cd765937f9e9b75fc4f4d08c7f21bf17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"1ec185d3_66becac2","updated":"2024-01-29 08:09:17.000000000","message":"recheck","commit_id":"107ca322ef594ceeb6296767efaa9f6e171d4467"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"abb85d09a053cd7243ee0f09e6d3a770a9e8495c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"52929566_2e7875ac","updated":"2024-01-31 14:54:25.000000000","message":"copying questions from kolla-whitboard etherpad - not to lost them:\n\nhow many and what form we want CI tests\n  what nodeset\n  all-in-one/multinode\n  Docker -\u003e Podman / Podman -\u003e Docker\n  currently 2 tests on Rocky9, one is multinode because of MariaDB difference when migrating on aio/mn\n\ncurrent CI tests don\u0027t gather container logs after migrating, any hints how to fix?","commit_id":"76c53a5af0f8cd92a46d52a18e97f723403359fe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01687580770b54dcf0f1a295464a3a96a322b64a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"644cab1a_d4560617","updated":"2024-02-02 12:16:55.000000000","message":"recheck holding a node for debugging\nalso ignore the unrelated debian failures","commit_id":"c69cd2f3d547666d8d268f6c368705a9118655d3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d2a6a50c5c8673e76c40da4c86265784a63df1b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"6185e332_42948fc0","updated":"2024-02-28 10:34:47.000000000","message":"please address the open coments in any form :)","commit_id":"95eea2902c33fb3f064a577248f8ee79c28b9134"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"79bff358d9e9c7817711fe7ec38b7f996fecb106","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":40,"id":"fa0f32b4_e7f336c1","updated":"2024-03-05 16:51:52.000000000","message":"Most of this LGTM. What\u0027s still not clear to me is, if this is intended for \"public\" usage or is just seen as an internal tool to check if migrations work in our CI.\n\nRegardless of the above I find it necessary to add at least some minimal documentation for this new role imho, because I find it very likely user discover this role and actually would want to use it. Even if this would not be the case it would also be good to have docs one can reference when working with this upstream.\n\nI personally think this should go into a new document \"migration from docker to podman\" or something like this and this should be linked from either \"operating kolla\" or the \"advanced configuration\" stuff (though it\u0027s not really configuration).\n\nMaybe there also exists a better place to put these docs, I didn\u0027t conduct an intense search myself.\n\nI would expect it to cover basic usage, limitations, and big fat warnings where the possibility of data loss during the migration can not be ruled out :) Just to give some starting point.\n\nIt would of course be possible to supply the docs in a separate change, but I personally hold the opinion that docs are as important as features and should be supplied side-by-side.\n\nThanks.","commit_id":"76ab6111d45e361f73b1ce6a0a743679ac0e0904"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1501d94677b319fa5666919da2862afca16211df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"791f8c20_5afac508","in_reply_to":"0991b444_ce65da48","updated":"2024-07-10 12:36:25.000000000","message":"Done","commit_id":"76ab6111d45e361f73b1ce6a0a743679ac0e0904"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"2e3563569fefa54a8c7c2654bd77c80d627ed8ae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":40,"id":"0991b444_ce65da48","in_reply_to":"fa0f32b4_e7f336c1","updated":"2024-07-03 13:28:53.000000000","message":"Documentation has been created. Check if it\u0027s sufficient, please.","commit_id":"76ab6111d45e361f73b1ce6a0a743679ac0e0904"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"48bbd331f9ea881178a7458389f78d26a2c5ec9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"d94aef7b_50812031","updated":"2024-03-25 08:45:44.000000000","message":"recheck","commit_id":"beff05474cea3011415c8456e2ff0a6173570662"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"42fbbe306837847489edb077367d87885628d85c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"652581b1_8e729e1c","updated":"2024-04-04 09:04:24.000000000","message":"recheck","commit_id":"5319cd9a91a23a721ca98f7be81b85e8533b3f4d"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"db5f9c2ac891b3ee26cb67973831c1aeb19df944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"2f83e1fd_b246f15b","updated":"2024-05-16 07:26:16.000000000","message":"recheck","commit_id":"ac6c7990f98378bfb8d213b407c2f515915028fe"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"31c06a9215ef3364c707130ecf819acf2db43004","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1f39136b_82990160","updated":"2024-05-22 14:55:23.000000000","message":"Some info about the state of migration.\n\nCURRENTLY\nMigration works when all running VMs are stopped before migrating and started after it is done.\nHere are logs of this version (70) passing: https://zuul.opendev.org/t/openstack/build/b9ad9083b6b143db8e397ae5834dacf2/logs\nLogs are in file test-container-engine-migration.\n\nPREVIOUSLY\nI was attempting to support rolling migration with VMs alive before, during a after. It was not possible because sometimes* there would be qemu processes running in /var/lib/docker which prevented removal of this directory.\n\nHere are those processes logged (same file as above): https://zuul.opendev.org/t/openstack/build/08707bdddc3e42cf95dddda413e97730/logs\n\nIf those processes were ignored, the tested VM would end up dead after the migration: https://zuul.opendev.org/t/openstack/build/595dc22802ad4acc8a6502e815c07a47/logs\n\n*In some cases the problem with qemu processes did not happen and migration finished successfully with alive VM before and after: https://zuul.opendev.org/t/openstack/build/929fdbcedbfd43bda4bd1fba8fe7fd23/logs\n\nI was unable to find out more about those processes because I was unable to reproduce it in my environment, even when I build Rocky9 image using our project-config and DIB.","commit_id":"c6835c389645b03f2d511ca9969d7cdca5bb492d"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"2e3563569fefa54a8c7c2654bd77c80d627ed8ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"a19e35a1_9062b4bc","in_reply_to":"1f39136b_82990160","updated":"2024-07-03 13:28:53.000000000","message":"Acknowledged","commit_id":"c6835c389645b03f2d511ca9969d7cdca5bb492d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90587ee75cbcabbd56c8d451476aacf0d41a00d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"7c30d1af_69991416","updated":"2024-06-10 09:46:13.000000000","message":"-1 until we have consensus if we still want to add completely new test code as bash instead of python/ansible.\n\nFrom my pov we agreed to move stuff to ansible, where possible. I think completely new code is a prime example where it would make sense to move to ansible, no?\n\nI think especially new code like these tests should thus be written in ansible, as there is no reason like backwards compatibility for keeping it in bash.\n\nThanks.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1501d94677b319fa5666919da2862afca16211df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":80,"id":"7aba96c5_396902e0","updated":"2024-07-10 12:36:25.000000000","message":"just one nit regarding the docs.","commit_id":"a61186e8361650f09dd4b07c3298a20e8fe5d5d9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bcbb25288c3621b3d38e22270189e171b69cc4df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":82,"id":"7e62cdc0_d1b36d90","updated":"2024-08-22 05:53:58.000000000","message":"merge conflict","commit_id":"753ac64096e57bf88971b053b448552aa56ad358"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"a5b7e1a13e0d4567485a7ef0152788c0af4426fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":82,"id":"831f1321_215cbc14","updated":"2024-07-16 09:24:03.000000000","message":"recheck - openstack-tox-docs POST_FAILURE","commit_id":"753ac64096e57bf88971b053b448552aa56ad358"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"7fb8712c8caf04a085f3bf0bc18d1b069c559a57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":82,"id":"911403cc_ab758fb7","in_reply_to":"7e62cdc0_d1b36d90","updated":"2024-10-02 13:09:47.000000000","message":"Done","commit_id":"753ac64096e57bf88971b053b448552aa56ad358"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"51dd0a1ee8e2b67f444baeef83abda7b948612dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":85,"id":"8b722f6f_fac61860","updated":"2024-10-06 16:38:13.000000000","message":"About two months ago, package facts gathering was removed from master, so te rebase caused the tests to fail. Migration test are now passing with patch #85\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/901056","commit_id":"0277cd3b594b3e834790d5ef3a60cb094c676e41"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a5961b52d3c28a29d65b36a3b83144b8f882fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":86,"id":"cf4e4217_9bd7b3bb","updated":"2024-10-16 07:17:52.000000000","message":"I\u0027ve put all of the prerequisites into one chain and added Depends-on for the collection patchset, so the progress on this effort is easier track. This also got rid of all the TODOs created in this patchset.","commit_id":"bd2516ad926b1e2256157e8543df4eab32796e94"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"4decb25ee15aa1d9f876345ba1016b6617514311","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":89,"id":"b3a5e6ce_799d27e3","updated":"2024-10-29 12:15:54.000000000","message":"Master was updated with brand sparkling new python CLI :) , so I updated this patchset to make use of that. Also added some safegaurds to the cleanup script, so when migration fails midway, it can be rerun without the script failing.","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"1d579c0947122d9c94cd246db994b9a7a1c8beb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":93,"id":"a68211a3_c9fc7847","updated":"2025-01-16 07:12:22.000000000","message":"recheck ansible-collection-kolla dependency updated","commit_id":"a590e3b89807ee5209949a6b4a76df5c60591f1e"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b2fec96338f63557f4562269a16a1f5c5fae1e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":93,"id":"f4a85915_4725e8a1","updated":"2025-01-10 13:45:36.000000000","message":"recheck depends-on repository updated","commit_id":"a590e3b89807ee5209949a6b4a76df5c60591f1e"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"51643cdb4fd01867f46fe94414d9ccc703b393df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":93,"id":"7b6a61b5_6aa84ae0","updated":"2025-01-20 07:29:06.000000000","message":"recheck one particular mirror was missing an image of mariadb","commit_id":"a590e3b89807ee5209949a6b4a76df5c60591f1e"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"12b1973690eda85b928693f3e178a3ef90d7a253","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":96,"id":"5a02a5df_7118d188","updated":"2025-02-12 14:24:53.000000000","message":"Right now the migration tests are passing all except multinode debian. Interesting is also the fact that deployment with docker passes, but the second \"redeployment\" with podman fails with the following error and only on once of the nodes, the other two pass.\n\nERROR:\nThe requested image does not exist: mirror-int.dfw.rax.opendev.org:4447/openstack.kolla/nova-compute:master-debian-bookworm","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705ea38bca682053684cd99e8947ad350b196445","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":96,"id":"8ec87957_2d4f238d","updated":"2025-02-19 15:13:00.000000000","message":"The patch looks fairly clean to me. I think my strategy would have been to do one host at a time in a rolling fashion as part of a reimage (using live / cold migration to empty the hypervisors). Which is similar to the process we do for a a major host OS upgrade on Rocky, but I can see the appeal of doing this in place.","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c369f17265b8d5b4b2e9bdb3e65cbb625c8b27dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"1d1499a6_40641421","updated":"2025-03-02 21:53:38.000000000","message":"recheck dependency updated","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a139c89036bc6d40836218c4938a375afd8dcca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"3e50f0a9_eaab2be2","updated":"2025-02-26 18:32:44.000000000","message":"recheck dependency updated","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"4b30817afddcd475c2de6880c262ed1efbac3f49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"dd9e08c2_4b47aaab","updated":"2025-02-11 13:31:59.000000000","message":"recheck dependency updated","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"d1772728cc08e6dd8a582d1f40fc2d943db84049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"4fd246f2_326cccd0","updated":"2025-02-26 14:07:42.000000000","message":"recheck image not available after podman migration","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"562c610a_c20d81a2","in_reply_to":"5a02a5df_7118d188","updated":"2025-05-06 14:57:12.000000000","message":"I don\u0027t see this error anymore so I assume that this is resolved","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"b91d391b_941a73c8","in_reply_to":"7da05ea4_dd268307","updated":"2025-05-06 14:57:12.000000000","message":"good idea for the future, but not needed for this first step","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c723b3870029bc47a9c112ab198440544ea295f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":96,"id":"76b557db_f812dc2b","in_reply_to":"8ec87957_2d4f238d","updated":"2025-02-20 14:14:18.000000000","message":"I\u0027m guessing that might hit the same problem as upgrade does when using --limit. But I\u0027ll look more into it in further patchsets.\n\nhttps://docs.openstack.org/kolla-ansible/latest/user/operating-kolla.html","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c723b3870029bc47a9c112ab198440544ea295f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":96,"id":"7da05ea4_dd268307","in_reply_to":"8ec87957_2d4f238d","updated":"2025-02-20 14:14:18.000000000","message":"When I was reading upgrade documentation, it mentioned that upgrading with --limit (which I believe would equivalent to what you said) is not recommended. I have some future plans to make the migration easier, but right now, we would like to get the base off the ground and the follow up with improvements. \n\nI was thinking of maybe running both container engines (?) and moving the services one-by-one similar to how upgrade does things, but that\u0027s only an idea that I am not sure if would work and which would probably need quite a bit of work to implement and fine tune. But it\u0027s on my todo list","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3a8861e0cc269eda8451308370e572b2726be5c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"f53f5e06_a6677112","updated":"2025-04-30 09:52:29.000000000","message":"as discussed in the recent meetings, I think this is fine to get merged and let people start collecting experiences with it. one issue inline though","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7b09d37c83d091bd5df645f26a330e0d84d43b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"9a2791b4_78c65384","updated":"2025-05-08 18:27:05.000000000","message":"recheck - new images","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6be7c9e9978e5f71a16c425e03cadf60045cfd1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"34d5640c_4c840cab","updated":"2025-03-23 19:56:16.000000000","message":"recheck 502 error returned from podman image mirror","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"48814976e300305cf74d456f130c37c604800d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"82ee33ba_2cbab42f","updated":"2025-03-21 07:56:25.000000000","message":"recheck dependency fixed","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"27a4f9303106365636ebd1db2a8a92b6c531f942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"847ba55b_98a88d62","updated":"2025-03-20 17:02:50.000000000","message":"recheck dependency updated","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c99e58d0fc46a752f7d7652cca9c883784b3c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":97,"id":"95d23185_a98a8be4","updated":"2025-05-08 10:51:46.000000000","message":"recheck depends on merged","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"}],"ansible/migrate-container-engine.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0ff711e7307a76175dedcf736b7318ba79ab266b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"57165c9a_a9667523","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-01-09 16:37:46.000000000","message":"is this really a problem we need to fix?","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"81ef6682cad0e04b79810e2d0256afd0178bdac5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"376b97aa_e41a5085","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"29827508_8f55faf0","updated":"2024-01-18 14:48:09.000000000","message":"Reopened to keep this in focus.\n\nAlso, if we were to decide which engine is in use by checking what is installed, how would we update the globals.yml so any subsequent actions are executed with the new engine?","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"7ca225d14c1f71b50716b776389500924f38cfd0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf9ad40c_0d95bfad","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"376b97aa_e41a5085","updated":"2024-03-01 16:34:37.000000000","message":"I have added a simple check in ansible/roles/container-engine-migration/tasks/replace.yml. It just checks if target engine is installed and fails if it is.","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"46fd0b8f093c30c095d823b4c2ef129c948c43cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6ae6b81f_2183bf73","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"57165c9a_a9667523","updated":"2024-01-15 14:26:08.000000000","message":"Yes because the way it works now is that whichever container engine is in globals.yml is assumed to be the target of the migration. The other container engine is assumed to be currently in use.\nSo if we have Openstack running on Docker and try to migrate with Docker still set in globals.yml the playbook will assume that Podman is currently installed and will try to use it, which will cause error.","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"86cf133ee79a7c019044f9ae4b1e1bf943a28856","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"29827508_8f55faf0","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"6ae6b81f_2183bf73","updated":"2024-01-15 16:31:40.000000000","message":"okay, I guess then we really should just add a precheck that checks the currently actual in use container engine, instead of inferring it from the globals.yml.","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"79bff358d9e9c7817711fe7ec38b7f996fecb106","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO(m.hiner): implement checks to prevent same engine migrations"},{"line_number":5,"context_line":"- name: Prepare the Openstack migration"},{"line_number":6,"context_line":"  hosts: baremetal"},{"line_number":7,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"38027e6e_d359ad18","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"bf9ad40c_0d95bfad","updated":"2024-03-05 16:51:52.000000000","message":"Done","commit_id":"ffd300d6137690f726b56a9ee433714a4a3f4c8e"}],"ansible/roles/container-engine-migration/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cb56d9b642f5bf16b57af0b202ee7841781124a7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"engine_data:"},{"line_number":3,"context_line":"  docker:"},{"line_number":4,"context_line":"    name: docker"},{"line_number":5,"context_line":"    volumes_dir: \"/var/lib/docker/volumes/\""},{"line_number":6,"context_line":"    volumes_mode: \"0701\""},{"line_number":7,"context_line":"    packages:"},{"line_number":8,"context_line":"      - docker-ce"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"850116a0_27495e05","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":42},"updated":"2024-10-29 13:57:19.000000000","message":"{{ docker_volumes_path }} ?","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"28b0d6ffb8c5044e86ee7fd717441cb8ac96fa35","unresolved":false,"context_lines":[{"line_number":2,"context_line":"engine_data:"},{"line_number":3,"context_line":"  docker:"},{"line_number":4,"context_line":"    name: docker"},{"line_number":5,"context_line":"    volumes_dir: \"/var/lib/docker/volumes/\""},{"line_number":6,"context_line":"    volumes_mode: \"0701\""},{"line_number":7,"context_line":"    packages:"},{"line_number":8,"context_line":"      - docker-ce"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"a860d43b_6743f032","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":42},"in_reply_to":"1fde9df3_e8825d39","updated":"2024-10-31 17:18:30.000000000","message":"Done","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"35f8cd45dc786b33bc87f085489225fa4d74cc69","unresolved":true,"context_lines":[{"line_number":2,"context_line":"engine_data:"},{"line_number":3,"context_line":"  docker:"},{"line_number":4,"context_line":"    name: docker"},{"line_number":5,"context_line":"    volumes_dir: \"/var/lib/docker/volumes/\""},{"line_number":6,"context_line":"    volumes_mode: \"0701\""},{"line_number":7,"context_line":"    packages:"},{"line_number":8,"context_line":"      - docker-ce"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"1fde9df3_e8825d39","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":42},"in_reply_to":"850116a0_27495e05","updated":"2024-10-29 14:02:39.000000000","message":"\u003e {{ docker_volumes_path }} ?","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cb56d9b642f5bf16b57af0b202ee7841781124a7","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      - docker-ce"},{"line_number":9,"context_line":"  podman:"},{"line_number":10,"context_line":"    name: podman"},{"line_number":11,"context_line":"    volumes_dir: \"/var/lib/containers/storage/volumes\""},{"line_number":12,"context_line":"    volumes_mode: \"0700\""},{"line_number":13,"context_line":"    packages:"},{"line_number":14,"context_line":"      - podman"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"c347bce4_563304fb","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":54},"updated":"2024-10-29 13:57:19.000000000","message":"{{ podman_volumes_path }} ?","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"28b0d6ffb8c5044e86ee7fd717441cb8ac96fa35","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - docker-ce"},{"line_number":9,"context_line":"  podman:"},{"line_number":10,"context_line":"    name: podman"},{"line_number":11,"context_line":"    volumes_dir: \"/var/lib/containers/storage/volumes\""},{"line_number":12,"context_line":"    volumes_mode: \"0700\""},{"line_number":13,"context_line":"    packages:"},{"line_number":14,"context_line":"      - podman"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"32dd49ba_b2ea7fc5","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":54},"in_reply_to":"c347bce4_563304fb","updated":"2024-10-31 17:18:30.000000000","message":"Done","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3a8861e0cc269eda8451308370e572b2726be5c7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  docker:"},{"line_number":4,"context_line":"    name: docker"},{"line_number":5,"context_line":"    volumes_dir: \"{{ docker_volumes_path }}\""},{"line_number":6,"context_line":"    volumes_mode: \"0701\""},{"line_number":7,"context_line":"    packages:"},{"line_number":8,"context_line":"      - docker-ce"},{"line_number":9,"context_line":"  podman:"}],"source_content_type":"text/x-yaml","patch_set":97,"id":"911882ba_d8d6cd18","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":23},"updated":"2025-04-30 09:52:29.000000000","message":"this looks weird, either it is a typo or there is some hidden reason for it that warrants a comment?","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  docker:"},{"line_number":4,"context_line":"    name: docker"},{"line_number":5,"context_line":"    volumes_dir: \"{{ docker_volumes_path }}\""},{"line_number":6,"context_line":"    volumes_mode: \"0701\""},{"line_number":7,"context_line":"    packages:"},{"line_number":8,"context_line":"      - docker-ce"},{"line_number":9,"context_line":"  podman:"}],"source_content_type":"text/x-yaml","patch_set":97,"id":"2183dc9f_845a91ea","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":23},"in_reply_to":"911882ba_d8d6cd18","updated":"2025-05-06 14:57:12.000000000","message":"checking a local docker install it really has mode 0701 everywhere in /var/lib/docker/volumes. well then","commit_id":"f726cfd9982bf6a5250859f3ecfcacf018159b99"}],"ansible/roles/container-engine-migration/files/ce-cleanup.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fb151048798db87d45ad7f34ed862511677843fd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"echo \"Removing images...\""},{"line_number":46,"context_line":"sudo $engine rmi -f ${images_to_remove}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"echo \"All cleaned up!\""}],"source_content_type":"text/x-sh","patch_set":60,"id":"09b30341_96173e75","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":2},"updated":"2024-05-02 11:45:02.000000000","message":"currently this script does not check the success of each command, which can fail for a myriad of reasons.\n\neither check at least the success of every command or maybe add `set -o errexit\nset -o pipefail` at the top of the file.","commit_id":"bcee7fc0df16516b749f2d45de66303cc5f0db95"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"abd93dcbce5d4d3cb92a0737704c78ca8390218e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"echo \"Removing images...\""},{"line_number":46,"context_line":"sudo $engine rmi -f ${images_to_remove}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"echo \"All cleaned up!\""}],"source_content_type":"text/x-sh","patch_set":60,"id":"8d7a5335_6d3ac784","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":2},"in_reply_to":"09b30341_96173e75","updated":"2024-05-02 11:55:24.000000000","message":"Done. Forgot to add it there. Also `set -o xtrace` is nice to have there.","commit_id":"bcee7fc0df16516b749f2d45de66303cc5f0db95"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90587ee75cbcabbd56c8d451476aacf0d41a00d5","unresolved":true,"context_lines":[{"line_number":29,"context_line":"echo \"Removing containers...\""},{"line_number":30,"context_line":"(sudo $engine rm -v -f ${containers_to_kill} 2\u003e\u00261) \u003e /dev/null"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(mhiner): causes Zuul to close shared connection"},{"line_number":33,"context_line":"# echo \"Disconnecting containers from $engine host network\""},{"line_number":34,"context_line":"# for container in ${containers_to_kill}; do"},{"line_number":35,"context_line":"# (sudo $engine network disconnect -f host $container 2\u003e\u00261) \u003e /dev/null"},{"line_number":36,"context_line":"# done"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"echo \"Removing unit files...\""},{"line_number":39,"context_line":"sudo rm -f /etc/systemd/system/kolla-*-container.service"}],"source_content_type":"text/x-sh","patch_set":75,"id":"cd570541_25f62515","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":6},"updated":"2024-06-10 09:46:13.000000000","message":"I assume this code will be cleaned up? I see negative value in dead code being submitted.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"35ba91b490b9ad9c6401cc53106fbad6b4811b7a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"echo \"Removing containers...\""},{"line_number":30,"context_line":"(sudo $engine rm -v -f ${containers_to_kill} 2\u003e\u00261) \u003e /dev/null"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(mhiner): causes Zuul to close shared connection"},{"line_number":33,"context_line":"# echo \"Disconnecting containers from $engine host network\""},{"line_number":34,"context_line":"# for container in ${containers_to_kill}; do"},{"line_number":35,"context_line":"# (sudo $engine network disconnect -f host $container 2\u003e\u00261) \u003e /dev/null"},{"line_number":36,"context_line":"# done"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"echo \"Removing unit files...\""},{"line_number":39,"context_line":"sudo rm -f /etc/systemd/system/kolla-*-container.service"}],"source_content_type":"text/x-sh","patch_set":75,"id":"a6257c5f_d919e689","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":6},"in_reply_to":"cd570541_25f62515","updated":"2024-06-11 13:30:22.000000000","message":"Removed.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90587ee75cbcabbd56c8d451476aacf0d41a00d5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"sudo $engine rmi -f ${images_to_remove}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"Performing final cleanup of any remaining unused data...\""},{"line_number":46,"context_line":"sudo $engine system prune -a -f --volumes"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"echo \"All cleaned up!\""}],"source_content_type":"text/x-sh","patch_set":75,"id":"6813352e_86bd568d","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":2},"updated":"2024-06-10 09:46:13.000000000","message":"this will remove all stopped containers as well[1]. I guess there should be a warning or something about this in the docs or something. I also think the text of cleaning up unused data is wrong.\n\n[1]:https://docs.docker.com/reference/cli/docker/system/prune/\n\nIt might be the case that this is actually what we want to do here, but I think it should be advertised to the user as what it actually does, so users don\u0027t unexpectedly lose data here.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"35ba91b490b9ad9c6401cc53106fbad6b4811b7a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"sudo $engine rmi -f ${images_to_remove}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"Performing final cleanup of any remaining unused data...\""},{"line_number":46,"context_line":"sudo $engine system prune -a -f --volumes"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"echo \"All cleaned up!\""}],"source_content_type":"text/x-sh","patch_set":75,"id":"9df0b993_3df04a7a","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":2},"in_reply_to":"6813352e_86bd568d","updated":"2024-06-11 13:30:22.000000000","message":"Documentation already says that \"old container engine will be removed from the system and all it\u0027s resources and data will be deleted\". Is it insufficient?\n\nAlso \"data\" has been changed to \"resources\" in the text here.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80f67f9e8e3d658c475bb2b44c06eeff2e7372e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"sudo $engine rmi -f ${images_to_remove}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"Performing final cleanup of any remaining unused data...\""},{"line_number":46,"context_line":"sudo $engine system prune -a -f --volumes"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"echo \"All cleaned up!\""}],"source_content_type":"text/x-sh","patch_set":75,"id":"cf635a66_9028fcc0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":2},"in_reply_to":"9df0b993_3df04a7a","updated":"2024-07-10 12:45:01.000000000","message":"Acknowledged","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"}],"ansible/roles/container-engine-migration/tasks/migrate-volumes.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  when: engine_data[target_engine].packages[0] in ansible_facts.packages"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(mhiner): replace this command\u0027s functionality with our module\u0027s"},{"line_number":8,"context_line":"# functionality, when it is implemented."},{"line_number":9,"context_line":"- name: Get list of all containers"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""}],"source_content_type":"text/x-yaml","patch_set":81,"id":"204e192d_d764d8d5","line":8,"updated":"2024-07-15 07:54:26.000000000","message":"depends-on on a patch with that functionality?","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  when: engine_data[target_engine].packages[0] in ansible_facts.packages"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(mhiner): replace this command\u0027s functionality with our module\u0027s"},{"line_number":8,"context_line":"# functionality, when it is implemented."},{"line_number":9,"context_line":"- name: Get list of all containers"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""}],"source_content_type":"text/x-yaml","patch_set":81,"id":"ab0b192c_5215f2bd","line":8,"in_reply_to":"204e192d_d764d8d5","updated":"2024-07-15 13:55:43.000000000","message":"That change is not implemented yet. It would be dependent on Ivan\u0027s work on kolla_container_facts and that would place this migration patch on the end of relation chain, which I would prefer not to do.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a5961b52d3c28a29d65b36a3b83144b8f882fe5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  when: engine_data[target_engine].packages[0] in ansible_facts.packages"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(mhiner): replace this command\u0027s functionality with our module\u0027s"},{"line_number":8,"context_line":"# functionality, when it is implemented."},{"line_number":9,"context_line":"- name: Get list of all containers"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""}],"source_content_type":"text/x-yaml","patch_set":81,"id":"8f66cf80_75b8e8f5","line":8,"in_reply_to":"ab0b192c_5215f2bd","updated":"2024-10-16 07:17:52.000000000","message":"I\u0027ve done some work on the underlying patchsets and will be rebasing this on top of them / adding depends-on.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"35f8cd45dc786b33bc87f085489225fa4d74cc69","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get list of all containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container_facts:"},{"line_number":5,"context_line":"    action: get_containers_names"},{"line_number":6,"context_line":"    container_engine: \"{{ current_engine }}\""},{"line_number":7,"context_line":"  register: containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- import_tasks: ovs-cleanup.yml"},{"line_number":10,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"aba01e7e_a2bf7930","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":22},"updated":"2024-10-29 14:02:39.000000000","message":"What if there are additional containers running - not from kolla-ansible deployment, but different ones ?","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get list of all containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container_facts:"},{"line_number":5,"context_line":"    action: get_containers_names"},{"line_number":6,"context_line":"    container_engine: \"{{ current_engine }}\""},{"line_number":7,"context_line":"  register: containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- import_tasks: ovs-cleanup.yml"},{"line_number":10,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"6bfb851e_881ede7b","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"1e0a98ff_35806637","updated":"2025-05-06 14:57:12.000000000","message":"Acknowledged","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"00dfa44dced50a9ed84e95088c72781320ef904e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get list of all containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container_facts:"},{"line_number":5,"context_line":"    action: get_containers_names"},{"line_number":6,"context_line":"    container_engine: \"{{ current_engine }}\""},{"line_number":7,"context_line":"  register: containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- import_tasks: ovs-cleanup.yml"},{"line_number":10,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"1e0a98ff_35806637","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"47dc679e_1caa3422","updated":"2024-11-01 12:53:40.000000000","message":"Actually, I got it wrong. This part only stops the containers. The containers are removed in the bash script, and only those which have label \"kolla_version\" are removed. And since ansible-collection-kolla uninstall tasks have a check to see if there are any containers (running or stopped) or volumes leftover, the migration would fail and inform the user that there are still containers or volumes leftover on the machines. So no data loss should occur if the user forgets that they have some other containers.","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"28b0d6ffb8c5044e86ee7fd717441cb8ac96fa35","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get list of all containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container_facts:"},{"line_number":5,"context_line":"    action: get_containers_names"},{"line_number":6,"context_line":"    container_engine: \"{{ current_engine }}\""},{"line_number":7,"context_line":"  register: containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- import_tasks: ovs-cleanup.yml"},{"line_number":10,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":89,"id":"47dc679e_1caa3422","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"aba01e7e_a2bf7930","updated":"2024-10-31 17:18:30.000000000","message":"At this point, the other container engine gets completely removed. So if a user has other containers running, they will be stopped and removed.\n\nDo you propose to throw an error if there are non-kolla containers, or would big red warning in docs be sufficient?","commit_id":"05f07a1fcc79c8176cb0864072081c506a11df6f"}],"ansible/roles/container-engine-migration/tasks/ovs-cleanup.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove OVS bridges from neutron"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ current_engine }} exec -u root neutron_openvswitch_agent neutron-ovs-cleanup"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"bd4ad20f_978dea8c","line":2,"updated":"2024-07-15 07:54:26.000000000","message":"That is only required when neutron_plugin_agent \u003d\u003d openvswitch (not if OVN)","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"650ed2ed1dcbb664f720b9d64b8dd743ea530fea","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove OVS bridges from neutron"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ current_engine }} exec -u root neutron_openvswitch_agent neutron-ovs-cleanup"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"bf03eae7_bfefe844","line":2,"in_reply_to":"bcb39e97_c151e7ba","updated":"2024-10-02 13:09:31.000000000","message":"no, openvswitch_vswitchd exists in both ML2/OVS and ML2/OVN","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove OVS bridges from neutron"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ current_engine }} exec -u root neutron_openvswitch_agent neutron-ovs-cleanup"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"bcb39e97_c151e7ba","line":2,"in_reply_to":"bd4ad20f_978dea8c","updated":"2024-07-15 13:55:43.000000000","message":"Is the condition `when: \"\u0027openvswitch_vswitchd\u0027 in containers.stdout_lines\"` in `ansible/roles/container-engine-migration/tasks/migrate-volumes.yml:15` not sufficient? It\u0027s the only place where this task file is called from.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a5961b52d3c28a29d65b36a3b83144b8f882fe5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove OVS bridges from neutron"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ current_engine }} exec -u root neutron_openvswitch_agent neutron-ovs-cleanup"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"ff3e2c2a_cd2f17ef","line":2,"in_reply_to":"bf03eae7_bfefe844","updated":"2024-10-16 07:17:52.000000000","message":"I\u0027ve added the condition.\n\nHowever, doesn\u0027t that mean that the destroy code in master[1] is also missing this condition?\n\n[1] - https://opendev.org/openstack/kolla-ansible/src/branch/master/tools/cleanup-containers#L35-L41","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove OVS bridges from neutron"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    {{ current_engine }} exec -u root neutron_openvswitch_agent neutron-ovs-cleanup"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"91215378_c884973b","line":2,"in_reply_to":"ff3e2c2a_cd2f17ef","updated":"2025-05-06 14:57:12.000000000","message":"Done","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"}],"ansible/roles/container-engine-migration/tasks/replace.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d1771ebc5c3eb29d317536ac0dbabfa25a992c1f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(m.hiner): implement uninstall roles in openstack.kolla collection"},{"line_number":3,"context_line":"- name: Get list of all containers"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""},{"line_number":6,"context_line":"  register: containers"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Stop all containers"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"4477ec5e_70b7bc17","line":7,"range":{"start_line":3,"start_character":2,"end_line":7,"end_character":1},"updated":"2024-01-10 11:00:17.000000000","message":"would it maybe be better to implement this as a generic function inside kolla_container_worker and then just use that?","commit_id":"40b1db2facfc06630c067fc67c211dad112e726d"},{"author":{"_account_id":36701,"name":"Ivan Halomi","display_name":"Ivan Halomi","email":"ivan.halomi@gmail.com","username":"ivanhalomi"},"change_message_id":"411694a217fa19bd334adf95f7f56ad34d613f4f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(m.hiner): implement uninstall roles in openstack.kolla collection"},{"line_number":3,"context_line":"- name: Get list of all containers"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""},{"line_number":6,"context_line":"  register: containers"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Stop all containers"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"b5c147bc_d14c6c82","line":7,"range":{"start_line":3,"start_character":2,"end_line":7,"end_character":1},"in_reply_to":"4477ec5e_70b7bc17","updated":"2024-01-17 08:55:20.000000000","message":"Created patchset for that:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/905837","commit_id":"40b1db2facfc06630c067fc67c211dad112e726d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"71c544147b3c13e58b875487d29d880839255b25","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(m.hiner): implement uninstall roles in openstack.kolla collection"},{"line_number":3,"context_line":"- name: Get list of all containers"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""},{"line_number":6,"context_line":"  register: containers"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Stop all containers"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c1752b80_9c79fa2c","line":7,"range":{"start_line":3,"start_character":2,"end_line":7,"end_character":1},"in_reply_to":"b5c147bc_d14c6c82","updated":"2024-01-18 13:46:50.000000000","message":"nice, thank you, then please rebase this on top of the above and use it :)","commit_id":"40b1db2facfc06630c067fc67c211dad112e726d"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"81ef6682cad0e04b79810e2d0256afd0178bdac5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(m.hiner): implement uninstall roles in openstack.kolla collection"},{"line_number":3,"context_line":"- name: Get list of all containers"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: \"{{ current_engine }} ps -a --format {%raw%}\u0027{{.Names}}\u0027{%endraw%}\""},{"line_number":6,"context_line":"  register: containers"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Stop all containers"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e87cf99a_f7ac7dde","line":7,"range":{"start_line":3,"start_character":2,"end_line":7,"end_character":1},"in_reply_to":"c1752b80_9c79fa2c","updated":"2024-01-18 14:48:09.000000000","message":"Done","commit_id":"40b1db2facfc06630c067fc67c211dad112e726d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    enabled: false"},{"line_number":12,"context_line":"  when: current_engine \u003d\u003d \u0027docker\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# TODO(mhiner): implement uninstall roles in openstack.kolla collection"},{"line_number":15,"context_line":"- name: Uninstall current container engine packages"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"3f2bfb23_9910ff49","line":14,"updated":"2024-07-15 07:54:26.000000000","message":"Can we add Depends-On: to ansible-collection-kolla patch?","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    enabled: false"},{"line_number":12,"context_line":"  when: current_engine \u003d\u003d \u0027docker\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# TODO(mhiner): implement uninstall roles in openstack.kolla collection"},{"line_number":15,"context_line":"- name: Uninstall current container engine packages"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"d0bffc40_e11c19af","line":14,"in_reply_to":"3f2bfb23_9910ff49","updated":"2024-07-15 13:55:43.000000000","message":"Also not implemented yet.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a5961b52d3c28a29d65b36a3b83144b8f882fe5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    enabled: false"},{"line_number":12,"context_line":"  when: current_engine \u003d\u003d \u0027docker\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# TODO(mhiner): implement uninstall roles in openstack.kolla collection"},{"line_number":15,"context_line":"- name: Uninstall current container engine packages"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"edab992f_4e079f05","line":14,"in_reply_to":"d0bffc40_e11c19af","updated":"2024-10-16 07:17:52.000000000","message":"I\u0027ve done some work on the underlying patchsets and will be rebasing this on top of them / adding depends-on.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"}],"ansible/roles/keystone/templates/keystone.json.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"81b50e77993cf433f5415ed88812744220cf364e","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            \"perm\": \"0770\""},{"line_number":96,"context_line":"        },"},{"line_number":97,"context_line":"        {"},{"line_number":98,"context_line":"            \"path\": \"/etc/keystone/fernet-keys/*\","},{"line_number":99,"context_line":"            \"owner\": \"keystone:keystone\","},{"line_number":100,"context_line":"            \"perm\": \"0770\""},{"line_number":101,"context_line":"        },"},{"line_number":102,"context_line":"        {"},{"line_number":103,"context_line":"            \"path\": \"/etc/keystone/domains\","},{"line_number":104,"context_line":"            \"owner\": \"keystone:keystone\","}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"5461c41c_3a08fec5","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":10},"updated":"2024-01-08 18:00:51.000000000","message":"looks like not related to this change, maybe there is need a separate bug and fix?","commit_id":"6f17f65cf7cff4fd0fa0679dfb78e21bb9acd13b"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"46fd0b8f093c30c095d823b4c2ef129c948c43cd","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            \"perm\": \"0770\""},{"line_number":96,"context_line":"        },"},{"line_number":97,"context_line":"        {"},{"line_number":98,"context_line":"            \"path\": \"/etc/keystone/fernet-keys/*\","},{"line_number":99,"context_line":"            \"owner\": \"keystone:keystone\","},{"line_number":100,"context_line":"            \"perm\": \"0770\""},{"line_number":101,"context_line":"        },"},{"line_number":102,"context_line":"        {"},{"line_number":103,"context_line":"            \"path\": \"/etc/keystone/domains\","},{"line_number":104,"context_line":"            \"owner\": \"keystone:keystone\","}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"8e8159fb_009a5626","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":10},"in_reply_to":"5461c41c_3a08fec5","updated":"2024-01-15 14:26:08.000000000","message":"This has been here before I picked up this patch and honestly I don\u0027t know why it\u0027s here. That\u0027s why I am trying to set up CI test jobs to see if I can safely remove it.","commit_id":"6f17f65cf7cff4fd0fa0679dfb78e21bb9acd13b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9aaab296c13d852d9e673f9f05c5488aa9af7d8e","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            \"perm\": \"0770\""},{"line_number":96,"context_line":"        },"},{"line_number":97,"context_line":"        {"},{"line_number":98,"context_line":"            \"path\": \"/etc/keystone/fernet-keys/*\","},{"line_number":99,"context_line":"            \"owner\": \"keystone:keystone\","},{"line_number":100,"context_line":"            \"perm\": \"0770\""},{"line_number":101,"context_line":"        },"},{"line_number":102,"context_line":"        {"},{"line_number":103,"context_line":"            \"path\": \"/etc/keystone/domains\","},{"line_number":104,"context_line":"            \"owner\": \"keystone:keystone\","}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"a34ef632_5b7f5731","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":10},"in_reply_to":"8e8159fb_009a5626","updated":"2024-02-05 11:00:10.000000000","message":"please remove this unless someone finds a reason why it should be there.","commit_id":"6f17f65cf7cff4fd0fa0679dfb78e21bb9acd13b"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"7ca225d14c1f71b50716b776389500924f38cfd0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            \"perm\": \"0770\""},{"line_number":96,"context_line":"        },"},{"line_number":97,"context_line":"        {"},{"line_number":98,"context_line":"            \"path\": \"/etc/keystone/fernet-keys/*\","},{"line_number":99,"context_line":"            \"owner\": \"keystone:keystone\","},{"line_number":100,"context_line":"            \"perm\": \"0770\""},{"line_number":101,"context_line":"        },"},{"line_number":102,"context_line":"        {"},{"line_number":103,"context_line":"            \"path\": \"/etc/keystone/domains\","},{"line_number":104,"context_line":"            \"owner\": \"keystone:keystone\","}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"7a5a4f30_e4f6a641","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":10},"in_reply_to":"a34ef632_5b7f5731","updated":"2024-03-01 16:34:37.000000000","message":"Removed it.","commit_id":"6f17f65cf7cff4fd0fa0679dfb78e21bb9acd13b"}],"ansible/site.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ecf683d9ecdce7fe64db59a7be81cc669c1d9d09","unresolved":true,"context_lines":[{"line_number":660,"context_line":"    - { role: ovn-db,"},{"line_number":661,"context_line":"        tags: [ovn, ovn-db] }"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"# NOTE(mhiner): testing if placing nova deployment after ovs prevents it getting unhealthy"},{"line_number":664,"context_line":"# during migration. If it works, this should be changed in a separate patch."},{"line_number":665,"context_line":"# Seem to be working: https://zuul.opendev.org/t/openstack/build/a3ed24a3ce2b43c497538e61cd8def2d"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"# Nova deployment is more complicated than other services, so is covered in its"},{"line_number":668,"context_line":"# own playbook."},{"line_number":669,"context_line":"- import_playbook: nova.yml"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"- name: Apply role neutron"},{"line_number":672,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"2a3016bb_28427362","line":669,"range":{"start_line":663,"start_character":0,"end_line":669,"end_character":27},"updated":"2024-06-11 14:43:43.000000000","message":"why was this moved up again? I thought it worked better down here?","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"84dfccdc41fe29a7cd59860a03c8cf34eac79bb0","unresolved":true,"context_lines":[{"line_number":660,"context_line":"    - { role: ovn-db,"},{"line_number":661,"context_line":"        tags: [ovn, ovn-db] }"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"# NOTE(mhiner): testing if placing nova deployment after ovs prevents it getting unhealthy"},{"line_number":664,"context_line":"# during migration. If it works, this should be changed in a separate patch."},{"line_number":665,"context_line":"# Seem to be working: https://zuul.opendev.org/t/openstack/build/a3ed24a3ce2b43c497538e61cd8def2d"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"# Nova deployment is more complicated than other services, so is covered in its"},{"line_number":668,"context_line":"# own playbook."},{"line_number":669,"context_line":"- import_playbook: nova.yml"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"- name: Apply role neutron"},{"line_number":672,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"c16be4a3_28258434","line":669,"range":{"start_line":663,"start_character":0,"end_line":669,"end_character":27},"in_reply_to":"2a3016bb_28427362","updated":"2024-06-11 14:49:28.000000000","message":"It was necessary for live migration, which is not currently performed. So I want to test if it\u0027s still necessary. And if it is, it will get it\u0027s own patch. Sounds good?","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5b92457aa4a767684cfb58dd48edd821652f74f8","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    - { role: ovn-db,"},{"line_number":661,"context_line":"        tags: [ovn, ovn-db] }"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"# NOTE(mhiner): testing if placing nova deployment after ovs prevents it getting unhealthy"},{"line_number":664,"context_line":"# during migration. If it works, this should be changed in a separate patch."},{"line_number":665,"context_line":"# Seem to be working: https://zuul.opendev.org/t/openstack/build/a3ed24a3ce2b43c497538e61cd8def2d"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"# Nova deployment is more complicated than other services, so is covered in its"},{"line_number":668,"context_line":"# own playbook."},{"line_number":669,"context_line":"- import_playbook: nova.yml"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"- name: Apply role neutron"},{"line_number":672,"context_line":"  gather_facts: false"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"b775efe3_a95f6a2e","line":669,"range":{"start_line":663,"start_character":0,"end_line":669,"end_character":27},"in_reply_to":"c16be4a3_28258434","updated":"2024-06-11 16:21:24.000000000","message":"Acknowledged","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"}],"doc/source/admin/advanced-configuration.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90587ee75cbcabbd56c8d451476aacf0d41a00d5","unresolved":true,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"   kolla-ansible migrate-container-engine"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"During the migration, all the container volumes will be migrated"},{"line_number":353,"context_line":"under the new container engine. The old container engine will be"},{"line_number":354,"context_line":"removed from the system and all it\u0027s data deleted."}],"source_content_type":"text/x-rst","patch_set":75,"id":"048cdfe5_a93ccaad","line":354,"range":{"start_line":352,"start_character":1,"end_line":354,"end_character":50},"updated":"2024-06-10 09:46:13.000000000","message":"I think the fact that all the old container data will be deleted deserves this sentence to be also inside a \"warning\" block, no?","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"35ba91b490b9ad9c6401cc53106fbad6b4811b7a","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"   kolla-ansible migrate-container-engine"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"During the migration, all the container volumes will be migrated"},{"line_number":353,"context_line":"under the new container engine. The old container engine will be"},{"line_number":354,"context_line":"removed from the system and all it\u0027s data deleted."}],"source_content_type":"text/x-rst","patch_set":75,"id":"6db2c771_a5863712","line":354,"range":{"start_line":352,"start_character":1,"end_line":354,"end_character":50},"in_reply_to":"048cdfe5_a93ccaad","updated":"2024-06-11 13:30:22.000000000","message":"Agreed and done.","commit_id":"d3e3138043d3622eb00a6f81ed1c5ebf30ac59fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1501d94677b319fa5666919da2862afca16211df","unresolved":true,"context_lines":[{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"Before starting the migration, you have to change the value of"},{"line_number":328,"context_line":"``kolla_container_engine`` in your  file to the new"},{"line_number":329,"context_line":"container engine:"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":80,"id":"0318ba07_542ff120","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":41},"updated":"2024-07-10 12:36:25.000000000","message":"which file again? ;)\n\n```suggestion\n``kolla_container_engine`` in your ``/etc/kolla/globals.yml`` file to the new\n```","commit_id":"a61186e8361650f09dd4b07c3298a20e8fe5d5d9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80f67f9e8e3d658c475bb2b44c06eeff2e7372e1","unresolved":false,"context_lines":[{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"Before starting the migration, you have to change the value of"},{"line_number":328,"context_line":"``kolla_container_engine`` in your  file to the new"},{"line_number":329,"context_line":"container engine:"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":80,"id":"f9f59855_c7f41e5f","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":41},"in_reply_to":"0318ba07_542ff120","updated":"2024-07-10 12:45:01.000000000","message":"Done","commit_id":"a61186e8361650f09dd4b07c3298a20e8fe5d5d9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":319,"context_line":"Migrate container engine"},{"line_number":320,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Openstack supports two container engines - Docker and Podman."},{"line_number":323,"context_line":"It is possible to migrate deployed Openstack between these two engines."},{"line_number":324,"context_line":"Migration is supported in both directions, meaning it is possible to"},{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."}],"source_content_type":"text/x-rst","patch_set":81,"id":"6b6c4d2b_2220dbb0","line":322,"updated":"2024-07-15 07:54:26.000000000","message":"OpenStack - and actually Kolla-Ansible supports two container engines","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":false,"context_lines":[{"line_number":319,"context_line":"Migrate container engine"},{"line_number":320,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Openstack supports two container engines - Docker and Podman."},{"line_number":323,"context_line":"It is possible to migrate deployed Openstack between these two engines."},{"line_number":324,"context_line":"Migration is supported in both directions, meaning it is possible to"},{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."}],"source_content_type":"text/x-rst","patch_set":81,"id":"a91aae3c_dd292b5c","line":322,"in_reply_to":"6b6c4d2b_2220dbb0","updated":"2024-07-15 13:55:43.000000000","message":"Done","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":320,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Openstack supports two container engines - Docker and Podman."},{"line_number":323,"context_line":"It is possible to migrate deployed Openstack between these two engines."},{"line_number":324,"context_line":"Migration is supported in both directions, meaning it is possible to"},{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-rst","patch_set":81,"id":"3247bfb7_81561e28","line":323,"updated":"2024-07-15 07:54:26.000000000","message":"OpenStack","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":false,"context_lines":[{"line_number":320,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Openstack supports two container engines - Docker and Podman."},{"line_number":323,"context_line":"It is possible to migrate deployed Openstack between these two engines."},{"line_number":324,"context_line":"Migration is supported in both directions, meaning it is possible to"},{"line_number":325,"context_line":"migrate from Docker to Podman as well as from Podman to Docker."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-rst","patch_set":81,"id":"2b048628_cff6d6e7","line":323,"in_reply_to":"3247bfb7_81561e28","updated":"2024-07-15 13:55:43.000000000","message":"Done","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":".. warning::"},{"line_number":353,"context_line":"   During the migration, all the container volumes will be migrated"},{"line_number":354,"context_line":"   under the new container engine. The old container engine will be"},{"line_number":355,"context_line":"   removed from the system and all it\u0027s resources and data will be deleted."}],"source_content_type":"text/x-rst","patch_set":81,"id":"e8ee70af_3ec8b64a","line":354,"updated":"2024-07-15 07:54:26.000000000","message":"\"old container engine system packages\"","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":".. warning::"},{"line_number":353,"context_line":"   During the migration, all the container volumes will be migrated"},{"line_number":354,"context_line":"   under the new container engine. The old container engine will be"},{"line_number":355,"context_line":"   removed from the system and all it\u0027s resources and data will be deleted."}],"source_content_type":"text/x-rst","patch_set":81,"id":"8e8f4dcf_502d70b1","line":354,"in_reply_to":"e8ee70af_3ec8b64a","updated":"2024-07-15 13:55:43.000000000","message":"Done","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705ea38bca682053684cd99e8947ad350b196445","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. warning::"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   Currently, rolling migration is not supported. You have to stop"},{"line_number":342,"context_line":"   all virtual machines running in your OpenStack. Otherwise,"},{"line_number":343,"context_line":"   migration will become unstable and can fail."},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":96,"id":"7e6bba06_d181e46c","line":341,"updated":"2025-02-19 15:13:00.000000000","message":"Is there a possibility to do the hypervisors one host at a time if we can empty the hypervisors with live migration? This implies doing the control plane separately using limit. Nothing jumped out at me that would mean this was not possible, hence my curiosity.","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. warning::"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   Currently, rolling migration is not supported. You have to stop"},{"line_number":342,"context_line":"   all virtual machines running in your OpenStack. Otherwise,"},{"line_number":343,"context_line":"   migration will become unstable and can fail."},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":96,"id":"e1490624_21dcf8f3","line":341,"in_reply_to":"28a19bf0_1d6bff71","updated":"2025-05-06 14:57:12.000000000","message":"option for future improvement, not needed for this first step","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c723b3870029bc47a9c112ab198440544ea295f0","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":".. warning::"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   Currently, rolling migration is not supported. You have to stop"},{"line_number":342,"context_line":"   all virtual machines running in your OpenStack. Otherwise,"},{"line_number":343,"context_line":"   migration will become unstable and can fail."},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":96,"id":"28a19bf0_1d6bff71","line":341,"in_reply_to":"7e6bba06_d181e46c","updated":"2025-02-20 14:14:18.000000000","message":"If you move out all of the guests, then I belive the migration could be done using limit. But I think that might hit the same problem with nova as described for upgrade.\n\nhttps://docs.openstack.org/kolla-ansible/latest/user/operating-kolla.html","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"}],"tests/test-container-engine-migration.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"5941054d_d6a759ed","line":13,"updated":"2024-07-15 07:54:26.000000000","message":"if the functions are the same as in test core openstack - maybe we should just source them from that file?","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c723b3870029bc47a9c112ab198440544ea295f0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"9b5f7f97_950a1500","line":13,"in_reply_to":"074ea900_baa6be0b","updated":"2025-02-20 14:14:18.000000000","message":"One more thing that\u0027s going on my todo list. I would like to do it as a follow up to not inflate this patchset further.\n\nOr maybe some of the cores would like to take a look at Michal Arbet\u0027s effort to introduce rally and move CI to tempest? (*wink wink*) :)","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"baaea4c3_9d59dffb","line":13,"in_reply_to":"5941054d_d6a759ed","updated":"2024-07-15 13:55:43.000000000","message":"I don\u0027t think it is possible. If I used `source test-core-openstack.sh` it would also trigger the tests from there because of the function call on the line 505. Unless I\u0027m missing something of course.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705ea38bca682053684cd99e8947ad350b196445","unresolved":true,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"074ea900_baa6be0b","line":13,"in_reply_to":"66e96077_185684d0","updated":"2025-02-19 15:13:00.000000000","message":"The shared functions sound nice, but personally I would be happy with that as a follow up (but I\u0027m no core). Trying to be pragmatic here 😊","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"a26bcc55_618966f7","line":13,"in_reply_to":"9b5f7f97_950a1500","updated":"2025-05-06 14:57:12.000000000","message":"Acknowledged","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6a5961b52d3c28a29d65b36a3b83144b8f882fe5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"VM_NAME\u003d\"kolla_migration_test\""},{"line_number":11,"context_line":"FIP_ADDR\u003d"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function create_instance {"},{"line_number":14,"context_line":"    local name\u003d$1"},{"line_number":15,"context_line":"    local server_create_extra"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"66e96077_185684d0","line":13,"in_reply_to":"baaea4c3_9d59dffb","updated":"2024-10-16 07:17:52.000000000","message":"We would have to create something like \"openstack-test-utils.sh\" where we could keep the functions that would be shared between these two test scenarios.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"}],"zuul.d/base.yaml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705ea38bca682053684cd99e8947ad350b196445","unresolved":true,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"- job:"},{"line_number":324,"context_line":"    name: kolla-ansible-container-engine-migration-base"},{"line_number":325,"context_line":"    parent: kolla-ansible-base"},{"line_number":326,"context_line":"    voting: false"},{"line_number":327,"context_line":"    files:"},{"line_number":328,"context_line":"      - ^ansible/migrate-container-engine.yml"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"44d4c821_548841d2","line":325,"updated":"2025-02-19 15:13:00.000000000","message":"I think this means no coverage of OVN, right? Otherwise, we\u0027d need to inherit from kolla-ansible-ovn-base. For me, it would be nice to at least to call out that OVN is not tested in the docs (which may be fair whilst ml2/ovs is the default). I know there were concerns about the size of the test matrix already.","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d11f2e69d061b2f2c577b6b9c98be0e426a6ed14","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"- job:"},{"line_number":324,"context_line":"    name: kolla-ansible-container-engine-migration-base"},{"line_number":325,"context_line":"    parent: kolla-ansible-base"},{"line_number":326,"context_line":"    voting: false"},{"line_number":327,"context_line":"    files:"},{"line_number":328,"context_line":"      - ^ansible/migrate-container-engine.yml"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"3401d2dc_355d77c1","line":325,"in_reply_to":"44d4c821_548841d2","updated":"2025-05-06 14:57:12.000000000","message":"rather no coverage for OVS at this point in time, but I think that\u0027s o.k., yes, we do not need a huge test-matrix for this, deployers are expected to test it in their specific scenario anyway","commit_id":"c67248bab86de4ecf28c6baa158b8a19797e54b8"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0fb1a2936e013af9cfa7bec9a14c76f68da1b454","unresolved":true,"context_lines":[{"line_number":577,"context_line":"    nodeset: kolla-ansible-rocky9"},{"line_number":578,"context_line":"    vars:"},{"line_number":579,"context_line":"      base_distro: rocky"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"- job:"},{"line_number":582,"context_line":"    name: kolla-ansible-rocky9-container-engine-migration"},{"line_number":583,"context_line":"    parent: kolla-ansible-container-engine-migration-base"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"00490fac_baa1af62","line":580,"updated":"2024-07-15 07:54:26.000000000","message":"What about Ubuntu?","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"9022b03d1a31c4e2f6fc40f474ac889d575b357a","unresolved":true,"context_lines":[{"line_number":577,"context_line":"    nodeset: kolla-ansible-rocky9"},{"line_number":578,"context_line":"    vars:"},{"line_number":579,"context_line":"      base_distro: rocky"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"- job:"},{"line_number":582,"context_line":"    name: kolla-ansible-rocky9-container-engine-migration"},{"line_number":583,"context_line":"    parent: kolla-ansible-container-engine-migration-base"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"e8e9f7e4_09badf1c","line":580,"in_reply_to":"00490fac_baa1af62","updated":"2024-07-15 13:55:43.000000000","message":"I wasn\u0027t sure if it\u0027s okay to create 4 new test cases just for this new functionality. So I\u0027m open to suggestions here.\nWe can:\n - have all 4 test cases (wouldn\u0027t this take too much of Zuul\u0027s capacity?)\n - test all-in-one \u0026 multinode for one distro (as it is now)\n - test only all-in-one for both distros\n - same as previous but with multinode\n\nBTW, I made all-in-one and multinode test cases because of different ways MariaDB is handled.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"c723b3870029bc47a9c112ab198440544ea295f0","unresolved":false,"context_lines":[{"line_number":577,"context_line":"    nodeset: kolla-ansible-rocky9"},{"line_number":578,"context_line":"    vars:"},{"line_number":579,"context_line":"      base_distro: rocky"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"- job:"},{"line_number":582,"context_line":"    name: kolla-ansible-rocky9-container-engine-migration"},{"line_number":583,"context_line":"    parent: kolla-ansible-container-engine-migration-base"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"15e387ff_b8fd9c53","line":580,"in_reply_to":"37a43b07_9dca1af5","updated":"2025-02-20 14:14:18.000000000","message":"Done","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d7b81ecfd627610c8aa02cff8b3b5cff2c5d2088","unresolved":true,"context_lines":[{"line_number":577,"context_line":"    nodeset: kolla-ansible-rocky9"},{"line_number":578,"context_line":"    vars:"},{"line_number":579,"context_line":"      base_distro: rocky"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"- job:"},{"line_number":582,"context_line":"    name: kolla-ansible-rocky9-container-engine-migration"},{"line_number":583,"context_line":"    parent: kolla-ansible-container-engine-migration-base"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"37a43b07_9dca1af5","line":580,"in_reply_to":"dcb14ed4_e2d7f5ab","updated":"2024-11-08 16:16:47.000000000","message":"so I would suggest to run these on all supported distros, at least rocky, ubuntu and debian imho.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"28b0d6ffb8c5044e86ee7fd717441cb8ac96fa35","unresolved":true,"context_lines":[{"line_number":577,"context_line":"    nodeset: kolla-ansible-rocky9"},{"line_number":578,"context_line":"    vars:"},{"line_number":579,"context_line":"      base_distro: rocky"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"- job:"},{"line_number":582,"context_line":"    name: kolla-ansible-rocky9-container-engine-migration"},{"line_number":583,"context_line":"    parent: kolla-ansible-container-engine-migration-base"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"dcb14ed4_e2d7f5ab","line":580,"in_reply_to":"e8e9f7e4_09badf1c","updated":"2024-10-31 17:18:30.000000000","message":"This has actually caused me some headache. Because I\u0027ve overlooked that these tests are ran on rocky9, I\u0027ve been running my tests on Ubuntu and wondering why they work on my deployment and not working in the Zuul CI. So there are definitely some differences in behavior.","commit_id":"d38a5ad1eae2b07926b9d2be5de3e1f97117595c"}]}