)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d1b64d460d7b3e0cd8c63dcd3df85085204722c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c1f078d6_461e7ae1","updated":"2022-05-04 16:45:16.000000000","message":"Actually, this modification should not be required because the role is limited to hosts with openvswitch. What is your inventory?","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4ffc9e5736584f7a33bada3e76bd4acdb044c17f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"212020c4_a4f48db6","updated":"2023-08-26 23:03:43.000000000","message":"please address all the comments","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8b5dc2da01bbf14137d60c59ad1b3a006ed469e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4188430_43ff518f","in_reply_to":"23bc7d06_6370c479","updated":"2022-05-06 13:22:54.000000000","message":"We can\u0027t delete the comments either.\n\nPlease have a look at this more thorough patch: https://review.opendev.org/c/openstack/kolla-ansible/+/840895\nand try it out.\n\nIn your case, you can live without any fix, if you simply switch from reconfiguring neutron to reconfiguring loadbalancer group, i.e. put all neutron nodes in network and move network nodes to loadbalancer. You want to have control+loadbalancer on the same hosts but openstack networking elsewhere.\n\nBy the way, why do you put neutron network services on so many hosts?","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"ae17d379c165bbf4e2eb5333a8b93377ea8a997e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23bc7d06_6370c479","in_reply_to":"24e616df_0edf600a","updated":"2022-05-05 17:19:08.000000000","message":"Anyways, the problem arises from the following:\n\nThe openvswitch role is defined as follows:\n\n[openvswitch:children]\nnetwork\ncompute\nmanila-share\n\nBut on the defaults/main.yml file of the role we can see:\nopenvswitch_services:\n  openvswitch-db-server:\n    container_name: \"openvswitch_db\"\n    image: \"{{ openvswitch_db_image_full }}\"\n    enabled: \"{{ enable_openvswitch }}\"\n    group: openvswitch\n    host_in_groups: \u003e-\n      {{  \n      inventory_hostname in groups[\u0027compute\u0027]\n      or (enable_manila_backend_generic | bool and inventory_hostname in groups[\u0027manila-share\u0027])\n      or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]\n      or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]\n      or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]\n      }}\n\nSo OVS runs in compute nodes and nodes that run neutron agents, but the openvswitch role is applied to all network nodes, here lies the inconsistency.","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"cbde171936f20bc2f5efc1c8870abed5b8fb128b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24e616df_0edf600a","in_reply_to":"6a68e80d_7fcf3c55","updated":"2022-05-05 14:24:24.000000000","message":"HI, i was asked to edit the hostnames of the file, but made this comment beforehand. Could you please delete the comment ? it seems i can\u0027t as im not an admin.","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"7e47fb70752fed2596213187f2ddd6fea47526c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a68e80d_7fcf3c55","in_reply_to":"81aab8c4_080ad393","updated":"2022-05-05 13:53:02.000000000","message":"Our inventory when encountering this bug is the following:\n\n##\n## Cloud Inventory File\n##\nroles:\n\n  control:\n    - TC-MXTLNE1-CTRL001\n    - TC-MXTLNE1-CTRL002\n    - TC-MXTLNE1-CTRL003\n  network:\n    - TC-MXTLNE1-CTRL001\n    - TC-MXTLNE1-CTRL002\n    - TC-MXTLNE1-CTRL003\n  compute:\n    - TC-MXTLNE1-TENA001\n    - TC-MXTLNE1-TENA002\n    - TC-MXTLNE1-TENA003\n    - TC-MXTLNE1-TENA004\n    - TC-MXTLNE1-TENA005\n    - TC-MXTLNE1-TENA006\n    - TC-MXTLNE1-TENA007\n    - TC-MXTLNE1-TENA008\n    - TC-MXTLNE1-TENA009\n    - TC-MXTLNE1-TENA010\n    - TC-MXTLNE1-TENA011\n    - TC-MXTLNE1-TENA012\n    - TC-MXTLNE1-TENA013\n    - TC-MXTLNE1-TENA014\n    - TC-MXTLNE1-TENA015\n    - TC-MXTLNE1-TENA016\n    - TC-MXTLNE1-TENA017\n    - TC-MXTLNE1-TENA018\n    - TC-MXTLNE1-TENA019\n    - TC-MXTLNE1-TENA020\n    - TC-MXTLNE1-TENA021\n    - TC-MXTLNE1-TENA022\n    - TC-MXTLNE1-TENA023\n    - TC-MXTLNE1-TENA024\n    - TC-MXTLNE1-TENA025\n  neutron:\n    - TC-MXTLNE1-TENA001\n    - TC-MXTLNE1-TENA002\n    - TC-MXTLNE1-TENA003\n    - TC-MXTLNE1-TENA004\n    - TC-MXTLNE1-TENA005\n    - TC-MXTLNE1-TENA006\n    - TC-MXTLNE1-TENA007\n    - TC-MXTLNE1-TENA008\n    - TC-MXTLNE1-TENA009\n    - TC-MXTLNE1-TENA010\n    - TC-MXTLNE1-TENA011\n    - TC-MXTLNE1-TENA012\n    - TC-MXTLNE1-TENA013\n    - TC-MXTLNE1-TENA014\n    - TC-MXTLNE1-TENA015\n    - TC-MXTLNE1-TENA016\n    - TC-MXTLNE1-TENA017\n    - TC-MXTLNE1-TENA018\n    - TC-MXTLNE1-TENA019\n    - TC-MXTLNE1-TENA020\n    - TC-MXTLNE1-TENA021\n    - TC-MXTLNE1-TENA022\n    - TC-MXTLNE1-TENA023\n    - TC-MXTLNE1-TENA024\n    - TC-MXTLNE1-TENA025\n  monitoring:\n    - TC-MXTLNE1-CTRL001\n    - TC-MXTLNE1-CTRL002\n    - TC-MXTLNE1-CTRL003\n  storage:\n    - TC-MXTLNE1-CTRL001\n    - TC-MXTLNE1-CTRL002\n    - TC-MXTLNE1-CTRL003\n\ntargets:\n  common:\n    ansible_user: whitestack\n    ansible_become: yes\n\n  TC-MXTLNE1-CTRL001:\n    ansible_host: \"10.218.14.12\"    \n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0\"\n    neutron_bridge_name: \"br-ex0\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-CTRL002:\n    ansible_host: \"10.218.14.35\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0\"\n    neutron_bridge_name: \"br-ex0\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-CTRL003:\n    ansible_host: \"10.218.14.43\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0\"\n    neutron_bridge_name: \"br-ex0\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  \n  # Mode OVS\n  TC-MXTLNE1-TENA001:\n    ansible_host: \"10.218.14.13\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA002:\n    ansible_host: \"10.218.14.14\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA003:\n    ansible_host: \"10.218.14.15\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA004:\n    ansible_host: \"10.218.14.16\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA005:\n    ansible_host: \"10.218.14.17\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA006:\n    ansible_host: \"10.218.14.21\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA007:\n    ansible_host: \"10.218.14.22\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA008:\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA009:\n    ansible_host: \"10.218.14.24\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  TC-MXTLNE1-TENA010:\n    ansible_host: \"10.218.14.25\"\n    enable_ovs_dpdk: no\n    ovs_datapath: \"system\"\n    neutron_external_interface: \"bondD0,bondD1\"\n    neutron_bridge_name: \"br-ex0,br-ex1\"\n    tunnel_interface: \"TCLOUD_INT\"\n    enable_neutron_sriov: \"no\"\n  \n  # Mode OVS-DPDK + SR-IOV\n  TC-MXTLNE1-TENA011:\n    ansible_host: \"10.218.14.29\"\n  TC-MXTLNE1-TENA012:\n    ansible_host: \"10.218.14.30\"\n  TC-MXTLNE1-TENA013:\n    ansible_host: \"10.218.14.31\"\n  TC-MXTLNE1-TENA014:\n    ansible_host: \"10.218.14.32\"\n  TC-MXTLNE1-TENA015:\n    ansible_host: \"10.218.14.33\"\n  TC-MXTLNE1-TENA016:\n    ansible_host: \"10.218.14.37\"\n  TC-MXTLNE1-TENA017:\n    ansible_host: \"10.218.14.38\"\n  TC-MXTLNE1-TENA018:\n    ansible_host: \"10.218.14.39\"\n  TC-MXTLNE1-TENA019:\n    ansible_host: \"10.218.14.40\"\n  TC-MXTLNE1-TENA020:\n    ansible_host: \"10.218.14.41\"\n  TC-MXTLNE1-TENA021:\n    ansible_host: \"10.218.14.45\"\n  TC-MXTLNE1-TENA022:\n    ansible_host: \"10.218.14.46\"    \n  TC-MXTLNE1-TENA023:\n    ansible_host: \"10.218.14.47\"\n  TC-MXTLNE1-TENA024:\n    ansible_host: \"10.218.14.48\"\n  TC-MXTLNE1-TENA025:\n    ansible_host: \"10.218.14.49\"","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"873b8ee3ea7b3047b09708fbd6e7cfb23d402a14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81aab8c4_080ad393","in_reply_to":"c1f078d6_461e7ae1","updated":"2022-05-04 16:45:42.000000000","message":"(I realised I have dedicated controller nodes and NOT hit this bug.)","commit_id":"033a524ec482b65e870b728794db663bd8247874"}],"ansible/roles/openvswitch/tasks/post-config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"20186c099a8a2980a479839596da40eb53d7b534","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  loop:"},{"line_number":16,"context_line":"    - { col: \"external_ids\", name: \"system-id\", value: \"{{ openvswitch_system_id }}\" }"},{"line_number":17,"context_line":"    - { col: \"other_config\", name: \"hw-offload\", value: true, state: \"{{ \u0027present\u0027 if openvswitch_hw_offload | bool else \u0027absent\u0027 }}\" }"},{"line_number":18,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":19,"context_line":"      or (enable_manila_backend_generic | bool and inventory_hostname in groups[\u0027manila-share\u0027])"},{"line_number":20,"context_line":"      or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":21,"context_line":"      or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":22,"context_line":"      or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":25,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"13ed8e06_1ecc104b","line":22,"range":{"start_line":18,"start_character":8,"end_line":22,"end_character":63},"updated":"2022-05-04 16:38:55.000000000","message":"to avoid repetition (and associated bugs), can be simplified to:\n\n\"{{ openvswitch_services[\u0027openvswitch-db-server\u0027].host_in_groups }}\"","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"20186c099a8a2980a479839596da40eb53d7b534","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  command: docker exec openvswitch_db /usr/local/bin/kolla_ensure_openvswitch_configured {{ item.0 }} {{ item.1 }}"},{"line_number":27,"context_line":"  register: status"},{"line_number":28,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"},{"line_number":29,"context_line":"  when: inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":30,"context_line":"        or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":31,"context_line":"        or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":32,"context_line":"        or (inventory_hostname in groups[\"compute\"] and computes_need_external_bridge | bool )"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"80f4c76b_bc7ad7fa","line":29,"updated":"2022-05-04 16:38:55.000000000","message":"I believe manila-share would need it too; it was by default included with \"network\"; I am not 100% sure though","commit_id":"033a524ec482b65e870b728794db663bd8247874"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4ffc9e5736584f7a33bada3e76bd4acdb044c17f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  command: docker exec openvswitch_db /usr/local/bin/kolla_ensure_openvswitch_configured {{ item.0 }} {{ item.1 }}"},{"line_number":27,"context_line":"  register: status"},{"line_number":28,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"},{"line_number":29,"context_line":"  when: inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":30,"context_line":"        or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":31,"context_line":"        or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":32,"context_line":"        or (inventory_hostname in groups[\"compute\"] and computes_need_external_bridge | bool )"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0d1becb6_0f380433","line":29,"in_reply_to":"80f4c76b_bc7ad7fa","updated":"2023-08-26 23:03:43.000000000","message":"they needed","commit_id":"033a524ec482b65e870b728794db663bd8247874"}]}