)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"d11aab9478cd21c6a798a6b5094aa9db31374a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73bb22ee_a0a0de3e","updated":"2022-05-06 20:17:23.000000000","message":"Tested locally and indeed this fix solves our issues explained in our bug report (https://bugs.launchpad.net/kolla-ansible/+bug/1971488)","commit_id":"8815040ccd890277f273d5857dc1c995078c395b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1cf064fbabe8137c603a8b4f009402b6c704f07d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d5b82eb_4e2aedcd","in_reply_to":"73bb22ee_a0a0de3e","updated":"2022-05-07 09:53:58.000000000","message":"Thanks.","commit_id":"8815040ccd890277f273d5857dc1c995078c395b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d9b1463746296d9564ea87471aac8d9e9329cd40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ade1dc69_f3e14ca2","updated":"2022-05-13 17:47:56.000000000","message":"Since we are removing a hostgroup and no longer using it I would like a release note for it.","commit_id":"8d031dd73e4769d85fe3b3d89bcf8a3d5264625d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4f07f38b929b0b62afcb7b8c2e3b9f3bdfb58e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f2a192fe_150cfad6","in_reply_to":"ade1dc69_f3e14ca2","updated":"2022-05-13 19:29:50.000000000","message":"Makes sense.","commit_id":"8d031dd73e4769d85fe3b3d89bcf8a3d5264625d"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a43dcf807ebe9bbb6471f488d30b3a658a691008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70990667_965a00fe","updated":"2022-05-23 14:05:06.000000000","message":"Any new on this patch ?","commit_id":"3dbd4c24c0f06f312b4d459d280c3e75ab574504"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a21c026100f25a10cb23f8b8140d5e9106a3a8bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c82fc945_a77c416f","updated":"2022-05-14 07:35:02.000000000","message":"hmm, they broke ovn","commit_id":"3dbd4c24c0f06f312b4d459d280c3e75ab574504"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cb1f54c80f1143a49d6a81cb5d0ad7ebf7327198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"829f0a73_008d3201","in_reply_to":"70990667_965a00fe","updated":"2022-05-23 17:01:22.000000000","message":"now it needs rebasing, duh","commit_id":"3dbd4c24c0f06f312b4d459d280c3e75ab574504"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"29c0a0c9dc02eaf59dadfdb68b4b17d34d9e6d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"11c99cb6_db603703","updated":"2022-05-26 13:32:37.000000000","message":"Backwards compatible? ","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a52d536a_03186e02","updated":"2022-05-30 11:54:07.000000000","message":"I replied to comments. I will improve the flags with additional flags (\"yo, I heard you like flags, so I added flags to your flags\").","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c1cc39bc_e84a47a5","updated":"2022-05-30 11:33:42.000000000","message":"I wonder if OVN controller needs similar treatment","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"807899d034dfef7a8d0df231f4b4455893853a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5eda09ad_aae68cbc","in_reply_to":"11c99cb6_db603703","updated":"2022-05-26 13:34:26.000000000","message":"Yes.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"21aa7634_9e31bd3a","in_reply_to":"c1cc39bc_e84a47a5","updated":"2022-05-30 11:54:07.000000000","message":"No idea, open to discussion. Though, for now, more on the side of not breaking OVN with this.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"e4a0dde25d6c9e389b7f10f8c4e110e29b646bbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8b49bb07_165cd74d","updated":"2022-06-14 19:13:32.000000000","message":"Hello, any reviewers available for a +2? Cheers.","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0cd0902681d34596f2ea2178bdb1fd33cf7e002b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6a23f6ad_4e2f6ac1","updated":"2022-06-28 09:16:57.000000000","message":"I\u0027ve added a few missing bits of logic, but there are more for other agents.\n\nI think it would be better to break out the enabled/host_in_groups logic for each agent into a separate variable that can be referenced. The logic for each agent is complex enough - combining them is a nightmare.","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f78cac8c9aaccbeefa2aeeaebb9cc190b0139e03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e183fef_3244e358","updated":"2022-06-27 08:12:19.000000000","message":"Will review today","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"552c2863e117bfc31d96c02c00faeb7f884d8bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f42cbfaa_15419c8a","updated":"2022-06-20 09:04:41.000000000","message":"ping cores","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6b21b7bf0bfd029d71cc586610ad6ef5457151fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e351d00_65148627","updated":"2022-05-30 14:15:05.000000000","message":"recheck\n\ncirros failed to boot","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d18640699fa056f0fb7bd0837a595913cc4e6255","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"280bc409_b441d05a","in_reply_to":"6a23f6ad_4e2f6ac1","updated":"2022-06-28 13:29:34.000000000","message":"I\u0027ve countered all your proposals. Is your actual suggestion to rewrite the assignment of agents as well?","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a23668613b093ee1a65d9dc846d6fb0652b96812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e6d2eafa_4f9c2ed6","updated":"2023-02-01 13:14:12.000000000","message":"Hello, seeing as this change proposal is stuck and that the author appears to no longer be working on it, I wonder what can we do to advance this proposal. \n\nThis change is important for my organization and our Openstack Distribution, so we are interested in helping getting these changes merged.\n\nAre there any other things about this proposal that need fixing or editing ? If so, please leave comments so that I can address them and hopefully speed up and finish the process.","commit_id":"bb5ab2743438dc74a1bc779ea0bfb748abe74f67"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":true,"context_lines":[{"line_number":260,"context_line":"  {{"},{"line_number":261,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool)"},{"line_number":262,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":263,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":264,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":265,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":266,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":267,"context_line":"  }}"},{"line_number":268,"context_line":"host_needs_external_network: \u003e-"},{"line_number":269,"context_line":"  {{"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a5a5d4bd_fb2bf6af","line":266,"range":{"start_line":263,"start_character":0,"end_line":266,"end_character":61},"updated":"2022-05-30 11:33:42.000000000","message":"These need flags. e.g. if we\u0027re using OVN, the host might be in neutron-l3-agent group but that\u0027s irrelevant.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6ccda2ad276b81d04fc1128c9358c6f3e2f58508","unresolved":false,"context_lines":[{"line_number":260,"context_line":"  {{"},{"line_number":261,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool)"},{"line_number":262,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":263,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":264,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":265,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":266,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":267,"context_line":"  }}"},{"line_number":268,"context_line":"host_needs_external_network: \u003e-"},{"line_number":269,"context_line":"  {{"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b9339994_b18be1aa","line":266,"range":{"start_line":263,"start_character":0,"end_line":266,"end_character":61},"in_reply_to":"7b42ab49_2eadb6d2","updated":"2022-05-30 12:14:24.000000000","message":"Done","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":true,"context_lines":[{"line_number":260,"context_line":"  {{"},{"line_number":261,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool)"},{"line_number":262,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":263,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":264,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":265,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":266,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":267,"context_line":"  }}"},{"line_number":268,"context_line":"host_needs_external_network: \u003e-"},{"line_number":269,"context_line":"  {{"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7b42ab49_2eadb6d2","line":266,"range":{"start_line":263,"start_character":0,"end_line":266,"end_character":61},"in_reply_to":"a5a5d4bd_fb2bf6af","updated":"2022-05-30 11:54:07.000000000","message":"Good idea. This will make sure the logic is coherent with the actual choice.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":true,"context_lines":[{"line_number":269,"context_line":"  {{"},{"line_number":270,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool and computes_need_external_bridge | bool)"},{"line_number":271,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":272,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":273,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":274,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":275,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":276,"context_line":"  }}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"576220ea_e558483c","line":275,"range":{"start_line":272,"start_character":0,"end_line":275,"end_character":61},"updated":"2022-05-30 11:33:42.000000000","message":"ditto","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6ccda2ad276b81d04fc1128c9358c6f3e2f58508","unresolved":false,"context_lines":[{"line_number":269,"context_line":"  {{"},{"line_number":270,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool and computes_need_external_bridge | bool)"},{"line_number":271,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":272,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":273,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":274,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":275,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":276,"context_line":"  }}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4eec9b29_fe1cbfab","line":275,"range":{"start_line":272,"start_character":0,"end_line":275,"end_character":61},"in_reply_to":"50d52068_c3b6c164","updated":"2022-05-30 12:14:24.000000000","message":"Done","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":true,"context_lines":[{"line_number":269,"context_line":"  {{"},{"line_number":270,"context_line":"    (inventory_hostname in groups[\u0027compute\u0027] and not enable_nova_fake | bool and computes_need_external_bridge | bool)"},{"line_number":271,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":272,"context_line":"    or inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":273,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":274,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":275,"context_line":"    or inventory_hostname in groups[\u0027ovn-controller-network\u0027]"},{"line_number":276,"context_line":"  }}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"50d52068_c3b6c164","line":275,"range":{"start_line":272,"start_character":0,"end_line":275,"end_character":61},"in_reply_to":"576220ea_e558483c","updated":"2022-05-30 11:54:07.000000000","message":"ditto","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0cd0902681d34596f2ea2178bdb1fd33cf7e002b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"  {{"},{"line_number":263,"context_line":"    inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":264,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":265,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":266,"context_line":"  }}"},{"line_number":267,"context_line":"host_needs_switching: \u003e-"},{"line_number":268,"context_line":"  {{"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7103407b_51db0d37","line":265,"updated":"2022-06-28 09:16:57.000000000","message":"inventory_hostname in groups[\u0027compute\u0027] and enable_neutron_dvr | bool","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d18640699fa056f0fb7bd0837a595913cc4e6255","unresolved":true,"context_lines":[{"line_number":262,"context_line":"  {{"},{"line_number":263,"context_line":"    inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":264,"context_line":"    or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":265,"context_line":"    or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":266,"context_line":"  }}"},{"line_number":267,"context_line":"host_needs_switching: \u003e-"},{"line_number":268,"context_line":"  {{"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c2d75bb0_26ab67db","line":265,"in_reply_to":"7103407b_51db0d37","updated":"2022-06-28 13:29:34.000000000","message":"This is already covered by computes_need_external_bridge (for external case) and host_is_a_real_compute (for the switching case). Adding it here would actually break the logic because external networking is required only if neutron_compute_dvr_mode is also set to dvr. With this, it would be required also in other cases.","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0cd0902681d34596f2ea2178bdb1fd33cf7e002b","unresolved":true,"context_lines":[{"line_number":268,"context_line":"  {{"},{"line_number":269,"context_line":"    (host_is_a_real_compute | bool)"},{"line_number":270,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":271,"context_line":"    or (neutron_plugin_agent in [\u0027openvswitch\u0027, \u0027linuxbridge\u0027] and host_has_a_neutron_agent_depending_on_switching | bool)"},{"line_number":272,"context_line":"    or (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and inventory_hostname in groups[\u0027ovn-controller-network\u0027])"},{"line_number":273,"context_line":"  }}"},{"line_number":274,"context_line":"host_needs_external_network: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ede95e00_58e62265","line":271,"updated":"2022-06-28 09:16:57.000000000","message":"or (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and neutron_ovn_dhcp_agent | bool and inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027])\nor (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and inventory_hostname in groups[\u0027neutron-ovn-metadata-agent\u0027])","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d18640699fa056f0fb7bd0837a595913cc4e6255","unresolved":true,"context_lines":[{"line_number":268,"context_line":"  {{"},{"line_number":269,"context_line":"    (host_is_a_real_compute | bool)"},{"line_number":270,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":271,"context_line":"    or (neutron_plugin_agent in [\u0027openvswitch\u0027, \u0027linuxbridge\u0027] and host_has_a_neutron_agent_depending_on_switching | bool)"},{"line_number":272,"context_line":"    or (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and inventory_hostname in groups[\u0027ovn-controller-network\u0027])"},{"line_number":273,"context_line":"  }}"},{"line_number":274,"context_line":"host_needs_external_network: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b4b1c459_a136dab3","line":271,"in_reply_to":"ede95e00_58e62265","updated":"2022-06-28 13:29:34.000000000","message":"These are required to be in ovn-controller-network group, otherwise other logic breaks. Hence, the current selection is enough.","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d995945ac3c71a2b733e2aa09bb8892450096bc3","unresolved":true,"context_lines":[{"line_number":274,"context_line":"host_needs_external_network: \u003e-"},{"line_number":275,"context_line":"  {{"},{"line_number":276,"context_line":"    (host_is_a_real_compute | bool and computes_need_external_bridge | bool)"},{"line_number":277,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":278,"context_line":"    or (neutron_plugin_agent in [\u0027openvswitch\u0027, \u0027linuxbridge\u0027] and host_has_a_neutron_agent_depending_on_switching | bool)"},{"line_number":279,"context_line":"    or (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and inventory_hostname in groups[\u0027ovn-controller-network\u0027])"},{"line_number":280,"context_line":"  }}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6fb924ee_80bc9c4c","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":97},"updated":"2022-06-28 09:21:21.000000000","message":"Do all of these need an external network?","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d18640699fa056f0fb7bd0837a595913cc4e6255","unresolved":true,"context_lines":[{"line_number":274,"context_line":"host_needs_external_network: \u003e-"},{"line_number":275,"context_line":"  {{"},{"line_number":276,"context_line":"    (host_is_a_real_compute | bool and computes_need_external_bridge | bool)"},{"line_number":277,"context_line":"    or (inventory_hostname in groups[\u0027manila-share\u0027] and enable_manila_backend_generic | bool)"},{"line_number":278,"context_line":"    or (neutron_plugin_agent in [\u0027openvswitch\u0027, \u0027linuxbridge\u0027] and host_has_a_neutron_agent_depending_on_switching | bool)"},{"line_number":279,"context_line":"    or (neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 and inventory_hostname in groups[\u0027ovn-controller-network\u0027])"},{"line_number":280,"context_line":"  }}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e9d5fb88_60bc8cfa","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":97},"in_reply_to":"6fb924ee_80bc9c4c","updated":"2022-06-28 13:29:34.000000000","message":"That was the assumption so far.","commit_id":"73f914c30282fe7adbfa1f53a7f465645860a99c"}],"ansible/roles/openvswitch/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    container_name: \"openvswitch_db\""},{"line_number":5,"context_line":"    image: \"{{ openvswitch_db_image_full }}\""},{"line_number":6,"context_line":"    enabled: \"{{ enable_openvswitch }}\""},{"line_number":7,"context_line":"    host_in_groups: yes"},{"line_number":8,"context_line":"    volumes: \"{{ openvswitch_db_default_volumes + openvswitch_db_extra_volumes }}\""},{"line_number":9,"context_line":"    dimensions: \"{{ openvswitch_db_dimensions }}\""},{"line_number":10,"context_line":"    healthcheck: \"{{ openvswitch_db_healthcheck }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e961f6b7_0ce73e37","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":23},"updated":"2022-05-30 11:33:42.000000000","message":"Why not host_needs_switching?","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    container_name: \"openvswitch_db\""},{"line_number":5,"context_line":"    image: \"{{ openvswitch_db_image_full }}\""},{"line_number":6,"context_line":"    enabled: \"{{ enable_openvswitch }}\""},{"line_number":7,"context_line":"    host_in_groups: yes"},{"line_number":8,"context_line":"    volumes: \"{{ openvswitch_db_default_volumes + openvswitch_db_extra_volumes }}\""},{"line_number":9,"context_line":"    dimensions: \"{{ openvswitch_db_dimensions }}\""},{"line_number":10,"context_line":"    healthcheck: \"{{ openvswitch_db_healthcheck }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"42e0b113_56c666c2","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":23},"in_reply_to":"e961f6b7_0ce73e37","updated":"2022-05-30 11:54:07.000000000","message":"Due to site.yml. I am not sure which approach is better tbh. Regardless of the choice, the effect is the same. When one applies this role, one must deploy both the containers.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    container_name: \"openvswitch_vswitchd\""},{"line_number":13,"context_line":"    image: \"{{ openvswitch_vswitchd_image_full }}\""},{"line_number":14,"context_line":"    enabled: \"{{ enable_openvswitch }}\""},{"line_number":15,"context_line":"    host_in_groups: yes"},{"line_number":16,"context_line":"    privileged: True"},{"line_number":17,"context_line":"    volumes: \"{{ openvswitch_vswitchd_default_volumes + openvswitch_vswitchd_extra_volumes }}\""},{"line_number":18,"context_line":"    dimensions: \"{{ openvswitch_vswitchd_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fe8da6f3_28b3b751","line":15,"updated":"2022-05-30 11:33:42.000000000","message":"ditto","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    container_name: \"openvswitch_vswitchd\""},{"line_number":13,"context_line":"    image: \"{{ openvswitch_vswitchd_image_full }}\""},{"line_number":14,"context_line":"    enabled: \"{{ enable_openvswitch }}\""},{"line_number":15,"context_line":"    host_in_groups: yes"},{"line_number":16,"context_line":"    privileged: True"},{"line_number":17,"context_line":"    volumes: \"{{ openvswitch_vswitchd_default_volumes + openvswitch_vswitchd_extra_volumes }}\""},{"line_number":18,"context_line":"    dimensions: \"{{ openvswitch_vswitchd_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8fe3d797_8ce66786","line":15,"in_reply_to":"fe8da6f3_28b3b751","updated":"2022-05-30 11:54:07.000000000","message":"ditto","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"}],"ansible/roles/openvswitch/tasks/precheck.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2d3327050dd8b36a39b9c0975383f572bd17deb6","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    state: stopped"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - container_facts[\u0027openvswitch_db\u0027] is not defined"},{"line_number":26,"context_line":"    - openvswitch_db.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f9ce0655_a86084ac","line":26,"updated":"2022-05-30 11:33:42.000000000","message":"Needs host_in_groups","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06a01bc5976eafb89b2c7f9a069ca10afb088457","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    state: stopped"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - container_facts[\u0027openvswitch_db\u0027] is not defined"},{"line_number":26,"context_line":"    - openvswitch_db.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"669cf160_f0ef32f5","line":26,"in_reply_to":"f80a1a58_1b546bed","updated":"2022-05-30 12:14:33.000000000","message":"Done","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f3059f1cfd281d20942955d54690cd58725cda68","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    state: stopped"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - container_facts[\u0027openvswitch_db\u0027] is not defined"},{"line_number":26,"context_line":"    - openvswitch_db.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f80a1a58_1b546bed","line":26,"in_reply_to":"f9ce0655_a86084ac","updated":"2022-05-30 11:54:07.000000000","message":"It does not, this role is applied only where this task needs to run. I can remove the \"enabled\" too as it\u0027s only introducing confusion.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"}],"ansible/roles/ovn/tasks/bootstrap.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"29c0a0c9dc02eaf59dadfdb68b4b17d34d9e6d1d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-openflow-probe-interval, value: \"{{ ovn_openflow_probe_interval }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings }}\", state: \"{{ \u0027present\u0027 if host_needs_external_network else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":36,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"},{"line_number":37,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f1f31a1_b50f8b1b","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":135},"updated":"2022-05-26 13:32:37.000000000","message":"why? computes_need_external_bridge and ovn-controller-network group has not been touched in this change.","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"807899d034dfef7a8d0df231f4b4455893853a48","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-openflow-probe-interval, value: \"{{ ovn_openflow_probe_interval }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings }}\", state: \"{{ \u0027present\u0027 if host_needs_external_network else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":36,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"},{"line_number":37,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cd83018e_001c585a","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":135},"in_reply_to":"9f1f31a1_b50f8b1b","updated":"2022-05-26 13:34:26.000000000","message":"DRY optimisation","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"73fdf0e0b9cee4f4673e50f8edf0df471bb6f4cb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    - { name: ovn-remote, value: \"{{ ovn_sb_connection }}\" }"},{"line_number":32,"context_line":"    - { name: ovn-remote-probe-interval, value: \"{{ ovn_remote_probe_interval }}\" }"},{"line_number":33,"context_line":"    - { name: ovn-openflow-probe-interval, value: \"{{ ovn_openflow_probe_interval }}\" }"},{"line_number":34,"context_line":"    - { name: ovn-bridge-mappings, value: \"{{ ovn_mappings }}\", state: \"{{ \u0027present\u0027 if host_needs_external_network else \u0027absent\u0027 }}\" }"},{"line_number":35,"context_line":"    - { name: ovn-chassis-mac-mappings, value: \"{{ ovn_macs }}\", state: \"{{ \u0027present\u0027 if inventory_hostname in groups[\u0027ovn-controller-compute\u0027] else \u0027absent\u0027 }}\" }"},{"line_number":36,"context_line":"    - { name: ovn-cms-options, value: \"{{ ovn_cms_opts }}\", state: \"{{ \u0027present\u0027 if ovn_cms_opts !\u003d \u0027\u0027 else \u0027absent\u0027 }}\" }"},{"line_number":37,"context_line":"  when: inventory_hostname in groups.get(\u0027ovn-controller\u0027, [])"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7bafe593_98cb0051","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":135},"in_reply_to":"cd83018e_001c585a","updated":"2022-05-30 12:14:52.000000000","message":"Done","commit_id":"15aaaa4877ceaac0e5fb6c5acb895e33e407427f"}]}