)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da9d75637d4d394cd4512edf1c67b39317bc7b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1fe30e4_7d681345","updated":"2022-05-07 11:25:45.000000000","message":"In general: I suggest to improve the docs instead of changing the default behaviours.","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"50c02fd3690b687f50f63f3d88453ad4f9e4868a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e817ce35_12555a41","updated":"2022-05-12 14:22:07.000000000","message":"thanks, it could be improved but it\u0027s very nice already","commit_id":"e808317452c39b36078b2949f3f4ed083957e15c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2914532d2b2091956e6d195a666f4e4ec831cfbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de9187e7_c7443ef2","updated":"2022-05-13 00:45:29.000000000","message":"lets merge fix https://review.opendev.org/c/openstack/kolla-ansible/+/841660 with all dependent changes\n","commit_id":"6ca8dbb6db6a646040c734e6c7642106762df482"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da9d75637d4d394cd4512edf1c67b39317bc7b2b","unresolved":true,"context_lines":[{"line_number":624,"context_line":"enable_gnocchi: \"no\""},{"line_number":625,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":626,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":627,"context_line":"enable_hacluster: \"{{ enable_masakari | bool }}\""},{"line_number":628,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":629,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":630,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6daf640d_e17dcfe6","line":627,"updated":"2022-05-07 11:25:45.000000000","message":"let\u0027s not change it, it\u0027s not always required","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cf633ecf9738ea232a001cbf6dd2075e82d32283","unresolved":false,"context_lines":[{"line_number":624,"context_line":"enable_gnocchi: \"no\""},{"line_number":625,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":626,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":627,"context_line":"enable_hacluster: \"{{ enable_masakari | bool }}\""},{"line_number":628,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":629,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":630,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c537dc1e_8c074377","line":627,"in_reply_to":"6daf640d_e17dcfe6","updated":"2022-05-12 13:56:00.000000000","message":"Done","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da9d75637d4d394cd4512edf1c67b39317bc7b2b","unresolved":true,"context_lines":[{"line_number":537,"context_line":"qemu_user_gid: 42427"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":540,"context_line":"# NOTE(mmalchuk) disable libvirt SASL authentication when Masakari used because"},{"line_number":541,"context_line":"# instance-monitors don\u0027t support SASL authentication right now. Revert to true"},{"line_number":542,"context_line":"# when instance-monitors add support."},{"line_number":543,"context_line":"libvirt_enable_sasl: \"{{ not enable_masakari | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c8986f19_f2c66ac9","line":540,"range":{"start_line":540,"start_character":16,"end_line":540,"end_character":17},"updated":"2022-05-07 11:25:45.000000000","message":"needs a colon here to be identified as a NOTE by editors","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cf633ecf9738ea232a001cbf6dd2075e82d32283","unresolved":false,"context_lines":[{"line_number":537,"context_line":"qemu_user_gid: 42427"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"# Whether to enable libvirt SASL authentication."},{"line_number":540,"context_line":"# NOTE(mmalchuk) disable libvirt SASL authentication when Masakari used because"},{"line_number":541,"context_line":"# instance-monitors don\u0027t support SASL authentication right now. Revert to true"},{"line_number":542,"context_line":"# when instance-monitors add support."},{"line_number":543,"context_line":"libvirt_enable_sasl: \"{{ not enable_masakari | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba062f49_a4fc536d","line":540,"range":{"start_line":540,"start_character":16,"end_line":540,"end_character":17},"in_reply_to":"c8986f19_f2c66ac9","updated":"2022-05-12 13:56:00.000000000","message":"Done","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da9d75637d4d394cd4512edf1c67b39317bc7b2b","unresolved":true,"context_lines":[{"line_number":540,"context_line":"# NOTE(mmalchuk) disable libvirt SASL authentication when Masakari used because"},{"line_number":541,"context_line":"# instance-monitors don\u0027t support SASL authentication right now. Revert to true"},{"line_number":542,"context_line":"# when instance-monitors add support."},{"line_number":543,"context_line":"libvirt_enable_sasl: \"{{ not enable_masakari | bool }}\""},{"line_number":544,"context_line":"# Username for libvirt SASL."},{"line_number":545,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":546,"context_line":"# List of enabled libvirt SASL authentication mechanisms."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4b1dd661_a9394e87","line":543,"updated":"2022-05-07 11:25:45.000000000","message":"this is bad idea to suggest this by default as it may go unnoticed by users - better document  in masakari section that it requires SASL to be turned off (and explicitly that it\u0027s bad to do so)","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cf633ecf9738ea232a001cbf6dd2075e82d32283","unresolved":false,"context_lines":[{"line_number":540,"context_line":"# NOTE(mmalchuk) disable libvirt SASL authentication when Masakari used because"},{"line_number":541,"context_line":"# instance-monitors don\u0027t support SASL authentication right now. Revert to true"},{"line_number":542,"context_line":"# when instance-monitors add support."},{"line_number":543,"context_line":"libvirt_enable_sasl: \"{{ not enable_masakari | bool }}\""},{"line_number":544,"context_line":"# Username for libvirt SASL."},{"line_number":545,"context_line":"libvirt_sasl_authname: \"nova\""},{"line_number":546,"context_line":"# List of enabled libvirt SASL authentication mechanisms."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1c8cc494_665d8fff","line":543,"in_reply_to":"4b1dd661_a9394e87","updated":"2022-05-12 13:56:00.000000000","message":"Done","commit_id":"506c79548ef0e53dd7bbbfcf6af61c1d71b8e00c"}],"doc/source/reference/compute/libvirt-guide.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"50c02fd3690b687f50f63f3d88453ad4f9e4868a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"authenticated with SASL. This should not be considered as providing a secure,"},{"line_number":29,"context_line":"encrypted channel, since the username/password SASL mechanisms available for"},{"line_number":30,"context_line":"TCP are no longer considered cryptographically secure. However, it does at"},{"line_number":31,"context_line":"least provide some authentication for the libvirt API. The only case when SASL"},{"line_number":32,"context_line":"should be disabled is when Masakari is used because instance-monitors don\u0027t"},{"line_number":33,"context_line":"support SASL when connects to Libvirt right now. For a more secure encrypted"},{"line_number":34,"context_line":"channel, use :ref`libvirt TLS \u003clibvirt-tls\u003e`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"d9912665_86169599","line":31,"updated":"2022-05-12 14:22:07.000000000","message":"to be honest, as a user, I would expect to find this in Masakari part of the docs, not here, but better here than nowhere I guess","commit_id":"e808317452c39b36078b2949f3f4ed083957e15c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ea85ee438f0b752a94fd5cb7bdbd8e3023d83c4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"authenticated with SASL. This should not be considered as providing a secure,"},{"line_number":29,"context_line":"encrypted channel, since the username/password SASL mechanisms available for"},{"line_number":30,"context_line":"TCP are no longer considered cryptographically secure. However, it does at"},{"line_number":31,"context_line":"least provide some authentication for the libvirt API. The only case when SASL"},{"line_number":32,"context_line":"should be disabled is when Masakari is used because instance-monitors don\u0027t"},{"line_number":33,"context_line":"support SASL when connects to Libvirt right now. For a more secure encrypted"},{"line_number":34,"context_line":"channel, use :ref`libvirt TLS \u003clibvirt-tls\u003e`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"658493ff_bf631fed","line":31,"in_reply_to":"d9912665_86169599","updated":"2022-05-12 15:37:33.000000000","message":"Done","commit_id":"e808317452c39b36078b2949f3f4ed083957e15c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"50c02fd3690b687f50f63f3d88453ad4f9e4868a","unresolved":true,"context_lines":[{"line_number":34,"context_line":"channel, use :ref`libvirt TLS \u003clibvirt-tls\u003e`."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"SASL is enabled according to the ``libvirt_enable_sasl`` flag, which defaults"},{"line_number":37,"context_line":"to ``true``. When Masakari is enabled set it to ``false``."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The username is configured via ``libvirt_sasl_authname``, and defaults to"},{"line_number":40,"context_line":"``kolla``. The password is configured via ``libvirt_sasl_password``, and is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1076301a_b216db4d","line":37,"range":{"start_line":37,"start_character":37,"end_line":37,"end_character":38},"updated":"2022-05-12 14:22:07.000000000","message":"nit: comma","commit_id":"e808317452c39b36078b2949f3f4ed083957e15c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ea85ee438f0b752a94fd5cb7bdbd8e3023d83c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"channel, use :ref`libvirt TLS \u003clibvirt-tls\u003e`."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"SASL is enabled according to the ``libvirt_enable_sasl`` flag, which defaults"},{"line_number":37,"context_line":"to ``true``. When Masakari is enabled set it to ``false``."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The username is configured via ``libvirt_sasl_authname``, and defaults to"},{"line_number":40,"context_line":"``kolla``. The password is configured via ``libvirt_sasl_password``, and is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dd48c4a9_8a0bae74","line":37,"range":{"start_line":37,"start_character":37,"end_line":37,"end_character":38},"in_reply_to":"1076301a_b216db4d","updated":"2022-05-12 15:37:33.000000000","message":"Done","commit_id":"e808317452c39b36078b2949f3f4ed083957e15c"}]}