)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c01b12ab4ec5d905955e1acf9818bbffa402afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2cf59f8f_494e6da7","updated":"2022-05-11 15:29:49.000000000","message":"recheck","commit_id":"473e1b171e8a8cc8127797a9be7339586c524377"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4c7292fe513279de7e2ea557ceaac27337a5ba33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87ad4904_4741c771","updated":"2022-05-12 13:50:45.000000000","message":"2022-05-12T12:57:30.281727892Z ++ cp /etc/redis/redis.conf /etc/redis/redis-regenerated-by-config-rewrite.conf\n2022-05-12T12:57:30.284414161Z cp: cannot create regular file \u0027/etc/redis/redis-regenerated-by-config-rewrite.conf\u0027: Permission denied","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"41d1d946bce96cc6c2e445a908bb9df4228cf931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be96bd29_fee609c8","updated":"2022-05-12 13:50:09.000000000","message":"oh well, it\u0027s actually failing redis-sentinel: https://zuul.opendev.org/t/openstack/build/7278ab69d2694b8f8642e5cbf5872888","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d8277cbd1f513b20edac33f7b992049cfa9f5fb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"126a38a6_3faca6c8","updated":"2022-05-12 13:49:25.000000000","message":"thanks","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"97f9d28dadac7b180f5cca8f61c209b459d3577f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f10e528d_25e39e0b","updated":"2022-05-14 07:33:40.000000000","message":"now it worked, thanks","commit_id":"257ef9fae82dda82d3ef477919c14aa3a8915971"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"10d7ae96f6125d4ffc49c163ebd646227bacce94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d63de2d9_b37abc6b","updated":"2022-05-18 09:51:47.000000000","message":"recheck","commit_id":"257ef9fae82dda82d3ef477919c14aa3a8915971"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c0288e5ff827ffcc77f220327d38e0405c06195d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"01b8759a_b4238caa","updated":"2022-05-18 13:45:07.000000000","message":"this is not backportable as it needs image fixes, otherwise the container will be dying; I think the issue is minor enough that we should not bother","commit_id":"257ef9fae82dda82d3ef477919c14aa3a8915971"}],"ansible/roles/redis/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5571130ce53af02d623da995d4354682f2f73f54","unresolved":true,"context_lines":[{"line_number":74,"context_line":"redis_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":75,"context_line":"redis_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"redis_conf: \"/etc/redis/redis.conf\""},{"line_number":78,"context_line":"redis_generated_conf: \"/etc/redis/redis-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a2d977b0_f6cf84d9","line":77,"updated":"2022-05-12 07:40:13.000000000","message":"let\u0027s add _path suffix to these names to remind it\u0027s a path and not conf contents","commit_id":"473e1b171e8a8cc8127797a9be7339586c524377"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d8277cbd1f513b20edac33f7b992049cfa9f5fb7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"redis_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":75,"context_line":"redis_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"redis_conf: \"/etc/redis/redis.conf\""},{"line_number":78,"context_line":"redis_generated_conf: \"/etc/redis/redis-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f360562f_8d6b5c74","line":77,"in_reply_to":"a2d977b0_f6cf84d9","updated":"2022-05-12 13:49:25.000000000","message":"Done","commit_id":"473e1b171e8a8cc8127797a9be7339586c524377"}],"ansible/roles/redis/templates/redis-sentinel.json.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e2a1361d89d706502c9cd6aae17938c124fa209e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"redis-sentinel /etc/redis/redis-regenerated-by-config-rewrite.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/redis.conf\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c19e93e2_0a851fe1","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":82},"updated":"2022-05-11 13:36:10.000000000","message":"let\u0027s put this in a variable and use in both places","commit_id":"1ec6d043aa81d1867ac34d2b749ae594b9c846e9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5571130ce53af02d623da995d4354682f2f73f54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"redis-sentinel /etc/redis/redis-regenerated-by-config-rewrite.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/redis.conf\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0785daea_bd2eda89","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":82},"in_reply_to":"130f0d55_db3fd484","updated":"2022-05-12 07:40:13.000000000","message":"You know me so well. :-)","commit_id":"1ec6d043aa81d1867ac34d2b749ae594b9c846e9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a1a83cce306041e177cd5c6a7f4aa742ab0c0d3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"redis-sentinel /etc/redis/redis-regenerated-by-config-rewrite.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/redis.conf\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"130f0d55_db3fd484","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":82},"in_reply_to":"79828212_b2e865f0","updated":"2022-05-11 15:07:38.000000000","message":"Done","commit_id":"1ec6d043aa81d1867ac34d2b749ae594b9c846e9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ebb1d492d349aaafa5c1584879d1ad48e9d543fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"redis-sentinel /etc/redis/redis-regenerated-by-config-rewrite.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/redis.conf\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"79828212_b2e865f0","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":82},"in_reply_to":"c19e93e2_0a851fe1","updated":"2022-05-11 15:07:23.000000000","message":"I expected this comment :), actually I wanted to do it by this way...\nGoing to fix.","commit_id":"1ec6d043aa81d1867ac34d2b749ae594b9c846e9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b8d7e41b3e89cb192e91c669413803b27153e097","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"eafb921a_d2d0378d","line":11,"updated":"2022-05-12 13:52:19.000000000","message":"with the current config, we would need to also set permissions for the container to be able to modify its config; maybe we should think about using other place than /etc ? /tmp should be perfect","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6e6c9a0924c0dc5e9b9fbdd4a52f1299fba8c0a","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e6a66177_1557ded0","line":11,"in_reply_to":"1e16905b_87db5f63","updated":"2022-05-13 19:29:18.000000000","message":"Well, it\u0027s generated so /tmp is just as fine. Possibly /run might have been better but it\u0027s not obvious what perms it has.\n\nAs for the permissions, it clearly did not work in the CI so that\u0027s interesting. Let\u0027s see now. Whatever happened there.","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"29c8f8483f788219de36b5f3d2acb4f36fa29ca9","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ce5b5f2a_947393d4","line":11,"in_reply_to":"9e9a0720_be087492","updated":"2022-05-13 17:39:08.000000000","message":"(redis-sentinel)[root@ceph0 /]# ls -la /etc/ | grep redis\ndrwxrws--- 1 redis redis   4096 May 10 07:25 redis\n\nIt is.\nAnd if it was not problem to this moment, I don\u0027t understand why is it issue now ? /etc/redis is set to redis user and it\u0027s done by a package on all distros.\n\nBut yeah, it can be explicitly set by kolla.\n\nActually, the proof may be that this is happening also now - redis *is* reconfiguring its config file.","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"22d53d6c3e40b21af866534db45e11fea1de94e2","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1e16905b_87db5f63","line":11,"in_reply_to":"ce5b5f2a_947393d4","updated":"2022-05-13 17:46:47.000000000","message":"Ok, I\u0027ve added /etc/redis to permissions, /tmp/ for config file sounds weird.\n\n\"\"\"\n/etc. The /etc (et-see) directory is where a Linux system\u0027s configuration files live.\n\"\"\"","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9bd2d887fade16a235afa1f754832669cb5dc7ef","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9e9a0720_be087492","line":11,"in_reply_to":"d1e3ece3_68b37158","updated":"2022-05-13 16:06:53.000000000","message":"The issue is with permissions of the config *directory*. It\u0027s not readable by the final user and thus the container start fails. I suggest we use /tmp for simplicity.","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0f2b7c10d09ee8339c120d54f1a10508fb21a600","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"},{"line_number":13,"context_line":"            \"path\": \"/var/log/kolla/redis\","},{"line_number":14,"context_line":"            \"owner\": \"redis:redis\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"d1e3ece3_68b37158","line":11,"in_reply_to":"eafb921a_d2d0378d","updated":"2022-05-12 14:53:54.000000000","message":"I am not sure if i understand. {{ redis_conf_path }} is copied to {{ redis_generated_conf_path }}, and as {{ redis_conf_path }}, after copy {{ redis_generated_conf_path }} has also same permissions, so why it wouldn\u0027t modify it\u0027s config ? I was testing locally and it just work.","commit_id":"20aa67b771e6e2d2c8d76528b7600a8104deddd9"}]}