)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5a2bc6e5edb69686c41f6d471a11d96e4a35877","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Put openstack exporter behind HAproxy so only one is queried at a time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1972818"},{"line_number":11,"context_line":"Change-Id: I9e36b9169b6725bf6db953e464fc099087747778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f8f6301_ff1ce9bf","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":20},"updated":"2022-05-11 13:40:56.000000000","message":"you lost this in the commit message","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"533b7b32319ba9150897ff0ffc852245cc01845f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Put openstack exporter behind HAproxy so only one is queried at a time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1972818"},{"line_number":11,"context_line":"Change-Id: I9e36b9169b6725bf6db953e464fc099087747778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1cf81cde_ebfdcd5b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":20},"in_reply_to":"5f8f6301_ff1ce9bf","updated":"2022-05-12 14:33:46.000000000","message":"Ack","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b6ff638b4d5151c0a20daac8b3c698f1bfa29a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e07e61e2_4c8b8535","updated":"2022-05-10 15:54:37.000000000","message":"I don\u0027t see prometheus server reconfigured to query the VIP instead. Please clarify. Thanks.","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"986f6ea170513352327314e4cd3207f33c60e292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fdb612f_9258180a","updated":"2022-05-10 15:49:59.000000000","message":"Please have a look at my patch for the following issue with openstack exporter.\n\nKind regards, \n\nKyle","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"533b7b32319ba9150897ff0ffc852245cc01845f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d053a405_de3212e1","in_reply_to":"6ef93bd0_0090d15c","updated":"2022-05-12 14:33:46.000000000","message":"apologies, missed that change from my local.","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"94797b04f9fee8f9174f6e1dbb223320c8015022","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ef93bd0_0090d15c","in_reply_to":"e07e61e2_4c8b8535","updated":"2022-05-11 13:32:36.000000000","message":"This is still not answered.","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dfdc27b2eb19a607f42d3744bb958b6e26a63eef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3f905c52_56890941","updated":"2022-05-11 13:45:00.000000000","message":"thanks","commit_id":"60c38bd16869d6f26645c6359a24ade7cce9eff9"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ca1b6e65a35f08e793b76d222383e69701e2baba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"70febf17_25b2c232","updated":"2022-05-13 08:28:52.000000000","message":"Looks good, thanks Kyle.","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"ce6c121aa3f44fda3043c0dd66443f577ddbb223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1b7e4b15_a1a96c25","updated":"2022-05-13 08:11:02.000000000","message":"Thanks","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b6ff638b4d5151c0a20daac8b3c698f1bfa29a4","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        mode: \"http\""},{"line_number":86,"context_line":"        external: false"},{"line_number":87,"context_line":"        port: \"{{ prometheus_openstack_exporter_port }}\""},{"line_number":88,"context_line":"        custom_member_list: \"{{ prometheus_openstack_exporter_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":89,"context_line":"  prometheus-elasticsearch-exporter:"},{"line_number":90,"context_line":"    container_name: prometheus_elasticsearch_exporter"},{"line_number":91,"context_line":"    group: prometheus-elasticsearch-exporter"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf6b6afd_97ffea92","line":88,"updated":"2022-05-10 15:54:37.000000000","message":"we don\u0027t need to define a single default with backups so we should not set custom_member_list","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"533b7b32319ba9150897ff0ffc852245cc01845f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        mode: \"http\""},{"line_number":86,"context_line":"        external: false"},{"line_number":87,"context_line":"        port: \"{{ prometheus_openstack_exporter_port }}\""},{"line_number":88,"context_line":"        custom_member_list: \"{{ prometheus_openstack_exporter_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":89,"context_line":"  prometheus-elasticsearch-exporter:"},{"line_number":90,"context_line":"    container_name: prometheus_elasticsearch_exporter"},{"line_number":91,"context_line":"    group: prometheus-elasticsearch-exporter"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"92ce5f0e_5760bc9b","line":88,"in_reply_to":"bf6b6afd_97ffea92","updated":"2022-05-12 14:33:46.000000000","message":"Ack","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"94797b04f9fee8f9174f6e1dbb223320c8015022","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        mode: \"http\""},{"line_number":86,"context_line":"        external: false"},{"line_number":87,"context_line":"        port: \"{{ prometheus_openstack_exporter_port }}\""},{"line_number":88,"context_line":"        custom_member_list: \"{{ prometheus_openstack_exporter_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":89,"context_line":"  prometheus-elasticsearch-exporter:"},{"line_number":90,"context_line":"    container_name: prometheus_elasticsearch_exporter"},{"line_number":91,"context_line":"    group: prometheus-elasticsearch-exporter"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb28e38e_c7eac43a","line":88,"in_reply_to":"bf6b6afd_97ffea92","updated":"2022-05-11 13:32:36.000000000","message":"Done","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b6ff638b4d5151c0a20daac8b3c698f1bfa29a4","unresolved":true,"context_lines":[{"line_number":169,"context_line":"prometheus_openstack_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-openstack-exporter\""},{"line_number":170,"context_line":"prometheus_openstack_exporter_tag: \"{{ prometheus_tag }}\""},{"line_number":171,"context_line":"prometheus_openstack_exporter_image_full: \"{{ prometheus_openstack_exporter_image }}:{{ prometheus_openstack_exporter_tag }}\""},{"line_number":172,"context_line":"prometheus_openstack_exporter_haproxy_members: \"{% for host in groups[\u0027prometheus\u0027] %}server {{ hostvars[host].ansible_facts.hostname }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ prometheus_openstack_exporter_port }} check inter 2000 rise 2 fall 5{% if not loop.first %}{% endif %};{% endfor %}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"prometheus_elasticsearch_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-elasticsearch-exporter\""},{"line_number":175,"context_line":"prometheus_elasticsearch_exporter_tag: \"{{ prometheus_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0ae0fe5e_fe09b57f","line":172,"updated":"2022-05-10 15:54:37.000000000","message":"ditto; also, if we were to use it, it should be placed much below the image definitions","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"94797b04f9fee8f9174f6e1dbb223320c8015022","unresolved":false,"context_lines":[{"line_number":169,"context_line":"prometheus_openstack_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-openstack-exporter\""},{"line_number":170,"context_line":"prometheus_openstack_exporter_tag: \"{{ prometheus_tag }}\""},{"line_number":171,"context_line":"prometheus_openstack_exporter_image_full: \"{{ prometheus_openstack_exporter_image }}:{{ prometheus_openstack_exporter_tag }}\""},{"line_number":172,"context_line":"prometheus_openstack_exporter_haproxy_members: \"{% for host in groups[\u0027prometheus\u0027] %}server {{ hostvars[host].ansible_facts.hostname }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ prometheus_openstack_exporter_port }} check inter 2000 rise 2 fall 5{% if not loop.first %}{% endif %};{% endfor %}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"prometheus_elasticsearch_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-elasticsearch-exporter\""},{"line_number":175,"context_line":"prometheus_elasticsearch_exporter_tag: \"{{ prometheus_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac0dfc6d_93ff0865","line":172,"in_reply_to":"0ae0fe5e_fe09b57f","updated":"2022-05-11 13:32:36.000000000","message":"Done","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"533b7b32319ba9150897ff0ffc852245cc01845f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"prometheus_openstack_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-openstack-exporter\""},{"line_number":170,"context_line":"prometheus_openstack_exporter_tag: \"{{ prometheus_tag }}\""},{"line_number":171,"context_line":"prometheus_openstack_exporter_image_full: \"{{ prometheus_openstack_exporter_image }}:{{ prometheus_openstack_exporter_tag }}\""},{"line_number":172,"context_line":"prometheus_openstack_exporter_haproxy_members: \"{% for host in groups[\u0027prometheus\u0027] %}server {{ hostvars[host].ansible_facts.hostname }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ prometheus_openstack_exporter_port }} check inter 2000 rise 2 fall 5{% if not loop.first %}{% endif %};{% endfor %}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"prometheus_elasticsearch_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-prometheus-elasticsearch-exporter\""},{"line_number":175,"context_line":"prometheus_elasticsearch_exporter_tag: \"{{ prometheus_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"85e5132c_23763574","line":172,"in_reply_to":"0ae0fe5e_fe09b57f","updated":"2022-05-12 14:33:46.000000000","message":"I\u0027ve, made the changes you requested. I\u0027ve tested this and it seems the functionality stays the same with your suggestions.","commit_id":"410960443da98e38c6d74328cea91eb7246ecd99"}],"ansible/roles/prometheus/templates/prometheus.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3dfbbb648bb6d70eb0e8d9777befdf05a5290c9e","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    honor_labels: true"},{"line_number":101,"context_line":"    static_configs:"},{"line_number":102,"context_line":"      - targets:"},{"line_number":103,"context_line":"        - \u0027{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\u0027"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% if enable_prometheus_elasticsearch_exporter | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"81aefd3f_81205969","line":103,"updated":"2022-05-23 10:44:28.000000000","message":"Have you tested this with internal TLS enabled?","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"}],"releasenotes/notes/openstack-exporter-hammering-os-apis.yaml":[{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"7e2e19bf59ff1c7807cbfc14d47743d1ace41243","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The prometheus openstack exporters are now behind haproxy,"},{"line_number":5,"context_line":"    providing a unique time series in the prometheus database."},{"line_number":6,"context_line":"    Also ensures that only one exporter queries"},{"line_number":7,"context_line":"    the openstack APIs at any given time interval."},{"line_number":8,"context_line":"    With the previous behavior each openstack exporter"},{"line_number":9,"context_line":"    was scraped at the same time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf1a00bb_c412552c","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":16},"updated":"2022-05-12 13:33:06.000000000","message":"I\u0027ve tested the 3 controllers scenario and I think that still all are active. What could probably be useful here is active/passive mode, similar to https://review.opendev.org/c/openstack/kolla-ansible/+/790936","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"},{"author":{"_account_id":33307,"name":"Kyle Dean","email":"k.s-dean@outlook.com","username":"k-s-dean"},"change_message_id":"533b7b32319ba9150897ff0ffc852245cc01845f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The prometheus openstack exporters are now behind haproxy,"},{"line_number":5,"context_line":"    providing a unique time series in the prometheus database."},{"line_number":6,"context_line":"    Also ensures that only one exporter queries"},{"line_number":7,"context_line":"    the openstack APIs at any given time interval."},{"line_number":8,"context_line":"    With the previous behavior each openstack exporter"},{"line_number":9,"context_line":"    was scraped at the same time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9b0cfe58_4ee31d1e","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":16},"in_reply_to":"58b44f87_8d95068b","updated":"2022-05-12 14:33:46.000000000","message":"I spoke to mark about this, and he said we should leave it active/active Hence the original custom_members_list implementation as originally I implemented it Active/Backup. \n\nIf HAproxy is running in its default round robin mode then only one should be queried every 60 Seconds. the default should probably be 120 seconds. Since, querying the API\u0027s can take a couple of minutes to complete dependant on the size of the system.","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"ce6c121aa3f44fda3043c0dd66443f577ddbb223","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The prometheus openstack exporters are now behind haproxy,"},{"line_number":5,"context_line":"    providing a unique time series in the prometheus database."},{"line_number":6,"context_line":"    Also ensures that only one exporter queries"},{"line_number":7,"context_line":"    the openstack APIs at any given time interval."},{"line_number":8,"context_line":"    With the previous behavior each openstack exporter"},{"line_number":9,"context_line":"    was scraped at the same time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0663127e_25b90a5d","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":16},"in_reply_to":"9b0cfe58_4ee31d1e","updated":"2022-05-13 08:11:02.000000000","message":"Right; I thought we could avoid scraping more than once but there are still multiple Prometheus servers in HA scenario. Looks good, thanks both.","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"07146dc96ef7e866138258dcdb55b1737c468a26","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The prometheus openstack exporters are now behind haproxy,"},{"line_number":5,"context_line":"    providing a unique time series in the prometheus database."},{"line_number":6,"context_line":"    Also ensures that only one exporter queries"},{"line_number":7,"context_line":"    the openstack APIs at any given time interval."},{"line_number":8,"context_line":"    With the previous behavior each openstack exporter"},{"line_number":9,"context_line":"    was scraped at the same time."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"58b44f87_8d95068b","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":16},"in_reply_to":"bf1a00bb_c412552c","updated":"2022-05-12 14:09:27.000000000","message":"I think it\u0027s ok to spread this load. Or does it still cause issues this way?","commit_id":"656f6cdb083c4b40e9c6e12863631b80b8f6d1b5"}]}