)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6b8417e4b5f860e186ed0edb25af5d07b512979","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0752452a_e93a7298","updated":"2022-05-12 09:15:28.000000000","message":"Thank you, it\u0027s awesome it includes docs. I have one comment regarding the formula that we follow in this project in that we try not to own upstream variables unless necessary. It\u0027s easy to amend though.","commit_id":"e04b1631cfd29b9d1c955d024a16b20c62077ec2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed6c601030c70db5f7f6a7e525c3517bc1c5cdfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9cf2325a_02e88191","updated":"2022-05-12 14:20:00.000000000","message":"thanks, I noticed one final discrepancy that would now fail the code","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e4fb1236573a9fce27287e285283a9b336f11fe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"49e86461_6be1d385","updated":"2022-05-13 06:45:21.000000000","message":"thanks, one comment to solve and it\u0027s gtg","commit_id":"3ba60b0f1f88d49f7235a73c1d4889041f24f1dd"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3dde190eb8475a8bc68534952a03459c7a78e85d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1760fcc7_dbb8c6db","updated":"2022-05-13 14:13:06.000000000","message":"thanks","commit_id":"f088b799a5798623be2e3a0aad5c2ffb1ef2a46b"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed6c601030c70db5f7f6a7e525c3517bc1c5cdfa","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# Pure FlashArray Storage Driver"},{"line_number":266,"context_line":"################################"},{"line_number":267,"context_line":"# iscsi"},{"line_number":268,"context_line":"pure_backend: \"pure_iscsi_backend\""},{"line_number":269,"context_line":"pure_api_token:"},{"line_number":270,"context_line":"pure_san_ip:"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f5e66a8e_a2192a06","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":12},"updated":"2022-05-12 14:20:00.000000000","message":"pure_iscsi_backend","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad676c99decefa602207186b8ca3a0ea472c5e9f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# Pure FlashArray Storage Driver"},{"line_number":266,"context_line":"################################"},{"line_number":267,"context_line":"# iscsi"},{"line_number":268,"context_line":"pure_backend: \"pure_iscsi_backend\""},{"line_number":269,"context_line":"pure_api_token:"},{"line_number":270,"context_line":"pure_san_ip:"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"73a66c58_f139fcd6","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":12},"in_reply_to":"6f9d59ea_a3c34431","updated":"2022-05-12 18:52:57.000000000","message":"but then the value seems wrong; how do you imagine fc backend reusing it?","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1e53cfeb54b02f30e4f846f41d54aeecbbcd41e9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# Pure FlashArray Storage Driver"},{"line_number":266,"context_line":"################################"},{"line_number":267,"context_line":"# iscsi"},{"line_number":268,"context_line":"pure_backend: \"pure_iscsi_backend\""},{"line_number":269,"context_line":"pure_api_token:"},{"line_number":270,"context_line":"pure_san_ip:"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c4322525_1438f918","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":12},"in_reply_to":"73a66c58_f139fcd6","updated":"2022-05-12 20:20:13.000000000","message":"The plan is to use a seperate section in the cinder j2 file for  enable_cinder_backend_pure_fc that is defined in defaults/main.yml. The pure_backend will be different in the main.yml and the volume_driver will be different.\nI could add this in now if you want, but I wasn\u0027t convinced FC was currently suppoeted by Kolla","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0e449c3350cfa38be0077987a62bab7d236a4523","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# Pure FlashArray Storage Driver"},{"line_number":266,"context_line":"################################"},{"line_number":267,"context_line":"# iscsi"},{"line_number":268,"context_line":"pure_backend: \"pure_iscsi_backend\""},{"line_number":269,"context_line":"pure_api_token:"},{"line_number":270,"context_line":"pure_san_ip:"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e1569efe_95c82971","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":12},"in_reply_to":"c4322525_1438f918","updated":"2022-05-12 21:09:28.000000000","message":"I\u0027m adding the FC option in to this patch as well.","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"154d3f2885349bf90577dee3982d4a9e2ff087f9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# Pure FlashArray Storage Driver"},{"line_number":266,"context_line":"################################"},{"line_number":267,"context_line":"# iscsi"},{"line_number":268,"context_line":"pure_backend: \"pure_iscsi_backend\""},{"line_number":269,"context_line":"pure_api_token:"},{"line_number":270,"context_line":"pure_san_ip:"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6f9d59ea_a3c34431","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":12},"in_reply_to":"f5e66a8e_a2192a06","updated":"2022-05-12 15:07:19.000000000","message":"I changed in the jinja template as we may want to expand this to cover our FC driver in the future and don\u0027t want this parameter to be prototcol specific","commit_id":"85e080da981e5415cbd32481df6b424aec354d4c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e4fb1236573a9fce27287e285283a9b336f11fe4","unresolved":true,"context_lines":[{"line_number":227,"context_line":"  - name: \"QuobyteHD\""},{"line_number":228,"context_line":"    enabled: \"{{ enable_cinder_backend_quobyte | bool }}\""},{"line_number":229,"context_line":"  - name: \"Pure-FlashArray-fc\""},{"line_number":230,"context_line":"    enabled: \"{{ enable_cinder_backend_pure_fc | bool }}\""},{"line_number":231,"context_line":"  - name: \"Pure-FlashArray-iscsi\""},{"line_number":232,"context_line":"    enabled: \"{{ enable_cinder_backend_pure_iscsi | bool }}\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"71031f24_d047043e","line":230,"updated":"2022-05-13 06:45:21.000000000","message":"in all the other places, the order is: iscsi, fc\nso let\u0027s get this the same","commit_id":"3ba60b0f1f88d49f7235a73c1d4889041f24f1dd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"636c61274a0f843b8b2607c2438b6d5859e783e9","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  - name: \"QuobyteHD\""},{"line_number":228,"context_line":"    enabled: \"{{ enable_cinder_backend_quobyte | bool }}\""},{"line_number":229,"context_line":"  - name: \"Pure-FlashArray-fc\""},{"line_number":230,"context_line":"    enabled: \"{{ enable_cinder_backend_pure_fc | bool }}\""},{"line_number":231,"context_line":"  - name: \"Pure-FlashArray-iscsi\""},{"line_number":232,"context_line":"    enabled: \"{{ enable_cinder_backend_pure_iscsi | bool }}\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6f395988_7e739199","line":230,"in_reply_to":"71031f24_d047043e","updated":"2022-05-13 14:11:33.000000000","message":"Done","commit_id":"3ba60b0f1f88d49f7235a73c1d4889041f24f1dd"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6b8417e4b5f860e186ed0edb25af5d07b512979","unresolved":true,"context_lines":[{"line_number":202,"context_line":"volume_driver \u003d cinder.volume.drivers.pure.PureISCSIDriver"},{"line_number":203,"context_line":"san_ip \u003d {{ pure_san_ip }}"},{"line_number":204,"context_line":"pure_api_token \u003d {{ pure_api_token }}"},{"line_number":205,"context_line":"use_multipath_for_image_xfer \u003d {{ pure_use_multipath }}"},{"line_number":206,"context_line":"use_chap_auth \u003d {{ pure_use_chap }}"},{"line_number":207,"context_line":"pure_iscsi_cidr_list \u003d {{ pure_iscsi_cidr }}"},{"line_number":208,"context_line":"pure_eradicate_on_delete \u003d {{ pure_eradicate_on_delete }}"},{"line_number":209,"context_line":"pure_automatic_max_oversubscription_ratio \u003d {{ pure_automatic_max_oversubscription_ratio }}"},{"line_number":210,"context_line":"{% endif %}"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c0abfc70_91c9781b","line":209,"range":{"start_line":205,"start_character":0,"end_line":209,"end_character":91},"updated":"2022-05-12 09:15:28.000000000","message":"as these do not seem required, let\u0027s not own these variables and instead amend the docs to teach users how they can use the general ini update strategy to configure whatever more they might need (even should pure driver introduce new variables in cinder config) https://docs.openstack.org/kolla-ansible/latest/admin/advanced-configuration.html#openstack-service-configuration-in-kolla","commit_id":"e04b1631cfd29b9d1c955d024a16b20c62077ec2"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3ae94eccf7e17ca0d57a3bd2179b1b096a1365ff","unresolved":false,"context_lines":[{"line_number":202,"context_line":"volume_driver \u003d cinder.volume.drivers.pure.PureISCSIDriver"},{"line_number":203,"context_line":"san_ip \u003d {{ pure_san_ip }}"},{"line_number":204,"context_line":"pure_api_token \u003d {{ pure_api_token }}"},{"line_number":205,"context_line":"use_multipath_for_image_xfer \u003d {{ pure_use_multipath }}"},{"line_number":206,"context_line":"use_chap_auth \u003d {{ pure_use_chap }}"},{"line_number":207,"context_line":"pure_iscsi_cidr_list \u003d {{ pure_iscsi_cidr }}"},{"line_number":208,"context_line":"pure_eradicate_on_delete \u003d {{ pure_eradicate_on_delete }}"},{"line_number":209,"context_line":"pure_automatic_max_oversubscription_ratio \u003d {{ pure_automatic_max_oversubscription_ratio }}"},{"line_number":210,"context_line":"{% endif %}"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f0018697_3281d4a5","line":209,"range":{"start_line":205,"start_character":0,"end_line":209,"end_character":91},"in_reply_to":"c0abfc70_91c9781b","updated":"2022-05-12 12:43:14.000000000","message":"Done","commit_id":"e04b1631cfd29b9d1c955d024a16b20c62077ec2"}],"doc/source/reference/storage/cinder-guide-pure.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6b8417e4b5f860e186ed0edb25af5d07b512979","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also set the values for the following parameters in ``/etc/kolla/globals.yml``:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- pure_api_token"},{"line_number":22,"context_line":"- pure_san_ip"},{"line_number":23,"context_line":"- pure_use_chap"},{"line_number":24,"context_line":"- pure_use_multipath"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ca47803_13d89ad9","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":16},"updated":"2022-05-12 09:15:28.000000000","message":"put each between `` `` so that they render as code","commit_id":"e04b1631cfd29b9d1c955d024a16b20c62077ec2"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3ae94eccf7e17ca0d57a3bd2179b1b096a1365ff","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also set the values for the following parameters in ``/etc/kolla/globals.yml``:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- pure_api_token"},{"line_number":22,"context_line":"- pure_san_ip"},{"line_number":23,"context_line":"- pure_use_chap"},{"line_number":24,"context_line":"- pure_use_multipath"}],"source_content_type":"text/x-rst","patch_set":4,"id":"784b2547_46eaa901","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":16},"in_reply_to":"1ca47803_13d89ad9","updated":"2022-05-12 12:43:14.000000000","message":"Done","commit_id":"e04b1631cfd29b9d1c955d024a16b20c62077ec2"}]}