)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"26f03c5c71a31f6deb108d5a40524922b3e4ca15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aefef145_a386e702","updated":"2024-01-31 09:19:41.000000000","message":"Can\u0027t we just document not to use weird characters in passwords?","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d27b53bb9b701cf5595ee4fe859dd01a51c47e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9cd4bacc_616e68f8","updated":"2022-05-16 12:02:50.000000000","message":"I guess we should encode both username and passport in general.\n\nPlease let me know if you need help defining the new filter.\n\nThanks.","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b4647dc125948ea89eaf1b15fb523b016dda9a5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c80a4e12_4a793c5b","updated":"2023-08-26 22:57:53.000000000","message":"agree with custom filter, but also need the releasenote.","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"035e37ac8e72d5545699171bf35a3748b490123b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad7d11bc_66944980","in_reply_to":"aefef145_a386e702","updated":"2024-01-31 09:34:12.000000000","message":"sometimes it impossible due to requirements from security department","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d27b53bb9b701cf5595ee4fe859dd01a51c47e3f","unresolved":true,"context_lines":[{"line_number":203,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":204,"context_line":"om_rpc_vhost: \"/\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password | urlencode | replace(\u0027/\u0027, \u0027%2f\u0027) }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# oslo.messaging notify transport valid options are [ rabbit ]"},{"line_number":209,"context_line":"om_notify_transport: \"rabbit\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75bfa287_8be90a01","line":206,"range":{"start_line":206,"start_character":122,"end_line":206,"end_character":154},"updated":"2022-05-16 12:02:50.000000000","message":"Let\u0027s create a custom filter that does both. kolla_urlencode should do.","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e68d3ee937a413c886bbe83818e7b053c0b7dfbb","unresolved":true,"context_lines":[{"line_number":203,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":204,"context_line":"om_rpc_vhost: \"/\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password | urlencode | replace(\u0027/\u0027, \u0027%2f\u0027) }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# oslo.messaging notify transport valid options are [ rabbit ]"},{"line_number":209,"context_line":"om_notify_transport: \"rabbit\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6bf49cfb_1f70f0bb","line":206,"range":{"start_line":206,"start_character":122,"end_line":206,"end_character":154},"in_reply_to":"25617ff9_3f2167a0","updated":"2022-05-24 09:30:04.000000000","message":"The clue is \"in paths\". But it makes a difference in general. Let\u0027s please go with my suggestion from the first comment here.","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e3adf68f81799e33b94664fb8626be58f2412f4e","unresolved":true,"context_lines":[{"line_number":203,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":204,"context_line":"om_rpc_vhost: \"/\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password | urlencode | replace(\u0027/\u0027, \u0027%2f\u0027) }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# oslo.messaging notify transport valid options are [ rabbit ]"},{"line_number":209,"context_line":"om_notify_transport: \"rabbit\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e0a06185_75e9e156","line":206,"range":{"start_line":206,"start_character":122,"end_line":206,"end_character":154},"in_reply_to":"75bfa287_8be90a01","updated":"2022-05-24 08:59:50.000000000","message":"Why does urlencode not replace slashes? https://www.urlencoder.org/ does","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1f3382748554ee5655845c68e25260b0be8e113e","unresolved":true,"context_lines":[{"line_number":203,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":204,"context_line":"om_rpc_vhost: \"/\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password | urlencode | replace(\u0027/\u0027, \u0027%2f\u0027) }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# oslo.messaging notify transport valid options are [ rabbit ]"},{"line_number":209,"context_line":"om_notify_transport: \"rabbit\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"25617ff9_3f2167a0","line":206,"range":{"start_line":206,"start_character":122,"end_line":206,"end_character":154},"in_reply_to":"99e5b7c6_cb375a89","updated":"2022-05-24 09:22:58.000000000","message":"From https://jinja.palletsprojects.com/en/3.1.x/templates/#jinja-filters.urlencode\n\nWhen given a string, “/” is not quoted. HTTP servers treat “/” and “%2F” equivalently in paths. If you need quoted slashes, use the |replace(\"/\", \"%2F\") filter.","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ac536078d4c0bc8fcd01f957ab2589054e80988c","unresolved":true,"context_lines":[{"line_number":203,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":204,"context_line":"om_rpc_vhost: \"/\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password | urlencode | replace(\u0027/\u0027, \u0027%2f\u0027) }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# oslo.messaging notify transport valid options are [ rabbit ]"},{"line_number":209,"context_line":"om_notify_transport: \"rabbit\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"99e5b7c6_cb375a89","line":206,"range":{"start_line":206,"start_character":122,"end_line":206,"end_character":154},"in_reply_to":"e0a06185_75e9e156","updated":"2022-05-24 09:14:52.000000000","message":"No idea, feels wrong but what can we do? 🤷","commit_id":"3bc22037a38b93d480cdad2a14d10c8b22d1a4eb"}]}
