)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"31a8988de3509bf003b95bf8d61c1a9afdec98e3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-09 10:05:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix AlertManager\u0027s external web url"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove hard-coded internal address; introduce variable to control"},{"line_number":10,"context_line":"external web url."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"06dfb145_640d707b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2022-09-09 13:37:41.000000000","message":"It was not changed, so this commit message is wrong.","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"ebbeed0cf7b0955b7cbd8b6c998918e033e8e53c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb254822_6c76729a","updated":"2022-05-16 16:17:43.000000000","message":"Forgot the reno, incoming","commit_id":"654a86c1a551540c6fbbbc82a74d44a6c12c17cc"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"991177171448d3acfa665b189c790be28273ba28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41f22e96_4072fca7","updated":"2022-05-16 16:27:31.000000000","message":"Hmm, need to fix the protocol too","commit_id":"654a86c1a551540c6fbbbc82a74d44a6c12c17cc"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"aae5f575c0dd0ca720ddd60caf184dc8cce428b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ef4b62f_0bdfbf2a","updated":"2022-05-17 06:50:41.000000000","message":"check experimental","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74ed9d40ebcd29ba5f1046a9d9b7e78d851b31ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c205c06_e6ebc540","updated":"2022-09-08 09:47:42.000000000","message":"Revived because I\u0027m fed up of tunnelling to get to prometheus alertmanager address when clicking on URL from an alert (and probably there\u0027s more of fed up people).","commit_id":"51a99174fbdb651f5e243c90567165b206ba0842"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f933c3f9e11ecb59cee3b6640a704372600e49b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"046eaf17_aa794538","updated":"2022-09-09 09:41:19.000000000","message":"Skimmed the docs and code, and the ONLY place where this is used is the JSON body sent to a web hook (docs: https://prometheus.io/docs/alerting/latest/configuration/#webhook_config).\n\n@Doug - do you still oppose, or are you fine with changing the default of the backlink url on web hook sent content?","commit_id":"51a99174fbdb651f5e243c90567165b206ba0842"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"28c7c042bec868fcc09e3af353632f1cb65cddae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75dd25a1_2c239a76","updated":"2022-09-09 10:05:41.000000000","message":"Had a discussion with Doug, he still thinks changing the default is not a good idea, let\u0027s go with not changing the default.","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab81c61c20bf114fa7695a3f3206b5cf12237d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b2c5cf2e_ea013b95","updated":"2022-09-09 11:10:11.000000000","message":"If there is no compelling reason to change the default - which I haven\u0027t seen -, then the current solution seems reasonable.","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"02d20abbdb6bbbc4e74e69ca85253b55d31eb3a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f41bb63a_d3db5d7b","updated":"2022-09-09 11:05:22.000000000","message":"Please share the reasoning. Others would like to know too. ;-)","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a42fcc5816d3bacede4fb0fff2b7a7ed2e1a1e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc56b2fc_c20b5b26","updated":"2022-09-09 10:07:50.000000000","message":"Thanks Michal, looks good","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9480831701930258f11d2dc3b7ea8db128b65697","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c4d04c4_455417a8","in_reply_to":"f41bb63a_d3db5d7b","updated":"2022-09-09 12:15:44.000000000","message":"Since there\u0027s only one bug related to this, and nobody else have complained - let\u0027s leave the default and allow users to change it if they need to.","commit_id":"61ff6f811abfc96045230e9f6b09f1e9c59e5432"}],"ansible/roles/prometheus/templates/prometheus-alertmanager.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e86568e40f52434643ef2e7cadbc08b04bd82aa4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"6a7d66c3_3ccf33ea","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"updated":"2022-05-20 08:57:26.000000000","message":"Should we define `prometheus_alertmanager_external_url` to allow people to change the behaviour via an override? Just thinking that some people might legitimately rely on accessing it via the internal VIP and this patch would break that workflow?\n\nNote that Prometheus server continues to use the internal URL - we could cover that at the same time?\n\nhttps://github.com/openstack/kolla-ansible/blame/master/ansible/roles/prometheus/templates/prometheus-server.json.j2#L2","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d4238108bc6d599dcbb164f9397fbd234f93a8fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b5966cba_504e1893","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"02668591_7902f3cb","updated":"2022-05-27 12:36:11.000000000","message":"If we change the default it could break links in peoples existing notifications. I\u0027m happy to be convinced, but I don\u0027t see a strong reason to change it.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6187daab0c13e51d1b0cc6d886b5e0d215ba13df","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"664917a2_8d836a41","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"3854a2c0_e1a8169e","updated":"2022-05-23 11:04:20.000000000","message":"I think external in this case, just means behind a proxy.\n\nIf I understand correctly, by changing to the external VIP, we risk \u0027breaking\u0027 anyone currently accessing the Alertmanager UI via the internal VIP.\n\nI think the bug is really that we should be able to choose whether we pass the external, or internal VIP to Alertmanager as the \u0027external\u0027 URL. Both are valid use cases IMO.\n\nI think we should maintain the status-quo as a default, at least when backporting, because there is a real risk breaking peoples existing workflows.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"675147a96e56e3b66a0cfd718f6e98188e41a4c7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"02668591_7902f3cb","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"39987276_101c2e8f","updated":"2022-05-25 08:58:10.000000000","message":"Changing --web.external-url argument does not prevent from serving requests via internal VIP. It\u0027s value is merely a hint to Alertmanager for building backlink URLs in alert notifications.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6ab2573b94e6858738992d93289ba3c707876d03","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"af8c4e5f_2207e0dc","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"4d21b4f2_c0242acf","updated":"2022-06-06 10:36:31.000000000","message":"\u003e Doug, Piotr already explained where is this used and why it should be external.\n\nI respectfully disagree here - please see my earlier comments.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9c5ab856d95030d251bd4cdc18443bb0887fe07c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"39987276_101c2e8f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"664917a2_8d836a41","updated":"2022-05-23 11:21:16.000000000","message":"Ok then, let\u0027s introduce a new variable with defaulting to as-it-is-today on stable branches and change the default on master?","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"b1bb7cb63ab0e961522b3c2b9ada2a61fa3b76d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"cc3144d3_9ca6ee0c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"6a7d66c3_3ccf33ea","updated":"2022-05-20 09:09:31.000000000","message":"Actually, I just noticed that Prometheus server is only exposed internally, so we can leave that.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"539dc289968d851172cdb0f0ba71a0456d5c836b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3854a2c0_e1a8169e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"834b45cc_65844153","updated":"2022-05-23 08:22:19.000000000","message":"I think that if the cmdline variable is called web.external-url, then it should point to an externally accessible url - I don\u0027t think we\u0027ll break anybody with that. If we will - they should raise a bug and introduce a new variable?","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2dc8f6a64c068da9e0230661c4b195750397c534","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fdd4607b_bd2a76ef","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"af8c4e5f_2207e0dc","updated":"2022-09-08 09:49:47.000000000","message":"Your disagreement has been noted, let\u0027s wait for other reviews.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6d63727ba455e7e3308edb3c6f09c9b277ff4e1f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4d21b4f2_c0242acf","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"b5966cba_504e1893","updated":"2022-05-30 07:20:40.000000000","message":"Doug, Piotr already explained where is this used and why it should be external. I understand that we don\u0027t want to break existing deployments, that\u0027s why we will change the default in master (+reno) and backport this additional variable without changing the default.\n\nSecond thing is, that we probably would prefer to introduce a prometheus_alertmanager_external_fqdn variable (as it\u0027s done in https://review.opendev.org/c/openstack/kolla-ansible/+/823395).\n\nPiotr please propose a new version taking my notes in consideration - thanks.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"b7d8bf4db502830c670d75292fe47e372fac82bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"834b45cc_65844153","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"ca48cbab_ea9edcfb","updated":"2022-05-23 06:52:29.000000000","message":"\u003e Should we define `prometheus_alertmanager_external_url` to allow people to change the behaviour via an override?\nGood point, but this patch I intended to be a bugfix - one that needs to be backported quick \u0026 easily to the stable branches.","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c13bf5960cc0fde5080accdf974d7715cc79b94c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/prometheus_alertmanager/alertmanager --config.file\u003d/etc/prometheus/alertmanager.yml --web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --web.external-url\u003d{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }} --cluster.listen-address\u003d{% if groups[\"prometheus-alertmanager\"] | length \u003e 1 %}{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_cluster_port }} {% for host in groups[\"prometheus-alertmanager\"] %} --cluster.peer\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ hostvars[host][\u0027prometheus_alertmanager_cluster_port\u0027] }}{% endfor %}{% endif %} --storage.path /var/lib/prometheus\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/prometheus-alertmanager.yml\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ca48cbab_ea9edcfb","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":793},"in_reply_to":"cc3144d3_9ca6ee0c","updated":"2022-05-20 09:24:22.000000000","message":"Note there is a patch from Will to expose Prometheus server externally: https://review.opendev.org/c/openstack/kolla-ansible/+/828695","commit_id":"6120118d4d53faeb8675cfcb71f45e80fa413060"}]}