)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"43fff67de99c709bfaabf3a8ad8424f781d23013","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"650fe6e7_8656e565","updated":"2022-05-29 10:06:09.000000000","message":"We could merge it because it is seemingly a noop. The admin interface gets created automatically anyway. Thus this only needs a different commit message.","commit_id":"70a4be3c6b6b58baab1f70cf666fb860db5b8418"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"618b4deeb0f06addc5bc4947772427f48a041e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d7d251c_daef4062","updated":"2022-07-27 18:00:52.000000000","message":"(need to fix the python version for new jammy images)","commit_id":"52ad9efccc6f2638e8eda66f5b8c0ccbff081ab4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d8e91b13541ae1f82fa1d3f3dd38972b9c7a7597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aab3eaf0_e71e730b","updated":"2022-09-26 18:18:09.000000000","message":"Please revote and let\u0027s merge. ;-)","commit_id":"ee32736c1575500e374acdfb6067fd8d0950fdd4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cdd3077b6f2bfeb82ee25360728dfa94a79f91bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65e68b3f_eee56d49","updated":"2022-09-27 05:38:55.000000000","message":"meh, centos jobs use very old images","commit_id":"ee32736c1575500e374acdfb6067fd8d0950fdd4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"960ed795c6b68edcc3866ce30cf87c541ce3e3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d19495ed_5c3c53e1","updated":"2022-09-27 05:39:06.000000000","message":"need to merge and publish https://review.opendev.org/c/openstack/kolla/+/836664 first","commit_id":"ee32736c1575500e374acdfb6067fd8d0950fdd4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1037795a88bbb1633c51e16f72dff1145b0550de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"567fdafc_e25f2963","updated":"2022-10-07 15:58:48.000000000","message":"recheck (CI is fixed)","commit_id":"ee32736c1575500e374acdfb6067fd8d0950fdd4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ea9f833fabcfeb3b55f14061189c5716fd9976c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9054203c_83516587","updated":"2022-10-07 09:41:06.000000000","message":"recheck (external situation fixed)","commit_id":"ee32736c1575500e374acdfb6067fd8d0950fdd4"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"d0eb10889b2e988e2b4c48508b16fac6d18eae23","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"keystone_service_admin_endpoint: {\u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ keystone_internal_url }}\u0027}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"# TODO(yoctozepto): Remove after Zed."},{"line_number":205,"context_line":"keystone_create_admin_endpoint: false"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"keystone_ks_services:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9b903d81_3fa01946","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":37},"updated":"2022-09-26 12:01:50.000000000","message":"I would move that comment one line above as it looks like whole \"admin\" endpoint will be gone after Zed.","commit_id":"9c62e2742e552ef7ce67b61e4b51fbadb432263c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d8e91b13541ae1f82fa1d3f3dd38972b9c7a7597","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"keystone_service_admin_endpoint: {\u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ keystone_internal_url }}\u0027}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"# TODO(yoctozepto): Remove after Zed."},{"line_number":205,"context_line":"keystone_create_admin_endpoint: false"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"keystone_ks_services:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e3bdedb6_84431793","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":37},"in_reply_to":"34f68072_34401d0d","updated":"2022-09-26 18:18:09.000000000","message":"Done","commit_id":"9c62e2742e552ef7ce67b61e4b51fbadb432263c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f058547173bf675f6b917eba5f2e5ea0080c5d3f","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"keystone_service_admin_endpoint: {\u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ keystone_internal_url }}\u0027}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"# TODO(yoctozepto): Remove after Zed."},{"line_number":205,"context_line":"keystone_create_admin_endpoint: false"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"keystone_ks_services:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"34f68072_34401d0d","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":37},"in_reply_to":"9b903d81_3fa01946","updated":"2022-09-26 12:06:26.000000000","message":"Well, it will be. This comment is what we use to denote lines to remove but you it is right that we will remove more than this, let me rephrase.","commit_id":"9c62e2742e552ef7ce67b61e4b51fbadb432263c"}],"ansible/roles/keystone/tasks/register.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6653b030a69c19c1cfefc308825ffb7a820c3526","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    docker exec keystone kolla_keystone_bootstrap"},{"line_number":6,"context_line":"    {{ openstack_auth.username }} {{ openstack_auth.password }} {{ keystone_admin_project }}"},{"line_number":7,"context_line":"    admin _IGNORED_ADMIN_URL_ {{ keystone_internal_url }} {{ keystone_public_url }} {{ item }}"},{"line_number":8,"context_line":"  register: keystone_bootstrap"},{"line_number":9,"context_line":"  changed_when: (keystone_bootstrap.stdout | from_json).changed"},{"line_number":10,"context_line":"  failed_when: (keystone_bootstrap.stdout | from_json).failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b8301938_705e227b","line":7,"updated":"2022-08-09 13:22:16.000000000","message":"Maybe also make a note to drop this parameter from the script (in AA?)? Or is that too complicated to coordinate for upgrading and we need to keep this forever?","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"193042e0bfdd454eb7249fdf4db011fcd1c1e63b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    docker exec keystone kolla_keystone_bootstrap"},{"line_number":6,"context_line":"    {{ openstack_auth.username }} {{ openstack_auth.password }} {{ keystone_admin_project }}"},{"line_number":7,"context_line":"    admin _IGNORED_ADMIN_URL_ {{ keystone_internal_url }} {{ keystone_public_url }} {{ item }}"},{"line_number":8,"context_line":"  register: keystone_bootstrap"},{"line_number":9,"context_line":"  changed_when: (keystone_bootstrap.stdout | from_json).changed"},{"line_number":10,"context_line":"  failed_when: (keystone_bootstrap.stdout | from_json).failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"24d9dc2c_fc938e65","line":7,"in_reply_to":"384bb3fe_a7fb5994","updated":"2022-08-26 19:37:28.000000000","message":"Done","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"51f88438ab3aa26d9f8d5d8652808c8a54237440","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  command: \u003e"},{"line_number":5,"context_line":"    docker exec keystone kolla_keystone_bootstrap"},{"line_number":6,"context_line":"    {{ openstack_auth.username }} {{ openstack_auth.password }} {{ keystone_admin_project }}"},{"line_number":7,"context_line":"    admin _IGNORED_ADMIN_URL_ {{ keystone_internal_url }} {{ keystone_public_url }} {{ item }}"},{"line_number":8,"context_line":"  register: keystone_bootstrap"},{"line_number":9,"context_line":"  changed_when: (keystone_bootstrap.stdout | from_json).changed"},{"line_number":10,"context_line":"  failed_when: (keystone_bootstrap.stdout | from_json).failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"384bb3fe_a7fb5994","line":7,"in_reply_to":"b8301938_705e227b","updated":"2022-08-22 08:57:39.000000000","message":"It\u0027s complicated unless we add alternative support for keyword args and then switch to keyword args here. Or do it in a hacky way by depending on the number of args to interpret them. Either could be done as early as Zed. I will go with the hacky one.","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"}],"ansible/roles/keystone/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4f7914363223c88a3743f6673cf071d452c980b2","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    - not use_preconfigured_databases | bool"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO(yoctozepto): Remove after Zed (in AA)."},{"line_number":52,"context_line":"# This is needed to update the admin endpoint."},{"line_number":53,"context_line":"- import_role:"},{"line_number":54,"context_line":"    name: service-ks-register"},{"line_number":55,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"126f001b_f273e416","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":26},"updated":"2022-08-09 08:26:03.000000000","message":"What needs updating?","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"51f88438ab3aa26d9f8d5d8652808c8a54237440","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    - not use_preconfigured_databases | bool"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO(yoctozepto): Remove after Zed (in AA)."},{"line_number":52,"context_line":"# This is needed to update the admin endpoint."},{"line_number":53,"context_line":"- import_role:"},{"line_number":54,"context_line":"    name: service-ks-register"},{"line_number":55,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f965720d_1558cf5f","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":26},"in_reply_to":"126f001b_f273e416","updated":"2022-08-22 08:57:39.000000000","message":"The port. Do you want to include this info in the comment?","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"193042e0bfdd454eb7249fdf4db011fcd1c1e63b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    - not use_preconfigured_databases | bool"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO(yoctozepto): Remove after Zed (in AA)."},{"line_number":52,"context_line":"# This is needed to update the admin endpoint."},{"line_number":53,"context_line":"- import_role:"},{"line_number":54,"context_line":"    name: service-ks-register"},{"line_number":55,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffea7ecf_ab2ece05","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":26},"in_reply_to":"f965720d_1558cf5f","updated":"2022-08-26 19:37:28.000000000","message":"Done","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"}],"releasenotes/notes/keystone-admin-endpoint-optional-8eb8c9a18085d64e.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6653b030a69c19c1cfefc308825ffb7a820c3526","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Keystone\u0027s admin endpoint is not created by default. Operators"},{"line_number":5,"context_line":"    of existing deployments may wish to remove it after the upgrade"},{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"27be97e7_ff39ad77","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":33},"updated":"2022-08-09 13:22:16.000000000","message":"Either \"The Keystone admin endpoint\" like below or only \"Keystone\u0027s admin endpoint\"?\n\nAlso s/not/no longer/ for clarity?","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"51f88438ab3aa26d9f8d5d8652808c8a54237440","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Keystone\u0027s admin endpoint is not created by default. Operators"},{"line_number":5,"context_line":"    of existing deployments may wish to remove it after the upgrade"},{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"303b6d69_c34aedd6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":33},"in_reply_to":"27be97e7_ff39ad77","updated":"2022-08-22 08:57:39.000000000","message":"I think the current wording is fine. I will switch to \"no longer\" on the next iteration.","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"193042e0bfdd454eb7249fdf4db011fcd1c1e63b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Keystone\u0027s admin endpoint is not created by default. Operators"},{"line_number":5,"context_line":"    of existing deployments may wish to remove it after the upgrade"},{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"69aec167_2c1d2be2","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":33},"in_reply_to":"303b6d69_c34aedd6","updated":"2022-08-26 19:37:28.000000000","message":"Done","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6653b030a69c19c1cfefc308825ffb7a820c3526","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"},{"line_number":8,"context_line":"    to ``true`` to keep creating the admin endpoint but such support will"},{"line_number":9,"context_line":"    be removed after Zed and operators wishing to add it will have to do"},{"line_number":10,"context_line":"    so manually."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfd34a84_311ada5b","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":16},"updated":"2022-08-09 13:22:16.000000000","message":"I\u0027d remove that last part, the sentence is already complicated enough and we can deal with this in the AA release notes.","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"193042e0bfdd454eb7249fdf4db011fcd1c1e63b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"},{"line_number":8,"context_line":"    to ``true`` to keep creating the admin endpoint but such support will"},{"line_number":9,"context_line":"    be removed after Zed and operators wishing to add it will have to do"},{"line_number":10,"context_line":"    so manually."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8e188b34_92cfcd95","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":16},"in_reply_to":"6f18cd0c_bc329306","updated":"2022-08-26 19:37:28.000000000","message":"Done","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"51f88438ab3aa26d9f8d5d8652808c8a54237440","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    completes. Operators having external services relying on the availability"},{"line_number":7,"context_line":"    of the Keystone admin endpoint may set ``keystone_create_admin_endpoint``"},{"line_number":8,"context_line":"    to ``true`` to keep creating the admin endpoint but such support will"},{"line_number":9,"context_line":"    be removed after Zed and operators wishing to add it will have to do"},{"line_number":10,"context_line":"    so manually."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6f18cd0c_bc329306","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":16},"in_reply_to":"dfd34a84_311ada5b","updated":"2022-08-22 08:57:39.000000000","message":"Agreed. I will amend in the next iteration.","commit_id":"9f14aa963153658e3f24063aa939db5e004394c9"}]}