)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"16802d589589a8e80e930a8bc1f065ae1b7e25ef","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable hacluster role when it is needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Masakari-hostmonitor or Masakri-instancemonitor needs to"},{"line_number":10,"context_line":"have corosync/pacemaker deployed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch is just changing default enable_hascluter: \"no\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"204adcc5_307b3131","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":31},"updated":"2022-06-07 04:10:44.000000000","message":"Nit: Masakari","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78b43cca7ae5aecff4e9926019ee13abf101596e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable hacluster role when it is needed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Masakari-hostmonitor or Masakri-instancemonitor needs to"},{"line_number":10,"context_line":"have corosync/pacemaker deployed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch is just changing default enable_hascluter: \"no\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9284718a_5c51b8a5","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":31},"in_reply_to":"204adcc5_307b3131","updated":"2022-06-07 07:33:27.000000000","message":"Done","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"66ba94737dfc72e50793fc3012ece36714e4cfc5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Masakari-hostmonitor needs to have"},{"line_number":10,"context_line":"corosync/pacemaker deployed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch is just changing default enable_hascluter: \"no\""},{"line_number":13,"context_line":"to \"yes\" if masakari-hostmonitor is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1934149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff58b295_55b750c4","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":52},"updated":"2022-06-07 11:42:21.000000000","message":"enable_hacluster","commit_id":"92fd0dff0565f85a98f0a4edac308196ccde384c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a6929ca216c955c6f4933db380e782af700abee6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Masakari-hostmonitor needs to have"},{"line_number":10,"context_line":"corosync/pacemaker deployed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch is just changing default enable_hascluter: \"no\""},{"line_number":13,"context_line":"to \"yes\" if masakari-hostmonitor is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1934149"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"504ee9ab_80e4ecba","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":52},"in_reply_to":"ff58b295_55b750c4","updated":"2022-06-07 12:20:25.000000000","message":"ups","commit_id":"92fd0dff0565f85a98f0a4edac308196ccde384c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"16802d589589a8e80e930a8bc1f065ae1b7e25ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c91da166_4333bcb3","updated":"2022-06-07 04:10:44.000000000","message":"Maybe add a release note?","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b8ad45dcdfaca0123e55bf84285cf5cc7c20b212","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad9435ed_048495c7","in_reply_to":"9235c0f0_9b0507a2","updated":"2022-06-07 08:11:04.000000000","message":"Done, fixed.","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"79b79703cf5db123ed3d7ed092f9f81eba4d5557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9235c0f0_9b0507a2","in_reply_to":"a94d3ba3_b3f73628","updated":"2022-06-07 08:04:07.000000000","message":"Linter job has failed:\n\nreleasenotes/notes/change-value-of-enable-hacluster-4653fd447456f683.yaml:4: D001 Line too long\nreleasenotes/notes/change-value-of-enable-hacluster-4653fd447456f683.yaml:10: D001 Line too long","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78b43cca7ae5aecff4e9926019ee13abf101596e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a94d3ba3_b3f73628","in_reply_to":"c91da166_4333bcb3","updated":"2022-06-07 07:33:27.000000000","message":"I am not good in renos, so please could you check what i\u0027ve provided and let me know  ? :) Thanks","commit_id":"28e79c3671f1f5117099eb948b5a351e0e035dbd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f04035b99fe2fef3e854485710385d3d5237b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"93dc33c4_28e893a4","updated":"2022-06-07 09:03:37.000000000","message":"Could you also drop the override of enable_hacluster in tests/templates/globals-default.j2","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ac8d910c354aa965a780939abb490c99d9202d62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d4e1a30_a361ff67","in_reply_to":"93dc33c4_28e893a4","updated":"2022-06-07 11:31:58.000000000","message":"Dropped.","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a584ab578e471c0c3410cd41fe468708a47b848f","unresolved":true,"context_lines":[{"line_number":622,"context_line":"enable_gnocchi: \"no\""},{"line_number":623,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":624,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":625,"context_line":"enable_hacluster: \"{{ enable_masakari_instancemonitor | bool or enable_masakari_hostmonitor | bool }}\""},{"line_number":626,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":627,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":628,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6cba7b4a_47ef6453","line":625,"range":{"start_line":625,"start_character":22,"end_line":625,"end_character":53},"updated":"2022-06-07 08:34:35.000000000","message":"Is it necessary for instance monitor?","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f04035b99fe2fef3e854485710385d3d5237b5f","unresolved":true,"context_lines":[{"line_number":622,"context_line":"enable_gnocchi: \"no\""},{"line_number":623,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":624,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":625,"context_line":"enable_hacluster: \"{{ enable_masakari_instancemonitor | bool or enable_masakari_hostmonitor | bool }}\""},{"line_number":626,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":627,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":628,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c03af34b_27f4c303","line":625,"range":{"start_line":625,"start_character":22,"end_line":625,"end_character":53},"in_reply_to":"518a278e_9d0584d0","updated":"2022-06-07 09:03:37.000000000","message":"Instance monitor uses libvirt to monitor VMs. Host monitor uses pacemaker to detect host failures. They use the same config file. Possibly we could make the corosync config conditional, but not really necessary.","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"726e3c143123e230f670177e9d273895d8d0fd78","unresolved":true,"context_lines":[{"line_number":622,"context_line":"enable_gnocchi: \"no\""},{"line_number":623,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":624,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":625,"context_line":"enable_hacluster: \"{{ enable_masakari_instancemonitor | bool or enable_masakari_hostmonitor | bool }}\""},{"line_number":626,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":627,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":628,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"518a278e_9d0584d0","line":625,"range":{"start_line":625,"start_character":22,"end_line":625,"end_character":53},"in_reply_to":"6cba7b4a_47ef6453","updated":"2022-06-07 08:42:05.000000000","message":"To be honest, I am not expert on masakari but I suppose that yes, when checking below :  \n\nmichalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ cat ansible/roles/masakari/templates/masakari-instancemonitor.json.j2 \n{\n    \"command\": \"masakari-instancemonitor --config-file /etc/masakari-monitors/masakari-monitors.conf\",\n\n\nmichalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ cat ansible/roles/masakari/templates/masakari-monitors.conf.j2  | grep hacluster\n{% if inventory_hostname in groups[\u0027hacluster\u0027] %}\ncorosync_multicast_ports \u003d {{ hacluster_corosync_port }}\n{% elif inventory_hostname in groups[\u0027hacluster-remote\u0027] %}\n\n\n\nFrom above it looks like instancemonitor is using --config-file /etc/masakari-monitors/masakari-monitors.conf and this config-file has hacluster_corosync_port configured inside.\n\nSo, please, correct me if I am wrong, but from code it looks like.","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2279933882c3fd0a7e46d49b301a814852d8aae0","unresolved":false,"context_lines":[{"line_number":622,"context_line":"enable_gnocchi: \"no\""},{"line_number":623,"context_line":"enable_gnocchi_statsd: \"no\""},{"line_number":624,"context_line":"enable_grafana: \"{{ enable_monasca | bool }}\""},{"line_number":625,"context_line":"enable_hacluster: \"{{ enable_masakari_instancemonitor | bool or enable_masakari_hostmonitor | bool }}\""},{"line_number":626,"context_line":"enable_heat: \"{{ enable_openstack_core | bool }}\""},{"line_number":627,"context_line":"enable_horizon: \"{{ enable_openstack_core | bool }}\""},{"line_number":628,"context_line":"enable_horizon_blazar: \"{{ enable_blazar | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3e0744be_ab6b90fd","line":625,"range":{"start_line":625,"start_character":22,"end_line":625,"end_character":53},"in_reply_to":"c03af34b_27f4c303","updated":"2022-06-07 09:14:47.000000000","message":"Done","commit_id":"0ae544fcedb24ea388d26fcdba0d04aac90fa879"}]}