)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"64d2e02fbce2c2c304768383e4296ad196fe8bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"480c6c0c_3da8d9f6","updated":"2022-07-04 19:54:49.000000000","message":"By Ceph conventions, the name of the file is ${cluster_name}.conf. So far we have allowed only for the default cluster, canonically named \"ceph\". As Ceph allows flexibility in cluster names, I suggest we should let the user configure the clusters\u0027 names as they wish. To keep things neat, I suggest to source .conf files from a subdirectory. Just \"ceph\" would do. As that is the expected name in /etc. Would it make sense to add same support to Nova, Glance and Manila?","commit_id":"87590d538093216436cbcd7f3782db7bae41971f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b3895f46b8ad7b399bea135e48ecf14b0c61582c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52b5cc8d_06c9251b","in_reply_to":"480c6c0c_3da8d9f6","updated":"2022-07-04 19:55:06.000000000","message":"(unresolving)","commit_id":"87590d538093216436cbcd7f3782db7bae41971f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"bf90b634b7ab6737c2c06b76e7dd766dc0580bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a1f23a5_304b1e19","in_reply_to":"52b5cc8d_06c9251b","updated":"2022-07-21 20:22:04.000000000","message":"Done","commit_id":"87590d538093216436cbcd7f3782db7bae41971f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6e3159754148d565ae72a0b030e9444fd0bfa045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7b86f676_4de6e867","updated":"2022-07-21 20:21:45.000000000","message":"Applied changes in order to copy ceph conf files into a ´ceph´ subdirectory in each container config directory and then copying the contents if this subdirectory into `/etc/ceph`.","commit_id":"3f9024033648b39b89334d846cd28f27a2de997b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cb895cf1835634edf1ecf2a25e4a631b7711bed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bfd4ab00_4faf0b2c","updated":"2022-07-22 08:00:39.000000000","message":"It\u0027s likely fine but we hit a CI issue now related to Jammy:\n\nFailed to update apt cache: W:The repository \u0027http://download.ceph.com/debian-pacific jammy Release\u0027 does not have a Release file., W:Data from such a repository can\u0027t be authenticated and is therefore potentially dangerous to use., W:See apt-secure(8) manpage for repository creation and user configuration details., W:https://download.docker.com/linux/ubuntu/dists/jammy/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details., E:Failed to fetch http://download.ceph.com/debian-pacific/dists/jammy/main/binary-amd64/Packages  404  Not Found [IP: 158.69.68.124 80], E:Some index files failed to download. They have been ignored, or old ones used instead.","commit_id":"3f9024033648b39b89334d846cd28f27a2de997b"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6ca6926ed1119a3e3bdc6c43171cded7092d006d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"70b6cf4e_e1f6b7f5","updated":"2022-07-25 14:12:39.000000000","message":"Recheck","commit_id":"3f9024033648b39b89334d846cd28f27a2de997b"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a5a5014709897c744400c69c7fdbe27b8b7f1905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e0cee245_9d5e4233","updated":"2022-07-25 18:46:54.000000000","message":"Recheck","commit_id":"3f9024033648b39b89334d846cd28f27a2de997b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3076ff4ba50426a4cf37f7e59499859b2dbfa3af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7cc91a13_880dc603","updated":"2022-07-25 20:19:05.000000000","message":"the CI is broken, please be patient","commit_id":"3f9024033648b39b89334d846cd28f27a2de997b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"425518dde57cbc7150bd35ecc63bdb2c051ea5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a8c3d7c9_ec6e2c5b","updated":"2022-07-26 09:20:52.000000000","message":"TASK [cinder : Copying over ceph.conf for Cinder] ******************************\n\n    \"msg\": \"The conditional check \u0027item.1.value.enabled | bool\u0027 failed. The error was: error while evaluating conditional (item.1.value.enabled | bool): \u0027dict object\u0027 has no attribute \u0027value\u0027\\n\\nThe error appears to be in \u0027/home/zuul/.local/share/kolla-ansible/ansible/roles/cinder/tasks/external_ceph.yml\u0027: line 10, column 3, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n- name: Copying over ceph.conf for Cinder\\n  ^ here\\n\"\n","commit_id":"ce7b37ddeca109afc06837125572f09649b43f82"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"d92efce2bd4c3e04024cffba9274ed6cff58517a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f32d4e0d_bc79a745","in_reply_to":"58e3e63b_1a206632","updated":"2022-07-27 20:50:15.000000000","message":"Done","commit_id":"ce7b37ddeca109afc06837125572f09649b43f82"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a3d74a658bdb1668d2e6cc88e46afad3df6e2df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"58e3e63b_1a206632","in_reply_to":"a8c3d7c9_ec6e2c5b","updated":"2022-07-26 09:21:05.000000000","message":"(unresolving)","commit_id":"ce7b37ddeca109afc06837125572f09649b43f82"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9f75441bac66a3b422f790cbb2ee6c2d30f87560","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"24739894_51cec494","updated":"2022-07-28 08:21:28.000000000","message":"    \"msg\": \"Destination directory /etc/kolla/cinder-backup/ceph does not exist\"\n","commit_id":"0f2105b1b6701a8b5053305c18f6ac15065d4794"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"0faa6457313128fb4e256515664be4fb1c3c100c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9899a859_12101447","in_reply_to":"24739894_51cec494","updated":"2022-08-01 19:58:38.000000000","message":"Added a task that creates the needed directories.","commit_id":"0f2105b1b6701a8b5053305c18f6ac15065d4794"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"7786fa8a0fcfd43c648f443550f63771aa044264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"09a5b735_2c0c4105","updated":"2022-08-12 15:18:29.000000000","message":"Hello, I\u0027m still seeing CI errors unrelated to the proposed changes. Do we need to wait until these are resolved in order to merge or is there an alternative? ","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6e1382aa4b7daca95eed38543ebe38d556581ece","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"046a3925_311e4724","updated":"2022-08-02 07:59:58.000000000","message":"We still have \"error connecting to the cluster\" in the CI...","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"5d1e025f0443a1e2f84ab3cefebbb24db873bb34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0e0fe983_fb0bb717","updated":"2022-08-08 21:45:13.000000000","message":"recheck","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"7d62e540dd5e5f8518cb10ad6480d76556d7de67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a4510b7_57061bbd","updated":"2022-08-12 12:40:02.000000000","message":"recheck","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"ab341d3d3268beb0d83e772ee6888818888736b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d388ad32_92b90fdd","updated":"2022-08-04 15:15:33.000000000","message":"recheck","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"30834cbb91c51d3566602c70b131bd53d27d0c60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7dd514bb_d413ef76","updated":"2022-11-16 18:47:56.000000000","message":"recheck\n\nrunning again as logs have been deleted, trying to duplicate error on local","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"61d113969b2f917d76cb953642036047e21c98d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2997320b_a8b284de","updated":"2022-08-22 08:35:20.000000000","message":"recheck\n\nverifying failures","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"61d113969b2f917d76cb953642036047e21c98d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"359d8be8_9efdd2f5","in_reply_to":"09a5b735_2c0c4105","updated":"2022-08-22 08:35:20.000000000","message":"Hmm, the relevant jobs are green elsewhere so it suggests the errors are actually related. Let me recheck once more.","commit_id":"cd5f037c8988df3518a62bad71dee898bd76ff98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2155bbffc42840912b709de63d31adb791546522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"14e35399_b4a6bb12","updated":"2022-11-25 16:10:05.000000000","message":"Can we get that tested in the cephadm jobs?","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a609f60adc5e56b0cf95f769cfb4d31620578034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"aec43504_9f143599","updated":"2022-11-18 12:59:16.000000000","message":"Hi, finally got a minute to look into this, realized I was wiping the `/etc/ceph` directory when copying the ceph directory holding the ceph conf files, erasing ceph keyrings that were previously there. I changed the odrer in which they are copied to the container and now it seems to work.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a80796ef59800a04df7a162ea44afcad578c60b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0bc3aeed_cc1c9194","updated":"2022-11-25 17:31:13.000000000","message":"Hi, thanks for the comments! I have responded to clarify some points.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a80796ef59800a04df7a162ea44afcad578c60b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0c870d5d_2232f341","in_reply_to":"14e35399_b4a6bb12","updated":"2022-11-25 17:31:13.000000000","message":"I believe it has been tested in those jobs, see the Zuul tab at the bottom of the page.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"da7a211d21c00e4dc1ea519353a4a9e203ae7104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"80f764ce_5bb2e980","updated":"2022-11-25 19:49:26.000000000","message":"Forgot to apply to cinder-backup.json.j2 the same fix applied to cinder-volume.json.j2","commit_id":"c1060df7099b7fb968ff4cf53067f706d694c564"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7b84849424af3bf0fbe308bcd3fa7912a6b999c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f96499e9_236d673d","updated":"2022-12-02 11:00:51.000000000","message":"external ceph docs would need updating too","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c5657e4feed33d935b6417f8fa945151e949114","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c2c3015f_439a600c","in_reply_to":"51711737_e3f969e2","updated":"2022-12-02 12:39:21.000000000","message":"https://opendev.org/openstack/kolla-ansible/src/branch/master/doc/source/reference/storage/external-ceph-guide.rst","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"dfc1e4c940447583557d431d1d148f3e8e19c317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"de0bf126_e4da0f6a","in_reply_to":"c2c3015f_439a600c","updated":"2022-12-02 19:10:21.000000000","message":"Done","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"44d45bc27e13df9d0b00fe67f30af452438df2db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"51711737_e3f969e2","in_reply_to":"f96499e9_236d673d","updated":"2022-12-02 11:57:53.000000000","message":"I don\u0027t really know where to update the ceph docs, any help with this would be appreciated.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bea8385519830e721291d104ad1e766ee1b8922f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b4420bfa_f9fbfafe","updated":"2022-12-02 15:25:37.000000000","message":"Nice patch Juan!\n\nI have one question regarding the use of the patch. \n\nAlso, what if we applied the same idea to handle Keyrings? I mean, with this patch we can handle different files to be copied, but the keyring mounted in the container is always the same. What if we wanted to have different keyrings for different cinder agents. For instance, in a setup where we have multiple AZs, and each AZ has its own ceph cluster, we could have/use different keyrings for each one of them.\n\n\nWe might be able to achieve that by applying your proposal to handle keyrings as well. What do you think?\n","commit_id":"8fb29096f3375d76b278db95b16682b0ef12efec"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"92673131dfa3fadfbb946e721045ce18fb61b31e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"54fb9420_367df0cd","in_reply_to":"b4420bfa_f9fbfafe","updated":"2022-12-02 15:41:56.000000000","message":"Hi Rafael,\n\nGood idea! Surely something to work on. I\u0027d like to close this patch proposal before adding more features on top of it though.\n\nAlso, I don\u0027t know if I\u0027ll have the time to implement this soon, as the case described is not a concern for our company.","commit_id":"8fb29096f3375d76b278db95b16682b0ef12efec"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a8d769474382541ffde45d8a07a86f6e91d625d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"186f7fa5_f7e868a0","updated":"2023-01-05 19:52:09.000000000","message":"I have submitted 2 cherry-picks from this proposal into the stable/victoria and stable/xena branches. I selected these versions as they are the ones worked upon by us at WhiteStack, and we wish to reduce divergences from the stable branches. If any other cherry-pick is needed, please let me know.","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"34b08a1bcdfbdda04e8b8da96ef5ccbb286a834d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"84b1a86b_bf1ee164","updated":"2022-12-27 17:28:12.000000000","message":"Overall, it looks good. It would be interesting though to support multiple key rings as well. Anyways, we can do that in a further iteration.","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"939d06c37d937aed9dda2311fd9d3f5981c0c9d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1a794ea0_a355114d","updated":"2023-02-05 19:51:30.000000000","message":"Very useful feature, but if we have multiple CEPH backends, we also have multiple CEPH keyring for each backend, but this change doesn\u0027t deal with this. There need to convert each \u0027ceph_*_keyring variable\u0027 from string to the dict/list like \u0027ceph_conf_files\u0027 and additional changes not only in cinder role task but in nova-cell role task too. Also releasenotes doesn\u0027t reflect changes needed for upgrade variables, and documentation doesn\u0027t contains information how to deal with keyrings in multiple backends case.","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4e3d0395f7816fb37dd58b5eb24139a9d6513de1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d6c9ec69_25a64f72","updated":"2023-02-20 22:23:09.000000000","message":"lets merge this, we need a followup","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9a09023cfd727e8193840db63cf9a31cf85e1d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"541c139a_1961d164","in_reply_to":"1a794ea0_a355114d","updated":"2023-02-06 07:23:58.000000000","message":"No we don\u0027t - you can use different pools for each backend, cinder does not allow choosing a pool + metadata pool using volume type metadata, so that feature is useful already.\nAs we agreed earlier, it can be a followup (the multiple keyring feature).\nWhat are you missing in release notes (add a review comment in the release notes file), the same for docs.","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"8c4c0d74f3f7743ec8b33bb4ba574b7a977de03a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"45edd350_8ca7be20","in_reply_to":"541c139a_1961d164","updated":"2023-02-17 14:22:40.000000000","message":"Done","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"2de80f0db4f5d0e5d085850cd1c008afc119c69d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"72c29f3a_e38563b4","updated":"2023-03-02 13:18:56.000000000","message":"Could any reviewer provide the needed +2 for merge ?","commit_id":"63ea2012c478b70ddfef5d735bc12f6402b186b5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"437d33d509f0de63b1861edbb43dcc374ec8608f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4332cc51_4c5f3e15","updated":"2023-03-07 17:39:45.000000000","message":"the ceph jobs all seem broken by this","commit_id":"0edc2ddb0b50e395cba70745daadddba09dd7848"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2dd93f76a8e05c0e580deec32400a290a5d9dc13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5917caa9_077211a9","in_reply_to":"4332cc51_4c5f3e15","updated":"2023-03-07 17:42:28.000000000","message":"any log ?","commit_id":"0edc2ddb0b50e395cba70745daadddba09dd7848"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a18e709df233ba479c9346e81d0342c5453fcaa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"207354d1_ef4192e0","updated":"2023-03-07 22:12:13.000000000","message":"There is only linters error, i don\u0027t know why because everything is working as expected and variable is defined in defaults (variable which is reported as not defined in linters report)","commit_id":"ab122143e049ee88c647e087ce8367b5b134c729"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b99edb37ff0212119e2c7f4a76e8a5de27a6e488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"a948e4f4_90296836","updated":"2023-03-16 09:12:33.000000000","message":"Created new patch here https://review.opendev.org/c/openstack/kolla-ansible/+/877413  as i didn\u0027t want to change this as much..","commit_id":"daf5656b6281584edd39a21fb6581151cf897992"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"99b4502a914858a46fed6cbaf99a2e7721ff4ac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"d4e61479_5a55f608","updated":"2023-03-21 06:45:51.000000000","message":"Glance support ? \nKeyrings for differents cephs ? \nKeyrings are only copied - missing documentation that user should define block of configuration with backend specification refering to another ceph.conf.","commit_id":"2574aabe4cb013a1ac089b2aab22f7a4e6b476e1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4bd8e6e84d21d3d6b824428978b145a8baa13bbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"a0ecbddd_0d952f7b","updated":"2023-03-16 09:18:41.000000000","message":"Reverted to last patchset from Juan Pablo Suazo and created new patch which is solving also keyrings and other things https://review.opendev.org/c/openstack/kolla-ansible/+/877413. Also adding Juan Pablo Suazo \u003cjsuazo@whitestack.com\u003e as reviewer.","commit_id":"2574aabe4cb013a1ac089b2aab22f7a4e6b476e1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1bf48d1d67e7cdfae39384ffee496a4c81379712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"2bc18748_45e377d6","in_reply_to":"a0ecbddd_0d952f7b","updated":"2023-03-16 18:44:15.000000000","message":"should this review abandoned in favor of the new review?","commit_id":"2574aabe4cb013a1ac089b2aab22f7a4e6b476e1"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"61e8186b4e2b1b2e1dbba9b482b7fc437132ae31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"369ae663_df8d319e","in_reply_to":"d4e61479_5a55f608","updated":"2023-03-21 13:39:40.000000000","message":"Refer to Michal Nasiadka\u0027s comment about needing multiple keyrings:\n\"No we don\u0027t - you can use different pools for each backend, cinder does not allow choosing a pool + metadata pool using volume type metadata, so that feature is useful already.\nAs we agreed earlier, it can be a followup (the multiple keyring feature).\nWhat are you missing in release notes (add a review comment in the release notes file), the same for docs.\"","commit_id":"2574aabe4cb013a1ac089b2aab22f7a4e6b476e1"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7b84849424af3bf0fbe308bcd3fa7912a6b999c","unresolved":true,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files: [\"../ceph.conf\"]"},{"line_number":934,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":935,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":936,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"464fd4a0_6a6eb7ea","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":33},"updated":"2022-12-02 11:00:51.000000000","message":"nit: probably would look better as a yaml list, not in brackets.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"44d45bc27e13df9d0b00fe67f30af452438df2db","unresolved":true,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files: [\"../ceph.conf\"]"},{"line_number":934,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":935,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":936,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"53b40043_cfee9f36","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":33},"in_reply_to":"464fd4a0_6a6eb7ea","updated":"2022-12-02 11:57:53.000000000","message":"Will change to yaml list.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a4c3158b91a1eeb4a04d56fa8d77ea54b608a525","unresolved":false,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files: [\"../ceph.conf\"]"},{"line_number":934,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":935,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":936,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0b527839_61a63fac","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":33},"in_reply_to":"53b40043_cfee9f36","updated":"2022-12-02 13:51:31.000000000","message":"Done","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4be3161446038346f03aa1565c18a600b933fd0d","unresolved":true,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files:"},{"line_number":934,"context_line":"  - \"ceph.conf\""},{"line_number":935,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":936,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"18163ee9_c71dcb84","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":15},"updated":"2023-02-22 13:54:10.000000000","message":"Should this variable include cinder in the name?","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"312ac159266fa7adf7067edc2f553b5a20634061","unresolved":false,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files:"},{"line_number":934,"context_line":"  - \"ceph.conf\""},{"line_number":935,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":936,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d203f3f9_b12153ce","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":15},"in_reply_to":"1524e6a5_f4dceda5","updated":"2023-02-23 12:41:55.000000000","message":"sure","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1d43590f4db773acb468897d3233b7d9b80b14fe","unresolved":true,"context_lines":[{"line_number":930,"context_line":"# Cinder options"},{"line_number":931,"context_line":"#################################"},{"line_number":932,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":933,"context_line":"ceph_conf_files:"},{"line_number":934,"context_line":"  - \"ceph.conf\""},{"line_number":935,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":936,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1524e6a5_f4dceda5","line":933,"range":{"start_line":933,"start_character":0,"end_line":933,"end_character":15},"in_reply_to":"18163ee9_c71dcb84","updated":"2023-02-22 15:02:14.000000000","message":"indeed","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"}],"ansible/roles/cinder/tasks/external_ceph.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da9ecb009dcae4e7d8d7701d371f896fb282baf7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name : Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/\""},{"line_number":5,"context_line":"    patterns: \u0027(^ceph\\d*\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Copying over ceph.conf for Cinder"},{"line_number":11,"context_line":"  vars:"},{"line_number":12,"context_line":"    services_need_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"88822e0c_6ff7f399","line":9,"range":{"start_line":2,"start_character":0,"end_line":9,"end_character":0},"updated":"2022-06-29 06:40:05.000000000","message":"Can we just have a list of ceph_conf files for user to define? Limiting to an integer in the name is a bit... limiting.","commit_id":"677ca2a2b84830546a0213b659a23da534010a23"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"9f71da171588a7f82297b4c055b1dc2149eddec6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name : Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/\""},{"line_number":5,"context_line":"    patterns: \u0027(^ceph\\d*\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Copying over ceph.conf for Cinder"},{"line_number":11,"context_line":"  vars:"},{"line_number":12,"context_line":"    services_need_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db4afe8f_47b66b22","line":9,"range":{"start_line":2,"start_character":0,"end_line":9,"end_character":0},"in_reply_to":"88822e0c_6ff7f399","updated":"2022-06-29 14:58:16.000000000","message":"I wanted to mirror the process already in place, leaving all ceph_conf files in a specific directory to be copied later. Maybe we could adapt the regex pattern to cover a broader spectrum? Something like: `(^ceph[0-9a-zA-Z-_]*\\.conf)`","commit_id":"677ca2a2b84830546a0213b659a23da534010a23"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"cd9e6feccfb4dce34b02513e73fb4d5b6e6f7d23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name : Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/\""},{"line_number":5,"context_line":"    patterns: \u0027(^ceph\\d*\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Copying over ceph.conf for Cinder"},{"line_number":11,"context_line":"  vars:"},{"line_number":12,"context_line":"    services_need_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"16ddb190_345df945","line":9,"range":{"start_line":2,"start_character":0,"end_line":9,"end_character":0},"in_reply_to":"db4afe8f_47b66b22","updated":"2022-07-05 15:25:11.000000000","message":"Done","commit_id":"677ca2a2b84830546a0213b659a23da534010a23"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a9cc97fad1076b498a54ee5c0cfd53732b09367","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.*\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2bb30e44_a560219e","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":19},"updated":"2022-07-05 11:37:34.000000000","message":"Use + as we expect this file to have a name and not be a hidden file.","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"cd9e6feccfb4dce34b02513e73fb4d5b6e6f7d23","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.*\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"88347d1b_56e43b31","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":19},"in_reply_to":"2bb30e44_a560219e","updated":"2022-07-05 15:25:11.000000000","message":"Done","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a9cc97fad1076b498a54ee5c0cfd53732b09367","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf3734ae_2bf6cde3","line":17,"updated":"2022-07-05 11:37:34.000000000","message":"we need to still handle the legacy ceph.conf; I suggest to also handle the new ceph directory in all the locations - maybe it\u0027s easiest to simply merge and copy the entire director(ies)? similarly in the jsons","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"0e3e594458c58cc95e5d5709daf92ee1451947dd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"653766ca_fcda3b6b","line":17,"in_reply_to":"0a8890af_e7889a40","updated":"2022-07-20 21:40:56.000000000","message":"Added support for legacy conf file.","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"40c8fa78447f9d80eaba020b9fac2855474f6271","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a010c385_03d7d118","line":17,"in_reply_to":"569f6c27_0df0c772","updated":"2022-07-16 14:55:12.000000000","message":"Hi, sorry for the delay, I forgot to reply. With \"all locations\" I meant the practice we have in k-a that involves some global config, some per-host config and some per-service config. Supporting per-host config is very handy.","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"ce96241f67bf9a1e92f0fbeeb8aaf6a787ad49d4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfaa4e84_9efcb698","line":17,"in_reply_to":"a010c385_03d7d118","updated":"2022-07-19 13:57:37.000000000","message":"So, you suggest having different ceph conf files for each host ? I am not too familiar with those configurations. Do you have an example configuration i could use as a base ?","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"cd9e6feccfb4dce34b02513e73fb4d5b6e6f7d23","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e59978e2_1a83759d","line":17,"in_reply_to":"bf3734ae_2bf6cde3","updated":"2022-07-05 15:25:11.000000000","message":"I\u0027m not quite sure I understand this comment correctly, when you say `all the locations´, you mean Nova, Glance and Manila?","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5aa9e560cbcd6739887c593176a1733c90d9c943","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0a8890af_e7889a40","line":17,"in_reply_to":"bfaa4e84_9efcb698","updated":"2022-07-20 18:04:40.000000000","message":"Sorry, I have just noticed this was *not* supported for ceph.conf somehow. That said, you don\u0027t have to work on supporting that part. You just need to make sure we still copy the legacy ceph.conf (as otherwise also the jobs in CI fail - see these FAILURE results from Zuul on cephadm jobs).","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"c44f9884ff3784dac961fca637433e2ce778fd9e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      - \"cinder-backup\""},{"line_number":15,"context_line":"  merge_configs:"},{"line_number":16,"context_line":"    sources:"},{"line_number":17,"context_line":"      - \"{{ item.0.path }}\""},{"line_number":18,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.1.key }}/ceph.conf\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.1.key }}/{{ item.0.path.split(\u0027/\u0027)[-1] }}\""},{"line_number":20,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"569f6c27_0df0c772","line":17,"in_reply_to":"e59978e2_1a83759d","updated":"2022-07-15 16:42:46.000000000","message":"Hi, if you have a minute could you clarify this comment please?","commit_id":"ffa82eba50d43101e7beeab8b4e7fa39f973e92f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"23f94b36b5bb6b981f55767b367dcba2e1a22119","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    - item.1.key in services_need_config"},{"line_number":27,"context_line":"  with_nested:"},{"line_number":28,"context_line":"    - \"{{ ceph_conf_files.files + [{\u0027path\u0027: legacy_ceph_conf_file}] }}\""},{"line_number":29,"context_line":"    - \"{{ cinder_services | dict2items }}\""},{"line_number":30,"context_line":"  notify:"},{"line_number":31,"context_line":"    - Restart {{ item.1.key }} container"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2cd7bcdd_1d0949b9","line":29,"updated":"2022-07-21 09:41:59.000000000","message":"let\u0027s put it first so that it does not override the new same-named config","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6e3159754148d565ae72a0b030e9444fd0bfa045","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - item.1.key in services_need_config"},{"line_number":27,"context_line":"  with_nested:"},{"line_number":28,"context_line":"    - \"{{ ceph_conf_files.files + [{\u0027path\u0027: legacy_ceph_conf_file}] }}\""},{"line_number":29,"context_line":"    - \"{{ cinder_services | dict2items }}\""},{"line_number":30,"context_line":"  notify:"},{"line_number":31,"context_line":"    - Restart {{ item.1.key }} container"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ec18cb39_12633577","line":29,"in_reply_to":"2cd7bcdd_1d0949b9","updated":"2022-07-21 20:21:45.000000000","message":"Done","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2155bbffc42840912b709de63d31adb791546522","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.+\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Create directories for Ceph files"},{"line_number":11,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"279b966e_88594940","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":27},"updated":"2022-11-25 16:10:05.000000000","message":"instead of that and limiting users to ceph.conf, ceph1.conf, ceph2.conf etc - I think it would be better to have a list of ceph.conf files that need to be copied.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a80796ef59800a04df7a162ea44afcad578c60b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.+\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Create directories for Ceph files"},{"line_number":11,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fc3fb9f6_ab33bdc9","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":27},"in_reply_to":"279b966e_88594940","updated":"2022-11-25 17:31:13.000000000","message":"I need to update the commit contents, but what was agreed with the previous reviewer was creating a new \u003cconfig\u003e/cinder/ceph/ directory where all ceph conf files can be placed, regardless of name.\n\nThe legacy ceph.conf file is still being handled in the same way as before, so old deployments should work correctly.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"c8e72aa340f2864c08d04ae4825bb1084f2577a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.+\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Create directories for Ceph files"},{"line_number":11,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"06b19044_d71e4599","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":27},"in_reply_to":"8be4d6ba_a4426814","updated":"2022-11-28 15:08:46.000000000","message":"Added a new variable `ceph_conf_files` where the names of conf files must be declared for them to be copied. \n\nI think using the `cinder/ceph/` directory is helpful to maintain order, so this variable must hold a list of the name of the ceph conf files present in said directory. So if the variable is declared like this:\n\nceph_conf_files: [\"ceph-ec.conf\", \"ceph-ec-secondpool.conf\", \"ceph-ec-thirdpool.conf\"]\n\nThe directory should look this way:\n\n{{ node_custom_config }}\n└──cinder\n    └── ceph\n        ├── ceph-ec.conf\n        ├── ceph-ec-secondpool.conf\n        └── ceph-ec-thirdpool.conf\n\nLeft a default value to handle legacy ceph.conf files.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"45bd61bb7b3c40a25ad3e1eebbae89b7ac6ec543","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Find ceph conf files"},{"line_number":3,"context_line":"  find:"},{"line_number":4,"context_line":"    paths: \"{{ node_custom_config }}/cinder/ceph\""},{"line_number":5,"context_line":"    patterns: \u0027(^.+\\.conf$)\u0027"},{"line_number":6,"context_line":"    use_regex: yes"},{"line_number":7,"context_line":"  delegate_to: localhost"},{"line_number":8,"context_line":"  register: ceph_conf_files"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Create directories for Ceph files"},{"line_number":11,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8be4d6ba_a4426814","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":27},"in_reply_to":"fc3fb9f6_ab33bdc9","updated":"2022-11-28 07:46:14.000000000","message":"I know it was, but if we do it this way - we\u0027ll end up with the issue that I pointed out in config.json file review - and personally I like to have ceph.confs named, instead of doing them numbered (like ceph-ec.conf, ceph-ec-secondpool.conf, instead of ceph1.conf ceph2.conf which are a bit meaningless unless you look inside).","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2155bbffc42840912b709de63d31adb791546522","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      - \"cinder-volume\""},{"line_number":32,"context_line":"      - \"cinder-backup\""},{"line_number":33,"context_line":"    legacy_ceph_conf_file: \"{{ node_custom_config }}/cinder/ceph.conf\""},{"line_number":34,"context_line":"  merge_configs:"},{"line_number":35,"context_line":"    sources:"},{"line_number":36,"context_line":"      - \"{{ item.1.path }}\""},{"line_number":37,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"627fe68e_73b429de","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"updated":"2022-11-25 16:10:05.000000000","message":"merge_configs does not support tabs, which are used by cephadm ceph.conf generator - I don\u0027t know if merging that is a great idea (users will be confused by the error).","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a80796ef59800a04df7a162ea44afcad578c60b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      - \"cinder-volume\""},{"line_number":32,"context_line":"      - \"cinder-backup\""},{"line_number":33,"context_line":"    legacy_ceph_conf_file: \"{{ node_custom_config }}/cinder/ceph.conf\""},{"line_number":34,"context_line":"  merge_configs:"},{"line_number":35,"context_line":"    sources:"},{"line_number":36,"context_line":"      - \"{{ item.1.path }}\""},{"line_number":37,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d44e411f_04b31abe","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"627fe68e_73b429de","updated":"2022-11-25 17:31:13.000000000","message":"While altered to work with the new changes, this was done by the task previously so I did it this way for consistency reasons.\n\nIf this part of the task is problematic it should be fixed in separate bugfix proposal IMHO, happy to do it myself though.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"45bd61bb7b3c40a25ad3e1eebbae89b7ac6ec543","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - \"cinder-volume\""},{"line_number":32,"context_line":"      - \"cinder-backup\""},{"line_number":33,"context_line":"    legacy_ceph_conf_file: \"{{ node_custom_config }}/cinder/ceph.conf\""},{"line_number":34,"context_line":"  merge_configs:"},{"line_number":35,"context_line":"    sources:"},{"line_number":36,"context_line":"      - \"{{ item.1.path }}\""},{"line_number":37,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"de2f979b_da0df532","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"d44e411f_04b31abe","updated":"2022-11-28 07:46:14.000000000","message":"Ok, let\u0027s leave it for now, and try to fix that in merge_configs later.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7b84849424af3bf0fbe308bcd3fa7912a6b999c","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"612bb456_77fa3fcb","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"updated":"2022-12-02 11:00:51.000000000","message":"don\u0027t we break existing deployments?","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"257429b3fe27281665d9c02c48d93e2782c2b55f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3ea3804b_c5179274","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"14c22d43_9ce3caa2","updated":"2022-12-05 13:29:46.000000000","message":"They can just include the subdir in each files name, works the same ;-)","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a4c3158b91a1eeb4a04d56fa8d77ea54b608a525","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6f2c0f38_c026e5ee","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"4f315ede_c4f000e2","updated":"2022-12-02 13:51:31.000000000","message":"I think I\u0027m not explaining myself correctly. For existing deployments the conf file copied WILL be {{ node_custom_config }}/cinder/ceph.conf, this will not break existing deployments as seen by the zuul jobs:\nhttps://zuul.opendev.org/t/openstack/build/7e033ef23a7f45b58056a73b3834fa68/log/primary/logs/ansible/test-core-openstack#638\nhttps://zuul.opendev.org/t/openstack/build/703e2b59887543e294be5266c1f1469b/log/primary/logs/ansible/test-core-openstack\nhttps://zuul.opendev.org/t/openstack/build/172e9e54d0a142e1b77232224f209875/log/primary/logs/ansible/test-core-openstack\n\nWhile the task is searching inside {{ node_custom_config }}/cinder/ceph/, the default value of ceph_conf_files considers this and contains the path of the ceph.conf file relative to this directory.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"44d45bc27e13df9d0b00fe67f30af452438df2db","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e229ff22_ad1d7ad2","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"612bb456_77fa3fcb","updated":"2022-12-02 11:57:53.000000000","message":"If we assume existing deployments won\u0027t use the ceph_conf_files variable, the default value will take over which is a list only containing \"../ceph.conf\", the task will copy `{{ node_custom_config }}/cinder/ceph/../ceph.conf` \u003d\u003d `{{ node_custom_config }}/cinder/ceph.conf`. This has been tested locally and passed the zuul jobs.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"feb7c407cc96006d48cd3e51560b68c495663bff","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"cf05b60d_026d1a32","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"6f2c0f38_c026e5ee","updated":"2022-12-02 15:53:25.000000000","message":"Ok, I understand - but I would prefer not to introduce new directories, unless it\u0027s required - since we can define any ceph.conf name now - let\u0027s just leave it under cinder/ without adding a new subdirectory for ceph stuff.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"dfc1e4c940447583557d431d1d148f3e8e19c317","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"14c22d43_9ce3caa2","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"cf05b60d_026d1a32","updated":"2022-12-02 19:10:21.000000000","message":"Applied the change, but i still think that going forward, if users will be able to use multiple conf files (or keyrings) and the amount of files in the cinder directory could grow, some new directories should be created in order to maintain the organization of files.","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c5657e4feed33d935b6417f8fa945151e949114","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      - \"cinder-backup\""},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/cinder/ceph/{{ item.1 }}\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/cinder/{{ item.0.key }}/ceph.conf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.0.key }}/ceph/{{ item.1 }}\""},{"line_number":30,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4f315ede_c4f000e2","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":59},"in_reply_to":"e229ff22_ad1d7ad2","updated":"2022-12-02 12:39:21.000000000","message":"Yes, but existing users have ceph.conf in {{ node_custom_config }}/cinder/ceph.conf not cinder/ceph/ceph.conf - we don\u0027t want to break them, can we use the old path (without ceph subdirectory)?","commit_id":"c8d016758403e53f7f77397788698ef364acd851"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"257429b3fe27281665d9c02c48d93e2782c2b55f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create directories for Ceph files"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    services_need_config:"},{"line_number":6,"context_line":"      - \"cinder-volume\""},{"line_number":7,"context_line":"      - \"cinder-backup\""},{"line_number":8,"context_line":"  file:"},{"line_number":9,"context_line":"    path: \"{{ node_config_directory }}/{{ item.key }}/ceph\""},{"line_number":10,"context_line":"    state: directory"},{"line_number":11,"context_line":"    mode: \"0660\""},{"line_number":12,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":13,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - item.value.enabled | bool"},{"line_number":16,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":17,"context_line":"    - item.key in services_need_config"},{"line_number":18,"context_line":"  with_dict: \"{{ cinder_services }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Copying over ceph.conf for Cinder"},{"line_number":21,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"6317928e_05ad7c16","line":18,"range":{"start_line":2,"start_character":0,"end_line":18,"end_character":36},"updated":"2022-12-05 13:29:46.000000000","message":"that\u0027s not needed anymore, is it?","commit_id":"e927172d8830d0b92c473016056950225628001a"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"d2917e5ae0ab9dab719b9ac2b1f55c0b0ef10698","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create directories for Ceph files"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    services_need_config:"},{"line_number":6,"context_line":"      - \"cinder-volume\""},{"line_number":7,"context_line":"      - \"cinder-backup\""},{"line_number":8,"context_line":"  file:"},{"line_number":9,"context_line":"    path: \"{{ node_config_directory }}/{{ item.key }}/ceph\""},{"line_number":10,"context_line":"    state: directory"},{"line_number":11,"context_line":"    mode: \"0660\""},{"line_number":12,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":13,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - item.value.enabled | bool"},{"line_number":16,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":17,"context_line":"    - item.key in services_need_config"},{"line_number":18,"context_line":"  with_dict: \"{{ cinder_services }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Copying over ceph.conf for Cinder"},{"line_number":21,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7b03e339_ad769f6b","line":18,"range":{"start_line":2,"start_character":0,"end_line":18,"end_character":36},"in_reply_to":"6317928e_05ad7c16","updated":"2022-12-05 17:39:10.000000000","message":"Erased it.","commit_id":"e927172d8830d0b92c473016056950225628001a"}],"ansible/roles/cinder/templates/cinder-backup.json.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"23f94b36b5bb6b981f55767b367dcba2e1a22119","unresolved":true,"context_lines":[{"line_number":13,"context_line":"            \"owner\": \"cinder\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %}{% if cinder_backend_ceph | bool %},"},{"line_number":16,"context_line":"{% if ceph_conf_files is defined and ceph_conf_files.matched \u003e 0 %}"},{"line_number":17,"context_line":"{% for file in ceph_conf_files.files %}"},{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"source\": \"{{ container_config_directory }}/{{file.path.split(\u0027/\u0027)[-1]}}\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"f707f303_40cc3220","line":16,"updated":"2022-07-21 09:41:59.000000000","message":"we need to copy the legacy config as well as the new config in here too; in fact, this can be simplified by copying above to a ceph subdirectory and then copying it all in here","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6e3159754148d565ae72a0b030e9444fd0bfa045","unresolved":false,"context_lines":[{"line_number":13,"context_line":"            \"owner\": \"cinder\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }{% endif %}{% if cinder_backend_ceph | bool %},"},{"line_number":16,"context_line":"{% if ceph_conf_files is defined and ceph_conf_files.matched \u003e 0 %}"},{"line_number":17,"context_line":"{% for file in ceph_conf_files.files %}"},{"line_number":18,"context_line":"        {"},{"line_number":19,"context_line":"            \"source\": \"{{ container_config_directory }}/{{file.path.split(\u0027/\u0027)[-1]}}\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"2da89737_c465925d","line":16,"in_reply_to":"f707f303_40cc3220","updated":"2022-07-21 20:21:45.000000000","message":"Done","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2155bbffc42840912b709de63d31adb791546522","unresolved":true,"context_lines":[{"line_number":21,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":22,"context_line":"        },"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph/\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/ceph\","},{"line_number":26,"context_line":"            \"owner\": \"cinder\","},{"line_number":27,"context_line":"            \"perm\": \"0600\","}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"027235a7_42b406df","line":24,"updated":"2022-11-25 16:10:05.000000000","message":"I don\u0027t think that\u0027s a great idea - copying everything...","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"4a80796ef59800a04df7a162ea44afcad578c60b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":22,"context_line":"        },"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph/\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/ceph\","},{"line_number":26,"context_line":"            \"owner\": \"cinder\","},{"line_number":27,"context_line":"            \"perm\": \"0600\","}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"da0e9343_a65a1844","line":24,"in_reply_to":"027235a7_42b406df","updated":"2022-11-25 17:31:13.000000000","message":"See above, we are copying everything as this directory will be dedicated to ceph files, a user has to create this directory for this purpose in mind, so i dont think worrying about a user placing other files here should be a concern.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"c8e72aa340f2864c08d04ae4825bb1084f2577a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":22,"context_line":"        },"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph/\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/ceph\","},{"line_number":26,"context_line":"            \"owner\": \"cinder\","},{"line_number":27,"context_line":"            \"perm\": \"0600\","}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"cd13408d_b6338350","line":24,"in_reply_to":"d83abbb7_71cfccae","updated":"2022-11-28 15:08:46.000000000","message":"Using the ceph_conf_files, only the desired conf files will be copied.","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"45bd61bb7b3c40a25ad3e1eebbae89b7ac6ec543","unresolved":true,"context_lines":[{"line_number":21,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":22,"context_line":"        },"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph/\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/ceph\","},{"line_number":26,"context_line":"            \"owner\": \"cinder\","},{"line_number":27,"context_line":"            \"perm\": \"0600\","}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"d83abbb7_71cfccae","line":24,"in_reply_to":"da0e9343_a65a1844","updated":"2022-11-28 07:46:14.000000000","message":"In a scenario, where user starts with 5 ceph configs, and then downscales to 4, ceph5.conf will still be copied (because we don\u0027t remove templated out files that are not necessary anymore).","commit_id":"d123d7bb2ea4274d30d26082e49593d75f9f07b0"}],"ansible/roles/cinder/templates/cinder-volume.json.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"23f94b36b5bb6b981f55767b367dcba2e1a22119","unresolved":true,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\","},{"line_number":15,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"{% if ceph_conf_files is defined and ceph_conf_files.matched \u003e 0 %}"},{"line_number":18,"context_line":"{% for file in ceph_conf_files.files %}"},{"line_number":19,"context_line":"        {"},{"line_number":20,"context_line":"            \"source\": \"{{ container_config_directory }}/{{file.path.split(\u0027/\u0027)[-1]}}\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9f7b8a98_0a5ca22b","line":17,"updated":"2022-07-21 09:41:59.000000000","message":"ditto","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6e3159754148d565ae72a0b030e9444fd0bfa045","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\","},{"line_number":15,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"{% if ceph_conf_files is defined and ceph_conf_files.matched \u003e 0 %}"},{"line_number":18,"context_line":"{% for file in ceph_conf_files.files %}"},{"line_number":19,"context_line":"        {"},{"line_number":20,"context_line":"            \"source\": \"{{ container_config_directory }}/{{file.path.split(\u0027/\u0027)[-1]}}\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"97ec4e57_d500b726","line":17,"in_reply_to":"9f7b8a98_0a5ca22b","updated":"2022-07-21 20:21:45.000000000","message":"Done","commit_id":"b793ae93be4509d7d9b8545525d11b93189d3941"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"e92c6832a80157393b39e4e03d8e8ff8b028f540","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% for file in ceph_conf_files %}"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}\","},{"line_number":13,"context_line":"            \"dest\": \"/etc/ceph/{{ file }}\","},{"line_number":14,"context_line":"            \"owner\": \"cinder\","},{"line_number":15,"context_line":"            \"perm\": \"0600\","},{"line_number":16,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"0b5e22da_6a0a12c6","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":31},"updated":"2022-12-07 08:07:03.000000000","message":"configure of different backend to store in different path is better. To avoid some situation like different user keyring for cinder","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09a49b011c0a8d8df21d31e7f33fed5696fef87a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% for file in ceph_conf_files %}"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}\","},{"line_number":13,"context_line":"            \"dest\": \"/etc/ceph/{{ file }}\","},{"line_number":14,"context_line":"            \"owner\": \"cinder\","},{"line_number":15,"context_line":"            \"perm\": \"0600\","},{"line_number":16,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"0be64f6b_cb3bab5c","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":31},"in_reply_to":"0b5e22da_6a0a12c6","updated":"2022-12-15 12:29:49.000000000","message":"That feature is only for configs - does it matter here?","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"21b8144a0184c4449710abf499bee8207d43cebb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% for file in ceph_conf_files %}"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}\","},{"line_number":13,"context_line":"            \"dest\": \"/etc/ceph/{{ file }}\","},{"line_number":14,"context_line":"            \"owner\": \"cinder\","},{"line_number":15,"context_line":"            \"perm\": \"0600\","},{"line_number":16,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"9f60fb7b_f31c6484","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":31},"in_reply_to":"0be64f6b_cb3bab5c","updated":"2022-12-20 12:53:36.000000000","message":"I don\u0027t think its relevant for this proposal.","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"690e0288a00df8276442a5e2d3f89c5cf2048217","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% for file in ceph_conf_files %}"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}\","},{"line_number":13,"context_line":"            \"dest\": \"/etc/ceph/{{ file }}\","},{"line_number":14,"context_line":"            \"owner\": \"cinder\","},{"line_number":15,"context_line":"            \"perm\": \"0600\","},{"line_number":16,"context_line":"            \"optional\": {{ (not cinder_backend_ceph | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"53331d0b_a386dbfa","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":31},"in_reply_to":"9f60fb7b_f31c6484","updated":"2023-01-05 13:10:59.000000000","message":"Done","commit_id":"92e34980f15b501c6e3fc22fa74d898dfd2d3f60"}],"releasenotes/notes/feature_multiple-ceph-conf-files-f579323d856d8ca4.yaml":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bea8385519830e721291d104ad1e766ee1b8922f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Implements [Copy Multiple Ceph Conf files into Cinder Containers]."},{"line_number":5,"context_line":"    Allows for multiple ceph.conf files to be stored in the custom config"},{"line_number":6,"context_line":"    directory and to be copied into cinder_volume and cinder_backup containers."},{"line_number":7,"context_line":"    These conf files must be named cephX.conf, where X is either an integer or"},{"line_number":8,"context_line":"    not present (i.e; ceph.conf, ceph1.conf, ceph2.conf, etc...)."},{"line_number":9,"context_line":"    `Blueprint multiple-ceph-conf-files"},{"line_number":10,"context_line":"    \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/multiple-ceph-conf-files\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a0b96d0d_05438451","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":55},"updated":"2022-12-02 15:25:37.000000000","message":"Is this valid? Looking at the code, it seems that we can use any name we want.","commit_id":"8fb29096f3375d76b278db95b16682b0ef12efec"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"92673131dfa3fadfbb946e721045ce18fb61b31e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Implements [Copy Multiple Ceph Conf files into Cinder Containers]."},{"line_number":5,"context_line":"    Allows for multiple ceph.conf files to be stored in the custom config"},{"line_number":6,"context_line":"    directory and to be copied into cinder_volume and cinder_backup containers."},{"line_number":7,"context_line":"    These conf files must be named cephX.conf, where X is either an integer or"},{"line_number":8,"context_line":"    not present (i.e; ceph.conf, ceph1.conf, ceph2.conf, etc...)."},{"line_number":9,"context_line":"    `Blueprint multiple-ceph-conf-files"},{"line_number":10,"context_line":"    \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/multiple-ceph-conf-files\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1b401c60_d1bd4cb5","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":55},"in_reply_to":"a0b96d0d_05438451","updated":"2022-12-02 15:41:56.000000000","message":"I\u0027ve been waiting to get the merge approval to update the release notes, as there have been some changes and I\u0027m waiting on having the definitive version.\n\nYou are correct,  in the current state of the patch you can use any name.","commit_id":"8fb29096f3375d76b278db95b16682b0ef12efec"}]}