)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dcf571d6e0fd72477e7f470e480cf4ac6fd10c24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3c8d58e_f80e4f83","updated":"2022-07-28 13:11:06.000000000","message":"I would also say let\u0027s keep haproxy-config (as it has this name also in the paths) but create loadbalancer-config that calls haproxy-config.","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8267b4d068684cc8ee51cad394b7ef75c68a6fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8ee1edd_9fe743f7","in_reply_to":"05b1557e_0edab340","updated":"2022-07-28 17:46:48.000000000","message":"Done","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7a626c3d320707d3a4c859f75b113e0ee5716973","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27800fde_27e41874","in_reply_to":"128c4119_b90b96e9","updated":"2022-07-28 17:21:47.000000000","message":"Don\u0027t worry, kevko. Let\u0027s merge the base patch and then I will help with the others, ok?","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78a7a2022ecacaa46f226b1dd0dd860a69ac9f07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05b1557e_0edab340","in_reply_to":"27800fde_27e41874","updated":"2022-07-28 17:26:56.000000000","message":"Fixed already","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a22d2f845359abd6c51e3c66ff2e8c56849bca02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"128c4119_b90b96e9","in_reply_to":"c3c8d58e_f80e4f83","updated":"2022-07-28 17:13:42.000000000","message":":( Now i am trying to ..but problem is that if i follow your suggestion - lookup which i implemented in proxysql-config defaults (also your advice) is not working :( - probably - import -\u003e import -\u003e import \n\nI permanently rewriting a code and the real reason why this should be merged disappears.\n\nBefore loadbalancer.yml just imported two roles, proxysql-config and haproxy-config.\n\nEverything was working, now I am just rewriting and rewriting without real reason :(","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a70908000c20e5d57e65e4ba39a9d2e3208ada0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"26d8349b_429819ac","updated":"2022-08-02 15:56:38.000000000","message":"This is just movement haproxy-config to wrapper role loadbalancer-config, simple patch. Any +2 guys ? ","commit_id":"5f834e76e6d54feb7cfa90d1abd897444cb32d3c"}],"ansible/roles/haproxy-config/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4369363c3dc3794e48aeb3bad1bacebe6a902943","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"haproxy-config\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"haproxy_service_template: \"haproxy_single_service_split.cfg.j2\""},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9fefd4be_cfed349e","line":2,"updated":"2022-08-01 09:06:48.000000000","message":"nit: not needed/useful","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37f3ba11664ab850491bde2652f46f813bb4b8be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"haproxy-config\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"haproxy_service_template: \"haproxy_single_service_split.cfg.j2\""},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4ecadca1_d0b59765","line":2,"in_reply_to":"9fefd4be_cfed349e","updated":"2022-08-02 11:38:06.000000000","message":"Done","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"}],"ansible/roles/loadbalancer-config/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4369363c3dc3794e48aeb3bad1bacebe6a902943","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"loadbalancer-config\""},{"line_number":3,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1769910f_483e4d88","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":35},"updated":"2022-08-01 09:06:48.000000000","message":"nit: not really needed/useful","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37f3ba11664ab850491bde2652f46f813bb4b8be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"loadbalancer-config\""},{"line_number":3,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2361dddf_7e970c68","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":35},"in_reply_to":"1769910f_483e4d88","updated":"2022-08-02 11:38:06.000000000","message":"Done","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"}],"ansible/roles/loadbalancer-config/tasks/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0cbfaf4be27eaae08f4336056c704d07a1aeb11","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"97bbfaaa_991c33b1","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"updated":"2022-07-28 17:34:57.000000000","message":"import_role","commit_id":"2f772baa1706860a691a3e4737e44d7b7746d98e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37f3ba11664ab850491bde2652f46f813bb4b8be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a663ac05_61c3b21e","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"in_reply_to":"538c5690_c81747af","updated":"2022-08-02 11:38:06.000000000","message":"Done, but can I ask when I can use include and when import ? I thought that it is about time of load the role (on the beggining or during the play) ...and as a \"helper\" I always thought that when \"when:\" is used ..it is include ..and if not it is import. So how it is ?","commit_id":"2f772baa1706860a691a3e4737e44d7b7746d98e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8267b4d068684cc8ee51cad394b7ef75c68a6fb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"538c5690_c81747af","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"in_reply_to":"97bbfaaa_991c33b1","updated":"2022-07-28 17:46:48.000000000","message":"Nope, include_role\n\nLoadbalancer_config role has \"helper\" in defaults below : \n\nhaproxy_config_install: \"{% if project_name \u003d\u003d \u0027mariadb\u0027 %}{% if enable_proxysql | bool %}False{% else %}True{% endif %}{% else %}True{% endif %}\"\n\nIt\u0027s because proxysql-config role generating user/rules for every project\n\nAs it is in same loadbalancer-config role, we need to run only one in time.","commit_id":"2f772baa1706860a691a3e4737e44d7b7746d98e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da2416e91b9a5a96a3f37795dee958bfbfe9aeaa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3d248e19_602da89f","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"in_reply_to":"a663ac05_61c3b21e","updated":"2022-08-02 14:17:11.000000000","message":"Imports are static - they are resolved as soon as the role is in play. Indeed, for a huge role behind a conditional it might be more beneficial to stay with include, especially if the condition is rarely true. Then we save time on task enumeration for tasks that will not happen anyway. In other cases, we prefer to use imports. There are also some cases where include is required because of Ansible quirks but it\u0027s yet another story.","commit_id":"2f772baa1706860a691a3e4737e44d7b7746d98e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4369363c3dc3794e48aeb3bad1bacebe6a902943","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"},{"line_number":4,"context_line":"  when: haproxy_config_install | bool"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7d956536_f0a97172","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"updated":"2022-08-01 09:06:48.000000000","message":"import_role","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"37f3ba11664ab850491bde2652f46f813bb4b8be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_role:"},{"line_number":3,"context_line":"    name: haproxy-config"},{"line_number":4,"context_line":"  when: haproxy_config_install | bool"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"01917696_8afedc30","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"in_reply_to":"7d956536_f0a97172","updated":"2022-08-02 11:38:06.000000000","message":"Done","commit_id":"82ce8e87edb974b0ef60e1a8f114d8c9f3945f93"}],"ansible/roles/loadbalancer-config/vars/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dcf571d6e0fd72477e7f470e480cf4ac6fd10c24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"haproxy-config\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8124aade_bdb98467","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":22},"updated":"2022-07-28 13:11:06.000000000","message":"loadbalancer","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8267b4d068684cc8ee51cad394b7ef75c68a6fb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"haproxy-config\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"90f37e2c_13b26063","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":22},"in_reply_to":"8124aade_bdb98467","updated":"2022-07-28 17:46:48.000000000","message":"Done","commit_id":"4a2a26f8042bc46aaa3058c8611d7421f6f9a293"}],"ansible/roles/mariadb/tasks/loadbalancer.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"575fb2195abd169e553e88ee31ebd8b16adecada","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    label: \"{{ host }}\""},{"line_number":38,"context_line":"  failed_when: False"},{"line_number":39,"context_line":"  run_once: True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: \"Configure loadbalancer for {{ project_name }}\""},{"line_number":42,"context_line":"  import_role:"},{"line_number":43,"context_line":"    name: loadbalancer-config"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4d41b53c_ba00db16","line":40,"updated":"2022-08-02 18:58:43.000000000","message":"How do you ensure the old haproxy service config is removed when switching to proxysql?","commit_id":"5f834e76e6d54feb7cfa90d1abd897444cb32d3c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e32709d837798b968429f00698f74a1bbdbd6639","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    label: \"{{ host }}\""},{"line_number":38,"context_line":"  failed_when: False"},{"line_number":39,"context_line":"  run_once: True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: \"Configure loadbalancer for {{ project_name }}\""},{"line_number":42,"context_line":"  import_role:"},{"line_number":43,"context_line":"    name: loadbalancer-config"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b0582c67_31fb1bc5","line":40,"in_reply_to":"4d41b53c_ba00db16","updated":"2022-08-08 11:02:55.000000000","message":"Installing/Removing mariadb.cfg is resolved in loadbalancer role.","commit_id":"5f834e76e6d54feb7cfa90d1abd897444cb32d3c"}]}