)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cad0a6459cf01ae4deb17b374cfe50404c6eab36","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-17 14:25:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce variables for cinder backend names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icfdc2e5726fec8b645d6c2c63391a13c31f2ce9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"48a33366_9a1cbfc8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2022-08-17 13:39:55.000000000","message":"Why?","commit_id":"7045ce3f3a9ec90ff56c28287c2b3cdd8edaed55"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5c614a19bd05ff41d277cc6328abeff0f088ae70","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-17 14:25:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce variables for cinder backend names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icfdc2e5726fec8b645d6c2c63391a13c31f2ce9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a7ef04fc_cc0054ca","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"in_reply_to":"48a33366_9a1cbfc8","updated":"2022-08-17 15:09:38.000000000","message":"Updated the commit message.","commit_id":"7045ce3f3a9ec90ff56c28287c2b3cdd8edaed55"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f04794aff2ad67dded771050035ce60fbe84caa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4fa68d95_7b5f128e","updated":"2022-08-12 16:48:18.000000000","message":"LGTM, but a small reno would be nice 😊","commit_id":"6b26b03d2fa7317438323d0783c238cf255757f2"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5c614a19bd05ff41d277cc6328abeff0f088ae70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b1741cc_9fbde59f","in_reply_to":"4fa68d95_7b5f128e","updated":"2022-08-17 15:09:38.000000000","message":"Done","commit_id":"6b26b03d2fa7317438323d0783c238cf255757f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab1e2a662cb736b50211bee81c0923348448640a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbe326e8_00d2f821","updated":"2022-09-27 15:13:23.000000000","message":"As this is only moving hardcoded values to variables, let\u0027s merge. Nice change. Thanks.","commit_id":"0fe8010c887550a41774ec57d3628c626a8eb3be"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"a0370e5f2e70d04f0c61f94332dc2dbbd3956bcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"850d4766_a588d18a","updated":"2022-08-18 12:58:19.000000000","message":"Thanks!","commit_id":"0fe8010c887550a41774ec57d3628c626a8eb3be"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8c3cccf41d5b7e4bf9f6278b6dd5ed1770230d6d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"[{{ cinder_backend_lvm_name }}]"},{"line_number":123,"context_line":"volume_group \u003d {{ cinder_volume_group }}"},{"line_number":124,"context_line":"volume_driver \u003d cinder.volume.drivers.lvm.LVMVolumeDriver"},{"line_number":125,"context_line":"volume_backend_name \u003d {{ cinder_backend_lvm_name }}"},{"line_number":126,"context_line":"target_helper \u003d {{ cinder_target_helper }}"},{"line_number":127,"context_line":"target_protocol \u003d iscsi"},{"line_number":128,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5d532d13_028c798b","line":125,"updated":"2022-08-22 08:51:36.000000000","message":"Overally, this is a nice little change. However, I am unsure about the proposed handling of volume_backend_name as it does not necessarily need to follow the section name. Moreover, we don\u0027t set it for some backend and configure separately for others (pure).","commit_id":"0fe8010c887550a41774ec57d3628c626a8eb3be"}]}