)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6465ec926344f3247c1d2b2f6c3f6ce3b5ea09b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Radosław Piliszek \u003cradoslaw.piliszek@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-30 16:27:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated sysctl knobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8ccd3ab6f22a6f548b1da8d3acd334068dc48f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"503e8eaa_a5eef6c9","line":7,"updated":"2022-09-08 08:27:38.000000000","message":"Add a reference as to why these are deprecated?","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"266e11c8bb736ab7661859ad0916b4fad6e73483","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Radosław Piliszek \u003cradoslaw.piliszek@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-30 16:27:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated sysctl knobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8ccd3ab6f22a6f548b1da8d3acd334068dc48f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c0b53d6d_430532e8","line":7,"in_reply_to":"503e8eaa_a5eef6c9","updated":"2022-09-10 14:20:57.000000000","message":"Ok","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"072c6ba9991e421f2352e6d7a0b1bfa20984df46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Radosław Piliszek \u003cradoslaw.piliszek@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-30 16:27:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated sysctl knobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8ccd3ab6f22a6f548b1da8d3acd334068dc48f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5346df20_6bf7713e","line":7,"in_reply_to":"c0b53d6d_430532e8","updated":"2022-09-10 16:53:21.000000000","message":"Done","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"69f36c9543aae9df24512373245fb6156d7d473d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8db42246_f72d62f6","updated":"2022-08-30 16:29:57.000000000","message":"(rp_filter ones were deprecated via a reno)","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52e2b64e56abc5e1545f7f2ab0d2bf5e3a1fee31","unresolved":true,"context_lines":[{"line_number":577,"context_line":"# Set to KOLLA_SKIP to skip setting these (even if set already - total ignore)."},{"line_number":578,"context_line":"# Set to KOLLA_UNSET to make Kolla unset these in the managed sysctl.conf file."},{"line_number":579,"context_line":"neutron_l3_agent_host_ipv4_ip_forward: KOLLA_UNSET"},{"line_number":580,"context_line":"neutron_l3_agent_host_rp_filter_mode: KOLLA_SKIP"},{"line_number":581,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh1: 128"},{"line_number":582,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh2: 28672"},{"line_number":583,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh3: 32768"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a05d5573_b5104f4a","side":"PARENT","line":580,"range":{"start_line":580,"start_character":0,"end_line":580,"end_character":36},"updated":"2022-08-31 10:54:32.000000000","message":"I\u0027m not sure I was ever convinced that not setting RP filter is a good idea.","commit_id":"b8928ce54bb9ccb17148dd36cf49af2b8c7dfc21"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"072c6ba9991e421f2352e6d7a0b1bfa20984df46","unresolved":false,"context_lines":[{"line_number":577,"context_line":"# Set to KOLLA_SKIP to skip setting these (even if set already - total ignore)."},{"line_number":578,"context_line":"# Set to KOLLA_UNSET to make Kolla unset these in the managed sysctl.conf file."},{"line_number":579,"context_line":"neutron_l3_agent_host_ipv4_ip_forward: KOLLA_UNSET"},{"line_number":580,"context_line":"neutron_l3_agent_host_rp_filter_mode: KOLLA_SKIP"},{"line_number":581,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh1: 128"},{"line_number":582,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh2: 28672"},{"line_number":583,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh3: 32768"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"37ff40ec_f46e568c","side":"PARENT","line":580,"range":{"start_line":580,"start_character":0,"end_line":580,"end_character":36},"in_reply_to":"6316a657_07251cd4","updated":"2022-09-10 16:53:21.000000000","message":"Done","commit_id":"b8928ce54bb9ccb17148dd36cf49af2b8c7dfc21"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7341727fef110f9efdb35791e55fca432fe69456","unresolved":true,"context_lines":[{"line_number":577,"context_line":"# Set to KOLLA_SKIP to skip setting these (even if set already - total ignore)."},{"line_number":578,"context_line":"# Set to KOLLA_UNSET to make Kolla unset these in the managed sysctl.conf file."},{"line_number":579,"context_line":"neutron_l3_agent_host_ipv4_ip_forward: KOLLA_UNSET"},{"line_number":580,"context_line":"neutron_l3_agent_host_rp_filter_mode: KOLLA_SKIP"},{"line_number":581,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh1: 128"},{"line_number":582,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh2: 28672"},{"line_number":583,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh3: 32768"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6316a657_07251cd4","side":"PARENT","line":580,"range":{"start_line":580,"start_character":0,"end_line":580,"end_character":36},"in_reply_to":"a05d5573_b5104f4a","updated":"2022-08-31 11:55:55.000000000","message":"We used to turn off rp_filter which is generally bad.","commit_id":"b8928ce54bb9ccb17148dd36cf49af2b8c7dfc21"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6465ec926344f3247c1d2b2f6c3f6ce3b5ea09b","unresolved":true,"context_lines":[{"line_number":575,"context_line":"openstack_neutron_auth: \"{{ openstack_auth }}\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"# Set to KOLLA_SKIP to skip setting these (even if set already - total ignore)."},{"line_number":578,"context_line":"# Set to KOLLA_UNSET to make Kolla unset these in the managed sysctl.conf file."},{"line_number":579,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh1: 128"},{"line_number":580,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh2: 28672"},{"line_number":581,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh3: 32768"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9b08b9ac_ff763ebc","line":578,"updated":"2022-09-08 08:27:38.000000000","message":"Is the comment still needed? I don\u0027t think so","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"266e11c8bb736ab7661859ad0916b4fad6e73483","unresolved":false,"context_lines":[{"line_number":575,"context_line":"openstack_neutron_auth: \"{{ openstack_auth }}\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"# Set to KOLLA_SKIP to skip setting these (even if set already - total ignore)."},{"line_number":578,"context_line":"# Set to KOLLA_UNSET to make Kolla unset these in the managed sysctl.conf file."},{"line_number":579,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh1: 128"},{"line_number":580,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh2: 28672"},{"line_number":581,"context_line":"neutron_l3_agent_host_ipv4_neigh_gc_thresh3: 32768"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"502d2e1e_37fd4583","line":578,"in_reply_to":"9b08b9ac_ff763ebc","updated":"2022-09-10 14:20:57.000000000","message":"It is. The other knobs can still use this functionality.","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"}],"ansible/roles/nova-cell/tasks/config-host.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6465ec926344f3247c1d2b2f6c3f6ce3b5ea09b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    - { name: \"net.bridge.bridge-nf-call-ip6tables\", value: 1}"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - set_sysctl | bool"},{"line_number":26,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":27,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"80f9fc52_e5147466","line":26,"updated":"2022-09-08 08:27:38.000000000","message":"Do we want to clean up the whole logic around KOLLA_SKIP/UNSET too? Or keep it around just to confuse readers?","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"266e11c8bb736ab7661859ad0916b4fad6e73483","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    - { name: \"net.bridge.bridge-nf-call-ip6tables\", value: 1}"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - set_sysctl | bool"},{"line_number":26,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":27,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d2e3f74e_cdd0771f","line":26,"in_reply_to":"80f9fc52_e5147466","updated":"2022-09-10 14:20:57.000000000","message":"Yeah, in here it does not make sense to keep. I can remove already, I kept it around because I am touching this code again in a patch that I have not yet upstreamed.","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"072c6ba9991e421f2352e6d7a0b1bfa20984df46","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - { name: \"net.bridge.bridge-nf-call-ip6tables\", value: 1}"},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - set_sysctl | bool"},{"line_number":26,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":27,"context_line":"    - inventory_hostname in groups[nova_cell_compute_group]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# NOTE(yoctozepto): Part of bug #1681461 fix."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ed95515_3d1198b3","line":26,"in_reply_to":"d2e3f74e_cdd0771f","updated":"2022-09-10 16:53:21.000000000","message":"Done","commit_id":"1f716ec0c23b6fd41cbd9ac177c5e09f0492e9f3"}]}