)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1ec44c6d116f62d8947abb01a7ef4065bcb81ec3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c922a7c_6e481269","updated":"2022-09-02 08:50:46.000000000","message":"\"msg\": \"Ansible inventory does not contain the expected group prometheus-ovn-exporter for service prometheus-ovn-exporter in prometheus.\"","commit_id":"6d9423f24e12adace7eb8b66a684c8af17d605c2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38d0a4ab_b64cfc0e","in_reply_to":"0c922a7c_6e481269","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"6d9423f24e12adace7eb8b66a684c8af17d605c2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3f422476_7b002184","updated":"2022-09-21 11:26:48.000000000","message":"Linting failures are unrelated, will be fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/858571, you can rebase once that is merged or at least finalized.\n\nDo we need/want a (multinode?) job that actually tests this deployment? Currently it seems like we deploy OVS by default, so we don\u0027t see the exporter do any actual work.","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"37425bed_1651c46e","updated":"2022-09-26 09:34:03.000000000","message":"In the default OVS deployment, this is creating a lot of errors in the exporter log [0] and I cannot find any useful data in the metrics. Maybe this really should be enabled only for OVN?\n\nI also think you should add enabling the exporter to the `scenario \u003d\u003d \"prometheus-efk\"` block in `tests/templates/globals-default.j2` so that this code actually gets tested.\n\n[0] https://paste.opendev.org/show/bVhlSD9niemzLbp490ml/","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3c96db77_ccc82a15","in_reply_to":"37425bed_1651c46e","updated":"2023-02-22 23:41:38.000000000","message":"\u003e In the default OVS deployment, this is creating a lot of errors in the exporter log [0] and I cannot find any useful data in the metrics. Maybe this really should be enabled only for OVN?\n\u003e \n\u003e I also think you should add enabling the exporter to the `scenario \u003d\u003d \"prometheus-efk\"` block in `tests/templates/globals-default.j2` so that this code actually gets tested.\n\u003e \n\u003e [0] https://paste.opendev.org/show/bVhlSD9niemzLbp490ml/","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1935682832f80d1149f88efb65c70a2a47677e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"67bd96cc_7674ac83","updated":"2023-09-26 09:47:43.000000000","message":"Can we test that in the OVN jobs?","commit_id":"f02305406c26c399a20c4d3c06a748e11db3d25b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5edcd4d8_ab20cef1","in_reply_to":"43fe06b8_8d1beff2","updated":"2024-03-26 13:31:12.000000000","message":"so I rearranged everything a little bit. This is now tested in the \"ovn\" scenario, as this was the easiest way to make the tests green, which was my primary goal for now, to have this even passing and hopefully get it merged.\n\nPlease take a look @frickler@offenerstapel.de and @mnasiadka@gmail.com if my solution is acceptible.\n\nI investigated the rabbitmq podman container failure on ARM, but I have not really found a clue there just yet. Seems unrelated as at least the rabbitmq log itself is happy.\n\nThat being said, I don\u0027t know how important the ARM tests are, as they are also non voting - which doesn\u0027t really tell anything it seems, when it comes to importance of tests.","commit_id":"f02305406c26c399a20c4d3c06a748e11db3d25b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5e3222ebf50afb7caefe5fbf59ddc9af53169242","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1753ceef_946b9c22","in_reply_to":"5edcd4d8_ab20cef1","updated":"2024-04-05 15:29:46.000000000","message":"this is being deployed in the ovn scenario.\nspecific tests have not been added. Notice that most exporters are not tested as of yet. If someone has ideas for meaningful tests, please add or document those. marking this as resolved for now.","commit_id":"f02305406c26c399a20c4d3c06a748e11db3d25b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d57a79352a07a50ac29a653d43eda05b89c78f7a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"43fe06b8_8d1beff2","in_reply_to":"67bd96cc_7674ac83","updated":"2023-09-26 11:24:40.000000000","message":"well frickler wanted to test this in the prometheus-opensearch job instead.\nwould that be okay as well?\n\nwe maybe should also specify what exactly should be checked here.","commit_id":"f02305406c26c399a20c4d3c06a748e11db3d25b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"405817994154439b5940ebdf54e3cbd7bdf833b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"2c48c9de_bf5bb72b","updated":"2023-11-06 11:16:14.000000000","message":"recheck get fresh CI results","commit_id":"ed5e425480d06c93fdb2ea0dae82826a34b8f5b5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9cbf99660c47f48f3561cfe436a5187ef51f44ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"60ec8f38_588c9d58","updated":"2023-12-11 08:53:58.000000000","message":"recheck need fresh CI results","commit_id":"6414a93f9fc1c5040b963601de9529c84b6c0156"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1bc2eba39f3d4ca0ac76f2a059454670f72c945a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0c60048a_6e4dd49a","updated":"2024-03-01 15:15:02.000000000","message":"I honestly don\u0027t think the mariadb port issue from the last CI run is related to this change.\n\nI will have a look where to integrate this into our testing makes the most sense and push a new patch for this as well.","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"2f55ef05c28c57345ec49c7d01883ccd18b851e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1e150cc2_74f26b6f","updated":"2023-12-15 13:29:05.000000000","message":"Prometheus jobs are still failing on:\n\n```\nTASK [mariadb : Check MariaDB service port liveness] ***************************\n(···)\n\"msg\": \"Timeout when waiting for search string MariaDB in 192.0.2.1:3306\"\n```\nand\n```\nTASK [ovn-controller : Create br-int bridge on OpenvSwitch] ********************\n(···)\n\"stderr\": \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\\n\",\n```","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b585f735c13469cf9715f4cfaf7c5c7bec8a3f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"10a92cd4_fc2b0e9b","updated":"2023-12-14 12:47:54.000000000","message":"recheck ci should be fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/903364","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"76fddd626e581b5da12090853a5ff499c81955dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4b689961_00d1d126","updated":"2023-12-11 15:50:44.000000000","message":"recheck temp CI failure: https://review.opendev.org/c/opendev/base-jobs/+/903351","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"de22f27db6988eea7262e2d5443b304716f49a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8ff36186_01d41501","updated":"2023-12-12 07:55:25.000000000","message":"retry CI defect","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f2d23962f35473240cbe019f72ab01f68e1022fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"be0237f0_66fff11a","updated":"2023-12-14 12:47:16.000000000","message":"retry ci should be fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/903364","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1bd3adc36e3270cc76e34bf715e83aa30916b977","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b1942458_fbf23c9e","in_reply_to":"1058483f_090996d4","updated":"2024-03-01 16:23:18.000000000","message":"the main issue seems to be that the job `kolla-ansible-prometheus-opensearch-base`, where this is currently being tested in, has missing the necessary roles files for ovn.\n\nadded those (not sure if we want/can use multi parents for this job).","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"58daa9a7cdb164f639f6e8c2454677b9c314a2d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9ac1d26c_e04f79cf","in_reply_to":"1e150cc2_74f26b6f","updated":"2023-12-15 14:04:06.000000000","message":"marking this as unresolved, thanks for the investigation.","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db775777a1ad9710a296d0ca3f3e872d03e754ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1058483f_090996d4","in_reply_to":"47f70e09_453f78e5","updated":"2024-03-01 16:08:42.000000000","message":"the database connection still fails in Task \"Create br-int bridge on OpenvSwitch\". Here is the complete task output from job \"kolla-ansible-rocky9-prometheus-opensearch\":\n\n```\n\nTASK [ovn-controller : Create br-int bridge on OpenvSwitch] ********************\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/ovn-controller/tasks/setup-ovs.yml:2\n\nFriday 01 March 2024  15:39:26 +0000 (0:00:00.770)       0:06:18.082 ********** \n\nUsing module file /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/library/kolla_toolbox.py\n\nPipelining is enabled.\n\n\u003c149.202.166.143\u003e ESTABLISH SSH CONNECTION FOR USER: None\n\n\u003c149.202.166.143\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d300 -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/370da368b3\"\u0027 149.202.166.143 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-hgbbvrqrlcblumwdvxklvkiqrrqkwusb ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\n\u003c149.202.166.143\u003e (0, b\u0027\\n{\"action\": \"openvswitch_bridge\", \"changed\": false, \"cmd\": \"/usr/bin/ovs-vsctl -t 5 list-br\", \"failed\": true, \"invocation\": {\"module_args\": {\"bridge\": \"br-int\", \"database_socket\": null, \"external_ids\": null, \"fail_mode\": \"secure\", \"ovs-vsctl\": \"/usr/bin/ovs-vsctl\", \"parent\": null, \"set\": null, \"state\": \"present\", \"timeout\": 5, \"vlan\": null}}, \"msg\": \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\", \"rc\": 1, \"stderr\": \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\\\\n\", \"stderr_lines\": [\"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\"], \"stdout\": \"\", \"stdout_lines\": []}\\n\u0027, b\u0027\u0027)\n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"action\": \"openvswitch_bridge\",\n\n    \"changed\": false,\n\n    \"cmd\": \"/usr/bin/ovs-vsctl -t 5 list-br\",\n\n    \"invocation\": {\n\n        \"module_args\": {\n\n            \"bridge\": \"br-int\",\n\n            \"database_socket\": null,\n\n            \"external_ids\": null,\n\n            \"fail_mode\": \"secure\",\n\n            \"ovs-vsctl\": \"/usr/bin/ovs-vsctl\",\n\n            \"parent\": null,\n\n            \"set\": null,\n\n            \"state\": \"present\",\n\n            \"timeout\": 5,\n\n            \"vlan\": null\n\n        }\n\n    },\n\n    \"msg\": \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\",\n\n    \"rc\": 1,\n\n    \"stderr\": \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\\n\",\n\n    \"stderr_lines\": [\n\n        \"ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (No such file or directory)\"\n\n    ],\n\n    \"stdout\": \"\",\n\n    \"stdout_lines\": []\n\n}\n```","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1bc2eba39f3d4ca0ac76f2a059454670f72c945a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"47f70e09_453f78e5","in_reply_to":"9ac1d26c_e04f79cf","updated":"2024-03-01 15:15:02.000000000","message":"recheck get fresh ci results","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b1f02b0e6fe71824ad0e48a304c2fce3cbe5f864","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"eb9cd0e0_1a057d05","in_reply_to":"b1942458_fbf23c9e","updated":"2024-03-04 18:02:38.000000000","message":"so, after debugging this, the actual problem seems to be our usage of kolla_toolbox here to invoke ansible modules, namely installing the ovs bridge in `setup-ovs.yml`.\n\nAt least one part of the problem is, that this breaks with podman, because we don\u0027t mount `/run/` there, see: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/common/defaults/main.yml#L110\n\nStill looking into a solution that doesn\u0027t involve completely rewriting everything.","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"560f105a_3f36b2c4","in_reply_to":"eb9cd0e0_1a057d05","updated":"2024-03-26 13:31:12.000000000","message":"Done","commit_id":"536a962a5a64a79520f38cf86726943bc40c155f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a6073c0eb5d020954d1f5fecee5ae263137c0b9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"3331f62f_3effad38","updated":"2024-03-04 12:13:43.000000000","message":"Okay, so it seems this is really missing the sockets in our deployment:\n\nhttps://github.com/greenpau/ovn_exporter/issues/10\nhttps://github.com/greenpau/ovn_exporter/issues/11\n\nI don\u0027t know why these issues where opened to be honest, as we imho can just bindmount the socket in kolla.\n\nI\u0027ll work on that.","commit_id":"2bd13070b20cc7c0e50d81067b75fa88e5559901"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4ec39d6c98dfdfba2430a8be5a0dcc6fafb5be00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"a4d20aba_36226168","updated":"2024-03-04 10:00:11.000000000","message":"recheck galaxy error (503)","commit_id":"2bd13070b20cc7c0e50d81067b75fa88e5559901"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f41beb5a_c885fe0d","in_reply_to":"3331f62f_3effad38","updated":"2024-03-26 13:31:12.000000000","message":"Done","commit_id":"2bd13070b20cc7c0e50d81067b75fa88e5559901"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f55661ecb663753dbb21bdeb694fb3a8e09a2980","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"b8d0a743_51205e8c","updated":"2024-03-20 19:27:10.000000000","message":"I have a suspicion that the `enable_ovn` flag itself is already broken in CI somehow (I didn\u0027t find any other test that actually sets this to \"yes\" just yet).\n\nTesting in https://review.opendev.org/c/openstack/kolla-ansible/+/913838","commit_id":"966be884638613350ac1d6280ff71e7849de92d7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"07088e25_afd741c3","in_reply_to":"b8d0a743_51205e8c","updated":"2024-03-26 13:31:12.000000000","message":"Done","commit_id":"966be884638613350ac1d6280ff71e7849de92d7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"215ec8e5896b384e9701ca696e8889f88a3d1e31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"77a00bb8_764fad8f","updated":"2024-03-22 10:55:28.000000000","message":"failures in `tests/ceck-failure.sh` fixed by: https://review.opendev.org/c/openstack/kolla-ansible/+/913961","commit_id":"a80d63d42d5d272dde795016452e373369956ce3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dfe39a6e6d9e09b5102950e8e9e47e30e3ab33fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7b0d0b08_bd6f9c36","updated":"2024-03-22 09:31:36.000000000","message":"recheck docker26 broke fluentd labeling fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/913868","commit_id":"a80d63d42d5d272dde795016452e373369956ce3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b9e234dad948a149fc634e67f151f83c8ddc2bc4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"13fb0b62_b3bd738c","updated":"2024-03-25 11:55:23.000000000","message":"finally some new hints - and new failures, yay - in job kolla-ansible-ubuntu-ovn (non-voting) FAILURE in check-failure.sh:\n\n```\nRunning command: \u0027/opt/openstack-exporter/openstack-exporter --endpoint-type\u003dinternal --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d192.0.2.1:9198 default --disable-service.volume --disable-service.dns --disable-service.object-store\u0027\n+ echo \u0027Running command: \u0027\\\u0027\u0027/opt/openstack-exporter/openstack-exporter --endpoint-type\u003dinternal --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d192.0.2.1:9198 default --disable-service.volume --disable-service.dns --disable-service.object-store\u0027\\\u0027\u0027\u0027\n+ exec /opt/openstack-exporter/openstack-exporter --endpoint-type\u003dinternal --os-client-config\u003d/etc/openstack/clouds.yml --web.listen-address\u003d192.0.2.1:9198 default --disable-service.volume --disable-service.dns --disable-service.object-store\nts\u003d2024-03-25T11:18:00.611Z caller\u003dmain.go:64 level\u003dinfo msg\u003d\"Build context\" build_context\u003d\"(go\u003dgo1.19.13, platform\u003dlinux/amd64, user\u003d, date\u003d, tags\u003dunknown)\"\nts\u003d2024-03-25T11:18:00.611Z caller\u003dmain.go:85 level\u003dinfo msg\u003d\"openstack exporter started in legacy mode\"\nts\u003d2024-03-25T11:18:00.612Z caller\u003dtls_config.go:274 level\u003dinfo msg\u003d\"Listening on\" address\u003d192.0.2.1:9198\nts\u003d2024-03-25T11:18:00.612Z caller\u003dtls_config.go:277 level\u003dinfo msg\u003d\"TLS is disabled.\" http2\u003dfalse address\u003d192.0.2.1:9198\nts\u003d2024-03-25T11:18:08.199Z caller\u003dmain.go:169 level\u003dinfo msg\u003d\"Starting openstack exporter version for cloud\" version\u003d\"(version\u003d, branch\u003d, revision\u003dunknown)\" cloud\u003ddefault\nts\u003d2024-03-25T11:18:08.199Z caller\u003dmain.go:170 level\u003dinfo msg\u003d\"Build context\" build_context\u003d\"(go\u003dgo1.19.13, platform\u003dlinux/amd64, user\u003d, date\u003d, tags\u003dunknown)\"\nts\u003d2024-03-25T11:18:08.201Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dcompute error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.203Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003ddatabase error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.204Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dplacement error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.205Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dnetwork error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.206Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dimage error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.207Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dload-balancer error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.208Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dcontainer-infra error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.209Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003didentity error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.210Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dbaremetal error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.211Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dgnocchi error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.212Z caller\u003dmain.go:184 level\u003derror err\u003d\"enabling exporter for service failed\" service\u003dorchestration error\u003d\"The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.\"\nts\u003d2024-03-25T11:18:08.212Z caller\u003dmain.go:194 level\u003derror err\u003d\"No exporter has been enabled, exiting\"\n+ check_docker_unhealthies\n++ sudo docker ps -a --format \u0027{{.Names}}\u0027 --filter health\u003dunhealthy\n+ unhealthy_containers\u003d\n+ [[ -n \u0027\u0027 ]]\n+ [[ -n prometheus_openstack_exporter ]]\n+ exit 1\n```\n\nInvestigating this.","commit_id":"8b580f09f89e76b8322c434a4b692664483ffd33"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4fe54cabb9e5b5c0dcf9346d7b909db627e32a94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"19156a77_e9128e88","updated":"2024-03-26 10:36:11.000000000","message":"now I feel a little dumb, prometheus_openstack_exporter doesn\u0027t seem to be tested anywhere, it was explicitly disabled - without a comment as to why - in https://review.opendev.org/c/openstack/kolla-ansible/+/740083/8..10/tests/templates/globals-default.j2\n\ndisabling it thus here as well.","commit_id":"8b580f09f89e76b8322c434a4b692664483ffd33"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"86c8365f8756e39abbbc78c3882a4159a0edef33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"272107e1_55c9edc5","updated":"2024-03-25 10:49:26.000000000","message":"recheck fix for failure script merged https://review.opendev.org/c/openstack/kolla-ansible/+/913961","commit_id":"8b580f09f89e76b8322c434a4b692664483ffd33"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"810cfc18_1f505f1a","in_reply_to":"13fb0b62_b3bd738c","updated":"2024-03-26 13:31:12.000000000","message":"Done","commit_id":"8b580f09f89e76b8322c434a4b692664483ffd33"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a30ec4a3bed3505f8d67e0ecb4dd74c8adde599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"6aae7b31_8d9f7781","updated":"2024-03-26 13:31:12.000000000","message":"All tests are green now, except for ARM - see my other comment.","commit_id":"0506b3829506da45bf21620663d1b2fd5c786c4e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7134f840eb23e30b00bd300cd0d8f2ee706e7f81","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"b4b65b63_2300757f","updated":"2024-03-28 08:17:26.000000000","message":"Initial review done\nI think it\u0027s missing bits to add it automatically for scraping in prometheus","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca26a435d186f83656b6d25c4ab5ddfe9a523d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"87e0f335_ef8590f0","in_reply_to":"53605c29_50f499b6","updated":"2024-03-28 12:52:00.000000000","message":"I think that deserves a refactor with a proper loop - but not in this patch.","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0eef73142a8b3f8592a99c33458c1f2cc006a58f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"7ab7e871_150f40fb","in_reply_to":"87e0f335_ef8590f0","updated":"2024-04-02 09:31:19.000000000","message":"Ack 😄","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e834dd9e84df044a22ca1fd0141551a41522de09","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":28,"id":"53605c29_50f499b6","in_reply_to":"b4b65b63_2300757f","updated":"2024-03-28 10:25:50.000000000","message":"I added the `scrape_configs` job for the exporter (the file itself already is a bit messy, nothing is ordered alphabetically or I am unable to parse the ordering logic so I just added it to the end of the other exporters).","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":34646,"name":"Mathias Fechner","email":"mfechner@wavecon.de","username":"matfechner"},"change_message_id":"c8fa4738ed879e2c3d0d17b22442c5cf155fc5d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"db2878a4_c926f6b8","updated":"2024-04-03 07:33:12.000000000","message":"LGTM","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0371be2fbab28f21d070510b0e4d830cb4be5cb9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"043c8c56_028cb4b4","updated":"2024-04-09 09:44:20.000000000","message":"CI status blocked by https://review.opendev.org/c/openstack/kolla-ansible/+/915119","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a74588de1613487f4efb77b996fdbedfe83e8e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"8bd68a24_50b68196","updated":"2024-04-08 09:00:28.000000000","message":"recheck got an error early during installation from ansible galaxy","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a3159a3e035173c34f8df3738ab1def11c2cc77f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"52f78feb_5243b1f8","updated":"2024-04-15 10:58:40.000000000","message":"recheck grafana build failure should be fixed (upstream repo issue)","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8c9f79994a8a67e91cffde66cfd385000bf60c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"91524bee_2ee8ae18","updated":"2024-04-08 17:43:42.000000000","message":"recheck kolla-ansible-rocky9-prometheus-opensearch FAILURE opensearch dashboard test via curl returned 401 \"dashboard not accessible yet\"","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7c11edd43bbc93077595c0eaa799a11583174430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"30fee07b_7da25067","updated":"2024-04-15 08:50:41.000000000","message":"recheck opensearch pin merged","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"75764bd04b12ac0f4f5b441c3d0f517d4ccb2b76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ab3b334b_b9f0f13b","updated":"2024-04-16 09:00:25.000000000","message":"the patch itself looks fine to me, but the opensearch jobs are still failing. most likely the failures are unrelated, but we should fix that issue in order to be sure about this","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a3159a3e035173c34f8df3738ab1def11c2cc77f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"78435b66_1d8dd904","in_reply_to":"043c8c56_028cb4b4","updated":"2024-04-15 10:58:40.000000000","message":"Done","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fd722edde78ccdd15d93c220847f0479132d7f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"c1d867f4_32166747","in_reply_to":"8fda510d_62b13d9b","updated":"2024-04-19 08:28:16.000000000","message":"fixed the CI jobs. cephadm upgrade fails currently, but I wasn\u0027t able so far to find the root cause. Still looking into it.","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f99c6f2186f33d5785b0c7a9a3389296b935b9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"8fda510d_62b13d9b","in_reply_to":"ab3b334b_b9f0f13b","updated":"2024-04-17 08:10:21.000000000","message":"I\u0027m looking into it. Thought it was somehow missing the opensearch pinned packages, because the failure occurs in the opensearch dashboard test and returns a 403.\nDid an accidental rebase somehow which seems to have messed things up.","commit_id":"04e354f3a46e4e20265b399025250cb3f4e0b280"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9c595f8b6140716fed83730d97edc6eab2088e7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"b53ae5a9_ef9b0496","updated":"2024-04-18 08:17:18.000000000","message":"recheck weird flake8 linter error \"couldn\u0027t resolve module/action \u0027kolla_docker\u0027\" can\u0027t reproduce locally.","commit_id":"4faea2352cd1d1ba48c67e9eb8aa95cf6a2642dc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0df0f4777a047a2a16a9a8b355ce81b82f127dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"a73ba06f_be08e238","in_reply_to":"0b70f539_614437dc","updated":"2024-04-18 14:47:10.000000000","message":"somehow during rebase necessary changes from patchset 32 went missing. readded those in patchset 35 again. CI should hopefully be green then again.","commit_id":"4faea2352cd1d1ba48c67e9eb8aa95cf6a2642dc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d171cc6d9377b2bc8c7885f3b93113f64438ce14","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"0b70f539_614437dc","in_reply_to":"b53ae5a9_ef9b0496","updated":"2024-04-18 08:18:52.000000000","message":"scratch that, I can in fact reproduce this.","commit_id":"4faea2352cd1d1ba48c67e9eb8aa95cf6a2642dc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"00bae51bb04416c3f80417eb0e9c80364466a837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"cca1070c_de465b42","updated":"2024-04-23 05:16:53.000000000","message":"Did you check that this actually outputs useful data? From the container log https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6ec/855498/35/check/kolla-ansible-ubuntu-ovn/6ec7f20/primary/logs/container_logs/prometheus_ovn_exporter.txt it looks like a lot of things are not working there.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"05a37cce05c5adae05516622afbadabec91c625e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"ea19b65b_dcb665f6","updated":"2024-04-18 15:00:43.000000000","message":"kolla-ansible-centos9s (non-voting)FAILURE failed due to unrelated galaxy upstream mirror failure, as it\u0027s non-voting I won\u0027t retry for that:\n\n```\nopenstack.kolla:1.0.0 was installed successfully\nERROR! Error when finding available api versions from default (https://galaxy.ansible.com) (HTTP Code: 504, Message: Gateway Time-out)\n```","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e8874d022a96a303694416ba50783dac98786d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"fb98b561_3ceb99f9","updated":"2024-04-19 09:32:13.000000000","message":"recheck kolla-ansible-ubuntu-upgrade-cephadm failed with create_a_volume_from_image test_volume_from_image_from_volume test_image_from_volume taking to long","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c232997c975d9e42bb040698dc118145cfaa961e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"a59fb63f_deaa9f73","updated":"2024-04-22 16:17:03.000000000","message":"recheck unrelated failure in kolla-ansible-rocky9-ovn in task TASK [service-ks-register : nova | Creating roles] keystone answers with a 500 server error.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9f85110e3ff01c46b088cf05087a3be376844cb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3c6e46d8_6e6871d7","updated":"2024-04-18 18:03:38.000000000","message":"recheck unrelated upstream mirror issue: (https://galaxy.ansible.com) (HTTP Code: 504, Message: Gateway Time-out","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"19c85161380d7a3982135e57106b8f393b73a0a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"1bcebdf0_ebbbb007","updated":"2024-04-19 15:47:31.000000000","message":"unrelated failure in kolla-ansible-rocky9-ovn in task TASK [service-ks-register : nova | Creating roles]\nkeystone answers with a 500 server error.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7ebe41d2f5ac19ef1dd3d7a58b96d46eb8f4f50c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"cda4868d_28fd5298","in_reply_to":"2a72fe19_d7ed203c","updated":"2024-04-24 07:59:06.000000000","message":"fixed some more bugs, maybe I need to patch the ovn-exporter itself. let\u0027s see if we can ignore ovs related files for now.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"607f2a96b769bd61c740161e53314004b8761cae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"852c2f50_cba26abf","in_reply_to":"3f3dbca0_2bf4a3cc","updated":"2024-04-23 07:55:47.000000000","message":"almost didn\u0027t see this comment as it\u0027s marked resolved. agreed, that\u0027s not good, I thought I could avoid the socket stuff, let me take a look.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dc1d6b004a45815055968b4f5183ddad3bb352e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"ee940334_6fcad947","in_reply_to":"852c2f50_cba26abf","updated":"2024-04-23 08:01:41.000000000","message":"in kolla-ansible-debian-ovn job (it has the same errors as the ubuntu job above) I find these neutron-server errors, investigating if ovn even runs properly (that would at least explain why the socket doesn\u0027t work):\n\n```\n/var/log/kolla/neutron/neutron-server.log\n\n2024-04-22 17:19:36.986 25 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.ovsdb_monitor [None req-87e20ed8-542e-4277-8bf1-47fc48994c41 - - - - - -] HashRing is empty, error: Hash Ring returned empty when hashing \"b\u002763d89463-8469-4ff7-8163-bea8be0929d0\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster: neutron.common.ovn.exceptions.HashRingIsEmpty: Hash Ring returned empty when hashing \"b\u002763d89463-8469-4ff7-8163-bea8be0929d0\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster\n\n2024-04-22 17:19:36.998 25 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.ovsdb_monitor [None req-87e20ed8-542e-4277-8bf1-47fc48994c41 - - - - - -] HashRing is empty, error: Hash Ring returned empty when hashing \"b\u00279f7abaaf-be49-466b-8cd1-e61cb9de3999\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster: neutron.common.ovn.exceptions.HashRingIsEmpty: Hash Ring returned empty when hashing \"b\u00279f7abaaf-be49-466b-8cd1-e61cb9de3999\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster\n\n2024-04-22 17:19:37.092 25 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.ovsdb_monitor [None req-87e20ed8-542e-4277-8bf1-47fc48994c41 - - - - - -] HashRing is empty, error: Hash Ring returned empty when hashing \"b\u0027cc0e1b4a-ac81-45b9-8b2d-7f379dfc55d6\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster: neutron.common.ovn.exceptions.HashRingIsEmpty: Hash Ring returned empty when hashing \"b\u0027cc0e1b4a-ac81-45b9-8b2d-7f379dfc55d6\u0027\". All 0 nodes were found offline. This should never happen in a normal situation, please check the status of your cluster\n```","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b55076acee5fe50fa1e103edb03a082ea28c893d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3f3dbca0_2bf4a3cc","in_reply_to":"cca1070c_de465b42","updated":"2024-04-23 07:20:02.000000000","message":"just noticed that as well, that\u0027s not good.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3d04bf5f17c8e59d3bdc9ca90e3fbd41b474ad8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"2a72fe19_d7ed203c","in_reply_to":"ee940334_6fcad947","updated":"2024-04-23 19:02:35.000000000","message":"above error I posted should be unrelated(TM). The real culprit for this error:\n\n```\n2024-04-22T16:42:55.171097254Z + CMD\u003d\u0027/opt/ovn-exporter -web.listen-address 192.0.2.1:9476  [\u0027\\\u0027\u0027-database.northbound.socket.remote tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\u0027\\\u0027\u0027,\n \u0027\\\u0027\u0027-database.southbound.socket.remote tcp:192.0.2.1:6642,tcp:192.0.2.2:6642,tcp:192.0.2.3:6642\u0027\\\u0027\u0027]  [\u0027\\\u0027\u0027-database.northbound.socket.remote tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\u0027\\\u0027\u0027,\n  \u0027\\\u0027\u0027-database.southbound.socket.remote tcp:192.0.2.1:6642,tcp:192.0.2.2:6642,tcp:192.0.2.3:6642\u0027\\\u0027\u0027]  [\u0027\\\u0027\u0027-database.northbound.socket.remote tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\u0027\\\u0027\u0027,\n   \u0027\\\u0027\u0027-database.southbound.socket.remote tcp:192.0.2.1:6642,tcp:192.0.2.2:6642,tcp:192.0.2.3:6642\u0027\\\u0027\u0027]  -database.vswitch.socket.remote 127.0.0.1:6640 \u0027\\\u0027\u0027\u0027\n2024-04-22T16:42:55.195166358Z ts\u003d2024-04-22T16:42:55.194Z caller\u003dmain.go:177 level\u003derror msg\u003d\"failed to finalize exporter calls properly\" exporter_name\u003dovn-exporter\n error\u003d\"[failed connecting to Open_vSwitch via unix:/var/run/openvswitch/db.sock: dial unix /var/run/openvswitch/db.sock: connect: no such file or directory failed connecting to OVN_Northbound\n  via unix:/run/openvswitch/ovnnb_db.sock: dial unix /run/openvswitch/ovnnb_db.sock: connect: no such file or directory failed connecting to OVN_Southbound\n   via   unix:/run/openvswitch/ovnsb_db.sock: dial unix /run/openvswitch/ovnsb_db.sock: connect: no such file or directory]\"\n```\n\nis of course this code: https://review.opendev.org/c/openstack/kolla-ansible/+/855498/36/ansible/roles/prometheus/templates/prometheus-ovn-exporter.json.j2\n\nit returns a list of `prometheus_ovn_exporter_enabled_items` which must be converted to a string, delimited by \",\". This was not done, but the whole list was appended, which resulted in the options being ignored instead of passed on to the exporter.\n\nI hope this was the only bug, thanks for catching it! Let\u0027s see what CI has to say about it.\n\nAt least I\u0027m now way more familiar with the innards of both ovn and even the ovn-exporter\u0027s go code.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":37294,"name":"Danny Webb","display_name":"Danny Webb","email":"danny.webb@unity3d.com","username":"dannywebb"},"change_message_id":"11ff5129e28d1aa57e8b9a60ce6fdb8c6ab29066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"9e023d7b_092da82a","updated":"2024-10-24 11:20:50.000000000","message":"Couple of issues found when trying this patch out in a 2024.1 environment.","commit_id":"6c0c885b04d5f3dd559e589765465674fd7ca7d3"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1146,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1147,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1148,"context_line":"enable_prometheus_ovn_exporter: \"no\""},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1151,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"849d5b7c_d7fc5410","line":1148,"updated":"2022-09-21 11:26:48.000000000","message":"Is there a reason not to enable automatically if Neutron uses OVN as backend?","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1146,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1147,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1148,"context_line":"enable_prometheus_ovn_exporter: \"no\""},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1151,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"53aced66_7742ab6a","line":1148,"in_reply_to":"849d5b7c_d7fc5410","updated":"2022-09-26 09:34:03.000000000","message":"Done","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1146,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1147,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1148,"context_line":"enable_prometheus_ovn_exporter: \"{{ (enable_prometheus | bool and enable_ovn | bool ) or (enable_prometheus | bool and enable_openvswitch | bool) }}\""},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1151,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"efa80c8b_582ce6ff","line":1148,"updated":"2022-09-26 09:34:03.000000000","message":"I would swap the and/or logic to make it simpler:\n\nenable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool )","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1146,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1147,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1148,"context_line":"enable_prometheus_ovn_exporter: \"{{ (enable_prometheus | bool and enable_ovn | bool ) or (enable_prometheus | bool and enable_openvswitch | bool) }}\""},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1151,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"12bb5aeb_3553c824","line":1148,"in_reply_to":"efa80c8b_582ce6ff","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f96cd931aebdd45ba38a90bda994a066199932d9","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"743d2421_900b8429","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"updated":"2023-02-20 07:16:01.000000000","message":"and ML2/OVS users without OVN will get an OVN exporter?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"93f555277409bd27f4d3c6e703f27bddd1c76305","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f0c56103_39c110d8","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"2089a1a9_eb7f6ec1","updated":"2023-06-02 07:34:43.000000000","message":"any update on this?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"51bbb7ce_577d8ebd","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"3037bae9_82dffe0a","updated":"2023-02-22 23:41:38.000000000","message":"I\u0027m looking at adding ovs_exporter in via another change, which will cover the OVS monitoring portion. I think keeping this specific for OVN though should be adequate, no?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed4ba3ab5bd94f1b2aabfa35e43222e3cacf1569","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"59b9ab5c_35ca874d","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"51bbb7ce_577d8ebd","updated":"2023-04-05 09:55:55.000000000","message":"can\u0027t both exporters report their respective metrics?\nfwiw - afaik this is the mentioned ovs exporter - the ovs exporter _also_ reports ovn metrics:\n\nhttps://github.com/greenpau/ovs_exporter\n\nmaybe this could be consolidated upstream instead, as both exporters seem to overlap quite a bit.\n\nbut I see no harm if metrics are reported, when they are present?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"82f6efdde20e1cf909afa337d0e82cd3096b7eda","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2089a1a9_eb7f6ec1","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"59b9ab5c_35ca874d","updated":"2023-04-14 08:15:24.000000000","message":"I just asked upstream what they think is the best way moving forward, as both exporters seem to be from the same person:\n\nhttps://github.com/greenpau/ovs_exporter/issues/9\n\nmaybe it\u0027s planned to even merge these two in a single exporter, let\u0027s see what upstream says.","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3965f8ab9983047feb7d015dd07bbe93b12b454d","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"13c71c34_da7137da","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"5ae428cb_e4d88d8d","updated":"2023-06-16 08:42:10.000000000","message":"hmm, o.k., let\u0027s start with what we have and then iterate","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":34646,"name":"Mathias Fechner","email":"mfechner@wavecon.de","username":"matfechner"},"change_message_id":"b2f765020ffee153977b6f1be38726785b3e96c8","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"92d6f7df_74a90f2b","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"743d2421_900b8429","updated":"2023-02-21 08:46:17.000000000","message":"OVN Exporter is able too, to read the Open_vSwitch database. That was my intention to enable it here","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":34646,"name":"Mathias Fechner","email":"mfechner@wavecon.de","username":"matfechner"},"change_message_id":"3d39bdda5b47f242021ad59a87ee917155593314","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3037bae9_82dffe0a","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"92d6f7df_74a90f2b","updated":"2023-02-21 08:47:27.000000000","message":"https://github.com/greenpau/ovn_exporter","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"88826ab96d3e02ebf6354dbab5f091cdf279bffd","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] }}\""},{"line_number":1131,"context_line":"enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":1132,"context_line":"enable_prometheus_msteams: \"no\""},{"line_number":1133,"context_line":"enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and ( enable_ovn | bool or enable_openvswitch | bool ) }}\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1136,"context_line":"prometheus_scrape_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5ae428cb_e4d88d8d","line":1133,"range":{"start_line":1133,"start_character":65,"end_line":1133,"end_character":115},"in_reply_to":"f0c56103_39c110d8","updated":"2023-06-02 07:41:01.000000000","message":"not from upstream no.\nMy plan would be to indeed at first split this up, so ovs exporter only reports ovs metrics and ovn exporter only ovn metrics.\n\nI\u0027d then like to document, or even activate by default, ovs exporter if ovn exporter is enabled.\n\nWhat do you think?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7134f840eb23e30b00bd300cd0d8f2ee706e7f81","unresolved":true,"context_lines":[{"line_number":609,"context_line":"# Prometheus instance label to use for metrics"},{"line_number":610,"context_line":"prometheus_instance_label:"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"prometheus_ovn_exporter_port: \"9476\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"proxysql_admin_port: \"6032\""},{"line_number":615,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3563aa4f_a5518fe0","line":612,"updated":"2024-03-28 08:17:26.000000000","message":"move that up before prometheus_instance_label","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"367a7c953a4931cb75442d9a67d836311902f6be","unresolved":false,"context_lines":[{"line_number":609,"context_line":"# Prometheus instance label to use for metrics"},{"line_number":610,"context_line":"prometheus_instance_label:"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"prometheus_ovn_exporter_port: \"9476\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"proxysql_admin_port: \"6032\""},{"line_number":615,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"41444a3b_9f9d7818","line":612,"in_reply_to":"3563aa4f_a5518fe0","updated":"2024-03-28 09:48:45.000000000","message":"Done","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7134f840eb23e30b00bd300cd0d8f2ee706e7f81","unresolved":true,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"d232a06f_26938cf5","line":655,"updated":"2024-03-28 08:17:26.000000000","message":"can somebody share current list of metrics that this exposes for both types of nodes?","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c255ede75bf22123b78db42445c7fd33c4b213d3","unresolved":false,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ef5feb9c_a4fda37a","line":655,"in_reply_to":"17afcac9_d7046ca4","updated":"2024-03-28 09:57:23.000000000","message":"Let\u0027s say it does, it brings some useful metrics.","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"367a7c953a4931cb75442d9a67d836311902f6be","unresolved":true,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"17afcac9_d7046ca4","line":655,"in_reply_to":"d232a06f_26938cf5","updated":"2024-03-28 09:48:45.000000000","message":"Not sure I understand the reason for this question, but the set of metric can be found in the upstream Readme: https://github.com/greenpau/ovn_exporter/tree/main?tab\u003dreadme-ov-file#exported-metrics\n\nI would expect e.g. `ovn_cluster_enabled` to be a relevant metric here? I\u0027m far from an expert on ovn-exporter though, unfortunately.\n\nDoes that answer your question?","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bcbe9382b740e3e4421c6869f2f453974092ed6a","unresolved":true,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"48bf3d37_ca8fcb38","line":655,"range":{"start_line":655,"start_character":0,"end_line":655,"end_character":14},"updated":"2024-04-05 09:00:02.000000000","message":"is it taking metrics from ovn-controller or just ovn nb/sb?\novn-controller is basically on every host in the deployment","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d555b612c87f68ea27ea84a689fe6ffc3f453c08","unresolved":true,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"b5b61c84_aaf063cf","line":655,"range":{"start_line":655,"start_character":0,"end_line":655,"end_character":14},"in_reply_to":"48bf3d37_ca8fcb38","updated":"2024-04-05 15:24:28.000000000","message":"after careful examination and rereading the ovn-architecture document[1] as well as consulting the ovn-exporter code I can conclude that the software indeed does _not_ directly connect to or assemble information from the ovn-controller component, which merely populates the `physical network` (PN) table and the `Chassis` Column in the `Binding` table with the hypervisors status. As such this process should not hold information interesting to the monitoring system. process statistics etc. are better served by e.g. running node-exporter or cadvisor.\n\nI have thus removed the `ovn-controller` host group from the inventory accordingly.\n\n[1]: https://www.ovn.org/support/dist-docs/ovn-architecture.7.html","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c68a57bf6b63273c683b79750760462ef12a1edf","unresolved":false,"context_lines":[{"line_number":652,"context_line":"prometheus-alertmanager"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":655,"context_line":"ovn-controller"},{"line_number":656,"context_line":"ovn-database"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"[masakari-api:children]"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"01420c36_a0943a70","line":655,"range":{"start_line":655,"start_character":0,"end_line":655,"end_character":14},"in_reply_to":"b5b61c84_aaf063cf","updated":"2024-04-05 15:27:43.000000000","message":"Done","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"}],"ansible/inventory/multinode":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":true,"context_lines":[{"line_number":722,"context_line":"prometheus-alertmanager"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":725,"context_line":"ovn-database"},{"line_number":726,"context_line":"ovn-controller-compute"},{"line_number":727,"context_line":"ovn-controller-network"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"[masakari-api:children]"},{"line_number":730,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"d7441a38_37a90f43","line":727,"range":{"start_line":725,"start_character":0,"end_line":727,"end_character":22},"updated":"2022-09-21 11:26:48.000000000","message":"sorting? Also maybe use \"ovn-controller\" instead of the two subgroups?","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":false,"context_lines":[{"line_number":722,"context_line":"prometheus-alertmanager"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":725,"context_line":"ovn-database"},{"line_number":726,"context_line":"ovn-controller-compute"},{"line_number":727,"context_line":"ovn-controller-network"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"[masakari-api:children]"},{"line_number":730,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"da449b4e_8e6e37d7","line":727,"range":{"start_line":725,"start_character":0,"end_line":727,"end_character":22},"in_reply_to":"d7441a38_37a90f43","updated":"2022-09-26 09:34:03.000000000","message":"Done","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bcbe9382b740e3e4421c6869f2f453974092ed6a","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"e9d93027_f565b6f9","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"updated":"2024-04-05 09:00:02.000000000","message":"do we always enable this? what if somebody tweaked the inventory and has different hosts for NB and different hosts for SB?","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0665e5ef35705b2a17bf2ae6332e38025aae54d0","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"3a90d465_83340d15","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"01378d1c_0fbaa138","updated":"2024-04-08 09:34:03.000000000","message":"But prometheus_ovn_exporter_enabled_items will cause that to be always enabled - I was thinking of something automatic, as in if host in group ovn-nb-db - then we do nb-db scraping, if in sb-db - we do sb-db scraping.","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"af866bdfe810bc8eda72be89fc1331920cb9f8d7","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"364ea13e_0f731bb0","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"04d451f7_4d62861f","updated":"2024-04-16 13:41:23.000000000","message":"@Michal: I would like to make your suggest change in a separate patchset, if that is okay with you to not further complicate this one.","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4eb0d8c0e2a3d30536a44e20379f72fec406c855","unresolved":false,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"616fbeda_de0bb50f","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"21610cdc_0e6bd6de","updated":"2024-09-06 11:48:46.000000000","message":"Acknowledged","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8d83b0bff2eeaa4a30da92527b006b2bab6a8dec","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"625ebb22_9ba966b5","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"364ea13e_0f731bb0","updated":"2024-04-23 07:19:18.000000000","message":"Maybe it\u0027s me - but I don\u0027t like the approach to follow up on a new feature just after the original patch ;-)","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fa78590e7211793abe584b34dc701e0295513bc1","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"04d451f7_4d62861f","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"3a90d465_83340d15","updated":"2024-04-08 09:45:39.000000000","message":"ah, interesting, now I understood your use case. out of curiosity: do you know of any deployments that are split this way? Is this done to scale out the single components for large deployments, or what are the primary reasons to do so?\n\nI\u0027ll think about how to incorporate this in the scraping logic. This might get a little convoluted though. Honestly not sure if there are many benefits to this (you could simply mask out empty fields on the prometheus/grafana side instead) and my intuitive thought would be that the scraping of additional data does not incur that much overhead, because afaik the exporter scrapes all the data in bulk.","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"607f2a96b769bd61c740161e53314004b8761cae","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"21610cdc_0e6bd6de","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"625ebb22_9ba966b5","updated":"2024-04-23 07:55:47.000000000","message":"well, I would view the ability to split ovn-nb-db and ovn-sb-db on different hosts as a new feature, not a bug in the existing implementation.\n\nThe change is already large enough, I would rather see an explicit statement that this kind of deployment is at least actually in use somewhere before submitting to doing extra work which nobody then is going to use.\n\nThis is why I asked if you know of such deployments, but so far you dodged the question.\n\nchanges should be as small as possible. this is far from it. so please answer the question, thanks.","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d555b612c87f68ea27ea84a689fe6ffc3f453c08","unresolved":true,"context_lines":[{"line_number":375,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":376,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":377,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":378,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"prometheus_blackbox_exporter_cmdline_extras: \"\""},{"line_number":381,"context_line":"prometheus_cadvisor_cmdline_extras: \"--docker_only --store_container_labels\u003dfalse --disable_metrics\u003dpercpu,referenced_memory,cpu_topology,resctrl,udp,advtcp,sched,hugetlb,memory_numa,tcp,process\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"01378d1c_0fbaa138","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":119},"in_reply_to":"e9d93027_f565b6f9","updated":"2024-04-05 15:24:28.000000000","message":"this is being taken care of already, as far as I can see, see the definition of `prometheus_ovn_exporter_enabled_nb` and sb respectively. Here is the code:\n\n```\nprometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\"\nprometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\"\n```\n\nso this in turn references ovn_nb_connection which is defined as:\n\n```\novn_nb_connection: \"{% for host in groups[\u0027ovn-nb-db\u0027] %}tcp:{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ ovn_nb_db_port }}{% if not loop.last %},{% endif %}{% endfor %}\"\n```\n\nanalogue for ovn_sb_connection.\n\nso as long as the groups ovn-nb-db and ovn-sb-db are used this works.\n\nIs this sufficient, or should I document it explicitly?","commit_id":"ecc07d554eb5981f744b6ff376553f128268bae3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"00bae51bb04416c3f80417eb0e9c80364466a837","unresolved":true,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":354,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":355,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":356,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"92b6d9cb_264eeed6","line":355,"updated":"2024-04-23 05:16:53.000000000","message":"This is just a fixed string, why does it need to be in \"{{ }}\"?","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"607f2a96b769bd61c740161e53314004b8761cae","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"prometheus_ovn_exporter_enabled_nb: \"{{ \u0027-database.northbound.socket.remote\u0027 }} {{ ovn_nb_connection }}\""},{"line_number":354,"context_line":"prometheus_ovn_exporter_enabled_sb: \"{{ \u0027-database.southbound.socket.remote\u0027 }} {{ ovn_sb_connection }}\""},{"line_number":355,"context_line":"prometheus_ovn_exporter_enabled_ovs: \"{{ \u0027-database.vswitch.socket.remote 127.0.0.1:6640\u0027 }}\""},{"line_number":356,"context_line":"prometheus_ovn_exporter_enabled_items: \"{{ [prometheus_ovn_exporter_enabled_nb, prometheus_ovn_exporter_enabled_sb] }}\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2a39fc6d_61242a71","line":355,"in_reply_to":"92b6d9cb_264eeed6","updated":"2024-04-23 07:55:47.000000000","message":"Done","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a1e066ca786220fac96ee2dadcda5328b6c64203","unresolved":true,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5780961c_ddecf83f","line":364,"updated":"2024-04-24 10:45:59.000000000","message":"We need to support separate hosts for nb and separate hosts for sb","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a14a0440fdc8a4dff5541ff36b6b9266c64284d0","unresolved":true,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"1ac44509_a281b1b0","line":364,"in_reply_to":"0ef1cc99_8d5b9032","updated":"2024-09-04 04:47:49.000000000","message":"Ok, let\u0027s get something working, we might want to invest time to get that exporter in a better shape - but for now I guess we have no other choice.","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4eb0d8c0e2a3d30536a44e20379f72fec406c855","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5008a5a8_6f367ed8","line":364,"in_reply_to":"1ac44509_a281b1b0","updated":"2024-09-06 11:48:46.000000000","message":"Done","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"101ba9c715636ca009135166dbd92a199aeea258","unresolved":true,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"0ef1cc99_8d5b9032","line":364,"in_reply_to":"1e6d77f7_eed6064c","updated":"2024-08-09 09:49:26.000000000","message":"I don\u0027t see how this would be currently possible from upstreams code. I even tried to fix this in the ovn-exporter myself:\n\nhttps://github.com/artificial-intelligence/ovn_exporter/tree/feature/make_metrics_selectable\n\nbut you need to completely rewrite the logic in the underlying `ovsdb` library, because it\u0027s \"NewOVNClient\" function assumes that it can reach every ovn/ovs component on the same host.\n\nit simply connects to all components: northdb, ovs etc. on every single function call:\n\nhttps://github.com/greenpau/ovsdb/blob/ba2fa6bc5e69ee5511f72847d060e6709036ae0f/ovn.go#L44\n\ncan you explain why this is a hard requirement to run each exporter on a separate host? I would really like to get this merged and maybe I can iterate on upstream to make this configurable in the future?\n\nThis is also complicated by the fact that there is no real upstream development and I guess I\u0027ll have to do everything myself, if you don\u0027t happen to have a seasoned golang dev up your sleeves?\n\nThanks","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bdd3bb3709b8b2afd95fa691bf1524f9560570bc","unresolved":true,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"dc990f9a_6b117a57","line":364,"in_reply_to":"5780961c_ddecf83f","updated":"2024-05-13 13:44:56.000000000","message":"This seems currently not possible because of the upstream ovn-exporter codebase.\nE.g. take a look at https://github.com/greenpau/ovsdb/blob/ba2fa6bc5e69ee5511f72847d060e6709036ae0f/ovn_logical_switch.go#L33 which is called in `pkg/ovn_exporter/ovn_exporter.go` in https://github.com/greenpau/ovn_exporter/blob/79cb6010e656fd6b24c9ccba29bde4cddcf832c2/pkg/ovn_exporter/ovn_exporter.go#L652\n\nit returns the logical switches and to do so, it first connects to the northbound db and then to the southbound db which does not work if either of them is not available on the configured host.\n\nI\u0027m not sure if it\u0027s possible to refactor this to only use the southbound or northbound db.\n\nI\u0027m currently looking into if this is possible to refactor in the upstream codebase.","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6639de14c8ab95c1a4783e53c053d412558aa3d8","unresolved":true,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"1e6d77f7_eed6064c","line":364,"in_reply_to":"dc990f9a_6b117a57","updated":"2024-05-13 13:49:03.000000000","message":"Either that or support connecting to NB/SB via tcp","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a1e066ca786220fac96ee2dadcda5328b6c64203","unresolved":true,"context_lines":[{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"},{"line_number":368,"context_line":"  /opt/prometheus/prometheus --web.config.file\u003d/etc/prometheus/web.yml --config.file /etc/prometheus/prometheus.yml"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"2daccbeb_9b25ce97","line":365,"updated":"2024-04-24 10:45:59.000000000","message":"And we assume that ovs is on every host - that\u0027s wrong as well","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5b30b9ad40d2a3128672f21f477f361fdd8ba71c","unresolved":false,"context_lines":[{"line_number":362,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":363,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":364,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":365,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"prometheus_server_command: \u003e-"},{"line_number":368,"context_line":"  /opt/prometheus/prometheus --web.config.file\u003d/etc/prometheus/web.yml --config.file /etc/prometheus/prometheus.yml"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"90fc8c88_42179b97","line":365,"in_reply_to":"2daccbeb_9b25ce97","updated":"2024-09-06 11:49:31.000000000","message":"Acknowledged","commit_id":"3009fc06a08d303e5f221cd4325068f3acd4e833"},{"author":{"_account_id":37294,"name":"Danny Webb","display_name":"Danny Webb","email":"danny.webb@unity3d.com","username":"dannywebb"},"change_message_id":"11ff5129e28d1aa57e8b9a60ce6fdb8c6ab29066","unresolved":true,"context_lines":[{"line_number":312,"context_line":"  - \"{{ node_config_directory }}/prometheus-ovn-exporter/:{{ container_config_directory }}/:ro\""},{"line_number":313,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":314,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":315,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":316,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"prometheus_extra_volumes: \"{{ default_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba27eda1_83a29fe5","line":315,"updated":"2024-10-24 11:20:50.000000000","message":"nothing on the controllers currently uses this volume.  ovn-nb-db and ovn-sb-db both user /run/ovn, but there are no mounts for them so they are contained solely in the container.  If we need to access the unix sockets we\u0027ll need to add in /run/ovn mounts for sb/nb dbs.","commit_id":"6c0c885b04d5f3dd559e589765465674fd7ca7d3"},{"author":{"_account_id":37294,"name":"Danny Webb","display_name":"Danny Webb","email":"danny.webb@unity3d.com","username":"dannywebb"},"change_message_id":"11ff5129e28d1aa57e8b9a60ce6fdb8c6ab29066","unresolved":true,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":347,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":348,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":349,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"c9ffb202_de309b89","line":348,"updated":"2024-10-24 11:20:50.000000000","message":"This creates a loop of already looped items and results in a mess of options.  It should be sans loop and just:\n\n{{ prometheus_ovn_exporter_enabled_items | join(\u0027 \u0027) }} \n\nif the hosts are supposed to be comma separated under a single flag\n\nThe looping of hosts already happens in ovn_nb_connection / ovn_sb_connection.","commit_id":"6c0c885b04d5f3dd559e589765465674fd7ca7d3"},{"author":{"_account_id":37294,"name":"Danny Webb","display_name":"Danny Webb","email":"danny.webb@unity3d.com","username":"dannywebb"},"change_message_id":"9881d1650238d35008f8df8530f91a6378eaa8e4","unresolved":true,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"prometheus_ovn_exporter_command: \u003e-"},{"line_number":347,"context_line":"  /opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }}"},{"line_number":348,"context_line":"  {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items | join(\u0027,\u0027) }} {% endfor %}"},{"line_number":349,"context_line":"  {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"prometheus_server_command: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"598e13d1_bfb5c86e","line":348,"in_reply_to":"c9ffb202_de309b89","updated":"2024-10-24 14:36:35.000000000","message":"Ok, further investigation of the ovn-exporter in it\u0027s current state:\n\n1) the remote flags expect a single address and you cannot set multiple remote flags.  It will simply use the last set remote flag if multiple are given.\n2) the remote flags for TCP based connections are just IP:PORT, not tcp:IP:PORT\n3) the remote tcp connection must be to the current primary, connections to a replica will fail\n\nI\u0027ve also not currently got all of the metrics returning properly.  Although it sees all of my chassis, it reports them as down.  System-ID is missing for all metrics, ovn_up is reporting as down.","commit_id":"6c0c885b04d5f3dd559e589765465674fd7ca7d3"}],"ansible/roles/prometheus/handlers/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":true,"context_lines":[{"line_number":182,"context_line":"  when:"},{"line_number":183,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"- name: Restart prometheus-ovn container"},{"line_number":186,"context_line":"  vars:"},{"line_number":187,"context_line":"    service_name: \"prometheus-ovn-exporter\""},{"line_number":188,"context_line":"    service: \"{{ prometheus_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fccf6327_d3208513","line":185,"range":{"start_line":185,"start_character":16,"end_line":185,"end_character":30},"updated":"2022-09-26 09:34:03.000000000","message":"Missing \"-exporter\", the handler name needs to match the way it is being triggered.","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  when:"},{"line_number":183,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"- name: Restart prometheus-ovn container"},{"line_number":186,"context_line":"  vars:"},{"line_number":187,"context_line":"    service_name: \"prometheus-ovn-exporter\""},{"line_number":188,"context_line":"    service: \"{{ prometheus_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"607d687b_7f6c81e6","line":185,"range":{"start_line":185,"start_character":16,"end_line":185,"end_character":30},"in_reply_to":"fccf6327_d3208513","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":true,"context_lines":[{"line_number":190,"context_line":"  kolla_docker:"},{"line_number":191,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":192,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":193,"context_line":"    environment: \"{{ service.environment }}\""},{"line_number":194,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":195,"context_line":"    image: \"{{ service.image }}\""},{"line_number":196,"context_line":"    volumes: \"{{ service.volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c373c177_dd256c0a","line":193,"updated":"2022-09-26 09:34:03.000000000","message":"You haven\u0027t defined an enviroment, need to drop this line to avoid a failure.","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  kolla_docker:"},{"line_number":191,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":192,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":193,"context_line":"    environment: \"{{ service.environment }}\""},{"line_number":194,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":195,"context_line":"    image: \"{{ service.image }}\""},{"line_number":196,"context_line":"    volumes: \"{{ service.volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"765b4046_0d0e0a0b","line":193,"in_reply_to":"c373c177_dd256c0a","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"2e034a98459eabc7332feb37b138b4a5cd83afd5","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    service_name: \"prometheus-ovn-exporter\""},{"line_number":188,"context_line":"    service: \"{{ prometheus_services[service_name] }}\""},{"line_number":189,"context_line":"  become: true"},{"line_number":190,"context_line":"  kolla_docker:"},{"line_number":191,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":192,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":193,"context_line":"    name: \"{{ service.container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b1ec7115_667acaf2","line":190,"updated":"2023-12-11 14:02:13.000000000","message":"Should be ``kolla_container`` instead of ``kolla_docker``. This results in error on the Zuul:\n\n```\nERROR! couldn\u0027t resolve module/action \u0027kolla_docker\u0027. This often indicates a misspelling, missing collection, or incorrect module path.\n\nThe error appears to be in \u0027/home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/prometheus/handlers/main.yml\u0027: line 185, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Restart prometheus-ovn-exporter container\n  ^ here\n```","commit_id":"6414a93f9fc1c5040b963601de9529c84b6c0156"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a47f75fff8bbe1a7661383ac7b7f5f7f7172943","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    service_name: \"prometheus-ovn-exporter\""},{"line_number":188,"context_line":"    service: \"{{ prometheus_services[service_name] }}\""},{"line_number":189,"context_line":"  become: true"},{"line_number":190,"context_line":"  kolla_docker:"},{"line_number":191,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":192,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":193,"context_line":"    name: \"{{ service.container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6d30877e_2cc1bf32","line":190,"in_reply_to":"b1ec7115_667acaf2","updated":"2023-12-11 15:09:30.000000000","message":"Done","commit_id":"6414a93f9fc1c5040b963601de9529c84b6c0156"}],"ansible/roles/prometheus/tasks/config.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3965f8ab9983047feb7d015dd07bbe93b12b454d","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":284,"context_line":"    - service.enabled | bool"},{"line_number":285,"context_line":"  with_first_found:"},{"line_number":286,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/config.json.j2\""},{"line_number":287,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/config.json.j2\""},{"line_number":288,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":289,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"013ed527_8cf081f6","line":286,"range":{"start_line":286,"start_character":68,"end_line":286,"end_character":75},"updated":"2023-06-16 08:42:10.000000000","message":"this would better be a more specific name, like \"ovn-exporter-config\"? or even \"prometheus-ovn-exporter-config\"?","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8e6a38ac82d694959f60fdfa1b673d99cf21fcf","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":284,"context_line":"    - service.enabled | bool"},{"line_number":285,"context_line":"  with_first_found:"},{"line_number":286,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/config.json.j2\""},{"line_number":287,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/config.json.j2\""},{"line_number":288,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":289,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"f1e12abd_8d6699f9","line":286,"range":{"start_line":286,"start_character":68,"end_line":286,"end_character":75},"in_reply_to":"013ed527_8cf081f6","updated":"2023-06-16 09:21:24.000000000","message":"sounds like a good change to me, will do!","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"efa18e07fed781a7e4cf65c4761bb04b76352028","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":284,"context_line":"    - service.enabled | bool"},{"line_number":285,"context_line":"  with_first_found:"},{"line_number":286,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/config.json.j2\""},{"line_number":287,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/config.json.j2\""},{"line_number":288,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":289,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9ced9d7e_4f6a9c5e","line":286,"range":{"start_line":286,"start_character":68,"end_line":286,"end_character":75},"in_reply_to":"f1e12abd_8d6699f9","updated":"2023-09-26 09:44:55.000000000","message":"Ack: I went with \"prometheus-ovn-exporter\" to be consistent with the rest of the config file names.","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7134f840eb23e30b00bd300cd0d8f2ee706e7f81","unresolved":true,"context_lines":[{"line_number":303,"context_line":"  with_first_found:"},{"line_number":304,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus-ovn-exporter.json.j2\""},{"line_number":305,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/prometheus-ovn-exporter.json.j2\""},{"line_number":306,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":307,"context_line":"  notify:"},{"line_number":308,"context_line":"    - Restart prometheus-ovn-exporter container"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"67eaad3a_2324fe47","line":306,"updated":"2024-03-28 08:17:26.000000000","message":"config in json? or you just forgot to add this exporter to prometheus_services?","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c255ede75bf22123b78db42445c7fd33c4b213d3","unresolved":true,"context_lines":[{"line_number":303,"context_line":"  with_first_found:"},{"line_number":304,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus-ovn-exporter.json.j2\""},{"line_number":305,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/prometheus-ovn-exporter.json.j2\""},{"line_number":306,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":307,"context_line":"  notify:"},{"line_number":308,"context_line":"    - Restart prometheus-ovn-exporter container"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ef21aa12_1bfe5509","line":306,"in_reply_to":"474af639_3aeec41d","updated":"2024-03-28 09:57:23.000000000","message":"Look at L19 - all exporters use one function to copy in config.json","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"367a7c953a4931cb75442d9a67d836311902f6be","unresolved":true,"context_lines":[{"line_number":303,"context_line":"  with_first_found:"},{"line_number":304,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus-ovn-exporter.json.j2\""},{"line_number":305,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/prometheus-ovn-exporter.json.j2\""},{"line_number":306,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":307,"context_line":"  notify:"},{"line_number":308,"context_line":"    - Restart prometheus-ovn-exporter container"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"474af639_3aeec41d","line":306,"in_reply_to":"67eaad3a_2324fe47","updated":"2024-03-28 09:48:45.000000000","message":"it is added to prometheus_services here? https://review.opendev.org/c/openstack/kolla-ansible/+/855498/28/ansible/roles/prometheus/defaults/main.yml#140\n\nI don\u0027t understand what you are referring to with \"config in json?\", could you explain that please a little more? other exporters like the `prometheus-openstack-exporter` have basically the same config setup. Do you think this does not work? Then please indicate why. Thank you.\n\nedit: or do you mean this config file should be copied by this function already? https://github.com/openstack/kolla-ansible/blob/2a150d1be9be242b0ee1e9075840d3802cfb21e6/ansible/roles/prometheus/tasks/config.yml#L19\n\nnot sure though if that is what you meant, please elaborate.","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a800193c353c21c5d0f36c200908e42927e19375","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  with_first_found:"},{"line_number":304,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus-ovn-exporter.json.j2\""},{"line_number":305,"context_line":"    - \"{{ node_custom_config }}/prometheus/prometheus-ovn-exporter/prometheus-ovn-exporter.json.j2\""},{"line_number":306,"context_line":"    - \"{{ role_path }}/templates/prometheus-ovn-exporter.json.j2\""},{"line_number":307,"context_line":"  notify:"},{"line_number":308,"context_line":"    - Restart prometheus-ovn-exporter container"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"41a47dc4_70e42e1e","line":306,"in_reply_to":"ef21aa12_1bfe5509","updated":"2024-03-28 10:03:50.000000000","message":"Done","commit_id":"13003daaae80ee0c70f07b66ceb3c08badc64668"}],"ansible/roles/prometheus/tasks/precheck.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0663fe05027fb9be94377cbe1fd3ec9818fb18c7","unresolved":true,"context_lines":[{"line_number":193,"context_line":"    - inventory_hostname in groups[\u0027prometheus-ovn-exporter\u0027]"},{"line_number":194,"context_line":"    - enable_prometheus_ovn_exporter | bool"},{"line_number":195,"context_line":"  with_items:"},{"line_number":196,"context_line":"    - \"{{ prometheus_ovn_exporter_port }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"81bb09e3_610a3b16","line":196,"updated":"2022-09-26 09:34:03.000000000","message":"This variable isn\u0027t defined anywhere, causing the precheck to fail.\n\nAlso using a loop when there is only one fixed item is an anti-pattern IMO. Even if this has been copied a couple of times before, maybe we can stop doing it. Probably best by doing a patch cleaning up the other misuses before this one.","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    - inventory_hostname in groups[\u0027prometheus-ovn-exporter\u0027]"},{"line_number":194,"context_line":"    - enable_prometheus_ovn_exporter | bool"},{"line_number":195,"context_line":"  with_items:"},{"line_number":196,"context_line":"    - \"{{ prometheus_ovn_exporter_port }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5fdb4378_70e15973","line":196,"in_reply_to":"81bb09e3_610a3b16","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"a8a3d765539869b06df99ac0437b566233d5988a"}],"ansible/roles/prometheus/templates/prometheus-ovn-exporter.json.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"26fafad3787583d1f54ab1cc033ae497be792ee0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }} {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items }} {% endfor %} {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}\u0027\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"permissions\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"0c7ab911_601195a5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":394},"updated":"2024-04-18 20:34:06.000000000","message":"may be create a local variable to move the logic outside the command and shorten the very long line?","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f32663402c0907530a44defeed894103ae1a0839","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }} {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items }} {% endfor %} {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}\u0027\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"permissions\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"dcd9225e_d43cde79","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":394},"in_reply_to":"0c7ab911_601195a5","updated":"2024-04-19 08:15:00.000000000","message":"it\u0027s just in the top 10! ;)\n\n```\n find . -type f -name \"*.j2\" -exec awk \u0027{ if ( length \u003e x ) { x \u003d length; longest \u003d $0 } } END { print length(longest) \" \" FILENAME }\u0027 \"{}\" \\; | sort -nk 1 | tail\n395 ./ansible/roles/prometheus/templates/prometheus-ovn-exporter.json.j2\n398 ./ansible/roles/prometheus/templates/prometheus-memcached-exporter.json.j2\n400 ./ansible/roles/neutron/templates/neutron-server.json.j2\n415 ./ansible/roles/prometheus/templates/prometheus-elasticsearch-exporter.json.j2\n467 ./ansible/roles/prometheus/templates/prometheus-openstack-exporter.json.j2\n484 ./.tox/linters/lib/python3.10/site-packages/ansible_collections/ovirt/ovirt/roles/hosted_engine_setup/templates/vm.conf.j2\n660 ./ansible/roles/rabbitmq/templates/definitions.json.j2\n684 ./ansible/roles/letsencrypt/templates/letsencrypt-lego-run.sh.j2\n719 ./ansible/roles/prometheus/templates/prometheus-alertmanager.json.j2\n722 ./ansible/roles/letsencrypt/templates/crontab.j2\n```\n\nI\u0027ll see if it makes a difference.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"eed847d43ec6db9acdbbee20b36afa0ae102bba0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/ovn-exporter -web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_ovn_exporter_port }} {% for host in groups[\"ovn-database\"] %} {{ prometheus_ovn_exporter_enabled_items }} {% endfor %} {{ prometheus_ovn_exporter_enabled_ovs }} {% if prometheus_ovn_exporter_cmdline_extras %} {{ prometheus_ovn_exporter_cmdline_extras }}{% endif %}\u0027\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"permissions\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"1030d838_4b3489b2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":394},"in_reply_to":"dcd9225e_d43cde79","updated":"2024-04-19 10:02:51.000000000","message":"I don\u0027t think much is gained by making this line shorter to be honest.\nIt\u0027s just shuffeling the complexity around and even introducing more of it\nby adding more layers of abstractions and more files involved.","commit_id":"442487d282c3aa448eb0bd219df4f1849f30967b"}],"etc/kolla/globals.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3965f8ab9983047feb7d015dd07bbe93b12b454d","unresolved":true,"context_lines":[{"line_number":730,"context_line":"#enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":731,"context_line":"#enable_prometheus_msteams: \"no\""},{"line_number":732,"context_line":"#enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and enable_ovn | bool }}\""},{"line_number":733,"context_line":""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"# The labels to add to any time series or alerts when communicating with external systems (federation, remote storage, Alertmanager)."},{"line_number":736,"context_line":"# prometheus_external_labels:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"03b00aae_67115fb2","line":733,"updated":"2023-06-16 08:42:10.000000000","message":"nit: no need for an extra empty line","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8e6a38ac82d694959f60fdfa1b673d99cf21fcf","unresolved":false,"context_lines":[{"line_number":730,"context_line":"#enable_prometheus_etcd_integration: \"{{ enable_prometheus | bool and enable_etcd | bool }}\""},{"line_number":731,"context_line":"#enable_prometheus_msteams: \"no\""},{"line_number":732,"context_line":"#enable_prometheus_ovn_exporter: \"{{ enable_prometheus | bool and enable_ovn | bool }}\""},{"line_number":733,"context_line":""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"# The labels to add to any time series or alerts when communicating with external systems (federation, remote storage, Alertmanager)."},{"line_number":736,"context_line":"# prometheus_external_labels:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"eff10dff_95f64346","line":733,"in_reply_to":"03b00aae_67115fb2","updated":"2023-06-16 09:21:24.000000000","message":"Ack","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"}],"releasenotes/notes/add-prometheus-ovn-exporter-1e3496e2c986cafe.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for deploying ``prometheus-ovn-exporter``, which can be used"},{"line_number":5,"context_line":"    to observe Open Virtual Network (OVN) and Openvswitch with ovn-exporter"},{"line_number":6,"context_line":"    It is enabled by setting  ``enable_prometheus_ovn_exporter`` to ``true``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f4f2751f_fab20248","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":57},"updated":"2022-09-21 11:26:48.000000000","message":"Wouldn\u0027t OVS need a different exporter? Also missing \".\" at the end of the sentence.","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for deploying ``prometheus-ovn-exporter``, which can be used"},{"line_number":5,"context_line":"    to observe Open Virtual Network (OVN) and Openvswitch with ovn-exporter"},{"line_number":6,"context_line":"    It is enabled by setting  ``enable_prometheus_ovn_exporter`` to ``true``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ee52c822_09a70795","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":57},"in_reply_to":"f4f2751f_fab20248","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for deploying ``prometheus-ovn-exporter``, which can be used"},{"line_number":5,"context_line":"    to observe Open Virtual Network (OVN) and Openvswitch with ovn-exporter"},{"line_number":6,"context_line":"    It is enabled by setting  ``enable_prometheus_ovn_exporter`` to ``true``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f44b0866_05cb01a5","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":9},"updated":"2022-09-21 11:26:48.000000000","message":"maybe s/is/can be/ ?","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for deploying ``prometheus-ovn-exporter``, which can be used"},{"line_number":5,"context_line":"    to observe Open Virtual Network (OVN) and Openvswitch with ovn-exporter"},{"line_number":6,"context_line":"    It is enabled by setting  ``enable_prometheus_ovn_exporter`` to ``true``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d20bbe63_cfff2ed1","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":9},"in_reply_to":"f44b0866_05cb01a5","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f96cd931aebdd45ba38a90bda994a066199932d9","unresolved":true,"context_lines":[{"line_number":163,"context_line":"enable_grafana: \"yes\""},{"line_number":164,"context_line":"enable_prometheus: \"yes\""},{"line_number":165,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":166,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":167,"context_line":"{% endif %}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"96903067_b2197950","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":37},"updated":"2023-02-20 07:16:01.000000000","message":"there\u0027s no OVN in this scenario","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"88826ab96d3e02ebf6354dbab5f091cdf279bffd","unresolved":false,"context_lines":[{"line_number":163,"context_line":"enable_grafana: \"yes\""},{"line_number":164,"context_line":"enable_prometheus: \"yes\""},{"line_number":165,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":166,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":167,"context_line":"{% endif %}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"53ee263e_5ee617f5","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":37},"in_reply_to":"778b8b35_f3875746","updated":"2023-06-02 07:41:01.000000000","message":"I don\u0027t know what you mean by \"enable it directly\"?\n\nIt get\u0027s enabled in the current patch set \"directly\"? did you mean to say I should enable it in the ovn test scenario only and not globaly like the current code does?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed4ba3ab5bd94f1b2aabfa35e43222e3cacf1569","unresolved":true,"context_lines":[{"line_number":163,"context_line":"enable_grafana: \"yes\""},{"line_number":164,"context_line":"enable_prometheus: \"yes\""},{"line_number":165,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":166,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":167,"context_line":"{% endif %}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"a52db210_1248337e","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":37},"in_reply_to":"87df22a0_ba5bcdd0","updated":"2023-04-05 09:55:55.000000000","message":"so should I remove this for now until this is enabled in the ovn test scenario?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":true,"context_lines":[{"line_number":163,"context_line":"enable_grafana: \"yes\""},{"line_number":164,"context_line":"enable_prometheus: \"yes\""},{"line_number":165,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":166,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":167,"context_line":"{% endif %}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"87df22a0_ba5bcdd0","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":37},"in_reply_to":"96903067_b2197950","updated":"2023-02-22 23:41:38.000000000","message":"This was recommended by frickler in an earlier comment. Maybe we should enable Prometheus and the exporter in the ovn test scenario?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"93f555277409bd27f4d3c6e703f27bddd1c76305","unresolved":true,"context_lines":[{"line_number":163,"context_line":"enable_grafana: \"yes\""},{"line_number":164,"context_line":"enable_prometheus: \"yes\""},{"line_number":165,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":166,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":167,"context_line":"{% endif %}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"778b8b35_f3875746","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":37},"in_reply_to":"a52db210_1248337e","updated":"2023-06-02 07:34:43.000000000","message":"why not enable it directly?","commit_id":"37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3965f8ab9983047feb7d015dd07bbe93b12b454d","unresolved":true,"context_lines":[{"line_number":176,"context_line":"enable_grafana: \"yes\""},{"line_number":177,"context_line":"enable_prometheus: \"yes\""},{"line_number":178,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":179,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":180,"context_line":"{% endif %}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"ef0e37e9_60e3e9ce","line":179,"updated":"2023-06-16 08:42:10.000000000","message":"Would it be possible (and make sense) to just deploy OVN in this scenario without having neutron on top?\n\nThat would avoid having to deploy prometheus in the OVN scenario just for testing this exporter.\n\nI think we can defer this question to a follow-up if you just drop this line for now.","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d4f75903cd462095a4d6867d8ca8971623dce36","unresolved":true,"context_lines":[{"line_number":176,"context_line":"enable_grafana: \"yes\""},{"line_number":177,"context_line":"enable_prometheus: \"yes\""},{"line_number":178,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":179,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":180,"context_line":"{% endif %}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"6765244d_3e6dddd9","line":179,"in_reply_to":"0d5b314c_0cc91b35","updated":"2023-06-20 05:12:07.000000000","message":"Setting enable_prometheus_ovn_exporter: \"yes\" only makes sense if both prometheus and OVN are getting installed in the job where it is being applied. Currently this is not happening (afaict, corrent me if I\u0027m wrong on that).\n\nSo there are two options to resolve this: 1.: Install OVN into the prometheus-opensearch scenario, this is what I am proposing above and what would be consistent with setting this variable here. 2.: Install prometheus into the OVN scenario, that would result in a much larger job and is what I would like to avoid.","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"efa18e07fed781a7e4cf65c4761bb04b76352028","unresolved":false,"context_lines":[{"line_number":176,"context_line":"enable_grafana: \"yes\""},{"line_number":177,"context_line":"enable_prometheus: \"yes\""},{"line_number":178,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":179,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":180,"context_line":"{% endif %}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5e5190e0_b0d88bff","line":179,"in_reply_to":"6765244d_3e6dddd9","updated":"2023-09-26 09:44:55.000000000","message":"Ack","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8e6a38ac82d694959f60fdfa1b673d99cf21fcf","unresolved":true,"context_lines":[{"line_number":176,"context_line":"enable_grafana: \"yes\""},{"line_number":177,"context_line":"enable_prometheus: \"yes\""},{"line_number":178,"context_line":"enable_prometheus_openstack_exporter: \"no\""},{"line_number":179,"context_line":"enable_prometheus_ovn_exporter: \"yes\""},{"line_number":180,"context_line":"{% endif %}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% if scenario \u003d\u003d \"magnum\" %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"0d5b314c_0cc91b35","line":179,"in_reply_to":"ef0e37e9_60e3e9ce","updated":"2023-06-16 09:21:24.000000000","message":"I\u0027m sorry, but I fail to understand the first sentence.\nyou want to deploy ovn without deploying neutron? why would that result in not needing to deploy prometheus? I\u0027m sure I\u0027m misunderstanding something here.","commit_id":"3adae47cb46697859048be891443cd5ad027c5a5"}],"tests/templates/inventory.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8dfae634924ad3113de9b207c382651a84c92aee","unresolved":true,"context_lines":[{"line_number":776,"context_line":"prometheus-alertmanager"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":779,"context_line":"ovn-database"},{"line_number":780,"context_line":"ovn-controller-compute"},{"line_number":781,"context_line":"ovn-controller-network"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"# NOTE(yoctozepto): In CI we want to test Masakari HA but not of other services,"},{"line_number":784,"context_line":"# to conserve the resources. Hence, we set Masakari groups to use both"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"161deec0_383a9616","line":781,"range":{"start_line":779,"start_character":0,"end_line":781,"end_character":22},"updated":"2022-09-21 11:26:48.000000000","message":"Sort alphabetically?","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"22abf66a04e2323526633c90a5a1751e3e76a337","unresolved":false,"context_lines":[{"line_number":776,"context_line":"prometheus-alertmanager"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"[prometheus-ovn-exporter:children]"},{"line_number":779,"context_line":"ovn-database"},{"line_number":780,"context_line":"ovn-controller-compute"},{"line_number":781,"context_line":"ovn-controller-network"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"# NOTE(yoctozepto): In CI we want to test Masakari HA but not of other services,"},{"line_number":784,"context_line":"# to conserve the resources. Hence, we set Masakari groups to use both"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"2ff45a47_e8d39246","line":781,"range":{"start_line":779,"start_character":0,"end_line":781,"end_character":22},"in_reply_to":"161deec0_383a9616","updated":"2023-02-22 23:41:38.000000000","message":"Done","commit_id":"fa4b4dd5ebb7b03006e96b0147cf52afdbabe23c"}]}