)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4275e6013648a97f7e93c65ca1719c842edb6dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a626faff_53cc1dac","updated":"2022-09-09 07:51:26.000000000","message":"Not sure what you mean by this.\n\nEven if the one introduced for a different reason, we should keep coherence. \n\nWe are going to set the CPU mode in one file and the model in another. This is certainly not the right approach and prone to error on deployments. As mentioned previously if the cpu model is set you want to specifically set the model to ‘custom’.\n","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"94885fa347ed1f622cee53a3283a686b3c86ac40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"515fa5c9_da882247","updated":"2022-09-08 16:36:13.000000000","message":"Please do not add options that can be set via regular config overrides: https://docs.openstack.org/kolla-ansible/latest/admin/advanced-configuration.html#openstack-service-configuration-in-kolla","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"81b440c9a2d372eb9788bf449f1e139efeae6684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82541ec3_229e1d68","in_reply_to":"18a31d22_5c812a98","updated":"2022-09-09 19:36:46.000000000","message":"You can set both of them in the override. You don\u0027t even need to know this internal variable exists.","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b5596f5d29f06f55ed385898ca0e91927106a30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f624460f_3b0e5692","in_reply_to":"2177947a_d6e1aa51","updated":"2022-09-08 16:53:31.000000000","message":"Not quite. This way we could push it all the way to the bottom. ;-) The only reason the other variable exists is because of the aarch64 platform seemingly not working with nova\u0027s defaults (at least back then when it was introduced). Do note it is *not documented* which has lowest guarantees out of all variables (i.e. the proper guarantee is when a variable is in the globals.yml template file with the default value, an accompanying comment, and even better if also documented in the docs).","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"83f5fd4a6ef86680a46bc3e03e2873a82117ca23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b6b3158_39ebc3ad","in_reply_to":"3d69c5df_7c268070","updated":"2022-11-02 10:07:45.000000000","message":"Loos like a reasonable change for me. Or we should remove nova_libvirt_cpu_mode from libvirt.conf.j2","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"48a5caffea40f0250e52a4fa0ad68efba20b2143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e51d2b77_3d1c1f1a","in_reply_to":"515fa5c9_da882247","updated":"2022-09-08 16:37:03.000000000","message":"Since you proposed this change, I ask you kindly to let us know how to better expose this information in the docs.","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0dc443b3325f682bcf8d10a11b7115aab0a9df46","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d69c5df_7c268070","in_reply_to":"540d36bb_5e226a00","updated":"2022-11-02 06:53:59.000000000","message":"Should that patch be abandoned then?","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1cd32a9b097a9104021e18e409bce4f717048c62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"540d36bb_5e226a00","in_reply_to":"82541ec3_229e1d68","updated":"2022-09-12 09:21:50.000000000","message":"Even If I understand your point I feel like for this specific case is not right as you can be in a situation with mode set two time.\n\nAnyway as you disagree with it I wont argue too much.","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"688b20460c7e88f6c925733a485f6275d6193199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2177947a_d6e1aa51","in_reply_to":"e51d2b77_3d1c1f1a","updated":"2022-09-08 16:49:44.000000000","message":"I understand your point but since this option has a direct dependency with one that we define in the template libvirt.conf.j2 I would imagine for this specific case that would make sense, right?","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4275e6013648a97f7e93c65ca1719c842edb6dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18a31d22_5c812a98","in_reply_to":"f624460f_3b0e5692","updated":"2022-09-09 07:51:26.000000000","message":"Not completely sure of what you mean by this.\n\n\u003e Not quite. This way we could push it all the way to the bottom. ;-) \n\nEven if that has been introduced for a different reason, we should keep coherence. \n\nWe are going to set the CPU mode in one file and the model in another. This is certainly not the right approach and prone to error on deployments. As mentioned  if the cpu model is set you want to specifically set the mode to ‘custom’. Removing mode is not a choice has this could break deployment.","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a8f83efd4aed214e83e9910d949573af574bc6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ef2c0e7_90a5655d","updated":"2022-11-02 12:09:09.000000000","message":"I support Radek\u0027s -1, https://review.opendev.org/c/openstack/kolla/+/863088 has a good explanation of our policy on this, even if it is not yet merged. If you want to propose a reduction of libvirt config instead, go ahead with that and we\u0027ll see how that works.","commit_id":"4e1fa0ad2218889a1a4e229f0a26332ce8b9879a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0d5373f8f70dbce6f297b0dd742e03f492eca6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41b67f24_4a40430c","in_reply_to":"2ef2c0e7_90a5655d","updated":"2022-11-02 13:30:21.000000000","message":"\u003e If you want to propose a reduction of libvirt config instead, go ahead with that and we\u0027ll see how that works.\n\nIs that really makes sense, asking to do something and then thinking about it.","commit_id":"4e1fa0ad2218889a1a4e229f0a26332ce8b9879a"}],"releasenotes/notes/cpu-model-option-for-nova-libvirt-driver-83440729ebcb8959.yaml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"824f4b66cf917136e2f8cc3484ff3e89276a13d3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Some deployment may have the desir for guests running on host to"},{"line_number":5,"context_line":"    expose a certain set of capabilities."},{"line_number":6,"context_line":"    This updates gives to operator ability to set a model for guests"},{"line_number":7,"context_line":"    deployed. It\u0027s especially useful for deployment running different host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f191467a_4c447f9c","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":38},"updated":"2022-09-08 12:39:16.000000000","message":"desire","commit_id":"f1e24d4a50f8b8c0356391b3a9e7f7af4314ba5a"}]}