)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"40974d435c244ac26d8cab3e167397e997ab5a84","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-21 09:09:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix some issues reported by ansible-lint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6f52f2b0c1ef76de626657d79486d31e0f47f384"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"335190d3_39a55144","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":8},"updated":"2022-09-21 12:27:37.000000000","message":"s/some// (or all)?\n\nMaybe also be a bit more verbose about which issues were fixed and which ansible-lint version brought them to us?","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2448287d4ad9481c1a849f889b57830282a4b450","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-21 09:09:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix some issues reported by ansible-lint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6f52f2b0c1ef76de626657d79486d31e0f47f384"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9c4ac892_3f481e1c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":8},"in_reply_to":"335190d3_39a55144","updated":"2022-09-21 13:54:54.000000000","message":"Updated.","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b1940eb00943d29fb730c73031312caafdcf35fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2332cd4_b90995cf","updated":"2022-09-21 07:12:02.000000000","message":"and two more","commit_id":"541c74d71feb7294717cdd09a3b48dd698b6e4c6"}],"ansible/roles/common/tasks/config.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b1940eb00943d29fb730c73031312caafdcf35fc","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  delegate_to: localhost"},{"line_number":75,"context_line":"  when: common_services.fluentd.enabled | bool"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Copying over td-agent.conf"},{"line_number":78,"context_line":"  vars:"},{"line_number":79,"context_line":"    log_direct_to_elasticsearch: \u003e-"},{"line_number":80,"context_line":"      {{ ( enable_elasticsearch | bool or"},{"line_number":81,"context_line":"           ( elasticsearch_address !\u003d kolla_internal_fqdn )) and"},{"line_number":82,"context_line":"         ( not enable_monasca | bool or not monasca_ingest_control_plane_logs | bool ) }}"},{"line_number":83,"context_line":"    # Inputs"},{"line_number":84,"context_line":"    fluentd_input_files: \"{{ default_input_files_enabled | customise_fluentd(customised_input_files) }}\""},{"line_number":85,"context_line":"    default_input_files_enabled: \"{{ default_input_files | selectattr(\u0027enabled\u0027) | map(attribute\u003d\u0027name\u0027) | list }}\""},{"line_number":86,"context_line":"    default_input_files:"},{"line_number":87,"context_line":"      - name: \"conf/input/00-global.conf.j2\""},{"line_number":88,"context_line":"        enabled: true"},{"line_number":89,"context_line":"      - name: \"conf/input/01-syslog.conf.j2\""},{"line_number":90,"context_line":"        enabled: true"},{"line_number":91,"context_line":"      - name: \"conf/input/02-mariadb.conf.j2\""},{"line_number":92,"context_line":"        enabled: true"},{"line_number":93,"context_line":"      - name: \"conf/input/03-rabbitmq.conf.j2\""},{"line_number":94,"context_line":"        enabled: true"},{"line_number":95,"context_line":"      - name: \"conf/input/04-openstack-wsgi.conf.j2\""},{"line_number":96,"context_line":"        enabled: true"},{"line_number":97,"context_line":"      - name: \"conf/input/05-libvirt.conf.j2\""},{"line_number":98,"context_line":"        enabled: \"{{ enable_nova | bool and enable_nova_libvirt_container | bool }}\""},{"line_number":99,"context_line":"      - name: \"conf/input/06-zookeeper.conf.j2\""},{"line_number":100,"context_line":"        enabled: true"},{"line_number":101,"context_line":"      - name: \"conf/input/07-kafka.conf.j2\""},{"line_number":102,"context_line":"        enabled: true"},{"line_number":103,"context_line":"      - name: \"conf/input/08-prometheus.conf.j2\""},{"line_number":104,"context_line":"        enabled: \"{{ enable_prometheus_fluentd_integration | bool }}\""},{"line_number":105,"context_line":"      - name: \"conf/input/09-monasca.conf.j2\""},{"line_number":106,"context_line":"        enabled: true"},{"line_number":107,"context_line":"      - name: \"conf/input/10-openvswitch.conf.j2\""},{"line_number":108,"context_line":"        enabled: true"},{"line_number":109,"context_line":"    customised_input_files: \"{{ find_custom_fluentd_inputs.files | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":110,"context_line":"    # Filters"},{"line_number":111,"context_line":"    fluentd_filter_files: \"{{ default_filter_files | customise_fluentd(customised_filter_files) }}\""},{"line_number":112,"context_line":"    default_filter_files:"},{"line_number":113,"context_line":"      - \"conf/filter/00-record_transformer.conf.j2\""},{"line_number":114,"context_line":"      - \"conf/filter/01-rewrite.conf.j2\""},{"line_number":115,"context_line":"      - \"conf/filter/02-parser.conf.j2\""},{"line_number":116,"context_line":"    customised_filter_files: \"{{ find_custom_fluentd_filters.files | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":117,"context_line":"    # Formats"},{"line_number":118,"context_line":"    fluentd_format_files: \"{{ default_format_files | customise_fluentd(customised_format_files) }}\""},{"line_number":119,"context_line":"    default_format_files:"},{"line_number":120,"context_line":"      - \"conf/format/apache_access.conf.j2\""},{"line_number":121,"context_line":"      - \"conf/format/wsgi_access.conf.j2\""},{"line_number":122,"context_line":"    customised_format_files: \"{{ find_custom_fluentd_formats.files | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":123,"context_line":"    # Outputs"},{"line_number":124,"context_line":"    fluentd_output_files: \"{{ default_output_files_enabled | customise_fluentd(customised_output_files) }}\""},{"line_number":125,"context_line":"    default_output_files_enabled: \"{{ default_output_files | selectattr(\u0027enabled\u0027) | map(attribute\u003d\u0027name\u0027) | list }}\""},{"line_number":126,"context_line":"    default_output_files:"},{"line_number":127,"context_line":"      - name: \"conf/output/00-local.conf.j2\""},{"line_number":128,"context_line":"        enabled: true"},{"line_number":129,"context_line":"      - name: \"conf/output/01-es.conf.j2\""},{"line_number":130,"context_line":"        enabled: \"{{ log_direct_to_elasticsearch }}\""},{"line_number":131,"context_line":"      - name: \"conf/output/02-monasca.conf.j2\""},{"line_number":132,"context_line":"        enabled: \"{{ enable_monasca | bool and monasca_ingest_control_plane_logs | bool }}\""},{"line_number":133,"context_line":"    customised_output_files: \"{{ find_custom_fluentd_outputs.files | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":134,"context_line":"  template:"},{"line_number":135,"context_line":"    src: \"td-agent.conf.j2\""},{"line_number":136,"context_line":"    dest: \"{{ node_config_directory }}/fluentd/td-agent.conf\""},{"line_number":137,"context_line":"    mode: \"0660\""},{"line_number":138,"context_line":"  become: true"},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - common_services.fluentd | service_enabled_and_mapped_to_host"},{"line_number":141,"context_line":"  notify:"},{"line_number":142,"context_line":"    - Restart fluentd container"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- name: Copying over cron logrotate config file"},{"line_number":145,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8afbfd6e_22a63f9f","line":142,"range":{"start_line":77,"start_character":1,"end_line":142,"end_character":31},"updated":"2022-09-21 07:12:02.000000000","message":"jinja: Unexpected templating type error occurred on ({{ default_input_files_enabled | customise_fluentd(customised_input_files) }}): ansible_template.\u003clocals\u003e.\u003clambda\u003e() takes 1 positional argument but 2 were given (jinja[invalid])\nansible/roles/common/tasks/config.yml:77 Task/Handler: Copying over td-agent.conf","commit_id":"5def9871beb3997e6a35d5d6cff3f3363b1a5975"}],"ansible/roles/loadbalancer/tasks/precheck.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b1940eb00943d29fb730c73031312caafdcf35fc","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    - haproxy_enable_external_vip | bool"},{"line_number":102,"context_line":"    - not hostvars[inventory_hostname].ansible_facts[kolla_external_vip_interface][\u0027active\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not pingable from any node"},{"line_number":105,"context_line":"  command: \"{{ item.command }} -c 3 {{ item.address }}\""},{"line_number":106,"context_line":"  register: ping_output"},{"line_number":107,"context_line":"  changed_when: false"},{"line_number":108,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":109,"context_line":"  with_items:"},{"line_number":110,"context_line":"    - address: \"{{ kolla_internal_vip_address }}\""},{"line_number":111,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_internal_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":112,"context_line":"    - address: \"{{ kolla_external_vip_address }}\""},{"line_number":113,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_external_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":114,"context_line":"  when:"},{"line_number":115,"context_line":"    - enable_keepalived | bool"},{"line_number":116,"context_line":"    - keepalived_vip_prechecks"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2b97c438_cc957aea","line":113,"range":{"start_line":104,"start_character":0,"end_line":113,"end_character":79},"updated":"2022-09-21 07:12:02.000000000","message":"jinja: Unrecognized type \u003c\u003cclass \u0027ansible.template.AnsibleUndefined\u0027\u003e\u003e for ipv4 filter \u003cvalue\u003e (jinja[invalid])\nansible/roles/loadbalancer/tasks/precheck.yml:104 Task/Handler: Checking if kolla_internal_vip_address and kolla_external_vip_address are not pingable from any node","commit_id":"541c74d71feb7294717cdd09a3b48dd698b6e4c6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b37f263f32b8df7a336bfdb3e96614da1070b106","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    - haproxy_enable_external_vip | bool"},{"line_number":102,"context_line":"    - not hostvars[inventory_hostname].ansible_facts[kolla_external_vip_interface][\u0027active\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not pingable from any node"},{"line_number":105,"context_line":"  command: \"{{ item.command }} -c 3 {{ item.address }}\""},{"line_number":106,"context_line":"  register: ping_output"},{"line_number":107,"context_line":"  changed_when: false"},{"line_number":108,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":109,"context_line":"  with_items:"},{"line_number":110,"context_line":"    - address: \"{{ kolla_internal_vip_address }}\""},{"line_number":111,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_internal_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":112,"context_line":"    - address: \"{{ kolla_external_vip_address }}\""},{"line_number":113,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_external_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":114,"context_line":"  when:"},{"line_number":115,"context_line":"    - enable_keepalived | bool"},{"line_number":116,"context_line":"    - keepalived_vip_prechecks"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f15ad142_2612f1e3","line":113,"range":{"start_line":104,"start_character":0,"end_line":113,"end_character":79},"in_reply_to":"2b97c438_cc957aea","updated":"2022-09-21 13:11:48.000000000","message":"Done","commit_id":"541c74d71feb7294717cdd09a3b48dd698b6e4c6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"40974d435c244ac26d8cab3e167397e997ab5a84","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":109,"context_line":"  with_items:"},{"line_number":110,"context_line":"    - address: \"{{ kolla_internal_vip_address }}\""},{"line_number":111,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_internal_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":112,"context_line":"    - address: \"{{ kolla_external_vip_address }}\""},{"line_number":113,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_external_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":114,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d701704c_de735ee2","line":111,"updated":"2022-09-21 12:27:37.000000000","message":"Maybe we can just use \"ping\" everywhere by now? It should be able to detect what kind of address it is being given for a long time already.","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fc647352f0bc3068d09b7f992f842dd794b5f95c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":109,"context_line":"  with_items:"},{"line_number":110,"context_line":"    - address: \"{{ kolla_internal_vip_address }}\""},{"line_number":111,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_internal_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":112,"context_line":"    - address: \"{{ kolla_external_vip_address }}\""},{"line_number":113,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_external_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":114,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e83d833_9a54178d","line":111,"in_reply_to":"29edc955_9d2d5459","updated":"2022-09-21 13:11:06.000000000","message":"Done","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a26a2fd759cea4b6c25695545b25c116a119e324","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":109,"context_line":"  with_items:"},{"line_number":110,"context_line":"    - address: \"{{ kolla_internal_vip_address }}\""},{"line_number":111,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_internal_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":112,"context_line":"    - address: \"{{ kolla_external_vip_address }}\""},{"line_number":113,"context_line":"      command: \"{{ \u0027ping\u0027 if kolla_external_vip_address | ipv4 else \u0027ping6\u0027 }}\""},{"line_number":114,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"29edc955_9d2d5459","line":111,"in_reply_to":"d701704c_de735ee2","updated":"2022-09-21 13:00:59.000000000","message":"From quick check on CS9/Debian/Ubuntu it looks like we can.","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"}],"ansible/roles/neutron/tasks/rolling_upgrade.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"b1940eb00943d29fb730c73031312caafdcf35fc","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    neutron_server: \"{{ neutron_services[\u0027neutron-server\u0027] }}\""},{"line_number":49,"context_line":"    first_neutron_server_host: \"{{ groups[neutron_server.group][0] }}\""},{"line_number":50,"context_line":"    results_of_check_pending_contract_scripts: \"{{ hostvars[first_neutron_server_host][\u0027neutron_check_contract_db_stdout\u0027] }}\""},{"line_number":51,"context_line":"    # NOTE(hrw): no idea"},{"line_number":52,"context_line":"    filter_rc: \"results[?rc!\u003d`0`]\""},{"line_number":53,"context_line":"    is_stop_neutron_server: \"{{ results_of_check_pending_contract_scripts | json_query(filter_rc) }}\""},{"line_number":54,"context_line":"  become: true"},{"line_number":55,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6a8ff4ed_a8caca60","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":34},"updated":"2022-09-21 07:12:02.000000000","message":"jinja: Error in jmespath.search in json_query filter plugin:\n\u0027filter_rc\u0027 is undefined (jinja[invalid])\nansible/roles/neutron/tasks/rolling_upgrade.yml:46 Task/Handler: Stopping all neutron-server for contract db","commit_id":"5def9871beb3997e6a35d5d6cff3f3363b1a5975"}],"ansible/roles/octavia/templates/octavia-ssh-key.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"40974d435c244ac26d8cab3e167397e997ab5a84","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f921af5_1b933ce8","line":2,"updated":"2022-09-21 12:27:37.000000000","message":"Why the empty line?","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"53a8c63fe1681d84b4ce29624580a4a515265714","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc8195a4_dfc916ed","line":2,"in_reply_to":"8f921af5_1b933ce8","updated":"2022-09-21 12:57:47.000000000","message":"Done","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2448287d4ad9481c1a849f889b57830282a4b450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c079b7d0_d2934c42","line":2,"in_reply_to":"8f921af5_1b933ce8","updated":"2022-09-21 13:54:54.000000000","message":"Removed, let\u0027s see if it fails.","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"265ef71a441ff4def130b89cc0691a4aa74091a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21d5f560_4724d661","line":2,"in_reply_to":"90062230_9f7a6772","updated":"2022-09-21 14:44:28.000000000","message":"Yes, this is weird from gerrit, looking at the file locally, it only actually has a single line.","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dec4e2bff863db81bdff5cf9d61118b04815f5f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"90062230_9f7a6772","line":2,"in_reply_to":"c079b7d0_d2934c42","updated":"2022-09-21 14:35:25.000000000","message":"validate-all-files.py linter complains on no empty line","commit_id":"c4a988e44be2f28bf6e2caf0c280765bb982b0f2"}]}