)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"02b67e7098d5ad0aa18af77cbe83fe3dc9fd6f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a140207_3b27d6e0","updated":"2022-11-09 10:19:04.000000000","message":"Ack, this is just a cleanup as indicated in the code comments. Let\u0027s get this merged in order to be able to have a clean release.","commit_id":"b95de04ff471bd6db1cb522a3e44d4db8b3b2811"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2afa5c1090c9e999bbc851b7b94096a0eedcdab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42e97268_01028246","in_reply_to":"6a140207_3b27d6e0","updated":"2022-11-09 10:50:39.000000000","message":"ok","commit_id":"b95de04ff471bd6db1cb522a3e44d4db8b3b2811"}],"ansible/roles/ironic/tasks/upgrade.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"145d56af0955b2f8c6bc240c3e554f765f9d8283","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  run_once: true"},{"line_number":28,"context_line":"  when: not ironic_upgrade_skip_wait_check | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(yoctozepto): Remove this task in Zed."},{"line_number":31,"context_line":"- name: Remove old Ironic containers"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  kolla_docker:"},{"line_number":34,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":35,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":36,"context_line":"    name: \"{{ item }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    # NOTE(yoctozepto): Removing conductor to avoid it"},{"line_number":39,"context_line":"    # thinking that the tftp and http servers are available."},{"line_number":40,"context_line":"    - ironic_conductor"},{"line_number":41,"context_line":"    - ironic_pxe"},{"line_number":42,"context_line":"    - ironic_ipxe"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- include_tasks: rolling_upgrade.yml"},{"line_number":45,"context_line":"  when: ironic_enable_rolling_upgrade | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a1416a2_1bd3364c","side":"PARENT","line":42,"range":{"start_line":30,"start_character":0,"end_line":42,"end_character":17},"updated":"2022-11-08 18:47:42.000000000","message":"This task is removing old ironic containers, there should be a reno which will inform user...","commit_id":"4c60cc524ca2b11dae6a0527c82ec5760c894e91"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"806db7d41ed2bab701585d86b36676ff7648bcf6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  run_once: true"},{"line_number":28,"context_line":"  when: not ironic_upgrade_skip_wait_check | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(yoctozepto): Remove this task in Zed."},{"line_number":31,"context_line":"- name: Remove old Ironic containers"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  kolla_docker:"},{"line_number":34,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":35,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":36,"context_line":"    name: \"{{ item }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    # NOTE(yoctozepto): Removing conductor to avoid it"},{"line_number":39,"context_line":"    # thinking that the tftp and http servers are available."},{"line_number":40,"context_line":"    - ironic_conductor"},{"line_number":41,"context_line":"    - ironic_pxe"},{"line_number":42,"context_line":"    - ironic_ipxe"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- include_tasks: rolling_upgrade.yml"},{"line_number":45,"context_line":"  when: ironic_enable_rolling_upgrade | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fedea60b_dbf6713e","side":"PARENT","line":42,"range":{"start_line":30,"start_character":0,"end_line":42,"end_character":17},"in_reply_to":"2a1416a2_1bd3364c","updated":"2022-11-09 10:08:27.000000000","message":"No, it has already happened. I think a reno now would be confusing/adding extra content to read for no good reason. \n\nIf you think a reno is required, please propose its contents. Thanks.","commit_id":"4c60cc524ca2b11dae6a0527c82ec5760c894e91"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2afa5c1090c9e999bbc851b7b94096a0eedcdab7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  run_once: true"},{"line_number":28,"context_line":"  when: not ironic_upgrade_skip_wait_check | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(yoctozepto): Remove this task in Zed."},{"line_number":31,"context_line":"- name: Remove old Ironic containers"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  kolla_docker:"},{"line_number":34,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":35,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":36,"context_line":"    name: \"{{ item }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    # NOTE(yoctozepto): Removing conductor to avoid it"},{"line_number":39,"context_line":"    # thinking that the tftp and http servers are available."},{"line_number":40,"context_line":"    - ironic_conductor"},{"line_number":41,"context_line":"    - ironic_pxe"},{"line_number":42,"context_line":"    - ironic_ipxe"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- include_tasks: rolling_upgrade.yml"},{"line_number":45,"context_line":"  when: ironic_enable_rolling_upgrade | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"91c00b32_ad352bca","side":"PARENT","line":42,"range":{"start_line":30,"start_character":0,"end_line":42,"end_character":17},"in_reply_to":"fedea60b_dbf6713e","updated":"2022-11-09 10:50:39.000000000","message":"hmm ok","commit_id":"4c60cc524ca2b11dae6a0527c82ec5760c894e91"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"145d56af0955b2f8c6bc240c3e554f765f9d8283","unresolved":true,"context_lines":[{"line_number":47,"context_line":"- include_tasks: legacy_upgrade.yml"},{"line_number":48,"context_line":"  when: not ironic_enable_rolling_upgrade | bool"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# TODO(yoctozepto): Remove this task in Zed."},{"line_number":51,"context_line":"- name: Remove old Ironic volumes"},{"line_number":52,"context_line":"  become: true"},{"line_number":53,"context_line":"  kolla_docker:"},{"line_number":54,"context_line":"    action: \"remove_volume\""},{"line_number":55,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":56,"context_line":"    name: \"{{ item }}\""},{"line_number":57,"context_line":"  with_items:"},{"line_number":58,"context_line":"    - ironic_pxe"},{"line_number":59,"context_line":"    - ironic_ipxe"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8cb8340e_495f244a","side":"PARENT","line":59,"range":{"start_line":50,"start_character":0,"end_line":59,"end_character":17},"updated":"2022-11-08 18:47:42.000000000","message":"ditto","commit_id":"4c60cc524ca2b11dae6a0527c82ec5760c894e91"}]}
