)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f134437b227431955385bf3646e9b63bf12089d1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60i [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9630fadf_b3a62296","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":55},"updated":"2022-10-21 09:13:51.000000000","message":"60i means 60 intervals?","commit_id":"d413169071e769731e71959864846183b999d55a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d471879c7e2299330f19f0b6853b930d78c9f9bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60i [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f0adfc1_e4878adc","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":55},"in_reply_to":"15de1956_bf6309a4","updated":"2022-11-16 01:45:38.000000000","message":"Done","commit_id":"d413169071e769731e71959864846183b999d55a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d41100d9d9836bdb42b5916cd179669acc23c9a1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60i [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"15de1956_bf6309a4","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":55},"in_reply_to":"9630fadf_b3a62296","updated":"2022-10-21 11:32:17.000000000","message":"Yeah, it\u0027s a typo... (i from VIM insert mode ... :( ), thanks, i will fix.","commit_id":"d413169071e769731e71959864846183b999d55a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"37e8615416ca3af971d02652e187c46edf7b5ded","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"2a6a5e8b_356d1e71","line":9,"updated":"2022-11-16 15:27:36.000000000","message":"Here I\u0027m also interested to learn what value you want to set this to and why. The largescale sig seems to agree that the default value is fine https://docs.openstack.org/large-scale/journey/configure/rabbitmq.html#net-ticktime-and-heartbeat","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"64a82a1536c138c33824e14a2957dd155984932d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"e6b25caf_f94d415f","line":9,"in_reply_to":"2a6a5e8b_356d1e71","updated":"2022-11-16 16:27:53.000000000","message":"I cannot fulfill every wish, that\u0027s the reason why *I\u0027m not changing or adding value* to configuration. I am just adding ability to configure it if needed.\n\nIn our case it was needed to amend it.\nI asked my colleguage to reply to this thread, so let\u0027s wait for him.","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e7be57535437a656b099334a8f77a31935078031","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"90fb247c_561266fb","line":9,"in_reply_to":"2a6a5e8b_356d1e71","updated":"2022-11-16 16:24:59.000000000","message":"in our production we use\nheartbeat_rate \u003d 2\nheartbeat_timeout_threshold \u003d 0\nin the cloud with \u003e5000 VMs","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":22072,"name":"Viktor Křivák","email":"viktor.krivak@ultimum.io","username":"viktor-krivak"},"change_message_id":"adef01a61b1de197625b57c9e7a12097ba2e66c9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dfc1c586_bb5a1623","line":9,"in_reply_to":"866c202f_667e2e31","updated":"2022-11-22 18:51:11.000000000","message":"This is our old log from RabbitMQ, we occasionally lost some heartbeat which caused connection drop and sometime it was so severe that it cause also timeout on Nova API:\n2022-06-14 09:52:24.839 [error] \u003c0.10088.251\u003e closing AMQP connection \u003c0.10088.251\u003e (10.0.0.14:35620 -\u003e 10.0.0.16:5672 - nova-conductor:738:51619cda-d7e1-4f43-ac53-e8f6ded320fc):\nmissed heartbeats from client, timeout: 60s\n2022-06-14 09:52:24.839 [error] \u003c0.7110.251\u003e closing AMQP connection \u003c0.7110.251\u003e (10.0.0.14:35622 -\u003e 10.0.0.16:5672 - nova-conductor:738:c804cc2d-83ec-4ff8-a261-a0cb9364dcd2):\nmissed heartbeats from client, timeout: 60s\n2022-06-14 09:53:17.889 [error] \u003c0.6755.251\u003e closing AMQP connection \u003c0.6755.251\u003e (10.0.0.13:38028 -\u003e 10.0.0.16:5672 - nova-conductor:729:787b0946-2260-455b-8890-4840983919ae):\nmissed heartbeats from client, timeout: 60s\n\n\nAfter we change configuration to\n[oslo_messaging_rabbit]\nheartbeat_timeout_threshold\u003d120\nheartbeat_rate\u003d8\n\nThe problem just disappear, since is is a big cluster and configuration just works, we don\u0027t experiment with different configuration.\nNote that this configuration was done on client side, but to make it work you also need to change defaults in RabbitMQ itself since timeout parameter is negotiated (https://www.rabbitmq.com/heartbeats.html#heartbeats-timeout).","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77b62d73d5daeea1b56e9e854d6c039e99623d64","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a17d853b_57457e8d","line":9,"in_reply_to":"90fb247c_561266fb","updated":"2022-11-16 16:26:15.000000000","message":"@Michal it would be great if yo add heartbeat_timeout_threshold too","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cae4ded601f30fae60b6b7e84244e9e00b1d27c1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds ability to configure Rabbitmq\u0027s heartbeat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default Rabbitmq\u0027s default value of heartbeat is 60 [1]."},{"line_number":10,"context_line":"This should be configurable via kolla-ansible as every"},{"line_number":11,"context_line":"openstack deployment can be different in terms of network"},{"line_number":12,"context_line":"delays, bandwith, number of messages etc.. , so user should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"866c202f_667e2e31","line":9,"in_reply_to":"e6b25caf_f94d415f","updated":"2022-11-22 14:51:56.000000000","message":"One more thing : \n\nFrickler, they don\u0027t agree - They are *considering* and that is difference :) (*We consider that the default values are good.*)\nAnd also they are saying - *This config mostly depends on the network you have between the nodes.*.\n\nAnd what I am saying in commit message ? Same \n\nThis should be configurable via kolla-ansible as every\nopenstack deployment can be different in terms of network\ndelays, bandwith, number of messages etc.\n\nWe have now 70+ nodes, 800 kubernetes clusters, 12000 volumes..","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7024ccf344f135ce6b671d5b3da18b602b94db3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"473003d9_fa9b3ad9","updated":"2022-10-25 12:59:23.000000000","message":"recheck","commit_id":"b5febeae0548283db232b4fc7ae60ccb05bc06d7"},{"author":{"_account_id":34533,"name":"Ramona Beermann","display_name":"ra-beer","email":"ramona.beermann@osism.tech","username":"ramonarautenberg"},"change_message_id":"a236ab1fb96c43c118cbf525fa46d41209e53916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"76e84422_cc479536","updated":"2022-11-16 08:10:27.000000000","message":"LGTM","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8705789ea8457595908fdfe8831fe69dee4c6935","unresolved":true,"context_lines":[{"line_number":84,"context_line":"rabbitmq_tls_options: {}"},{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_heartbeat: \"60\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"97395ee0_04919a04","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":24},"updated":"2022-10-25 14:31:23.000000000","message":"set it to an empty value and do {% if rabbitmq_heartbeat | length \u003e 0 %} in template (or similar). We don\u0027t want to track if that default changes in future in RMQ.","commit_id":"b5febeae0548283db232b4fc7ae60ccb05bc06d7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d471879c7e2299330f19f0b6853b930d78c9f9bb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"rabbitmq_tls_options: {}"},{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_heartbeat: \"60\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"776fcf7a_5e3d3eed","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":24},"in_reply_to":"7dda920a_64314c06","updated":"2022-11-16 01:45:38.000000000","message":"Done","commit_id":"b5febeae0548283db232b4fc7ae60ccb05bc06d7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"035bca3d5572de5e988ec19b99199779ffaa64d4","unresolved":true,"context_lines":[{"line_number":84,"context_line":"rabbitmq_tls_options: {}"},{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_heartbeat: \"60\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7dda920a_64314c06","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":24},"in_reply_to":"97395ee0_04919a04","updated":"2022-10-25 15:23:10.000000000","message":"Well, it is also question if kolla shouldn\u0027t provide some better value than default 60s rabbitmq, We had to change this value and I\u0027ve already seen some discussions in openstack-discuss regarding rabbitmq.","commit_id":"b5febeae0548283db232b4fc7ae60ccb05bc06d7"}],"ansible/roles/rabbitmq/templates/rabbitmq.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bb43be913fddd69f117819e3c3d1f738eb445bc3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"cluster_partition_handling \u003d {{ rabbitmq_cluster_partition_handling }}"},{"line_number":10,"context_line":"{% if rabbitmq_heartbeat is not none %}"},{"line_number":11,"context_line":"heartbeat \u003d {{ rabbitmq_heartbeat }}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"management.listener.ip \u003d {{ api_interface_address }}"},{"line_number":15,"context_line":"management.listener.port \u003d {{ role_rabbitmq_management_port }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"92142e8d_4054d8fc","line":12,"updated":"2022-11-22 15:06:43.000000000","message":"Something we did in the chef openstack cookbooks was to use a generic dict instead. Like call is rabbitmq_extra_options and then do (not sure about the exact syntax):\n\n{% for (key,value) in rabbitmq_extra_options %}\n{{ key }} \u003d {{ value }}\n{% endfor %}\n\nThis way you could add anything you need and we do not need to have a new option for every parameter that might need tuning. What do you think about that?","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4da10fd4440bbc776a40bf2c864bcf5dfa0ce1d6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"cluster_partition_handling \u003d {{ rabbitmq_cluster_partition_handling }}"},{"line_number":10,"context_line":"{% if rabbitmq_heartbeat is not none %}"},{"line_number":11,"context_line":"heartbeat \u003d {{ rabbitmq_heartbeat }}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"management.listener.ip \u003d {{ api_interface_address }}"},{"line_number":15,"context_line":"management.listener.port \u003d {{ role_rabbitmq_management_port }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"690f82f0_343a0414","line":12,"in_reply_to":"92142e8d_4054d8fc","updated":"2022-11-22 15:20:25.000000000","message":"Well, yes, i like it. My point is just there should be an option to configure rabbitmq configuration options.","commit_id":"bdae397732fc414dde08923d4c0f5055bd0aa3b2"}]}