)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"a7fcfbbe5b1a569fc1d3d3c4983e33bcc7905c66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"cb8c90e8_3985a8ab","updated":"2023-02-20 15:49:00.000000000","message":"recheck\n","commit_id":"9a14a306ca60ceab336452c1384156356e26d6a7"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fd98167ca2a4f2265f1b6f707ffe64929d62dbd2","unresolved":true,"context_lines":[{"line_number":374,"context_line":"    module \u003d generate_module()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    cw: ContainerWorker \u003d None"},{"line_number":377,"context_line":"    result \u003d None"},{"line_number":378,"context_line":"    try:"},{"line_number":379,"context_line":"        from ansible.module_utils.kolla_docker_worker import DockerWorker"},{"line_number":380,"context_line":"        cw \u003d DockerWorker(module)"}],"source_content_type":"text/x-python","patch_set":17,"id":"eb4a8af7_f208ead2","line":377,"updated":"2023-02-07 14:06:27.000000000","message":"do we use it?","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"2bde62ecb67cacaa88408c3747a8d48ef3fc0798","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    module \u003d generate_module()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    cw: ContainerWorker \u003d None"},{"line_number":377,"context_line":"    result \u003d None"},{"line_number":378,"context_line":"    try:"},{"line_number":379,"context_line":"        from ansible.module_utils.kolla_docker_worker import DockerWorker"},{"line_number":380,"context_line":"        cw \u003d DockerWorker(module)"}],"source_content_type":"text/x-python","patch_set":17,"id":"93f24b87_c6e13cc4","line":377,"in_reply_to":"eb4a8af7_f208ead2","updated":"2023-02-07 17:05:22.000000000","message":"Not really.","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fd98167ca2a4f2265f1b6f707ffe64929d62dbd2","unresolved":true,"context_lines":[{"line_number":376,"context_line":"    cw: ContainerWorker \u003d None"},{"line_number":377,"context_line":"    result \u003d None"},{"line_number":378,"context_line":"    try:"},{"line_number":379,"context_line":"        from ansible.module_utils.kolla_docker_worker import DockerWorker"},{"line_number":380,"context_line":"        cw \u003d DockerWorker(module)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # TODO(inc0): We keep it bool to have ansible deal with consistent"}],"source_content_type":"text/x-python","patch_set":17,"id":"d3567f84_07131841","line":379,"updated":"2023-02-07 14:06:27.000000000","message":"pep8 suggests to import at the start of file","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"2bde62ecb67cacaa88408c3747a8d48ef3fc0798","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    cw: ContainerWorker \u003d None"},{"line_number":377,"context_line":"    result \u003d None"},{"line_number":378,"context_line":"    try:"},{"line_number":379,"context_line":"        from ansible.module_utils.kolla_docker_worker import DockerWorker"},{"line_number":380,"context_line":"        cw \u003d DockerWorker(module)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # TODO(inc0): We keep it bool to have ansible deal with consistent"}],"source_content_type":"text/x-python","patch_set":17,"id":"1e8ce56d_3b7f47a2","line":379,"in_reply_to":"d3567f84_07131841","updated":"2023-02-07 17:05:22.000000000","message":"This import is leftover from original Podman patch but in context of this patch it does not make much sense. Also the ContainerWorker is fairly redundant here so I reverted this section to the original.","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"}],"ansible/module_utils/kolla_container_worker.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1af0a2fcbe0f711dac7f8abb58737f45860270c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":13,"id":"76fc5bc1_2ac74eb9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2023-02-01 14:26:44.000000000","message":"not needed","commit_id":"fc5a69350e68c10323b80e234d6953747e3a8fc6"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"b08ac122d12ae3171f6607fbc4bfb98d3bca7c04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":13,"id":"eccc9137_c3841483","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"76fc5bc1_2ac74eb9","updated":"2023-02-01 14:37:03.000000000","message":"Done","commit_id":"fc5a69350e68c10323b80e234d6953747e3a8fc6"}],"ansible/module_utils/kolla_docker_worker.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1af0a2fcbe0f711dac7f8abb58737f45860270c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2015 Sam Yaple"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"d64fda5b_f7da53cc","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2023-02-01 14:26:44.000000000","message":"let\u0027s drop it here as well","commit_id":"fc5a69350e68c10323b80e234d6953747e3a8fc6"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"b08ac122d12ae3171f6607fbc4bfb98d3bca7c04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2015 Sam Yaple"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"991bbbba_40b755b4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"d64fda5b_f7da53cc","updated":"2023-02-01 14:37:03.000000000","message":"Done","commit_id":"fc5a69350e68c10323b80e234d6953747e3a8fc6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fd98167ca2a4f2265f1b6f707ffe64929d62dbd2","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            return None"},{"line_number":105,"context_line":"        return self.dc.inspect_container(self.params.get(\u0027name\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def compare_container(self):"},{"line_number":108,"context_line":"        container \u003d self.check_container()"},{"line_number":109,"context_line":"        if (not container or"},{"line_number":110,"context_line":"                self.check_container_differs() or"}],"source_content_type":"text/x-python","patch_set":17,"id":"ded8e0be_4887f873","line":107,"updated":"2023-02-07 14:06:27.000000000","message":"looks generic enough to be in ContainerWorker?","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"2bde62ecb67cacaa88408c3747a8d48ef3fc0798","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            return None"},{"line_number":105,"context_line":"        return self.dc.inspect_container(self.params.get(\u0027name\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def compare_container(self):"},{"line_number":108,"context_line":"        container \u003d self.check_container()"},{"line_number":109,"context_line":"        if (not container or"},{"line_number":110,"context_line":"                self.check_container_differs() or"}],"source_content_type":"text/x-python","patch_set":17,"id":"210275cb_6735400c","line":107,"in_reply_to":"ded8e0be_4887f873","updated":"2023-02-07 17:05:22.000000000","message":"Yes.","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fd98167ca2a4f2265f1b6f707ffe64929d62dbd2","unresolved":true,"context_lines":[{"line_number":365,"context_line":"        self.changed \u003d True"},{"line_number":366,"context_line":"        options \u003d self.build_container_options()"},{"line_number":367,"context_line":"        self.dc.create_container(**options)"},{"line_number":368,"context_line":"        if not self.params.get(\u0027restart_policy\u0027) \u003d\u003d \u0027no\u0027:"},{"line_number":369,"context_line":"            self.changed |\u003d self.systemd.create_unit_file()"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def recreate_or_restart_container(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"01c410d5_04e7aff9","line":368,"updated":"2023-02-07 14:06:27.000000000","message":"I think that old version is more readable","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"2bde62ecb67cacaa88408c3747a8d48ef3fc0798","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self.changed \u003d True"},{"line_number":366,"context_line":"        options \u003d self.build_container_options()"},{"line_number":367,"context_line":"        self.dc.create_container(**options)"},{"line_number":368,"context_line":"        if not self.params.get(\u0027restart_policy\u0027) \u003d\u003d \u0027no\u0027:"},{"line_number":369,"context_line":"            self.changed |\u003d self.systemd.create_unit_file()"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def recreate_or_restart_container(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"2f7454cf_c0411d9d","line":368,"in_reply_to":"01c410d5_04e7aff9","updated":"2023-02-07 17:05:22.000000000","message":"Done","commit_id":"2f5a4e82ab31acd9154cd1f7e4f08b65fdd17ab2"}]}