)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8c981c443e121b9a9ceb8a9fa84bb86c887ceabb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"702de40c_c81599d3","updated":"2022-11-24 12:34:01.000000000","message":"I still think starting with an empty rabbitmq_extra_config would be the most simple path forward, which should solve your original issues, then we can discuss moving existing options in another patch. But feel free to wait for other reviews first.","commit_id":"00484e079893b4c4047a962bee307f2986b77740"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"628e2af50dcfa1df5003bb4e69b6e33bd68943e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53591bb5_9da34481","in_reply_to":"702de40c_c81599d3","updated":"2022-11-29 12:13:01.000000000","message":"Could you check now please ?","commit_id":"00484e079893b4c4047a962bee307f2986b77740"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c7085fe30bd1b01b296617563955b29e7b2d0b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c422df1d_b20dc772","updated":"2023-01-25 10:04:59.000000000","message":"Actually it would be useful to add that to docs (https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html) :-)","commit_id":"701dc20f507bfde6e08e6b77877c55b9335266f0"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e548d51765c9a59e8a011d6d25f9c032b111ddc4","unresolved":true,"context_lines":[{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f37f3b94_6886edfa","line":88,"updated":"2022-11-23 15:41:35.000000000","message":"Would likely need a deprecation step first but then we could drop the secondary variable and just set the default here directly?","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"188dd512a677abca04431c2430ae738f1cdab30f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"05a84971_6b7e5b67","line":88,"in_reply_to":"c205d3e9_f23a1f15","updated":"2022-11-29 12:12:33.000000000","message":"Done","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edca2f3028dfa13056913a2f90b408449602328f","unresolved":true,"context_lines":[{"line_number":85,"context_line":"# To avoid split-brain"},{"line_number":86,"context_line":"rabbitmq_cluster_partition_handling: \"pause_minority\""},{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c205d3e9_f23a1f15","line":88,"in_reply_to":"f37f3b94_6886edfa","updated":"2022-11-24 00:06:39.000000000","message":"Yeah, we can, let\u0027s fix this on the end.","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e548d51765c9a59e8a011d6d25f9c032b111ddc4","unresolved":true,"context_lines":[{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ed4f18d_64149b13","line":90,"updated":"2022-11-23 15:41:35.000000000","message":"This doesn\u0027t work I think, role_rabbitmq_management_port is set to different values in ansible/site.yaml where the role is applied twice.","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edca2f3028dfa13056913a2f90b408449602328f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3857ffb5_fdaf8d1c","line":90,"in_reply_to":"1ed4f18d_64149b13","updated":"2022-11-24 00:06:39.000000000","message":"It works, I\u0027ve already tested, i\u0027ve just moved from template to defaults, role var is \n\nrole_rabbitmq_management_port: \u0027{{ rabbitmq_management_port }}\n\nAnd rabbitmq_management_port is defined in group_vars/all.yml which is accessible everywhere, if you change this in globals, everything is working as before, see diff below : \n\n(kolla-ansible)[root]# cat /etc/kolla/globals.yml  | tail -n 1 \nrabbitmq_management_port: \"THIS_IS_JUST_TEST\"\n(kolla-ansible)[root]# kolla-ansible -i /etc/kolla/inventory genconfig -t rabbitmq --check --diff \nGenerate configuration files for enabled OpenStack services : ansible-playbook -e @/etc/kolla/globals.yml  -e @/etc/kolla/passwords.yml -e CONFIG_DIR\u003d/etc/kolla  --tags rabbitmq --check --diff -e kolla_action\u003dconfig /opt/kolla-ansible/ansible/site.yml  --inventory /etc/kolla/inventory\n[WARNING]: While constructing a mapping from /opt/kolla-configuration/kolla/globals.yml, line 3, column 1, found a duplicate dict key (enable_elasticsearch). Using last defined value only.\n[WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details\n\n\nTASK [haproxy-config : Copying over rabbitmq haproxy config] ******************************************************************************************************************************************************\n--- before: /etc/kolla/haproxy/services.d/rabbitmq.cfg\n+++ after: /root/.ansible/tmp/ansible-local-81698q2tdvmwn/tmpm_9r6lhs/haproxy_single_service_split.cfg.j2\n@@ -4,12 +4,12 @@\n     option httplog\n     option forwardfor\n     http-request set-header X-Forwarded-Proto https if { ssl_fc }\n-    bind 192.168.205.254:15672\n+    bind 192.168.205.254:THIS_IS_JUST_TEST\n     default_backend rabbitmq_management_back\n \n backend rabbitmq_management_back\n     mode http\n-    server controller0 192.168.205.10:15672 check inter 2000 rise 2 fall 5  \n-    server controller1 192.168.205.11:15672 check inter 2000 rise 2 fall 5  \n-    server controller2 192.168.205.12:15672 check inter 2000 rise 2 fall 5  \n+    server controller0 192.168.205.10:THIS_IS_JUST_TEST check inter 2000 rise 2 fall 5  \n+    server controller1 192.168.205.11:THIS_IS_JUST_TEST check inter 2000 rise 2 fall 5  \n+    server controller2 192.168.205.12:THIS_IS_JUST_TEST check inter 2000 rise 2 fall 5  \n\n .\n .\n .\n .\n\nTASK [rabbitmq : Copying over rabbitmq.conf] **********************************************************************************************************************************************************************\n--- before: /etc/kolla/rabbitmq/rabbitmq.conf\n+++ after: /root/.ansible/tmp/ansible-local-81698q2tdvmwn/tmpqbwva4vp/rabbitmq.conf.j2\n@@ -2,12 +2,11 @@\n # despite specifying port via colon, the url format (e.g. [fd::]) is not accepted\n listeners.tcp.1 \u003d 192.168.205.10:5672\n cluster_partition_handling \u003d autoheal\n+management.listener.ip \u003d 192.168.205.10\n+management.listener.port \u003d THIS_IS_JUST_TEST\n+management.load_definitions \u003d /etc/rabbitmq/definitions.json\n+cluster_formation.peer_discovery_backend \u003d rabbit_peer_discovery_classic_config\n \n-management.listener.ip \u003d 192.168.205.10\n-management.listener.port \u003d 15672\n-management.load_definitions \u003d /etc/rabbitmq/definitions.json\n-\n-cluster_formation.peer_discovery_backend \u003d rabbit_peer_discovery_classic_config\n cluster_formation.classic_config.nodes.0 \u003d rabbit@controller0\n cluster_formation.classic_config.nodes.1 \u003d rabbit@controller1\n cluster_formation.classic_config.nodes.2 \u003d rabbit@controller2\n.\n.\n.\n.\n\nSo, why it should not work ?\nAlso, check rendered config here https://zuul.opendev.org/t/openstack/build/a9b43fffbeeb44e0bc1b6fb47e2a0ec8/log/primary/logs/kolla_configs/rabbitmq/rabbitmq.conf","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e2b52dc1a4f1a03de94155b4de7c9fd273d5f560","unresolved":false,"context_lines":[{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f52fd830_71f37b92","line":90,"in_reply_to":"3857ffb5_fdaf8d1c","updated":"2022-11-24 00:08:44.000000000","message":"I removed not interesting logs and formatting doesn\u0027t work in diff ..but I hope you see it.","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d7ffbe91186a44afb30794b35a7e093cdd14c74c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"rabbitmq_extra_config:"},{"line_number":88,"context_line":"  cluster_partition_handling: \"{{ rabbitmq_cluster_partition_handling }}\""},{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"833120fb_5ca9e6ed","line":90,"in_reply_to":"f52fd830_71f37b92","updated":"2022-11-24 00:16:39.000000000","message":"The last thing I wanted to say (sorry for several messages) is that I can remove existing values from rabbitmq_extra_config and leave it empty (to template i will just add {% if rabbitmq_extra_config is not None %})","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e548d51765c9a59e8a011d6d25f9c032b111ddc4","unresolved":true,"context_lines":[{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"####################"},{"line_number":95,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bc1da39b_6b660f46","line":92,"updated":"2022-11-23 15:41:35.000000000","message":"Nit: better keep the dict sorted by keys for easier reading and updating","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edca2f3028dfa13056913a2f90b408449602328f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  management.listener.ip: \"{{ api_interface_address }}\""},{"line_number":90,"context_line":"  management.listener.port: \"{{ role_rabbitmq_management_port }}\""},{"line_number":91,"context_line":"  management.load_definitions: \"/etc/rabbitmq/definitions.json\""},{"line_number":92,"context_line":"  cluster_formation.peer_discovery_backend: \"rabbit_peer_discovery_classic_config\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"####################"},{"line_number":95,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"54157eff_f5398d37","line":92,"in_reply_to":"bc1da39b_6b660f46","updated":"2022-11-24 00:06:39.000000000","message":"Done","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"}],"ansible/roles/rabbitmq/templates/rabbitmq.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e548d51765c9a59e8a011d6d25f9c032b111ddc4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"management.listener.port \u003d {{ role_rabbitmq_management_port }}"},{"line_number":13,"context_line":"management.load_definitions \u003d /etc/rabbitmq/definitions.json"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cluster_formation.peer_discovery_backend \u003d rabbit_peer_discovery_classic_config"},{"line_number":16,"context_line":"{% for host in groups[role_rabbitmq_groups] %}"},{"line_number":17,"context_line":"cluster_formation.classic_config.nodes.{{ loop.index0 }} \u003d rabbit@{{ hostvars[host].ansible_facts.hostname }}"},{"line_number":18,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d54a2a34_f6bae181","side":"PARENT","line":15,"updated":"2022-11-23 15:41:35.000000000","message":"I\u0027m not sure we want to move this one, thematically it belongs to the \"for\" loop below, I don\u0027t think we should separate it.\n\nIn theory we could also go one step further and move all the logic and options from this template into the corresponding playbooks. I\u0027m not sure though how much of that would be considered useful, what do other reviewers think?\n\nPossibly start with just adding the extra part below and split moving any of the existing options into a second patch? That might make things cleaner.","commit_id":"83a51bbb302b1e1b9b24e61ffcc54467cc296122"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edca2f3028dfa13056913a2f90b408449602328f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"management.listener.port \u003d {{ role_rabbitmq_management_port }}"},{"line_number":13,"context_line":"management.load_definitions \u003d /etc/rabbitmq/definitions.json"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cluster_formation.peer_discovery_backend \u003d rabbit_peer_discovery_classic_config"},{"line_number":16,"context_line":"{% for host in groups[role_rabbitmq_groups] %}"},{"line_number":17,"context_line":"cluster_formation.classic_config.nodes.{{ loop.index0 }} \u003d rabbit@{{ hostvars[host].ansible_facts.hostname }}"},{"line_number":18,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"702a6633_d66b7a91","side":"PARENT","line":15,"in_reply_to":"d54a2a34_f6bae181","updated":"2022-11-24 00:06:39.000000000","message":"Ok, now it thematically belongs to for below.","commit_id":"83a51bbb302b1e1b9b24e61ffcc54467cc296122"}],"releasenotes/notes/rabbitmq-configuration-6b100a390734dc29.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e548d51765c9a59e8a011d6d25f9c032b111ddc4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability to configure rabbitmq."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca353b60_0f2a800f","line":4,"updated":"2022-11-23 15:41:35.000000000","message":"Well that\u0027s a bit terse and also kind of wrong, since some configuration options already existed earlier. I think this deserves some kind of prose describing the new option and how it works, almost like some small documentation for this patch.","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"188dd512a677abca04431c2430ae738f1cdab30f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability to configure rabbitmq."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7e454c7a_e0e371a2","line":4,"in_reply_to":"be4c4f89_2fe04462","updated":"2022-11-29 12:12:33.000000000","message":"Done","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"edca2f3028dfa13056913a2f90b408449602328f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability to configure rabbitmq."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be4c4f89_2fe04462","line":4,"in_reply_to":"ca353b60_0f2a800f","updated":"2022-11-24 00:06:39.000000000","message":"Ok, let\u0027s fix this on the end please.","commit_id":"83509db9477fc9e3980ea7bed1f05e7335d99b4b"}]}