)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2c33b3b57f0634f8e5db35ea64bb6ba487c64d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0042296e_80c8efd3","updated":"2022-12-14 16:48:18.000000000","message":"recheck","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"18f98c7339dda4851357eff833139587ced47e10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc0ba415_779277a2","updated":"2023-02-16 11:10:53.000000000","message":"why we cannot update existing policy? It was common administrator task to alter retention day period via kolla-ansible when curator was in place.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"be8ba00044b57b831312bffb44610e0a2acdc915","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca804f76_252ac356","in_reply_to":"0118ede5_7aee663a","updated":"2023-03-06 09:56:20.000000000","message":"\"If somebody wants to configure that in the UI - he doesn\u0027t need to set it in Kolla-Ansible.\"\n\nThis would be the workflow:\n\n1. User sets retention policy via UI and doesn\u0027t update Kolla Ansible config\n2. Someone reconfigures OpenSearch with Kolla Ansible for $reason\n3. Users retention policy setting is wiped out by Kolla Ansible\n\nI think that\u0027s broken.\n\nThere needs to be a line drawn somewhere with API operations. We aren\u0027t writing out a config file anymore like with Curator.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"816ea45f4dc18a9de3628a8617cc05cb0f5ed7bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d506fb7d_d9f1fe90","in_reply_to":"0e1b2b63_c02e1b98","updated":"2023-08-08 08:43:43.000000000","message":"Weighing in here a little late. My suggestion is to provide a flag to configure whether to override existing retention policies. That way you can choose between \"UI wins\" or \"kolla wins\".\n\nThe next argument of course would be over what the default should be, but hopefully that will be easier to compromise on if it can easily be changed.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f5bf4e3b0c6e1936392e24ceb0a1c469d14861e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f1c9466_b3666aff","in_reply_to":"3eeea5f6_55579936","updated":"2023-08-25 12:02:40.000000000","message":"Let\u0027s assume it\u0027s step one and we revisit that if we need to update the policy often (or somebody else contributes to it).\nI\u0027m fine with that - as long as it\u0027s documented that this is what Kolla-Ansible does and here\u0027s the link to OpenSearch docs on how to update the ISM/ILM later on.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a6d7df348ce2e3e541659c7f0c5624caaab55c6a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0118ede5_7aee663a","in_reply_to":"553f3b7e_d418dcd2","updated":"2023-03-06 09:21:46.000000000","message":"I strongly disagree, Kolla-Ansible is for configuration as code, if somebody wants to configure that in the UI - he doesn\u0027t need to set it in Kolla-Ansible.\nWe should still check what is the current setting and provide correct changed/not changed status in Ansible.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"86358676e1a71d12daf68c4780e26751d31a4acd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8e65886_db1b0ddf","in_reply_to":"5af9b7d4_cf258352","updated":"2023-03-06 10:29:47.000000000","message":"I fundamentally disagree. I think we should take full advantage of the UI and the documentation provided by OpenSearch for index state management. You\u0027re welcome to propose an alternative patch.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8709ef4f58d0001359a84bb032b62671dd325c58","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3eeea5f6_55579936","in_reply_to":"7cf1f9ff_3d7fff76","updated":"2023-08-25 11:33:02.000000000","message":"@Michal, are you happy with Mark\u0027s suggestion above? If so I can implement it.\n\nIt\u0027s one step further than the existing code for adding Grafana datasources via the API:\n\n[1] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/grafana/tasks/post_config.yml#L34","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8746797ad222a3f2bea353bb9fb2bb881a066bf7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1fd4036_42aa7fad","in_reply_to":"7f1c9466_b3666aff","updated":"2023-11-24 17:53:03.000000000","message":"I have spent some time looking at how to fail if we detect a change in the existing policy. It isn\u0027t straight forward, because when you read the active policy from OpenSearch, there are a handful of extra fields in the response. These fields are things like `_seq_no`, `_version`, `schema_version` and in some places `last_updated_time`. Nested objects in the existing policy are also re-ordered.\n\nI think we would need to do something like:\n\n1. Recursively strip out all additional fields added by OpenSearch from the active policy. This may be fragile, since new fields may be added in future OpenSearch releases.\n2. Sort the active policy and the configured policy using a custom Python filter.\n3. Hash the two policies in a custom Python filter, and fail if the hashes don\u0027t match\n\nAn improved solution would give you a proper diff of the policies. \n\nI don\u0027t have time to implement the above in the near future, but I have updated the documentation as requested.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"22e373d810d26ca86542e11d3a4310ef32e44206","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f36e86f0_39b7f370","in_reply_to":"b5688fe5_abf0b35b","updated":"2023-03-02 14:10:19.000000000","message":"I don\u0027t think that\u0027s what most users want.\nLet\u0027s default to overriding the policy and make an option to not do that.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ebaa5aae2c7abf03cee60007a0d62c0460e8fd06","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5af9b7d4_cf258352","in_reply_to":"ca804f76_252ac356","updated":"2023-03-06 10:02:41.000000000","message":"We\u0027re enabling Grafana datasources using an API call and disabling the getting started page also using an API - the same situation more or less.\nBasically this OpenSearch is deployed using Kolla-Ansible - so let it be managed via Kolla-Ansible, if you want to manage it in a different manner - deploy it using a different tool (or manually).","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ac0179a1152e1ca33ee184d55c7fbe167aa5ee57","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e1b2b63_c02e1b98","in_reply_to":"d2fdb83c_b62ab9e8","updated":"2023-03-06 10:45:02.000000000","message":"At the very least you\u0027ll need to provide a release note stating that we no longer set a default retention policy, and Elastic/Curator users upgrading to OpenSearch should configure a retention policy via the OpenSearch dashboards UI.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a62be9db22306ed936eebb29342a35987a4ddfa9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da3dac6c_98ba0b45","in_reply_to":"d506fb7d_d9f1fe90","updated":"2023-08-11 14:46:58.000000000","message":"I think we would need something like the following for the \u0027kolla wins\u0027 approach:\n\n- Diff the target retention policy with the active retention policy, ignoring some additional fields in the active policy\n- If the policy is different, extract seq_no and primary_term from the current active policy\n- Update the policy, incrementing the seq_no field\n- Apply the new policy to existing indices. This step, from what I understand is asynchronous, and may take longer than you would typically wait for an Ansible task to complete. Eg. in some cases the new policy isn\u0027t applied until existing transitions have completed.\n- When the previous step has completed, check that the policy has been updated on existing indices (correct seq_no). Due to the asynchronous nature of applying the new policy, this step would need to run after the first service reconfigure. It could be as simple as just checking the UI, which provides a good overview.\n\nIt\u0027s quite rare to change the retention policy in my experience. Perhaps once or twice in a few years? People using OpenSearch will already be logging into OpenSearch Dashboards to view logs. Using the UI to update an existing policy is a click away for most, and is already well documented externally.\n\nHaving said that, if there is overwhelming support for the \u0027kolla\u0027 wins case, I can implement it.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7349f1310f703e7b60dc7dd0e43d80ec78fda7bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2fdb83c_b62ab9e8","in_reply_to":"d8e65886_db1b0ddf","updated":"2023-03-06 10:36:45.000000000","message":"Fine by me, let\u0027s all set it via UI and forget about this patch.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"185cb85cd8391d01664efbfcf4385db8fc2a9198","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7cf1f9ff_3d7fff76","in_reply_to":"da3dac6c_98ba0b45","updated":"2023-08-14 09:08:41.000000000","message":"Ok, I can see that that would be a bit fiddly to automate and hard to maintain.\n\nIt does seem like there\u0027s value in having a sane configuration out of the box though, so my preference would be to keep the approach proposed here, and:\n\n- make it very clear that this can only create a retention policy, and it will not be updated.\n- fail if we detect a change in an existing policy","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a01954d47d9d2ad1d9a1d6cd956fcdae0c9a1a08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5688fe5_abf0b35b","in_reply_to":"dc0ba415_779277a2","updated":"2023-02-20 09:16:53.000000000","message":"What has changed here, is that unlike Elasticsearch Curator, you can configure retention policies in the OpenSearch dashboards web UI. It\u0027s a design decision to not revert changes people have made via the web UI (like dashboards etc).\n\nYou can still easily change the retention policy via the web UI once it\u0027s in place.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c09a1f85e867b6ed7077ca659c6fa0a41131da03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3e1aeb8_1615e4f2","in_reply_to":"e1fd4036_42aa7fad","updated":"2023-12-20 11:18:36.000000000","message":"let\u0027s address that in follow up change","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2873fda7b0b61658b025bd4f60b6e65e25b69308","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"553f3b7e_d418dcd2","in_reply_to":"f36e86f0_39b7f370","updated":"2023-03-06 09:19:03.000000000","message":"If you change it so Kolla Ansible overrides the UI, it effective makes the new UI pointless, since you can\u0027t make any changes via the UI unless you also update the Kolla config.\n\nI strongly think that now we have a UI in OpenSearch Dashboards to configure the retention settings, the UI should be the go-to place where the retention settings are managed. Kolla should just set a default to get people started, and then it\u0027s over to the UI. The UI also provides a place to check that everything is operating as it should be. People should be aware of it and use it.\n\nIf we make it optional, then we have two paths to test and an increased maintenance burden (more API calls).","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"9109eb0c18ee4da7904de8bbb3097d8b694f27c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c4883fa5_2508ac00","updated":"2023-12-20 14:54:16.000000000","message":"recheck - galaxy issues?","commit_id":"faa6c0b9069cd2fcf895773e72d78b0f9f8aef32"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"758113aa780ba875e1e88431935e2637c205afe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7c8aa453_0fe8539c","updated":"2023-12-21 09:00:27.000000000","message":"this is missing upgrade notes, especially since it\u0027s indicated that the currently used approach of taking over elasticsearch retention policies will go away in the future, but this information is hidden away and not reflected in the reno. So at some point in the future users need to do something. It would be great to have this already in the renos.\n\nalso the new docs are not linked in the reno, how is a user supposed to find them?\nI certainly don\u0027t diff our complete docs on upgrades to see what\u0027s changed.\n\nPlease keep in mind that there are users out there who don\u0027t read the complete source code before using kolla-ansible. 😊\n\nFeature and code wise this looks very good, just add one or two sentences in the reno, thanks.","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"}],"ansible/roles/opensearch/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"758113aa780ba875e1e88431935e2637c205afe7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"# Duration after which an index is staged for deletion. This is implemented"},{"line_number":64,"context_line":"# by closing the index. Whilst in this state the index contributes negligible"},{"line_number":65,"context_line":"# load on the cluster and may be manually re-opened if required."},{"line_number":66,"context_line":"# NOTE: We carry over legacy settings from ElasticSearch Curator if they"},{"line_number":67,"context_line":"# are set. This may be removed in a later release."},{"line_number":68,"context_line":"opensearch_soft_retention_period_days: \"{{ elasticsearch_curator_soft_retention_period_days | default(30) }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Duration after which an index is permanently erased from the cluster."},{"line_number":71,"context_line":"opensearch_hard_retention_period_days: \"{{ elasticsearch_curator_hard_retention_period_days | default(60) }}\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"opensearch_retention_policy: |"},{"line_number":74,"context_line":"  policy:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e0bd8251_e305c4bd","line":71,"range":{"start_line":66,"start_character":0,"end_line":71,"end_character":109},"updated":"2023-12-21 09:00:27.000000000","message":"this should be mentioned in the \"Upgrades\" part of the reno imho (which is missing)","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"263f6ccdf0d6a1890609df96c5ba656fba1d021d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# Duration after which an index is staged for deletion. This is implemented"},{"line_number":64,"context_line":"# by closing the index. Whilst in this state the index contributes negligible"},{"line_number":65,"context_line":"# load on the cluster and may be manually re-opened if required."},{"line_number":66,"context_line":"# NOTE: We carry over legacy settings from ElasticSearch Curator if they"},{"line_number":67,"context_line":"# are set. This may be removed in a later release."},{"line_number":68,"context_line":"opensearch_soft_retention_period_days: \"{{ elasticsearch_curator_soft_retention_period_days | default(30) }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Duration after which an index is permanently erased from the cluster."},{"line_number":71,"context_line":"opensearch_hard_retention_period_days: \"{{ elasticsearch_curator_hard_retention_period_days | default(60) }}\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"opensearch_retention_policy: |"},{"line_number":74,"context_line":"  policy:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cae4eb45_8da529d7","line":71,"range":{"start_line":66,"start_character":0,"end_line":71,"end_character":109},"in_reply_to":"8dc932b1_82081277","updated":"2023-12-21 09:51:53.000000000","message":"Done","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2dc1885a0f270bb8da214b4ac68bee24f772f64","unresolved":true,"context_lines":[{"line_number":63,"context_line":"# Duration after which an index is staged for deletion. This is implemented"},{"line_number":64,"context_line":"# by closing the index. Whilst in this state the index contributes negligible"},{"line_number":65,"context_line":"# load on the cluster and may be manually re-opened if required."},{"line_number":66,"context_line":"# NOTE: We carry over legacy settings from ElasticSearch Curator if they"},{"line_number":67,"context_line":"# are set. This may be removed in a later release."},{"line_number":68,"context_line":"opensearch_soft_retention_period_days: \"{{ elasticsearch_curator_soft_retention_period_days | default(30) }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Duration after which an index is permanently erased from the cluster."},{"line_number":71,"context_line":"opensearch_hard_retention_period_days: \"{{ elasticsearch_curator_hard_retention_period_days | default(60) }}\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"opensearch_retention_policy: |"},{"line_number":74,"context_line":"  policy:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8dc932b1_82081277","line":71,"range":{"start_line":66,"start_character":0,"end_line":71,"end_character":109},"in_reply_to":"e0bd8251_e305c4bd","updated":"2023-12-21 09:24:49.000000000","message":"It\u0027s a bug, it will be back ported all the way to Yoga - I have no clue if we need to add it in upgrade: - it can be in any section that for now we\u0027re using these variables.","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"}],"ansible/roles/opensearch/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"185cb85cd8391d01664efbfcf4385db8fc2a9198","unresolved":true,"context_lines":[{"line_number":11,"context_line":"- name: Flush handlers"},{"line_number":12,"context_line":"  meta: flush_handlers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- import_tasks: post-config.yml"},{"line_number":15,"context_line":"  when: opensearch_apply_log_retention_policy | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8c050fcb_ceb7850c","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":14},"updated":"2023-08-14 09:08:41.000000000","message":"include_tasks","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Flush handlers"},{"line_number":12,"context_line":"  meta: flush_handlers"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- import_tasks: post-config.yml"},{"line_number":15,"context_line":"  when: opensearch_apply_log_retention_policy | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"55247314_8c0e125b","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":14},"in_reply_to":"8c050fcb_ceb7850c","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"}],"ansible/roles/opensearch/tasks/post-config.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"58205969de18ed6a203cdac0c011a9275324eb7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Wait for OpenSearch to become ready"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4cfa6171_a45bb254","line":2,"updated":"2023-02-16 11:11:00.000000000","message":"nit: empty line","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4652835d7a5d84873c8efe8c05be1a3cc7ad72ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Wait for OpenSearch to become ready"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fba9fd42_cfe2578b","line":2,"in_reply_to":"4cfa6171_a45bb254","updated":"2023-02-20 09:18:50.000000000","message":"Done","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"758113aa780ba875e1e88431935e2637c205afe7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027opensearch\u0027][0] }}\""},{"line_number":28,"context_line":"  run_once: true"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Create new log retention policy"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  kolla_toolbox:"},{"line_number":33,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":34,"context_line":"    module_name: uri"},{"line_number":35,"context_line":"    module_args:"},{"line_number":36,"context_line":"      url: \"{{ opensearch_internal_endpoint }}/_plugins/_ism/policies/retention\""},{"line_number":37,"context_line":"      method: PUT"},{"line_number":38,"context_line":"      status_code: 201"},{"line_number":39,"context_line":"      return_content: yes"},{"line_number":40,"context_line":"      body: \"{{ opensearch_retention_policy | from_yaml | to_json }}\""},{"line_number":41,"context_line":"      body_format: json"},{"line_number":42,"context_line":"  register: opensearch_retention_policy_create"},{"line_number":43,"context_line":"  delegate_to: \"{{ groups[\u0027opensearch\u0027][0] }}\""},{"line_number":44,"context_line":"  run_once: true"},{"line_number":45,"context_line":"  changed_when: opensearch_retention_policy_create.status \u003d\u003d 201"},{"line_number":46,"context_line":"  when: opensearch_retention_policy_check.status \u003d\u003d 404"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Apply retention policy to existing indicies"},{"line_number":49,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4d2c0ec6_d84c9a9e","line":46,"range":{"start_line":30,"start_character":0,"end_line":46,"end_character":55},"updated":"2023-12-21 09:00:27.000000000","message":"I can\u0027t see any form of authentication here. So forgive me my naive question, but can we set arbitrary log retention policys from the \"internal\" network without authentication?","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2dc1885a0f270bb8da214b4ac68bee24f772f64","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027opensearch\u0027][0] }}\""},{"line_number":28,"context_line":"  run_once: true"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Create new log retention policy"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  kolla_toolbox:"},{"line_number":33,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":34,"context_line":"    module_name: uri"},{"line_number":35,"context_line":"    module_args:"},{"line_number":36,"context_line":"      url: \"{{ opensearch_internal_endpoint }}/_plugins/_ism/policies/retention\""},{"line_number":37,"context_line":"      method: PUT"},{"line_number":38,"context_line":"      status_code: 201"},{"line_number":39,"context_line":"      return_content: yes"},{"line_number":40,"context_line":"      body: \"{{ opensearch_retention_policy | from_yaml | to_json }}\""},{"line_number":41,"context_line":"      body_format: json"},{"line_number":42,"context_line":"  register: opensearch_retention_policy_create"},{"line_number":43,"context_line":"  delegate_to: \"{{ groups[\u0027opensearch\u0027][0] }}\""},{"line_number":44,"context_line":"  run_once: true"},{"line_number":45,"context_line":"  changed_when: opensearch_retention_policy_create.status \u003d\u003d 201"},{"line_number":46,"context_line":"  when: opensearch_retention_policy_check.status \u003d\u003d 404"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Apply retention policy to existing indicies"},{"line_number":49,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ce2d537b_3601777e","line":46,"range":{"start_line":30,"start_character":0,"end_line":46,"end_character":55},"in_reply_to":"4d2c0ec6_d84c9a9e","updated":"2023-12-21 09:24:49.000000000","message":"OpenSearch in K-A does not support TLS today, which is a requirement for authentication.","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"}],"ansible/roles/opensearch/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"185cb85cd8391d01664efbfcf4385db8fc2a9198","unresolved":true,"context_lines":[{"line_number":100,"context_line":"- name: Flush handlers"},{"line_number":101,"context_line":"  meta: flush_handlers"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- import_tasks: post-config.yml"},{"line_number":104,"context_line":"  when: opensearch_apply_log_retention_policy | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0779724f_7bf628d5","line":103,"updated":"2023-08-14 09:08:41.000000000","message":"include_tasks","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"- name: Flush handlers"},{"line_number":101,"context_line":"  meta: flush_handlers"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- import_tasks: post-config.yml"},{"line_number":104,"context_line":"  when: opensearch_apply_log_retention_policy | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f9bed8c2_9996c105","line":103,"in_reply_to":"0779724f_7bf628d5","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"}],"doc/source/reference/logging-and-monitoring/central-logging-guide.rst":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"58205969de18ed6a203cdac0c011a9275324eb7a","unresolved":true,"context_lines":[{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Note that by design, it is not possible to an update an existing retention"},{"line_number":64,"context_line":"policy via Kolla Ansible. This is to prevent policy changes that may have"},{"line_number":65,"context_line":"been made via the OpenSearch API from being wiped out. You can"},{"line_number":66,"context_line":"work around this by first removing the policy via the OpenSearch Dashboards"},{"line_number":67,"context_line":"UI, before re-applying the updated policy with Kolla Ansible."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"OpenSearch Dashboards"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1b8e4baf_28516919","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":61},"updated":"2023-02-16 11:11:00.000000000","message":"can\u0027t we just fetch the current policy and compare it to the one set in kolla-ansible?","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4652835d7a5d84873c8efe8c05be1a3cc7ad72ea","unresolved":false,"context_lines":[{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Note that by design, it is not possible to an update an existing retention"},{"line_number":64,"context_line":"policy via Kolla Ansible. This is to prevent policy changes that may have"},{"line_number":65,"context_line":"been made via the OpenSearch API from being wiped out. You can"},{"line_number":66,"context_line":"work around this by first removing the policy via the OpenSearch Dashboards"},{"line_number":67,"context_line":"UI, before re-applying the updated policy with Kolla Ansible."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"OpenSearch Dashboards"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f1fbd2ec_5e93c6cb","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":61},"in_reply_to":"1b8e4baf_28516919","updated":"2023-02-20 09:18:50.000000000","message":"I\u0027ve fixed the wording slightly. Please also see reply to Bartosz.","commit_id":"37ab072376ace74ca86ade86e56bf0cfbcd7705f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"185cb85cd8391d01664efbfcf4385db8fc2a9198","unresolved":true,"context_lines":[{"line_number":53,"context_line":"configured ``elasticsearch_curator_soft_retention_period_days`` or"},{"line_number":54,"context_line":"``elasticsearch_curator_hard_retention_period_days``, those variables will"},{"line_number":55,"context_line":"be used instead of the defaults. You should migrate your configuration to"},{"line_number":56,"context_line":"use the new variable names before the B release."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Advanced users may wish to customise the retention policy, which"},{"line_number":59,"context_line":"is possible by overriding ``opensearch_retention_policy`` with"}],"source_content_type":"text/x-rst","patch_set":4,"id":"72e3a1c4_28e7a794","line":56,"updated":"2023-08-14 09:08:41.000000000","message":"Bobcat","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"configured ``elasticsearch_curator_soft_retention_period_days`` or"},{"line_number":54,"context_line":"``elasticsearch_curator_hard_retention_period_days``, those variables will"},{"line_number":55,"context_line":"be used instead of the defaults. You should migrate your configuration to"},{"line_number":56,"context_line":"use the new variable names before the B release."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Advanced users may wish to customise the retention policy, which"},{"line_number":59,"context_line":"is possible by overriding ``opensearch_retention_policy`` with"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cb54ce2b_6923f586","line":56,"in_reply_to":"72e3a1c4_28e7a794","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f5bf4e3b0c6e1936392e24ceb0a1c469d14861e4","unresolved":true,"context_lines":[{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Note that by design, it is not possible to an update an existing retention"},{"line_number":64,"context_line":"policy via Kolla Ansible. This is to prevent policy changes that may have"},{"line_number":65,"context_line":"been made via the OpenSearch Dashboards UI from being wiped out. You can"},{"line_number":66,"context_line":"work around this by first removing the policy via the OpenSearch Dashboards"},{"line_number":67,"context_line":"UI, before re-applying the updated policy with Kolla Ansible."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"OpenSearch Dashboards"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cf93d935_cf4d7cc3","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":61},"updated":"2023-08-25 12:02:40.000000000","message":"Can we have a link here to a guide how to update it?","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Note that by design, it is not possible to an update an existing retention"},{"line_number":64,"context_line":"policy via Kolla Ansible. This is to prevent policy changes that may have"},{"line_number":65,"context_line":"been made via the OpenSearch Dashboards UI from being wiped out. You can"},{"line_number":66,"context_line":"work around this by first removing the policy via the OpenSearch Dashboards"},{"line_number":67,"context_line":"UI, before re-applying the updated policy with Kolla Ansible."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"OpenSearch Dashboards"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6ef9db9d_c56d8195","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":61},"in_reply_to":"cf93d935_cf4d7cc3","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"bfecce94d7c301152cef036775d46d9e51b4207d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c5e41e87a7288768af20f56ed195fabe1510b6f1","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Advanced users may wish to customise the retention policy, which"},{"line_number":59,"context_line":"is possible by overriding ``opensearch_retention_policy`` with"},{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Updating log retention policies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7e7444b2_914d0dc4","line":60,"range":{"start_line":60,"start_character":64,"end_line":60,"end_character":109},"updated":"2023-11-27 18:10:17.000000000","message":"nit: this link expands to `https://opensearch.org/docs/latest/im-plugin/index/` in my browser. should we use that instead?","commit_id":"dca8fc37e94c345de8f40f072185c5595715a1b9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Advanced users may wish to customise the retention policy, which"},{"line_number":59,"context_line":"is possible by overriding ``opensearch_retention_policy`` with"},{"line_number":60,"context_line":"a valid policy. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":61,"context_line":"for further details."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Updating log retention policies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"83918a68_e972eaee","line":60,"range":{"start_line":60,"start_character":64,"end_line":60,"end_character":109},"in_reply_to":"7e7444b2_914d0dc4","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"dca8fc37e94c345de8f40f072185c5595715a1b9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c5e41e87a7288768af20f56ed195fabe1510b6f1","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There are three options for modifying an existing policy:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"1. Via the OpenSearch Dashboards UI. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":74,"context_line":"for further details."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"2. Via the OpenSearch API using external tooling."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fbdb6bf_54469734","line":73,"range":{"start_line":73,"start_character":85,"end_line":73,"end_character":130},"updated":"2023-11-27 18:10:17.000000000","message":"see above","commit_id":"dca8fc37e94c345de8f40f072185c5595715a1b9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"acc6dd9f7a80caefbcd746707f4b10cc4ce330fc","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There are three options for modifying an existing policy:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"1. Via the OpenSearch Dashboards UI. See the `Index Management plugin documentation \u003chttps://opensearch.org/docs/latest/im-plugin/\u003e`__"},{"line_number":74,"context_line":"for further details."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"2. Via the OpenSearch API using external tooling."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1e7cb6d5_3f96cb2c","line":73,"range":{"start_line":73,"start_character":85,"end_line":73,"end_character":130},"in_reply_to":"9fbdb6bf_54469734","updated":"2023-12-20 11:18:05.000000000","message":"Done","commit_id":"dca8fc37e94c345de8f40f072185c5595715a1b9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"758113aa780ba875e1e88431935e2637c205afe7","unresolved":true,"context_lines":[{"line_number":34,"context_line":"   ``opensearch`` to store the data of OpenSearch. The path can be set via"},{"line_number":35,"context_line":"   the variable ``opensearch_datadir_volume``."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Applying log retention policies"},{"line_number":38,"context_line":"-------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To stop your disks filling up, the Index State Management plugin for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"d2632a62_833b7ce4","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":2},"updated":"2023-12-21 09:00:27.000000000","message":"the new docs should at least get a honorable mention in the renos, nobody is going to diff our whole documentation when upgrading.\n\npeople will read the release notes, at least put a link there and one or two sentences what to do when upgrading.","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"263f6ccdf0d6a1890609df96c5ba656fba1d021d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   ``opensearch`` to store the data of OpenSearch. The path can be set via"},{"line_number":35,"context_line":"   the variable ``opensearch_datadir_volume``."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Applying log retention policies"},{"line_number":38,"context_line":"-------------------------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To stop your disks filling up, the Index State Management plugin for"}],"source_content_type":"text/x-rst","patch_set":11,"id":"52fd079d_561c4b6a","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":2},"in_reply_to":"d2632a62_833b7ce4","updated":"2023-12-21 09:51:53.000000000","message":"Done","commit_id":"3a51e696b9e81c6fd0fd54437de02fbbcf3e74e9"}],"releasenotes/notes/opensearch-log-retention-598c3389456a67e6.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d2fb2bf7d011b771f9c0e4dde2a3d0c952267bbb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b0e94a56_f3cf7546","line":9,"range":{"start_line":7,"start_character":4,"end_line":9,"end_character":1},"updated":"2023-12-20 16:45:48.000000000","message":"bug URL is missing:\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2047037","commit_id":"faa6c0b9069cd2fcf895773e72d78b0f9f8aef32"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"8122f305b4572752a4468ebbdafaf7efebbe6c03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f46f239f_9f8e59d8","line":9,"range":{"start_line":7,"start_character":4,"end_line":9,"end_character":1},"in_reply_to":"b0e94a56_f3cf7546","updated":"2023-12-21 08:42:43.000000000","message":"Done","commit_id":"faa6c0b9069cd2fcf895773e72d78b0f9f8aef32"}]}