)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4f4f82e16a7077f2592408cd66acbab8b884ec87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"48220773_40e1946b","updated":"2023-01-06 15:24:04.000000000","message":"This looks good overall. I think we should at least warn about the feature going away in Rabbit 4.0. The other suggestions could be follow ups.","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2f0a2199e17580a4c96601b99d1e8803c5d56a9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2e19e009_d536c7e6","updated":"2023-01-10 12:33:08.000000000","message":"If we want to backport this, is Michal going to ask for a bug report again? 😊","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"111821eba15cf5370de1b1a8f52d0013c219c004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b07e93b4_7713788e","updated":"2023-01-10 12:44:28.000000000","message":"Missing a doc entry in doc/source/reference/message-queues/rabbitmq.rst","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"be8efa085d4d69fc1c364abc449180f11cebf233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a1e5f14a_ec02946f","in_reply_to":"2e19e009_d536c7e6","updated":"2023-01-10 12:41:39.000000000","message":"Well, this is not a bug - the other one was ;-) But I assume you\u0027d want to lure some non-SHPC reviewer into getting that merged in stable branches ;-)","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f3f9be53a0c956f2058a0230272c31781094b950","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f9258b62_3f6147bb","in_reply_to":"4b48924a_777ea874","updated":"2023-01-10 13:49:23.000000000","message":"I\u0027ve added a basic description, happy to expand into more detail if that would be preferable.","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"114d704a0fe5ebccae3936c1d5c076cf7d144bc1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4b48924a_777ea874","in_reply_to":"5411638a_d67d3615","updated":"2023-01-10 13:17:35.000000000","message":"Probably the former.","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"387f3feb21845a4579b0d93e3a22cdb17a9e2b78","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5411638a_d67d3615","in_reply_to":"b07e93b4_7713788e","updated":"2023-01-10 12:45:00.000000000","message":"or high-availability","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0099ff4c3105465d1c58d6fb9a3badc65c9c888e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"903cd1d5_b2205803","in_reply_to":"f9258b62_3f6147bb","updated":"2023-01-13 12:28:06.000000000","message":"Done","commit_id":"1581e2709f608e8bcd35e23f69bd58b95d6c0014"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4090d5aff0279ce3aafb23d5f17d11ad081c65c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5da49542_8bed76d7","updated":"2023-01-13 10:58:38.000000000","message":"Let\u0027s merge it in small steps , another patchset should be merged I think -\u003e https://review.opendev.org/c/openstack/kolla-ansible/+/822135 \u003c- I will rebase.","commit_id":"2c32919ed0f9301b1380bb7a476012ef5b6ea40c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2a095b679ff86bd1c76d53b5f47521f79d3fd86f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7ba9b9fa_0782ba3e","updated":"2023-01-13 12:08:35.000000000","message":"Should we change the default to true for people upgrading to Antelope?","commit_id":"2c32919ed0f9301b1380bb7a476012ef5b6ea40c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a880cb622bd3d719cdd39191cc9cd1391cdf133a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f6dbb36_900175ec","updated":"2023-01-11 10:04:36.000000000","message":"recheck","commit_id":"2c32919ed0f9301b1380bb7a476012ef5b6ea40c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"44062d2e02eace6414146df7b7e67e334c3cf372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b006ee32_04d0ec87","updated":"2023-01-13 12:27:53.000000000","message":"recheck (ovh nodes don\u0027t have private_ipv4 address, asked on #opendev, but let\u0027s see if it fails again)","commit_id":"2c32919ed0f9301b1380bb7a476012ef5b6ea40c"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"365890018e84058700a4acb5492021ef1afdc661","unresolved":true,"context_lines":[{"line_number":234,"context_line":"# CA certificate bundle in containers using oslo.messaging with RabbitMQ TLS."},{"line_number":235,"context_line":"om_rabbitmq_cacert: \"{{ rabbitmq_cacert }}\""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"####################"},{"line_number":240,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3d084f2d_9ef1babe","line":237,"updated":"2022-12-15 10:05:10.000000000","message":"Needs a reno, change of default.","commit_id":"0ba745a8a56a51b0bc0a52cd8eb50d2b34465763"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a577e9701de5334833811d89327ee9b96e2beeb6","unresolved":false,"context_lines":[{"line_number":234,"context_line":"# CA certificate bundle in containers using oslo.messaging with RabbitMQ TLS."},{"line_number":235,"context_line":"om_rabbitmq_cacert: \"{{ rabbitmq_cacert }}\""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"####################"},{"line_number":240,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"970202b2_e7354ee3","line":237,"in_reply_to":"3d084f2d_9ef1babe","updated":"2022-12-15 10:32:38.000000000","message":"Done","commit_id":"0ba745a8a56a51b0bc0a52cd8eb50d2b34465763"}],"ansible/roles/aodh/templates/aodh.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"69baef84ff15b434ad3a66925b2035b9765c66bf","unresolved":true,"context_lines":[{"line_number":60,"context_line":"driver \u003d noop"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% if om_enable_rabbitmq_tls or om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"[oslo_messaging_rabbit]"},{"line_number":65,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":66,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"85af0c80_e4187000","line":63,"range":{"start_line":63,"start_character":6,"end_line":63,"end_character":28},"updated":"2022-12-19 14:13:32.000000000","message":"| bool","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6414f2e63a3985558f5d6a6bd4b1b96a347323ac","unresolved":false,"context_lines":[{"line_number":60,"context_line":"driver \u003d noop"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% if om_enable_rabbitmq_tls or om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"[oslo_messaging_rabbit]"},{"line_number":65,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":66,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3d102ea5_2217339f","line":63,"range":{"start_line":63,"start_character":6,"end_line":63,"end_character":28},"in_reply_to":"85af0c80_e4187000","updated":"2022-12-21 15:14:11.000000000","message":"Done","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c2cc8e8df9ab69bcc905a000d2049203e664c3bf","unresolved":true,"context_lines":[{"line_number":60,"context_line":"driver \u003d noop"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% if om_enable_rabbitmq_tls | bool or om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"[oslo_messaging_rabbit]"},{"line_number":65,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":66,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9c94a7c8_d354830a","line":63,"updated":"2022-12-22 16:36:29.000000000","message":"I guess we should rebase on your other patch and remove the outer condition?","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"936b1354040abf72a927ebc6f6762c7b236881b3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"driver \u003d noop"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% if om_enable_rabbitmq_tls | bool or om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"[oslo_messaging_rabbit]"},{"line_number":65,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":66,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"17ea291e_6f086653","line":63,"in_reply_to":"96a6c960_7c974372","updated":"2023-01-05 09:48:12.000000000","message":"Done","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7e677df96ca8af41bf24c26b073fbf0a02d8ee98","unresolved":true,"context_lines":[{"line_number":60,"context_line":"driver \u003d noop"},{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% if om_enable_rabbitmq_tls | bool or om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"[oslo_messaging_rabbit]"},{"line_number":65,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":66,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"96a6c960_7c974372","line":63,"in_reply_to":"9c94a7c8_d354830a","updated":"2022-12-22 16:40:22.000000000","message":"Yes that\u0027ll need to be removed. I was holding off rebasing as I wasn\u0027t sure if it was a good idea to have one patch relying on the other.","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"}],"ansible/roles/rabbitmq/templates/definitions.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f53c370f60a99bc412489f6475a74357ff3275e5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    {\"user\": \"{{ murano_agent_rabbitmq_user }}\", \"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"configure\": \".*\", \"write\": \".*\", \"read\": \".*\"}"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"29bc77da_1d1a772c","line":19,"updated":"2022-12-22 13:27:19.000000000","message":"The linter seems to take issue with something here","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cd815bdb6f7ced4f67bd5f06a5c3b5365c55989a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    {\"user\": \"{{ murano_agent_rabbitmq_user }}\", \"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"configure\": \".*\", \"write\": \".*\", \"read\": \".*\"}"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3bfd9e1f_7b0981c2","line":19,"in_reply_to":"29bc77da_1d1a772c","updated":"2022-12-22 13:42:06.000000000","message":"It\u0027s got a problem with the regex in the new pattern, possibly I need to escape it somehow? I haven\u0027t figured that out yet.","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"02099a77fe7cf0187a0b725ab0bd6a0d9c50608b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    {\"user\": \"{{ murano_agent_rabbitmq_user }}\", \"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"configure\": \".*\", \"write\": \".*\", \"read\": \".*\"}"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7c3695b9_8657ec21","line":19,"in_reply_to":"3bfd9e1f_7b0981c2","updated":"2023-01-05 11:47:54.000000000","message":"The issue is with the backslashes in `amp\\.`","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f44b866e0509c78c1480b25722cdfe2231ed7f61","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {\"user\": \"{{ murano_agent_rabbitmq_user }}\", \"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"configure\": \".*\", \"write\": \".*\", \"read\": \".*\"}"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a83048a7_29b335df","line":19,"in_reply_to":"7c3695b9_8657ec21","updated":"2023-01-09 16:52:34.000000000","message":"Done","commit_id":"f6235d509373b2c5ed0962ab0a777bb08188393a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4f4f82e16a7077f2592408cd66acbab8b884ec87","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"  ]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"0d511889_dfed799c","line":21,"updated":"2023-01-06 15:24:04.000000000","message":"What do you think about including `ha-promote-on-shutdown\": \"always\"` in the ha-all policy? The default is \u0027when-synced\u0027\n\nIt appears that \u0027when-synced\u0027 may cause issues with fail-over in certain cases:\n\nhttps://bugs.launchpad.net/charm-rabbitmq-server/+bug/1943929\n\nI\u0027m curious if you\u0027ve seen this in testing?","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"857f581405c4c42d5e37ad053dfa8df681bade70","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  ],"},{"line_number":19,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"  ]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"57c4f9d3_9ba67429","line":21,"in_reply_to":"0d511889_dfed799c","updated":"2023-01-09 09:44:55.000000000","message":"Should this be revived? https://review.opendev.org/c/openstack/kolla-ansible/+/822135","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4f4f82e16a7077f2592408cd66acbab8b884ec87","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"  ]"},{"line_number":25,"context_line":"{% else %}"},{"line_number":26,"context_line":"  \"policies\":[]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"50ecb411_97a9f6a1","line":23,"updated":"2023-01-06 15:24:04.000000000","message":"I\u0027m also wondering if we should include a message TTL in the ha-all policy (discussed here): https://review.opendev.org/c/openstack/kolla-ansible/+/822191\n\nIn the past we\u0027ve seen stale messages which can be hard to get rid of when mirroring is enabled.","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"857f581405c4c42d5e37ad053dfa8df681bade70","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  \"policies\":["},{"line_number":21,"context_line":"    {\"vhost\": \"/\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}{% if project_name \u003d\u003d \u0027outward_rabbitmq\u0027 %},"},{"line_number":22,"context_line":"    {\"vhost\": \"{{ murano_agent_rabbitmq_vhost }}\", \"name\": \"ha-all\", \"pattern\": \"^(?!(amq\\\\.)|(.*_fanout_)|(reply_)).*\", \"apply-to\": \"all\", \"definition\": {\"ha-mode\":\"all\"}, \"priority\":0}"},{"line_number":23,"context_line":"    {% endif %}"},{"line_number":24,"context_line":"  ]"},{"line_number":25,"context_line":"{% else %}"},{"line_number":26,"context_line":"  \"policies\":[]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ef4937c_6c42ccde","line":23,"in_reply_to":"50ecb411_97a9f6a1","updated":"2023-01-09 09:44:55.000000000","message":"Should this be revived? https://review.opendev.org/c/openstack/kolla-ansible/+/822191","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"}],"releasenotes/notes/add-a-flag-to-handle-rabbitmq-high-availability-44c709318be6cb7b.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e72cfd63eca6b860defc9ad1cb8cbf9654f5761f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"971b09df_c99c1e8a","line":5,"range":{"start_line":4,"start_character":59,"end_line":5,"end_character":65},"updated":"2022-12-15 12:02:16.000000000","message":"by default (and we also need upgrade: section - for those people doing upgrades and reading only this).","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e72cfd63eca6b860defc9ad1cb8cbf9654f5761f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e0d9c103_9b990628","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":65},"updated":"2022-12-15 12:02:16.000000000","message":"nit: whitespace","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6414f2e63a3985558f5d6a6bd4b1b96a347323ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9811405d_cbed0f4b","line":5,"range":{"start_line":4,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"22aa2a9b_4f4631ad","updated":"2022-12-21 15:14:11.000000000","message":"Done","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"161913eac793a0c8a30dcf63e5e450ed257e8d4a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"22aa2a9b_4f4631ad","line":5,"range":{"start_line":4,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"7fa768b3_668dafec","updated":"2022-12-15 13:37:19.000000000","message":"Oh I see, that\u0027s my bad I\u0027d forgotten to switch it to false after testing.","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e081dd2a5c647418ba618d4e077a464f652f0574","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7fa768b3_668dafec","line":5,"range":{"start_line":4,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"9629c1a5_56156d32","updated":"2022-12-15 13:27:40.000000000","message":"Well, you proposed setting this variable to true ;-)","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d858722c57ff24f005c21c6835b786ae5414f67d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9629c1a5_56156d32","line":5,"range":{"start_line":4,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"971b09df_c99c1e8a","updated":"2022-12-15 13:04:54.000000000","message":"Should we be enabling this by default? Enabling durable queues requires a restart of RabbitMQ nodes, so I think it would be best to have this feature as opt-in.","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a58c8111c9001dacace373a8cdd9e06930a7921c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ. "},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7b27cc99_c85e9469","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":65},"in_reply_to":"e0d9c103_9b990628","updated":"2022-12-15 13:41:58.000000000","message":"Done","commit_id":"524641e0c2abf7efe470366452d5c0a18134530d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"69baef84ff15b434ad3a66925b2035b9765c66bf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ."},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"930315bf_93012be6","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":63},"updated":"2022-12-19 14:13:32.000000000","message":"Setting this to true will...","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6414f2e63a3985558f5d6a6bd4b1b96a347323ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. This will enable"},{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ."},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"207031df_43db83cd","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":63},"in_reply_to":"930315bf_93012be6","updated":"2022-12-21 15:14:11.000000000","message":"Done","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"69baef84ff15b434ad3a66925b2035b9765c66bf","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ."},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Classic mirrored queues and durable queues in RabbitMQ can now only be used"},{"line_number":11,"context_line":"    in conjunction with each other. These can be enabled with the flag"},{"line_number":12,"context_line":"    ``om_enable_rabbitmq_high_availablity`` (defaults to ``false``)."},{"line_number":13,"context_line":"    The pattern used in classic mirroring has been changed from ``.*`` to"},{"line_number":14,"context_line":"    ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a16b9711_d7444083","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":45},"updated":"2022-12-19 14:13:32.000000000","message":"We probably don\u0027t need an upgrade section if there are no backwards incompatible changes. We would need one for backports to releases using HA mode by default since it would enable durable queues.","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6414f2e63a3985558f5d6a6bd4b1b96a347323ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    both durable queues and classic mirrored queues in RabbitMQ."},{"line_number":6,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":7,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Classic mirrored queues and durable queues in RabbitMQ can now only be used"},{"line_number":11,"context_line":"    in conjunction with each other. These can be enabled with the flag"},{"line_number":12,"context_line":"    ``om_enable_rabbitmq_high_availablity`` (defaults to ``false``)."},{"line_number":13,"context_line":"    The pattern used in classic mirroring has been changed from ``.*`` to"},{"line_number":14,"context_line":"    ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5119098_2a2e650c","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"a16b9711_d7444083","updated":"2022-12-21 15:14:11.000000000","message":"Done","commit_id":"375a89c1cd731e43f7ee7bcc5be4aab43e3ba931"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4f4f82e16a7077f2592408cd66acbab8b884ec87","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. Setting this to"},{"line_number":5,"context_line":"    ``true`` will enable both durable queues and classic mirrored queues in"},{"line_number":6,"context_line":"    RabbitMQ."},{"line_number":7,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":8,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2c8eb0cd_561cf2fc","line":5,"updated":"2023-01-06 15:24:04.000000000","message":"Should we mention here that the feature is subject to deprecation and removal at some unknown stage in the future when Rabbit 4.0 is released? We could perhaps mark it as experimental?\n\nDebian users may even get a surprise upgrade to Rabbit 4, since it doesn\u0027t appear to be pinned [1].\n\n[1] https://github.com/openstack/kolla/blob/master/docker/rabbitmq/Dockerfile.j2#L25","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"857f581405c4c42d5e37ad053dfa8df681bade70","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. Setting this to"},{"line_number":5,"context_line":"    ``true`` will enable both durable queues and classic mirrored queues in"},{"line_number":6,"context_line":"    RabbitMQ."},{"line_number":7,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":8,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"35966431_6ab3b900","line":5,"in_reply_to":"2c8eb0cd_561cf2fc","updated":"2023-01-09 09:44:55.000000000","message":"I\u0027d hope that we wouldn\u0027t get a major upgrade of Rabbit without moving to the next Debian/Ubuntu release, but I suppose it\u0027s possible.\n\nIt\u0027s worth mentioning so that people are aware, but ultimately kolla should be controlling the version and associated configuration here.","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"daf16c2e7b2a9a7313ac25b8b6f5eeb00bd27c86","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the flag ``om_enable_rabbitmq_high_availablity``. Setting this to"},{"line_number":5,"context_line":"    ``true`` will enable both durable queues and classic mirrored queues in"},{"line_number":6,"context_line":"    RabbitMQ."},{"line_number":7,"context_line":"    Changes the pattern used in classic mirroring to exclude some queue types."},{"line_number":8,"context_line":"    This pattern is ``^(?!(amq\\.)|(.*_fanout_)|(reply_)).*``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fadce9e7_2509ce98","line":5,"in_reply_to":"35966431_6ab3b900","updated":"2023-01-09 16:49:07.000000000","message":"Done","commit_id":"efd7b7c4d35d3a36d62e728417216d8bf6cd79cc"}]}