)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8241caacebd013f7a595a38fed7b3ceac24d101b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5bf6a7e_f8c6b861","updated":"2023-01-03 15:22:16.000000000","message":"Why this is not set for all wsgi apps currently in kolla-ansible ? \n\ngnocchi-api, freezer-api, placement-api","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"24b859d76571180c17f3cd4899f40bf34f8bbd30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8fb7f71_de1a8fc4","updated":"2023-01-03 10:55:11.000000000","message":"recheck","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"49807e480530090c9b81f092a2b6fe560a89e614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c58273c_7bc7c517","in_reply_to":"f5bf6a7e_f8c6b861","updated":"2023-01-04 09:25:33.000000000","message":"Those do not use oslo_messaging","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"}],"ansible/roles/aodh/templates/aodh.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1cad6c3a82665fa1e66ffcf81fa031afcb92d915","unresolved":true,"context_lines":[{"line_number":64,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":65,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":66,"context_line":"{% else %}"},{"line_number":67,"context_line":"heartbeat_in_pthread \u003d false"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":70,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3774abce_c4202203","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":28},"updated":"2022-12-22 12:08:43.000000000","message":"This would save a few lines:\n\n heartbeat_in_pthread \u003d {{ service_name \u003d\u003d \u0027aodh-api\u0027 }}","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"0b7661c7c86213630b17c6c4b32817d1d88773bf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":65,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":66,"context_line":"{% else %}"},{"line_number":67,"context_line":"heartbeat_in_pthread \u003d false"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":70,"context_line":"ssl \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7f873219_6d16573d","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":28},"in_reply_to":"3774abce_c4202203","updated":"2022-12-22 15:16:37.000000000","message":"Done","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d81db850edc31ec30d73cee46a3c285acd3de838","unresolved":true,"context_lines":[{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":65,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":66,"context_line":"{% else %}"},{"line_number":67,"context_line":"heartbeat_in_pthread \u003d false"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":70,"context_line":"ssl \u003d true"},{"line_number":71,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"},{"line_number":72,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2c1644b8_4539074f","line":69,"range":{"start_line":64,"start_character":0,"end_line":69,"end_character":38},"updated":"2022-12-22 12:05:57.000000000","message":"could we have this somewhere else for visibility? e.g. the services dict in defaults or a variable in defaults based on that if statement? That would be easier manageable in future I guess.","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"706b5ac76fb18bc91363c7fab794d699ec030d87","unresolved":true,"context_lines":[{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":65,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":66,"context_line":"{% else %}"},{"line_number":67,"context_line":"heartbeat_in_pthread \u003d false"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":70,"context_line":"ssl \u003d true"},{"line_number":71,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"},{"line_number":72,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"eafc1f8b_62a9ad97","line":69,"range":{"start_line":64,"start_character":0,"end_line":69,"end_character":38},"in_reply_to":"007c8ed1_0e8e81bf","updated":"2022-12-22 12:37:03.000000000","message":"Actually your proposal with heartbeat_in_pthread \u003d {{ service_name \u003d\u003d \u0027aodh-api\u0027 }} makes more sense, than polluting the services dict (which users can\u0027t override anyway).","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1cad6c3a82665fa1e66ffcf81fa031afcb92d915","unresolved":true,"context_lines":[{"line_number":61,"context_line":"{% endif %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[oslo_messaging_rabbit]"},{"line_number":64,"context_line":"{% if service_name \u003d\u003d \u0027aodh-api\u0027 %}"},{"line_number":65,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":66,"context_line":"{% else %}"},{"line_number":67,"context_line":"heartbeat_in_pthread \u003d false"},{"line_number":68,"context_line":"{% endif %}"},{"line_number":69,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":70,"context_line":"ssl \u003d true"},{"line_number":71,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"},{"line_number":72,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"007c8ed1_0e8e81bf","line":69,"range":{"start_line":64,"start_character":0,"end_line":69,"end_character":38},"in_reply_to":"2c1644b8_4539074f","updated":"2022-12-22 12:08:43.000000000","message":"What exactly would go in the services dict?","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"}],"ansible/roles/barbican/templates/barbican.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f2f66057270318ee829087064f6e7e1c96f86d5c","unresolved":true,"context_lines":[{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[oslo_messaging_rabbit]"},{"line_number":82,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":84,"context_line":"ssl \u003d true"},{"line_number":85,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fb8f049c_47391b39","line":82,"range":{"start_line":82,"start_character":23,"end_line":82,"end_character":27},"updated":"2022-12-21 15:55:10.000000000","message":"This should only be true for the barbican-api service which runs under apache. The service_name variable can be used to check which service this is for.\n\nThe same is true for other services.","commit_id":"b0935d513ba55cf9dcbfcef93f1925cf2480e5fc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a05ebe44bac15d101dad3af0d90aa3247a768306","unresolved":false,"context_lines":[{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[oslo_messaging_rabbit]"},{"line_number":82,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":83,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":84,"context_line":"ssl \u003d true"},{"line_number":85,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a5ff816_9a6190bc","line":82,"range":{"start_line":82,"start_character":23,"end_line":82,"end_character":27},"in_reply_to":"fb8f049c_47391b39","updated":"2022-12-22 11:13:21.000000000","message":"Done","commit_id":"b0935d513ba55cf9dcbfcef93f1925cf2480e5fc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"45d31d39e3136221350660b14cb1f9b9ab35ba1a","unresolved":true,"context_lines":[{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[oslo_messaging_rabbit]"},{"line_number":82,"context_line":"{% if service_name \u003d\u003d \u0027barbican-api\u0027 %}"},{"line_number":83,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":84,"context_line":"{% else %}"},{"line_number":85,"context_line":"heartbeat_in_pthread \u003d false"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5c09c327_ed07815a","line":82,"updated":"2022-12-22 14:34:38.000000000","message":"Actually I\u0027m unsure about barbican - it runs under uwsgi rather than apache.","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"92e3be7062bb6cb7fbecf6fa72d4a0b0006d4ab9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[oslo_messaging_rabbit]"},{"line_number":82,"context_line":"{% if service_name \u003d\u003d \u0027barbican-api\u0027 %}"},{"line_number":83,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":84,"context_line":"{% else %}"},{"line_number":85,"context_line":"heartbeat_in_pthread \u003d false"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"48a768a7_6d2ad94f","line":82,"in_reply_to":"5c09c327_ed07815a","updated":"2022-12-22 15:39:11.000000000","message":"From what I\u0027ve seen, the issues only occur under apache, I hadn\u0027t clocked that uwsgi was a different thing. I\u0027ll set this to false for barbican","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"}],"ansible/roles/cyborg/templates/cyborg.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"45d31d39e3136221350660b14cb1f9b9ab35ba1a","unresolved":true,"context_lines":[{"line_number":58,"context_line":"{% endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[oslo_messaging_rabbit]"},{"line_number":61,"context_line":"{% if service_name \u003d\u003d \u0027cyborg-api\u0027 %}"},{"line_number":62,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":63,"context_line":"{% else %}"},{"line_number":64,"context_line":"heartbeat_in_pthread \u003d false"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"517f7bff_39d3f510","line":61,"updated":"2022-12-22 14:34:38.000000000","message":"I don\u0027t see an apache config for cyborg","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"92e3be7062bb6cb7fbecf6fa72d4a0b0006d4ab9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"{% endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[oslo_messaging_rabbit]"},{"line_number":61,"context_line":"{% if service_name \u003d\u003d \u0027cyborg-api\u0027 %}"},{"line_number":62,"context_line":"heartbeat_in_pthread \u003d true"},{"line_number":63,"context_line":"{% else %}"},{"line_number":64,"context_line":"heartbeat_in_pthread \u003d false"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"31357728_f7fa2c58","line":61,"in_reply_to":"517f7bff_39d3f510","updated":"2022-12-22 15:39:11.000000000","message":"I\u0027d seen that cyborg could be run under uwsgi, but didn\u0027t realise this isn\u0027t actually being used. Regardless, as mentioned in my other comment, it should still be set to false even under uwsgi.","commit_id":"05828acf1bd304c51a01bf14aed63a54d6dd5002"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8241caacebd013f7a595a38fed7b3ceac24d101b","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{% endif %}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[oslo_messaging_rabbit]"},{"line_number":63,"context_line":"heartbeat_in_pthread \u003d {{ service_name \u003d\u003d \u0027keystone-api\u0027 }}"},{"line_number":64,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":65,"context_line":"ssl \u003d true"},{"line_number":66,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1b40261f_c0c79197","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"updated":"2023-01-03 15:22:16.000000000","message":"keystone-api -\u003e keystone","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"49807e480530090c9b81f092a2b6fe560a89e614","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{% endif %}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[oslo_messaging_rabbit]"},{"line_number":63,"context_line":"heartbeat_in_pthread \u003d {{ service_name \u003d\u003d \u0027keystone-api\u0027 }}"},{"line_number":64,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":65,"context_line":"ssl \u003d true"},{"line_number":66,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5903a08f_ac86cba1","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"in_reply_to":"1b40261f_c0c79197","updated":"2023-01-04 09:25:33.000000000","message":"Good catch","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ebea315a21e40d7eff4107f605f41cc8b2608933","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% endif %}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[oslo_messaging_rabbit]"},{"line_number":63,"context_line":"heartbeat_in_pthread \u003d {{ service_name \u003d\u003d \u0027keystone-api\u0027 }}"},{"line_number":64,"context_line":"{% if om_enable_rabbitmq_tls | bool %}"},{"line_number":65,"context_line":"ssl \u003d true"},{"line_number":66,"context_line":"ssl_ca_file \u003d {{ om_rabbitmq_cacert }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fbe562f6_b374326a","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"in_reply_to":"5903a08f_ac86cba1","updated":"2023-01-05 09:19:15.000000000","message":"Done","commit_id":"326e73fb56f8d14c23dc0dc65cc3fe9b4efe55eb"}]}
