)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"287e5f0a6c5a781827b736354df0c94c54f3ae90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5eeb8a26_138c42be","updated":"2023-01-04 12:32:19.000000000","message":"recheck (ubuntu-ovn failed on rc 13 with octavia config dir creation - permission denied?)","commit_id":"360c0d9f225af67e6bf2caed40accb00b9019b97"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"739f16231ba9d8134acd4bfa403638fb21377e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d2e3c37c_4d507fac","updated":"2023-04-27 14:54:42.000000000","message":"recheck (rocky9 upgrade ovn timed out on db)","commit_id":"b19cddd83ea5c20862226ef58ca85ada6c8cd596"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"128c1afc2b24d88380d89669c6131b1a07afbc8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b5dc2bbe_8cd6fc08","updated":"2023-04-26 05:57:44.000000000","message":"recheck (ubuntu ovn upgrade failed on RMQ)","commit_id":"b19cddd83ea5c20862226ef58ca85ada6c8cd596"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"5f4c61284771d2c4931bd1b8ef73b6944b239351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d448dabe_49458833","updated":"2023-05-05 10:14:15.000000000","message":"I\u0027ve cherry picked this patch for some controller migration testing (Yoga CS8 to Rocky 9) and it appears to be functionally sound. I\u0027ve seen some issues with MariaDB but don\u0027t think they\u0027re related.","commit_id":"f68b52c3a9d3904fc3d0c5137316b2f5a037f561"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bbdfe1d8a4bd38bb1eb5ee3f9dd6524c00bcf576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d509c802_af6baf28","updated":"2023-08-17 13:00:03.000000000","message":"Needs a reno, ideally a bit more in the commit message. Otherwise looks good.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"334f72cea2713489cf832047cee8f13aef95db8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"31a72f5b_2c2a71f9","updated":"2023-08-22 14:27:02.000000000","message":"Had a thought over the weekend - what happens to the cluster when we restart all containers?","commit_id":"9063c03c5b7294de8484e25cbc470315ee490d07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"f6a233c5_30b204c4","in_reply_to":"31a72f5b_2c2a71f9","updated":"2023-08-24 10:52:12.000000000","message":"It manages to elect a leader and sync up - so at least it\u0027s not behaving the same as Galera.","commit_id":"9063c03c5b7294de8484e25cbc470315ee490d07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e2040ed374693d72136cbe177380eea8328bdb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"c39ffe27_a8a9cfd2","updated":"2023-08-25 17:42:35.000000000","message":"recheck mirror fail","commit_id":"5f20b7cec650957f1c5e085cbd699da58030362e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"f7c2e7e455ea35eb4cff3b1b00f3217d4b2d7127","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"d464542f_5e21f4d9","updated":"2023-08-28 12:03:17.000000000","message":"\"docker exec\" should be done with {{ kolla_container_engine }}","commit_id":"c77812d04846bd5ee7b58bfb8ae7cc245d3d2b9b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dff0e23832390e454f1fcafb56cfcecccf36b84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"4cc910c0_e75f9678","in_reply_to":"d464542f_5e21f4d9","updated":"2023-08-28 12:32:40.000000000","message":"Done","commit_id":"c77812d04846bd5ee7b58bfb8ae7cc245d3d2b9b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"036aa357c19a725c0f46ae5e1d438ada290f4aae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"1beb42f6_610843ea","updated":"2023-09-04 12:50:58.000000000","message":"Code LGTM, but OVN job failed on Ubuntu: https://4a8ea77e4d7990fb09ad-6d688ba48e2919de170b3c689838ef40.ssl.cf1.rackcdn.com/868929/45/check/kolla-ansible-ubuntu-ovn/65ed23f/primary/logs/ansible/deploy","commit_id":"3378e38678e224b76003be481e8fa36891c3a8ae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"955c73045d3af14145fd7569217c0a5f30ec24bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":46,"id":"87c826b6_bad133da","updated":"2023-09-05 13:43:13.000000000","message":"now this job is failing: kolla-ansible-rocky9-ovn\n\n\n```\nPipelining is enabled.\n\n\u003c158.69.66.18\u003e ESTABLISH SSH CONNECTION FOR USER: None\n\n\u003c158.69.66.18\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d60s -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/4aa52a676f\"\u0027 158.69.66.18 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-hgtgpfjfmrzpmoyysokdprtogretvwjf ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\nEscalation succeeded\n\nEscalation succeeded\n\n\u003c158.69.66.181\u003e (1, b\u0027\\n{\"results\": [], \"rc\": 1, \"failed\": true, \"msg\": \"Failed to download metadata for repo \\\u0027appstream\\\u0027: repomd.xml parser error: Parse error at line: 1 (Extra content at the end of the document\\\\n)\", \"exception\": \"  File \\\\\"/tmp/ansible_ansible.legacy.dnf_payload_9y8zj9gi/ansible_ansible.legacy.dnf_payload.zip/ansible/modules/dnf.py\\\\\", line 733, in _base\\\\n  File \\\\\"/usr/lib/python3.9/site-packages/dnf/base.py\\\\\", line 377, in update_cache\\\\n    self.fill_sack(load_system_repo\u003dFalse, load_available_repos\u003dTrue)  # performs the md sync\\\\n  File \\\\\"/usr/lib/python3.9/site-packages/dnf/base.py\\\\\", line 406, in fill_sack\\\\n    self._add_repo_to_sack(r)\\\\n  File \\\\\"/usr/lib/python3.9/site-packages/dnf/base.py\\\\\", line 141, in _add_repo_to_sack\\\\n    repo.load()\\\\n  File \\\\\"/usr/lib/python3.9/site-packages/dnf/repo.py\\\\\", line 581, in load\\\\n    raise dnf.exceptions.RepoError(str(e))\\\\n\", \"invocation\": {\"module_args\": {\"name\": [\"docker-ce\"], \"update_cache\": true, \"state\": \"present\", \"allow_downgrade\": false, \"autoremove\": false, \"bugfix\": false, \"cacheonly\": false, \"disable_gpg_check\": false, \"disable_plugin\": [], \"disablerepo\": [], \"download_only\": false, \"enable_plugin\": [], \"enablerepo\": [], \"exclude\": [], \"installroot\": \"/\", \"install_repoquery\": true, \"install_weak_deps\": true, \"security\": false, \"skip_broken\": false, \"update_only\": false, \"validate_certs\": true, \"sslverify\": true, \"lock_timeout\": 30, \"allowerasing\": false, \"nobest\": false, \"conf_file\": null, \"disable_excludes\": null, \"download_dir\": null, \"list\": null, \"releasever\": null}}}\\n\u0027, b\u0027\u0027)\n\n\u003c158.69.66.181\u003e Failed to connect to the host via ssh: \n\nThe full traceback is:\n\n  File \"/tmp/ansible_ansible.legacy.dnf_payload_9y8zj9gi/ansible_ansible.legacy.dnf_payload.zip/ansible/modules/dnf.py\", line 733, in _base\n```\n\nseems unrelated to me at a first glance, but I have no deep knowledge of these tests.","commit_id":"7cc4bf62031d293487b1714448ba7bb65ed324d6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7845fca2d630bee7dc2c195e23ac3d722aa86025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"f2266359_4b2b0e84","updated":"2023-09-05 15:55:23.000000000","message":"recheck rocky mirrors fail","commit_id":"7cc4bf62031d293487b1714448ba7bb65ed324d6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4cfdef60728eed56ac0845b21f7748015f20a277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"22d40ce5_55e4676e","in_reply_to":"87c826b6_bad133da","updated":"2023-09-06 08:22:34.000000000","message":"It was Rocky mirrors problem, gone for now","commit_id":"7cc4bf62031d293487b1714448ba7bb65ed324d6"}],"ansible/library/kolla_container_volume_facts.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fa059dd2dd54f719e5e5378a4b0296dc86a652f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"},{"line_number":30,"context_line":"      - Name of container engine to use"},{"line_number":31,"context_line":"    required: True"},{"line_number":32,"context_line":"    type: str"},{"line_number":33,"context_line":"  api_version:"},{"line_number":34,"context_line":"    description:"},{"line_number":35,"context_line":"      - The version of the api for docker-py to use when contacting docker"},{"line_number":36,"context_line":"    required: False"}],"source_content_type":"text/x-python","patch_set":9,"id":"04866d5f_ce347d84","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":0},"updated":"2023-04-24 17:42:24.000000000","message":"declared but not used, supported only hardcoded docker","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"},{"line_number":30,"context_line":"      - Name of container engine to use"},{"line_number":31,"context_line":"    required: True"},{"line_number":32,"context_line":"    type: str"},{"line_number":33,"context_line":"  api_version:"},{"line_number":34,"context_line":"    description:"},{"line_number":35,"context_line":"      - The version of the api for docker-py to use when contacting docker"},{"line_number":36,"context_line":"    required: False"}],"source_content_type":"text/x-python","patch_set":9,"id":"c4776957_c53d6b71","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":0},"in_reply_to":"04866d5f_ce347d84","updated":"2023-05-09 09:47:24.000000000","message":"Just like in the other modules in this directory","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7162db446cb2b4ac0147c7e2cb2ca7b38df87be6","unresolved":true,"context_lines":[{"line_number":22,"context_line":"module: kolla_container_volume_facts"},{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"}],"source_content_type":"text/x-python","patch_set":11,"id":"de9bb918_50a1dafb","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":22},"updated":"2023-04-28 07:55:50.000000000","message":"targeted","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"module: kolla_container_volume_facts"},{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"}],"source_content_type":"text/x-python","patch_set":11,"id":"b06d8921_21695317","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":22},"in_reply_to":"de9bb918_50a1dafb","updated":"2023-05-09 09:47:24.000000000","message":"Done","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7162db446cb2b4ac0147c7e2cb2ca7b38df87be6","unresolved":true,"context_lines":[{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":11,"id":"25bf3e93_7b9eb88b","line":26,"range":{"start_line":26,"start_character":54,"end_line":26,"end_character":61},"updated":"2023-04-28 07:55:50.000000000","message":"on a/the host","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":11,"id":"f1f3b548_abbf738a","line":26,"range":{"start_line":26,"start_character":54,"end_line":26,"end_character":61},"in_reply_to":"25bf3e93_7b9eb88b","updated":"2023-05-09 09:47:24.000000000","message":"Done","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7162db446cb2b4ac0147c7e2cb2ca7b38df87be6","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"},{"line_number":30,"context_line":"      - Name of container engine to use"},{"line_number":31,"context_line":"    required: True"},{"line_number":32,"context_line":"    type: str"},{"line_number":33,"context_line":"  api_version:"},{"line_number":34,"context_line":"    description:"},{"line_number":35,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":11,"id":"c03530c4_5dd562eb","line":32,"range":{"start_line":28,"start_character":2,"end_line":32,"end_character":13},"updated":"2023-04-28 07:55:50.000000000","message":"default: docker\nallowed values: docker, podman?","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"74a6b31d680dc95e16a8e146d7828a96de325c63","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  - A module targeting at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"},{"line_number":30,"context_line":"      - Name of container engine to use"},{"line_number":31,"context_line":"    required: True"},{"line_number":32,"context_line":"    type: str"},{"line_number":33,"context_line":"  api_version:"},{"line_number":34,"context_line":"    description:"},{"line_number":35,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":11,"id":"affa9d47_7963dcd8","line":32,"range":{"start_line":28,"start_character":2,"end_line":32,"end_character":13},"in_reply_to":"c03530c4_5dd562eb","updated":"2023-04-28 08:03:09.000000000","message":"I just copied that from kolla_toolbox.py as it is now, that should rather be a separate change tied to the podman functionality.","commit_id":"0fc5275b91bf7d87b188d1626184e3148084a477"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3cb31c9b6f1155398a629c9fb9e7e2be97b336e8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeted at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host a in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"f3e4bbe8_64d709db","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":63},"updated":"2023-08-29 10:11:33.000000000","message":"nit: \"a host\"?","commit_id":"5f20b7cec650957f1c5e085cbd699da58030362e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a2a57663686af3b4df181f1ca2864610ff16932d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"short_description: Module for collecting Docker container volume facts"},{"line_number":24,"context_line":"description:"},{"line_number":25,"context_line":"  - A module targeted at collecting Docker container volume facts. It is used"},{"line_number":26,"context_line":"    for detecting whether the container volume exists on host a in Kolla."},{"line_number":27,"context_line":"options:"},{"line_number":28,"context_line":"  container_engine:"},{"line_number":29,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"a591fb1b_0eab61f0","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":63},"in_reply_to":"f3e4bbe8_64d709db","updated":"2023-08-29 12:56:54.000000000","message":"Done","commit_id":"5f20b7cec650957f1c5e085cbd699da58030362e"}],"ansible/roles/ovn-db/tasks/bootstrap-initial.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"aaf40a9eced2af1a7cc835d333f39593f3f2ab5a","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Unset bootstrap args fact"},{"line_number":25,"context_line":"      set_fact:"},{"line_number":26,"context_line":"        ovn_nb_bootstrap_args:"},{"line_number":27,"context_line":"        ovn_sb_bootstrap_args:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b1cd53da_8024f432","line":26,"updated":"2023-04-25 15:41:36.000000000","message":"Should these be ``ovn_nb_db_bootstrap_args`` and ``ovn_sb_db_bootstrap_args``? (Currently missing ``_db``)","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2c64066dce8834843280bc5556dfd8640595c591","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Unset bootstrap args fact"},{"line_number":25,"context_line":"      set_fact:"},{"line_number":26,"context_line":"        ovn_nb_bootstrap_args:"},{"line_number":27,"context_line":"        ovn_sb_bootstrap_args:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c79061f6_73a55042","line":26,"in_reply_to":"b1cd53da_8024f432","updated":"2023-04-25 16:24:53.000000000","message":"Done","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"8bd9fbe3_27ce2adc","line":7,"range":{"start_line":7,"start_character":126,"end_line":7,"end_character":153},"updated":"2023-05-09 15:53:38.000000000","message":"Is there a reason why we shouldn\u0027t always specify this arg?","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6a3d65d24c6b736cde0702614f027cde33d42dbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ae6b582b_7179d8ef","line":7,"range":{"start_line":7,"start_character":126,"end_line":7,"end_character":153},"in_reply_to":"3317c7e8_c84a98e3","updated":"2023-08-16 11:59:39.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ed40a79d906a4edb6e0bf664fbd57117f4a56903","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"a81be76e_6c676ae5","line":7,"range":{"start_line":7,"start_character":126,"end_line":7,"end_character":153},"in_reply_to":"8bd9fbe3_27ce2adc","updated":"2023-05-09 17:15:19.000000000","message":"Basically everything is explained in the bug:\n1. You start with a three node cluster - it works like charm\n2. You remove the first node - remote-addr is set to a nonexistent node, so it comes up with empty DB\n3. You end up with two clusters - one empty, and one not.","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"41ecb10c3990a0061c8798a0398d392051984a41","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3317c7e8_c84a98e3","line":7,"range":{"start_line":7,"start_character":126,"end_line":7,"end_character":153},"in_reply_to":"a81be76e_6c676ae5","updated":"2023-05-25 15:30:53.000000000","message":"Bug doesn\u0027t really say that, but it should","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a0484e1e848156baa36992655d2090ab3d9cdff","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"},{"line_number":11,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"b2768a08_5fde0565","line":8,"updated":"2023-08-17 14:38:52.000000000","message":"Do we care about followers here? If we have no leader we need to bootstrap anyway, right?","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB"},{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        ovn_nb_db_bootstrap_args: \"{% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) | put_address_in_context(\u0027url\u0027) }} {% endif %}\""},{"line_number":8,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Set bootstrap args fact for SB"},{"line_number":11,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"a6f4eb86_47f3114b","line":8,"in_reply_to":"b2768a08_5fde0565","updated":"2023-08-24 10:52:12.000000000","message":"If there is no leader, but there are followers - then the election is taking place right now - we should rather fail than continue","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a0484e1e848156baa36992655d2090ab3d9cdff","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        ovn_nb_db_bootstrap_args:"},{"line_number":27,"context_line":"        ovn_sb_db_bootstrap_args:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":31,"context_line":"    - groups[\u0027ovn-sb-db_leader\u0027] is not defined and groups[\u0027ovn-sb-db_follower\u0027] is not defined"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Bootstrap additional nodes (when leader exists)"},{"line_number":34,"context_line":"  block:"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"900bdfdc_36b7be0a","line":32,"range":{"start_line":29,"start_character":1,"end_line":32,"end_character":0},"updated":"2023-08-17 14:38:52.000000000","message":"This could go wrong if one cluster is running and the other is not.\n\nI suggest we use a single set of tasks, with all 4 set_fact tasks at the beginning. I think the when conditions should handle it.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        ovn_nb_db_bootstrap_args:"},{"line_number":27,"context_line":"        ovn_sb_db_bootstrap_args:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  when:"},{"line_number":30,"context_line":"    - groups[\u0027ovn-nb-db_leader\u0027] is not defined and groups[\u0027ovn-nb-db_follower\u0027] is not defined"},{"line_number":31,"context_line":"    - groups[\u0027ovn-sb-db_leader\u0027] is not defined and groups[\u0027ovn-sb-db_follower\u0027] is not defined"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Bootstrap additional nodes (when leader exists)"},{"line_number":34,"context_line":"  block:"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d2fd2915_0f112e51","line":32,"range":{"start_line":29,"start_character":1,"end_line":32,"end_character":0},"in_reply_to":"900bdfdc_36b7be0a","updated":"2023-08-24 10:52:12.000000000","message":"Done","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"beaa7dd1353ebbb1772f3a12b2f6367de1e4ea06","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Bootstrap new cluster"},{"line_number":3,"context_line":"  block:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB (new cluster)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5b684841_0118442c","line":2,"updated":"2023-08-22 15:58:14.000000000","message":"commenting on the whole bootstrap process, but I\u0027m really not sure:\n\nshouldn\u0027t we actually check that we are building at least a 3 node cluster to be able to achieve a viable ha quorum?","commit_id":"9063c03c5b7294de8484e25cbc470315ee490d07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Bootstrap new cluster"},{"line_number":3,"context_line":"  block:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB (new cluster)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"598aca8f_21741771","line":2,"in_reply_to":"560f9296_49e1a7a2","updated":"2023-08-24 10:52:12.000000000","message":"And find out that there are people running two controllers? We\u0027re not doing that in MariaDB, so I guess if we want to do that - it should be universally done (so as a followup).","commit_id":"9063c03c5b7294de8484e25cbc470315ee490d07"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"293805418d11f2bf56a53b9d1bf0fb66383b1093","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Bootstrap new cluster"},{"line_number":3,"context_line":"  block:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    - name: Set bootstrap args fact for NB (new cluster)"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"560f9296_49e1a7a2","line":2,"in_reply_to":"5b684841_0118442c","updated":"2023-08-24 10:49:59.000000000","message":"This would not pass on a single controller / all in one environment. I suppose we could check for 1 or \u003e\u003d3 nodes.","commit_id":"9063c03c5b7294de8484e25cbc470315ee490d07"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6205967c4a77f93ad249ae1269471620b4cd66cb","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1d5748c5_61bfc3b7","line":40,"updated":"2023-08-24 11:04:24.000000000","message":"Isn\u0027t this only a problem if the node doesn\u0027t have a volume?","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fc735f89705eaf5b926bb1a2272649c7ebfcc30d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"e48e1bc8_6bb815ec","line":40,"in_reply_to":"1d5748c5_61bfc3b7","updated":"2023-08-24 11:13:32.000000000","message":"All the other cluster nodes are barfing that they did get a packet from node A but there\u0027s a second node under this address and they expected a packet from the second node. \nThe obvious choice is to fail and point users to some guide how to remove a node from the cluster (will add some docs on this) - we could remove it automatically, but maybe there\u0027s some edge case.","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"882272413b0e03452d1552231bf435fb5931b617","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fe037837_a871f047","line":40,"in_reply_to":"860604de_0d9f9ac5","updated":"2023-08-28 08:47:23.000000000","message":"Done","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed26b01bb0e29555be784801c0680403f7b96499","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"b14e205c_2b61b58c","line":40,"in_reply_to":"9937c327_536b42f7","updated":"2023-08-24 12:55:10.000000000","message":"Makes sense, although if it\u0027s just a single command we may as well just remove the old node?","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d5e528e96e4fd1332a0b05afeef180176d729294","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"860604de_0d9f9ac5","line":40,"in_reply_to":"b14e205c_2b61b58c","updated":"2023-08-24 12:58:17.000000000","message":"Let me try and do some testing","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0d8f46fbc0c8522eada7680d542a703ed7c2016","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9937c327_536b42f7","line":40,"in_reply_to":"d85a9935_b455b226","updated":"2023-08-24 12:45:24.000000000","message":"at some point in time it was a member and raft is not removing cluster members after any timeout, so it will stay there forever and confuse raft/ovsdb cluster\nBasically here we\u0027re trying to fail when bootstrapping a new cluster member with the same ip that already existent cluster node","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a929fc224614cce325535565959d630ac7d91472","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    - name: Fail when a node with same ip exists in NB DB"},{"line_number":38,"context_line":"      fail:"},{"line_number":39,"context_line":"        msg: \"Cluster node with address {{ api_interface_address }} already exists, please remove it from cluster\""},{"line_number":40,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Fail when a node with same ip exists in SB DB"},{"line_number":43,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"d85a9935_b455b226","line":40,"in_reply_to":"e48e1bc8_6bb815ec","updated":"2023-08-24 12:41:23.000000000","message":"I suppose it depends on what it means when the IP exists in the DB. Does that mean that it thinks the IP is an active member of the cluster, or that perhaps that it was recently and is within some timeout, or just that at some point in the past it was a member?","commit_id":"3ed7f9dd473c4051e6601ca003ebff510c395562"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f32473bef72769f82426764748d33ccd0d749524","unresolved":true,"context_lines":[{"line_number":19,"context_line":"      become: true"},{"line_number":20,"context_line":"      changed_when: false"},{"line_number":21,"context_line":"      register: ovn_nb_db_cluster_status"},{"line_number":22,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is defined and inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":23,"context_line":"      delegate_to: \"{{ groups[\u0027ovn-nb-db_leader\u0027][0] }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Check SB cluster status"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5803bb1d_51d442bf","line":22,"updated":"2023-08-31 12:25:30.000000000","message":"This task is conditional","commit_id":"3fd6b3613b033ff53d50d60d5010a6c5d2c01ab2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33e8478ce622676f7260a55ba05ecddb1b6fc109","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      become: true"},{"line_number":20,"context_line":"      changed_when: false"},{"line_number":21,"context_line":"      register: ovn_nb_db_cluster_status"},{"line_number":22,"context_line":"      when: groups[\u0027ovn-nb-db_leader\u0027] is defined and inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":23,"context_line":"      delegate_to: \"{{ groups[\u0027ovn-nb-db_leader\u0027][0] }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Check SB cluster status"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"8c27ec96_3282feb5","line":22,"in_reply_to":"5803bb1d_51d442bf","updated":"2023-09-01 07:37:49.000000000","message":"Done","commit_id":"3fd6b3613b033ff53d50d60d5010a6c5d2c01ab2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f32473bef72769f82426764748d33ccd0d749524","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      command: \u003e"},{"line_number":40,"context_line":"        {{ kolla_container_engine }} exec ovn_nb_db ovs-appctl -t {{ ovn_db_path }}/ovnnb_db.ctl"},{"line_number":41,"context_line":"        cluster/kick OVN_Northbound {{ ovn_nb_old_node }}"},{"line_number":42,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address)) and inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":43,"context_line":"      delegate_to: \"{{ groups[\u0027ovn-nb-db_leader\u0027][0] }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Remove an old node with the same ip address as the new node in SB DB"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"e792cdd6_02eac89d","line":42,"updated":"2023-08-31 12:25:30.000000000","message":"But this one references ovn_nb_db_cluster_status unconditionally.\n\nAlso, should this be ovn_nb_db_cluster_status.stdout is search(... ?\n\n(same for SB of course)","commit_id":"3fd6b3613b033ff53d50d60d5010a6c5d2c01ab2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33e8478ce622676f7260a55ba05ecddb1b6fc109","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      command: \u003e"},{"line_number":40,"context_line":"        {{ kolla_container_engine }} exec ovn_nb_db ovs-appctl -t {{ ovn_db_path }}/ovnnb_db.ctl"},{"line_number":41,"context_line":"        cluster/kick OVN_Northbound {{ ovn_nb_old_node }}"},{"line_number":42,"context_line":"      when: (ovn_nb_db_cluster_status is search(\u0027at tcp:\u0027 + api_interface_address)) and inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":43,"context_line":"      delegate_to: \"{{ groups[\u0027ovn-nb-db_leader\u0027][0] }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Remove an old node with the same ip address as the new node in SB DB"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"fad20a03_314c7727","line":42,"in_reply_to":"e792cdd6_02eac89d","updated":"2023-09-01 07:37:49.000000000","message":"Done","commit_id":"3fd6b3613b033ff53d50d60d5010a6c5d2c01ab2"}],"ansible/roles/ovn-db/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: lookup_cluster.yml"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"f482148d_7033df61","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"updated":"2023-05-09 15:53:38.000000000","message":"include_tasks","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: lookup_cluster.yml"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ad25fc84_282b9628","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":14},"in_reply_to":"f482148d_7033df61","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: lookup_cluster.yml"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3dfd0b73_5a2124be","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":47},"updated":"2023-05-09 15:53:38.000000000","message":"- inventory_hostname in groups[\u0027ovn-nb-db\u0027] or\n      inventory_hostname in groups[\u0027ovn-sb-db\u0027]","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: lookup_cluster.yml"},{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"4397887e_5f81076f","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":47},"in_reply_to":"3dfd0b73_5a2124be","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"a328a2da_57e17189","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":14},"updated":"2023-05-09 15:53:38.000000000","message":"include_tasks","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"668db422_8ec4719e","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":14},"in_reply_to":"a328a2da_57e17189","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":11,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":12,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"db0454ad_b082a7b7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"updated":"2023-05-09 15:53:38.000000000","message":"Remove - Implied by the following two","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- import_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":11,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":12,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"985a1611_f24bb63b","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"db0454ad_b082a7b7","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":11,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":12,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- import_tasks: config.yml"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"80b29eb0_f60ff8d7","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":72},"updated":"2023-05-09 15:53:38.000000000","message":"- inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027) or\n      inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[\u0027ovn-nb-db\u0027]"},{"line_number":10,"context_line":"    - inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":11,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":12,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- import_tasks: config.yml"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ff6963ab_e446e474","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":72},"in_reply_to":"80b29eb0_f60ff8d7","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a0484e1e848156baa36992655d2090ab3d9cdff","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- include_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027) or"},{"line_number":10,"context_line":"      inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- import_tasks: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"4cc6bd6e_4a5a65c5","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":72},"updated":"2023-08-17 14:38:52.000000000","message":"This doesn\u0027t catch the case where there is a volume but no leader.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- include_tasks: bootstrap-initial.yml"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups.get(\u0027ovn-nb-db_had_volume_False\u0027, \u0027\u0027) or"},{"line_number":10,"context_line":"      inventory_hostname in groups.get(\u0027ovn-sb-db_had_volume_False\u0027, \u0027\u0027)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- import_tasks: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e1a6f1b6_26d34bc3","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":72},"in_reply_to":"4cc6bd6e_4a5a65c5","updated":"2023-08-24 10:52:12.000000000","message":"Now it does, in lookup_cluster.yml","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"}],"ansible/roles/ovn-db/tasks/lookup_cluster.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fa059dd2dd54f719e5e5378a4b0296dc86a652f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        - groups[\u0027ovn-nb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Get OVN NB database information"},{"line_number":55,"context_line":"      command: \u0027docker exec ovn_nb_db ovsdb-client query unix:/run/ovn/ovnnb_db.sock \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Northbound\\\"]],\\\"op\\\":\\\"select\\\"}]\"\u0027"},{"line_number":56,"context_line":"      become: true"},{"line_number":57,"context_line":"      changed_when: false"},{"line_number":58,"context_line":"      register: ovn_nb_db_info"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"77c1cca5_290319fc","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":194},"updated":"2023-04-24 17:42:24.000000000","message":"yaml support multiline strings","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        - groups[\u0027ovn-nb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Get OVN NB database information"},{"line_number":55,"context_line":"      command: \u0027docker exec ovn_nb_db ovsdb-client query unix:/run/ovn/ovnnb_db.sock \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Northbound\\\"]],\\\"op\\\":\\\"select\\\"}]\"\u0027"},{"line_number":56,"context_line":"      become: true"},{"line_number":57,"context_line":"      changed_when: false"},{"line_number":58,"context_line":"      register: ovn_nb_db_info"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5e22dbaf_4dfe6b96","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":194},"in_reply_to":"77c1cca5_290319fc","updated":"2023-05-09 09:47:24.000000000","message":"Done","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fa059dd2dd54f719e5e5378a4b0296dc86a652f","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    - name: Get OVN SB database information"},{"line_number":94,"context_line":"      command: \u0027docker exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\"\u0027"},{"line_number":95,"context_line":"      become: true"},{"line_number":96,"context_line":"      changed_when: false"},{"line_number":97,"context_line":"      register: ovn_sb_db_info"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"67704a96_5dfd8210","line":94,"range":{"start_line":94,"start_character":6,"end_line":94,"end_character":194},"updated":"2023-04-24 17:42:24.000000000","message":"ditto","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    - name: Get OVN SB database information"},{"line_number":94,"context_line":"      command: \u0027docker exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\"\u0027"},{"line_number":95,"context_line":"      become: true"},{"line_number":96,"context_line":"      changed_when: false"},{"line_number":97,"context_line":"      register: ovn_sb_db_info"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0a92f495_ac57f251","line":94,"range":{"start_line":94,"start_character":6,"end_line":94,"end_character":194},"in_reply_to":"67704a96_5dfd8210","updated":"2023-05-09 09:47:24.000000000","message":"Done","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        key: \"ovn-nb-db_port_alive_{{ check_ovn_nb_db_port_liveness is success }}\""},{"line_number":44,"context_line":"      changed_when: false"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Fail on existing but stopped NB cluster"},{"line_number":47,"context_line":"      fail:"},{"line_number":48,"context_line":"        msg: OVN NB cluster node exists but is stopped - please start it."},{"line_number":49,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"38e49375_761fccda","line":46,"updated":"2023-05-09 15:53:38.000000000","message":"This is taken from the mariadb role where you need to run the mariadb_recovery command in this case. We don\u0027t have an equivalent for OVN - presumably the user is running a deploy to try to start the cluster.","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6a3d65d24c6b736cde0702614f027cde33d42dbd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        key: \"ovn-nb-db_port_alive_{{ check_ovn_nb_db_port_liveness is success }}\""},{"line_number":44,"context_line":"      changed_when: false"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Fail on existing but stopped NB cluster"},{"line_number":47,"context_line":"      fail:"},{"line_number":48,"context_line":"        msg: OVN NB cluster node exists but is stopped - please start it."},{"line_number":49,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"2bd4a2be_082eb02a","line":46,"in_reply_to":"38e49375_761fccda","updated":"2023-08-16 11:59:39.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1572c14dcea8aee7fe34fa12358ad487dc588b7c","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - ovn_nb_db_cluster_exists"},{"line_number":51,"context_line":"        - inventory_hostname in groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":52,"context_line":"        - groups[\u0027ovn-nb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Get OVN NB database information"},{"line_number":55,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fe5fe018_1b9580a2","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":32},"updated":"2023-05-09 15:53:38.000000000","message":"remove","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9702e7ccbd3c485a9e78810b38d670c708a88fa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - ovn_nb_db_cluster_exists"},{"line_number":51,"context_line":"        - inventory_hostname in groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":52,"context_line":"        - groups[\u0027ovn-nb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: Get OVN NB database information"},{"line_number":55,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ef0b170d_ae90de61","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":32},"in_reply_to":"fe5fe018_1b9580a2","updated":"2023-08-16 11:59:28.000000000","message":"Done","commit_id":"e38d9959a939cb9905e4ff0e119f3411811f18bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a0484e1e848156baa36992655d2090ab3d9cdff","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: OVN NB checks"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"527dd25e_77b2b77d","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":0},"updated":"2023-08-17 14:38:52.000000000","message":"Don\u0027t need these.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: OVN NB checks"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fd3f3d93_3dd7c3b0","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":0},"in_reply_to":"064be4e0_12c491da","updated":"2023-08-24 10:52:12.000000000","message":"Ack","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc226c530c2b3a996316f6fa3de8bcc075ae97","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: OVN NB checks"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"cb502e8f_f077fd74","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":0},"in_reply_to":"527dd25e_77b2b77d","updated":"2023-08-21 09:09:02.000000000","message":"maybe it\u0027s just me, but could you maybe elaborate why these are not needed? I don\u0027t understand why. 😞","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fae6e0b80bb802e41dc192c9069075b06d87f392","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: OVN NB checks"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fec6d62f_fbf14c83","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":0},"in_reply_to":"cb502e8f_f077fd74","updated":"2023-08-21 11:40:53.000000000","message":"Pull down the code, git grep ovn_nb_db_cluster_exists","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c628e61e88ffab667d6446abe8659affef670875","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: OVN NB checks"},{"line_number":30,"context_line":"  block:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"064be4e0_12c491da","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":0},"in_reply_to":"fec6d62f_fbf14c83","updated":"2023-08-21 13:08:14.000000000","message":"That was a really complicated way of saying that this fact is not used anywhere.\nThanks anyway.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a0484e1e848156baa36992655d2090ab3d9cdff","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      register: check_ovn_nb_db_port_liveness"},{"line_number":39,"context_line":"      ignore_errors: yes"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: Divide hosts by their OVN NB service port liveness"},{"line_number":42,"context_line":"      group_by:"},{"line_number":43,"context_line":"        key: \"ovn-nb-db_port_alive_{{ check_ovn_nb_db_port_liveness is success }}\""},{"line_number":44,"context_line":"      changed_when: false"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Get OVN NB database information"},{"line_number":47,"context_line":"      command: \u003e"},{"line_number":48,"context_line":"        docker exec ovn_nb_db ovsdb-client query unix:/run/ovn/ovnnb_db.sock"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9cd16a1e_66aede9e","line":45,"range":{"start_line":41,"start_character":0,"end_line":45,"end_character":0},"updated":"2023-08-17 14:38:52.000000000","message":"Don\u0027t need this (or SB equivalent)","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2bc34f47824e7b4d9d4b985e7e63c0ff133119c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      register: check_ovn_nb_db_port_liveness"},{"line_number":39,"context_line":"      ignore_errors: yes"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: Divide hosts by their OVN NB service port liveness"},{"line_number":42,"context_line":"      group_by:"},{"line_number":43,"context_line":"        key: \"ovn-nb-db_port_alive_{{ check_ovn_nb_db_port_liveness is success }}\""},{"line_number":44,"context_line":"      changed_when: false"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Get OVN NB database information"},{"line_number":47,"context_line":"      command: \u003e"},{"line_number":48,"context_line":"        docker exec ovn_nb_db ovsdb-client query unix:/run/ovn/ovnnb_db.sock"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ffa55be2_94af17b1","line":45,"range":{"start_line":41,"start_character":0,"end_line":45,"end_character":0},"in_reply_to":"9cd16a1e_66aede9e","updated":"2023-08-24 10:52:12.000000000","message":"Now we do - we need to check for nodes that have a volume but are offline.","commit_id":"4dbb7656d0eea663de3a6b55790798c6339ed35e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd8cac7bad7d8adc8403be625a19e1986aa63112","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        key: \"ovn-sb-db_port_alive_{{ check_ovn_sb_db_port_liveness is success }}\""},{"line_number":77,"context_line":"      changed_when: false"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: Fail on existing but stopped SB cluster"},{"line_number":80,"context_line":"      fail:"},{"line_number":81,"context_line":"        msg: OVN SB cluster node exists but is stopped - please start it."},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - ovn_sb_db_cluster_exists"},{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"10abe5dd_8f98c265","line":85,"range":{"start_line":79,"start_character":0,"end_line":85,"end_character":65},"updated":"2023-08-17 14:19:17.000000000","message":"This task was removed for NB but not SB.","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cdd65b8ec23d9be7e9b2452e386aa93733d166b9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        key: \"ovn-sb-db_port_alive_{{ check_ovn_sb_db_port_liveness is success }}\""},{"line_number":77,"context_line":"      changed_when: false"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: Fail on existing but stopped SB cluster"},{"line_number":80,"context_line":"      fail:"},{"line_number":81,"context_line":"        msg: OVN SB cluster node exists but is stopped - please start it."},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - ovn_sb_db_cluster_exists"},{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"6a98c48a_860fbea3","line":85,"range":{"start_line":79,"start_character":0,"end_line":85,"end_character":65},"in_reply_to":"10abe5dd_8f98c265","updated":"2023-08-22 11:11:40.000000000","message":"Actually we might need it for both - when the cluster node is stopped, but there\u0027s a volume we might have a case where the cluster node was stopped for long time and it has inconsistent state - it might take considerable amount of time for the offline node to catch up.","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6205967c4a77f93ad249ae1269471620b4cd66cb","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        key: \"ovn-sb-db_port_alive_{{ check_ovn_sb_db_port_liveness is success }}\""},{"line_number":77,"context_line":"      changed_when: false"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: Fail on existing but stopped SB cluster"},{"line_number":80,"context_line":"      fail:"},{"line_number":81,"context_line":"        msg: OVN SB cluster node exists but is stopped - please start it."},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - ovn_sb_db_cluster_exists"},{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fdd9355a_10f2385d","line":85,"range":{"start_line":79,"start_character":0,"end_line":85,"end_character":65},"in_reply_to":"6a98c48a_860fbea3","updated":"2023-08-24 11:04:24.000000000","message":"I thought we discussed this. What would a user do that kolla-ansible would not to resolve the issue?","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fc735f89705eaf5b926bb1a2272649c7ebfcc30d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        key: \"ovn-sb-db_port_alive_{{ check_ovn_sb_db_port_liveness is success }}\""},{"line_number":77,"context_line":"      changed_when: false"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: Fail on existing but stopped SB cluster"},{"line_number":80,"context_line":"      fail:"},{"line_number":81,"context_line":"        msg: OVN SB cluster node exists but is stopped - please start it."},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - ovn_sb_db_cluster_exists"},{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"b1261a5f_90086235","line":85,"range":{"start_line":79,"start_character":0,"end_line":85,"end_character":65},"in_reply_to":"fdd9355a_10f2385d","updated":"2023-08-24 11:13:32.000000000","message":"Yeah, I just tested it multiple times and we can just skip it, will post a new patchset.","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd8cac7bad7d8adc8403be625a19e1986aa63112","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"},{"line_number":89,"context_line":"        docker exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock"},{"line_number":90,"context_line":"        \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\""},{"line_number":91,"context_line":"      become: true"},{"line_number":92,"context_line":"      changed_when: false"},{"line_number":93,"context_line":"      register: ovn_sb_db_info"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":96,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"6468aa40_75ee49b6","line":93,"range":{"start_line":87,"start_character":1,"end_line":93,"end_character":30},"updated":"2023-08-17 14:19:17.000000000","message":"But looking again, this task (and NB equivalent) will fail if the node is stopped.","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cdd65b8ec23d9be7e9b2452e386aa93733d166b9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        - inventory_hostname in groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027]"},{"line_number":85,"context_line":"        - groups[\u0027ovn-sb-db\u0027 + \u0027_port_alive_True\u0027] is not defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - name: Get OVN SB database information"},{"line_number":88,"context_line":"      command: \u003e"},{"line_number":89,"context_line":"        docker exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock"},{"line_number":90,"context_line":"        \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\""},{"line_number":91,"context_line":"      become: true"},{"line_number":92,"context_line":"      changed_when: false"},{"line_number":93,"context_line":"      register: ovn_sb_db_info"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":96,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"645ce904_1769cab3","line":93,"range":{"start_line":87,"start_character":1,"end_line":93,"end_character":30},"in_reply_to":"6468aa40_75ee49b6","updated":"2023-08-22 11:11:40.000000000","message":"if we fail when it\u0027s down, then it\u0027s solved. ;-)","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d38c293f678108a3a9bcb689db295c8fc60f8fe9","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        {{ kolla_container_engine }} exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock"},{"line_number":112,"context_line":"        \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\""},{"line_number":113,"context_line":"      become: true"},{"line_number":114,"context_line":"      changed_when: false"},{"line_number":115,"context_line":"      register: ovn_sb_db_info"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"80b22647_6ec1a694","line":114,"updated":"2023-08-31 09:08:17.000000000","message":"Need a similar liveness condition here","commit_id":"100c9d7ba45ae536404c433d797a68d254970031"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4cd249d3786acfebc4852cc4f9ba785cb48f7fb4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        {{ kolla_container_engine }} exec ovn_sb_db ovsdb-client query unix:/run/ovn/ovnsb_db.sock"},{"line_number":112,"context_line":"        \"[\\\"_Server\\\",{\\\"table\\\":\\\"Database\\\",\\\"where\\\":[[\\\"name\\\",\\\"\u003d\u003d\\\", \\\"OVN_Southbound\\\"]],\\\"op\\\":\\\"select\\\"}]\""},{"line_number":113,"context_line":"      become: true"},{"line_number":114,"context_line":"      changed_when: false"},{"line_number":115,"context_line":"      register: ovn_sb_db_info"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"5f5ea535_8ca10b33","line":114,"in_reply_to":"80b22647_6ec1a694","updated":"2023-08-31 09:11:11.000000000","message":"Done","commit_id":"100c9d7ba45ae536404c433d797a68d254970031"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d38c293f678108a3a9bcb689db295c8fc60f8fe9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":118,"context_line":"      group_by:"},{"line_number":119,"context_line":"        key: \"ovn-sb-db_{{ \u0027leader\u0027 if (ovn_sb_db_info.stdout | from_json).0.rows.0.leader else \u0027follower\u0027 }}\""},{"line_number":120,"context_line":"      changed_when: false"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    - name: Fail on existing cluster with no leader"},{"line_number":123,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"0295e00e_a7f7d5ba","line":120,"updated":"2023-08-31 09:08:17.000000000","message":"and here","commit_id":"100c9d7ba45ae536404c433d797a68d254970031"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4cd249d3786acfebc4852cc4f9ba785cb48f7fb4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":118,"context_line":"      group_by:"},{"line_number":119,"context_line":"        key: \"ovn-sb-db_{{ \u0027leader\u0027 if (ovn_sb_db_info.stdout | from_json).0.rows.0.leader else \u0027follower\u0027 }}\""},{"line_number":120,"context_line":"      changed_when: false"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    - name: Fail on existing cluster with no leader"},{"line_number":123,"context_line":"      fail:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"f241a401_7da1c1e7","line":120,"in_reply_to":"0295e00e_a7f7d5ba","updated":"2023-08-31 09:11:11.000000000","message":"Done","commit_id":"100c9d7ba45ae536404c433d797a68d254970031"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5bd9ae98ad069a2726d588a560a3e74c15cf0c35","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":119,"context_line":"      group_by:"},{"line_number":120,"context_line":"        key: \"ovn-sb-db_{{ \u0027leader\u0027 if (ovn_sb_db_info.stdout | from_json).0.rows.0.leader else \u0027follower\u0027 }}\""},{"line_number":121,"context_line":"      when: check_ovn_nb_db_port_liveness is success"},{"line_number":122,"context_line":"      changed_when: false"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    - name: Fail on existing cluster with no leader"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"f16b103b_b0ca315d","line":121,"updated":"2023-08-31 09:49:06.000000000","message":"sb","commit_id":"b57860cc9dea2caf6d09f038e3afb052b7c8f115"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83cb4d4aadfc5e0a53344ecdfea7dbe615a2ab09","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    - name: Divide hosts by their OVN SB leader/follower role"},{"line_number":119,"context_line":"      group_by:"},{"line_number":120,"context_line":"        key: \"ovn-sb-db_{{ \u0027leader\u0027 if (ovn_sb_db_info.stdout | from_json).0.rows.0.leader else \u0027follower\u0027 }}\""},{"line_number":121,"context_line":"      when: check_ovn_nb_db_port_liveness is success"},{"line_number":122,"context_line":"      changed_when: false"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    - name: Fail on existing cluster with no leader"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"ae955794_a538267a","line":121,"in_reply_to":"f16b103b_b0ca315d","updated":"2023-08-31 09:51:31.000000000","message":"Done","commit_id":"b57860cc9dea2caf6d09f038e3afb052b7c8f115"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4b0ed84e2f64a96a9c07c57047500752dad4496c","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"80605ff2_8263a11f","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":57},"updated":"2023-08-31 16:10:02.000000000","message":"imho the task name should include if it\u0027s about nb or sb, e.g. to make debugging easier.","commit_id":"f5ae9d62d811e834ec8da8e3ce46f447b13546b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33e8478ce622676f7260a55ba05ecddb1b6fc109","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    key: \"ovn-sb-db_had_volume_{{ ovn_db_container_volume_facts[\u0027ovn_sb_db\u0027] is defined }}\""},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"408265bb_ea5751ec","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":57},"in_reply_to":"80605ff2_8263a11f","updated":"2023-09-01 07:37:49.000000000","message":"Done","commit_id":"f5ae9d62d811e834ec8da8e3ce46f447b13546b9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4b0ed84e2f64a96a9c07c57047500752dad4496c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"ce4ea1d2_cb061cc0","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"updated":"2023-08-31 16:10:02.000000000","message":"imho the task name should include if it\u0027s about nb or sb, e.g. to make debugging easier.","commit_id":"f5ae9d62d811e834ec8da8e3ce46f447b13546b9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33e8478ce622676f7260a55ba05ecddb1b6fc109","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  set_fact:"},{"line_number":23,"context_line":"    ovn_nb_db_cluster_exists: \"{{ groups[\u0027ovn-nb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Establish whether the cluster has already existed"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ovn_sb_db_cluster_exists: \"{{ groups[\u0027ovn-sb-db\u0027 + \u0027_had_volume_True\u0027] is defined }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"37fbb04c_5c2fb9e3","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"in_reply_to":"ce4ea1d2_cb061cc0","updated":"2023-09-01 07:37:49.000000000","message":"Done","commit_id":"f5ae9d62d811e834ec8da8e3ce46f447b13546b9"}],"ansible/roles/ovn-db/templates/ovn-nb-db.json.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fa059dd2dd54f719e5e5378a4b0296dc86a652f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_nb_ovsdb --db-nb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-nb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_nb_db_bootstrap_args | default() }} --db-nb-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"49eecf25_e0322cf1","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"updated":"2023-04-24 17:42:24.000000000","message":"json also support multiline strings","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"92a1f0842eab34deae1fca6950bb408d6e0fb24d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_nb_ovsdb --db-nb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-nb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_nb_db_bootstrap_args | default() }} --db-nb-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"5fcdc15d_0fff2e7b","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"in_reply_to":"405061e2_0c398d00","updated":"2023-05-09 09:56:59.000000000","message":"I found only this: https://stackoverflow.com/a/2392888\n\nbut not sure that is really better/more readable?\n\nI also don\u0027t really find anything in the standard at: https://www.rfc-editor.org/rfc/rfc8259","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a0712cb3128e54240737b87de7369c0135375a4e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_nb_ovsdb --db-nb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-nb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_nb_db_bootstrap_args | default() }} --db-nb-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"405061e2_0c398d00","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"in_reply_to":"49eecf25_e0322cf1","updated":"2023-05-09 09:47:24.000000000","message":"since when?","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"31c4a7ae4e2c6577ce277df50dfb46466752b7f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_nb_ovsdb --db-nb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-nb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_nb_db_bootstrap_args | default() }} --db-nb-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"c3b17545_3a8d4a8f","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"in_reply_to":"5fcdc15d_0fff2e7b","updated":"2023-05-09 11:45:00.000000000","message":"Michal, ideal solution","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"}],"ansible/roles/ovn-db/templates/ovn-sb-db.json.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fa059dd2dd54f719e5e5378a4b0296dc86a652f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_sb_ovsdb --db-sb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-sb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_sb_db_bootstrap_args | default() }} --db-sb-sock\u003d/run/ovn/ovnsb_db.sock --db-sb-pid\u003d/run/ovn/ovnsb_db.pid --db-sb-file\u003d/var/lib/openvswitch/ovn-sb/ovnsb.db --ovn-sb-logfile\u003d/var/log/kolla/openvswitch/ovn-sb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"d914a2e1_7bd57d8d","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"updated":"2023-04-24 17:42:24.000000000","message":"ditto","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"31c4a7ae4e2c6577ce277df50dfb46466752b7f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/share/ovn/scripts/ovn-ctl run_sb_ovsdb --db-sb-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} --db-sb-cluster-local-addr\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }} {{ ovn_sb_db_bootstrap_args | default() }} --db-sb-sock\u003d/run/ovn/ovnsb_db.sock --db-sb-pid\u003d/run/ovn/ovnsb_db.pid --db-sb-file\u003d/var/lib/openvswitch/ovn-sb/ovnsb.db --ovn-sb-logfile\u003d/var/log/kolla/openvswitch/ovn-sb-db.log\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"e4ff52ac_bb35cff5","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":442},"in_reply_to":"d914a2e1_7bd57d8d","updated":"2023-05-09 11:45:00.000000000","message":"Done","commit_id":"d73ab25b5554a29054598d0be9d4b6a38ccaa076"}],"releasenotes/notes/1875223-05552108375d005a.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd8cac7bad7d8adc8403be625a19e1986aa63112","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes issues with OVN NB/DB deployment, where first"},{"line_number":5,"context_line":"    node needs to rebootstrapped."},{"line_number":6,"context_line":"    `LP#1875223 \u003chttps://launchpad.net/bugs/1875223\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"d562f9b4_fdfdd26e","line":4,"updated":"2023-08-17 14:19:17.000000000","message":"NB/SB DB","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cdd65b8ec23d9be7e9b2452e386aa93733d166b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes issues with OVN NB/DB deployment, where first"},{"line_number":5,"context_line":"    node needs to rebootstrapped."},{"line_number":6,"context_line":"    `LP#1875223 \u003chttps://launchpad.net/bugs/1875223\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"73c8bb35_b6655784","line":4,"in_reply_to":"d562f9b4_fdfdd26e","updated":"2023-08-22 11:11:40.000000000","message":"Done","commit_id":"c54901e828676e05dad9769f4c0bb61add626419"}]}
