)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     1f71aa56 (CI: Support tox4)"},{"line_number":2,"context_line":"Author:     Dawud M \u003c7688823+technowhizz@users.noreply.github.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2022-12-29 23:37:38 +0000"},{"line_number":4,"context_line":"Commit:     Dawud M \u003cdawud@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-30 20:37:26 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff33f47b_5280b248","line":2,"updated":"2023-01-02 10:34:27.000000000","message":"Nit: Did you pull this commit from github? Not sure this email address is useful.","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add filter to label groups for prometheus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the filter \u0027return_inventory_group\u0027 which takes in"},{"line_number":10,"context_line":"a host and the inventory groups varible and returns the group to which"},{"line_number":11,"context_line":"the host belongs based on the following hierarchy:"},{"line_number":12,"context_line":"Controllers -\u003e Compute -\u003e Storage -\u003e Network -\u003e Monitoring."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ea46b9d_77c18606","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":51},"updated":"2023-01-02 10:34:27.000000000","message":"What\u0027s the meaning of the \"return_\" prefix? Could we just use \"inventory_group\"?","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add filter to label groups for prometheus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the filter \u0027return_inventory_group\u0027 which takes in"},{"line_number":10,"context_line":"a host and the inventory groups varible and returns the group to which"},{"line_number":11,"context_line":"the host belongs based on the following hierarchy:"},{"line_number":12,"context_line":"Controllers -\u003e Compute -\u003e Storage -\u003e Network -\u003e Monitoring."},{"line_number":13,"context_line":"This group can then be used to add a custom label in prometheus."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"03022dd5_261aa280","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":39},"updated":"2023-01-02 10:34:27.000000000","message":"variable","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This commit adds the filter \u0027return_inventory_group\u0027 which takes in"},{"line_number":10,"context_line":"a host and the inventory groups varible and returns the group to which"},{"line_number":11,"context_line":"the host belongs based on the following hierarchy:"},{"line_number":12,"context_line":"Controllers -\u003e Compute -\u003e Storage -\u003e Network -\u003e Monitoring."},{"line_number":13,"context_line":"This group can then be used to add a custom label in prometheus."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9d979f93fc121e3cabbbeaa9e6031629471a5794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"74d7d026_f8ba4369","line":12,"updated":"2023-01-02 10:34:27.000000000","message":"Is there a rationale for this hierarchy? The first two steps seem fine, the others I\u0027m not so sure about.","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":10,"context_line":"a host and the inventory groups varible and returns the group to which"},{"line_number":11,"context_line":"the host belongs based on the following hierarchy:"},{"line_number":12,"context_line":"Controllers -\u003e Compute -\u003e Storage -\u003e Network -\u003e Monitoring."},{"line_number":13,"context_line":"This group can then be used to add a custom label in prometheus."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9d979f93fc121e3cabbbeaa9e6031629471a5794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfa8f8e4_5f523684","line":13,"updated":"2023-01-02 10:34:27.000000000","message":"Is there an example available on how to actually do this? Should we even do this by default?","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"933838c207ed840136c2087f4403a62257007f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"087e71df_a1c16d53","updated":"2023-01-06 16:23:19.000000000","message":"We need to avoid hard coding all the groups. Let\u0027s put this on hold for now.","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"}],"kolla_ansible/filters.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":109,"context_line":"            if service_enabled_and_mapped_to_host(context, service)}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def return_inventory_group(host, groups):"},{"line_number":113,"context_line":"    if host in groups[\u0027controllers\u0027]:"},{"line_number":114,"context_line":"        group \u003d \u0027controllers\u0027"},{"line_number":115,"context_line":"    elif host in groups[\u0027compute\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b0a4ece_5ceab8da","line":112,"updated":"2023-01-02 10:34:27.000000000","message":"I\u0027m not sure that this module is the correct location for this function, since it is about service filtering. But maybe I\u0027m just missing the context on how to use this.","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"}],"kolla_ansible/tests/unit/test_filters.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7dbad56dda0e285af9c7a38bb0412f18ae2dfde","unresolved":true,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        host \u003d \"comp-node1\""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        groups \u003d {"},{"line_number":575,"context_line":"            \u0027controllers\u0027: [\u0027con-node1\u0027, \u0027con-node2\u0027, \u0027con-node3\u0027],"},{"line_number":576,"context_line":"            \u0027network\u0027: [\u0027con-node1\u0027, \u0027con-node2\u0027, \u0027con-node3\u0027],"},{"line_number":577,"context_line":"            \u0027compute\u0027: [\u0027comp-node1\u0027, \u0027comp-node2\u0027, \u0027comp-node3\u0027, \u0027comp-node4\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"091eabe8_e7c02cbe","line":574,"updated":"2023-01-02 10:34:27.000000000","message":"Can you make this a global variable in order to reduce duplication? Or maybe create a helper function that gets passed \"host\" and \"expected\".","commit_id":"fafc1dda8e245130ab24226503d06e6fc05a4b80"}]}