)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c2aefeacf3bc7c47d00e5c6b2ed365e3fe5ef19d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b438628_39b98bfa","updated":"2023-04-05 17:53:48.000000000","message":"here: https://github.com/Huawei/OpenStack_Driver/blob/2.1.RC4/ReleaseDoc/en/OpenStack%20Cinder%20Driver%20Configuration%20Guide.pdf\npage 4\nHuawei recommends for example use cinder_huawei_conf.xml\nsomeone can use their own name, so we need to support *.xml\nalso we need to configure cinder.conf with backend, driver and this name for option cinder_huawei_conf_file.\n","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":23871,"name":"MargaritaShakhova","email":"shakhova.margarita@gmail.com","username":"MargaritaShakhova"},"change_message_id":"42f31e4b3059e1ecdc6afd722cc32a1b0406d9d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"79893af7_76ce14c2","updated":"2023-04-06 18:08:22.000000000","message":"typo: /etc/huawei does not exist, shoud be /etc/cinder","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"52b608aec3836a7fb29eff944ae40921f482399a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"31b01b93_dc4eadcd","updated":"2023-04-05 17:36:38.000000000","message":"we need this https://github.com/huawei/openstack_driver.git merged into the Cinder code prior use these changes.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f1f3dc5fe246411757855d1c9386f871093fa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f62a70ff_d85036f6","in_reply_to":"1a3622d7_7017eb6e","updated":"2024-09-21 22:57:02.000000000","message":"Done","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b37449b224cb5a5f4fef3b93ea0984aa44a7c84d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a3622d7_7017eb6e","in_reply_to":"39058479_3cec8afe","updated":"2023-08-26 22:32:15.000000000","message":"it safe to have as many as you wish *.xml files in the /etc/cinder directory for any number of the backends.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"400f737293c50a05c1d1f6d593e7da8fe6890787","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"39058479_3cec8afe","in_reply_to":"79893af7_76ce14c2","updated":"2023-06-09 20:26:07.000000000","message":"The directory is created when copying the files. It was done this way as you can have multiple backend integrations, and we wish to keep their conf files separate for order sake.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d1981d7b9d46046a0439d2764d78e1be3d6f268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"52d5db6d_2df4359e","updated":"2023-06-12 07:49:48.000000000","message":"I don\u0027t see why this has to be specific about huawei? Can this be made mode generic to add data for any xyz backend?","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f1f3dc5fe246411757855d1c9386f871093fa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"542699c7_fda4d307","in_reply_to":"3aa31d22_6d4cb543","updated":"2024-09-21 22:57:02.000000000","message":"Done","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"1a86367b5675eac5aa048c8797620fb98717e133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"764dee8e_08892601","in_reply_to":"52d5db6d_2df4359e","updated":"2023-06-14 22:37:07.000000000","message":"Sure thing, we actually were discussing this same point with our team.","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b37449b224cb5a5f4fef3b93ea0984aa44a7c84d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3aa31d22_6d4cb543","in_reply_to":"764dee8e_08892601","updated":"2023-08-26 22:32:15.000000000","message":"I\u0027ve mentioned the option \u0027cinder_huawei_conf_file\u0027 before in the previous comments. please address it and do the changes to the cinder.conf template.","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"88e352e4b9a9da65ab4df515af8910b28197f588","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4c2225a0_ae3bfae4","updated":"2023-09-02 07:20:26.000000000","message":"As long as this isn\u0027t changed to be about generic cinder backends, I don\u0027t see this as feasible change.","commit_id":"4f5b91df460eb4412f8433cb93e6b23da33a5b07"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b37449b224cb5a5f4fef3b93ea0984aa44a7c84d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c7852971_5a35404d","updated":"2023-08-26 22:32:15.000000000","message":"Thanks Margarita, but we need more changes here, at least the cinder.conf template forgotten.","commit_id":"4f5b91df460eb4412f8433cb93e6b23da33a5b07"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f1f3dc5fe246411757855d1c9386f871093fa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"270bf36b_27cc004a","in_reply_to":"4c2225a0_ae3bfae4","updated":"2024-09-21 22:57:02.000000000","message":"completely updated change","commit_id":"4f5b91df460eb4412f8433cb93e6b23da33a5b07"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f1f3dc5fe246411757855d1c9386f871093fa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec04c418_d6e7aae2","in_reply_to":"c7852971_5a35404d","updated":"2024-09-21 22:57:02.000000000","message":"Done","commit_id":"4f5b91df460eb4412f8433cb93e6b23da33a5b07"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66cbcc7d19a8dd6352997471900aa73d56a57fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"238a1f2f_ca9e86a0","updated":"2024-09-25 15:29:10.000000000","message":"This still isn\u0027t really as generic as it could be IMO. Reducing my vote to -1 though in order to allow others to override if they see this differently.","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d8447f2bb3fcd726c841cf326e88bac0869c0424","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"44f148ea_32754fd9","updated":"2024-10-02 20:53:54.000000000","message":"please merge this as discussed in irc","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a604eeb5beaa025f7fe1503d0a756066c7bb1fa4","unresolved":true,"context_lines":[{"line_number":937,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":938,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":939,"context_line":"huawei_xml_files:"},{"line_number":940,"context_line":"  - \"cinder_dorado_v3.xml\""},{"line_number":941,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":942,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":943,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"88ef030d_392a184c","line":940,"range":{"start_line":940,"start_character":5,"end_line":940,"end_character":21},"updated":"2023-04-05 17:41:31.000000000","message":"we should use all possible filenames, use find files to form the list.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"1a86367b5675eac5aa048c8797620fb98717e133","unresolved":false,"context_lines":[{"line_number":937,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":938,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":939,"context_line":"huawei_xml_files:"},{"line_number":940,"context_line":"  - \"cinder_dorado_v3.xml\""},{"line_number":941,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":942,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":943,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2e870791_0ae33a61","line":940,"range":{"start_line":940,"start_character":5,"end_line":940,"end_character":21},"in_reply_to":"1fb12d3b_838805e0","updated":"2023-06-14 22:37:07.000000000","message":"Michal Nasiadka\nPatchset 14\nNov 25, 2022\ninstead of that and limiting users to ceph.conf, ceph1.conf, ceph2.conf etc - I think it would be better to have a list of ceph.conf files that need to be copied.\n\nJuan Pablo Suazo\nPatchset 14\nNov 25, 2022\nI need to update the commit contents, but what was agreed with the previous reviewer was creating a new \u003cconfig\u003e/cinder/ceph/ directory where all ceph conf files can be placed, regardless of name.\n\nThe legacy ceph.conf file is still being handled in the same way as before, so old deployments should work correctly.\n\nMichal Nasiadka\nPatchset 14\nNov 27, 2022\nI know it was, but if we do it this way - we\u0027ll end up with the issue that I pointed out in config.json file review - and personally I like to have ceph.confs named, instead of doing them numbered (like ceph-ec.conf, ceph-ec-secondpool.conf, instead of ceph1.conf ceph2.conf which are a bit meaningless unless you look inside).","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f9d078664579fffb7875a14283c2dfca960da55d","unresolved":true,"context_lines":[{"line_number":937,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":938,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":939,"context_line":"huawei_xml_files:"},{"line_number":940,"context_line":"  - \"cinder_dorado_v3.xml\""},{"line_number":941,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":942,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":943,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fb12d3b_838805e0","line":940,"range":{"start_line":940,"start_character":5,"end_line":940,"end_character":21},"in_reply_to":"76d3ecd8_f6c36585","updated":"2023-06-12 13:08:08.000000000","message":"there can be several cinder backends and several different xml files for each.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"400f737293c50a05c1d1f6d593e7da8fe6890787","unresolved":true,"context_lines":[{"line_number":937,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":938,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":939,"context_line":"huawei_xml_files:"},{"line_number":940,"context_line":"  - \"cinder_dorado_v3.xml\""},{"line_number":941,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":942,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":943,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"76d3ecd8_f6c36585","line":940,"range":{"start_line":940,"start_character":5,"end_line":940,"end_character":21},"in_reply_to":"88ef030d_392a184c","updated":"2023-06-09 20:26:07.000000000","message":"This way of declaring conf files was done in the same manner of other proposals similar to this, where core reviewers suggested doing it this way to avoid copying unwanted files. Originally, I had the same idea.","commit_id":"a7ff8271c4552febd795f63075da76160564e025"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66cbcc7d19a8dd6352997471900aa73d56a57fd4","unresolved":true,"context_lines":[{"line_number":1051,"context_line":"#################################"},{"line_number":1052,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":1053,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":1054,"context_line":"cinder_backend_huawei_xml_files: []"},{"line_number":1055,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":1056,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":1057,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b05de769_2691d4e0","line":1054,"range":{"start_line":1054,"start_character":0,"end_line":1054,"end_character":31},"updated":"2024-09-25 15:29:10.000000000","message":"I still do not see why this should have `huawei` in the name, it can be just any files needed for backend configuration? Doesn\u0027t even need to be XML. So how about simply `cinder_backend_extra_files`?","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d8447f2bb3fcd726c841cf326e88bac0869c0424","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"#################################"},{"line_number":1052,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":1053,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":1054,"context_line":"cinder_backend_huawei_xml_files: []"},{"line_number":1055,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":1056,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":1057,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c13ce1d4_130ea7a8","line":1054,"range":{"start_line":1054,"start_character":0,"end_line":1054,"end_character":31},"in_reply_to":"0e8fb778_a2883e12","updated":"2024-10-02 20:53:54.000000000","message":"Done","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8195645f6781714f37a3bf0c72f728e47d6eb034","unresolved":true,"context_lines":[{"line_number":1051,"context_line":"#################################"},{"line_number":1052,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":1053,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":1054,"context_line":"cinder_backend_huawei_xml_files: []"},{"line_number":1055,"context_line":"cinder_backend_vmwarevc_vmdk: \"no\""},{"line_number":1056,"context_line":"cinder_backend_vmware_vstorage_object: \"no\""},{"line_number":1057,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0e8fb778_a2883e12","line":1054,"range":{"start_line":1054,"start_character":0,"end_line":1054,"end_character":31},"in_reply_to":"b05de769_2691d4e0","updated":"2024-09-25 18:45:44.000000000","message":"because of: https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/huawei-storage-driver.html\nalso this mentioned in the commit message.","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"}],"ansible/roles/cinder/tasks/config.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66cbcc7d19a8dd6352997471900aa73d56a57fd4","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include_tasks: external_huawei.yml"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - cinder_backend_huawei | bool"},{"line_number":15,"context_line":"    - cinder_backend_huawei_xml_files | length \u003e 0"},{"line_number":16,"context_line":"    - inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a5d5913_d10f9c4f","line":14,"updated":"2024-09-25 15:29:10.000000000","message":"This var isn\u0027t needed at all I\u0027d think, just the length check is enough","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8195645f6781714f37a3bf0c72f728e47d6eb034","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include_tasks: external_huawei.yml"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - cinder_backend_huawei | bool"},{"line_number":15,"context_line":"    - cinder_backend_huawei_xml_files | length \u003e 0"},{"line_number":16,"context_line":"    - inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"26ef2a19_a98fbbbb","line":14,"in_reply_to":"7a5d5913_d10f9c4f","updated":"2024-09-25 18:45:44.000000000","message":"safecheck. backend can be enabled by mistake, without list of files there is no need to execute the task.","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"}],"ansible/roles/cinder/tasks/external_huawei.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66cbcc7d19a8dd6352997471900aa73d56a57fd4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over Huawei XML files"},{"line_number":3,"context_line":"  copy:"},{"line_number":4,"context_line":"    src: \"{{ node_custom_config }}/cinder/{{ item }}\""},{"line_number":5,"context_line":"    dest: \"{{ node_config_directory }}/cinder-volume/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2b613ee5_9b147a43","line":2,"updated":"2024-09-25 15:29:10.000000000","message":"Task name should also be generic, like the name of this file","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8195645f6781714f37a3bf0c72f728e47d6eb034","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over Huawei XML files"},{"line_number":3,"context_line":"  copy:"},{"line_number":4,"context_line":"    src: \"{{ node_custom_config }}/cinder/{{ item }}\""},{"line_number":5,"context_line":"    dest: \"{{ node_config_directory }}/cinder-volume/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6271ceef_d9340191","line":2,"in_reply_to":"2b613ee5_9b147a43","updated":"2024-09-25 18:45:44.000000000","message":"see 1st comment. its related.","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"}],"ansible/roles/cinder/templates/cinder-volume.json.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f9d078664579fffb7875a14283c2dfca960da55d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"{% for file in huawei_xml_files %}"},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"46f4906f_59da7807","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":32},"updated":"2023-06-12 13:08:08.000000000","message":"cinder","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6efb496596565d9647c7179c4662be147ba814bf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% for file in huawei_xml_files %}"},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"4f0a8323_ecfade31","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":32},"in_reply_to":"46f4906f_59da7807","updated":"2023-06-14 22:38:29.000000000","message":"will change it to cinder-backend for cleanliness\u0027 sake.","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f9d078664579fffb7875a14283c2dfca960da55d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"497eb239_68d7b6ce","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"updated":"2023-06-12 13:08:08.000000000","message":"0640","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"6efb496596565d9647c7179c4662be147ba814bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"96d2239e_56fcf165","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"in_reply_to":"497eb239_68d7b6ce","updated":"2023-06-14 22:38:29.000000000","message":"We tested this integration with both 0600 and 0640 permissions and both result in errors. 0700 did the trick.","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b37449b224cb5a5f4fef3b93ea0984aa44a7c84d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"a8791e02_623b58c0","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"in_reply_to":"96d2239e_56fcf165","updated":"2023-08-26 22:32:15.000000000","message":"0700 set the execute/search only if the file is a directory. how did you test this?)","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f1f3dc5fe246411757855d1c9386f871093fa42","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ file }}/\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/huawei/{{ file }}\","},{"line_number":8,"context_line":"            \"owner\": \"cinder\","},{"line_number":9,"context_line":"            \"perm\": \"0700\","},{"line_number":10,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":11,"context_line":"        },"},{"line_number":12,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3433a397_3325a6d2","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"in_reply_to":"a8791e02_623b58c0","updated":"2024-09-21 22:57:02.000000000","message":"Done","commit_id":"f41f71955df7d9180b883de54c83545af1ed3083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66cbcc7d19a8dd6352997471900aa73d56a57fd4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"            \"dest\": \"/etc/cinder/{{ file }}\","},{"line_number":13,"context_line":"            \"owner\": \"cinder\","},{"line_number":14,"context_line":"            \"perm\": \"0600\","},{"line_number":15,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":16,"context_line":"        },{% endfor%}{% endif %}{% if cinder_backend_ceph | bool %}"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph\","}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"95b95a6b_553fb9a8","line":15,"updated":"2024-09-25 15:29:10.000000000","message":"I don\u0027t think these files need to be optional? If they are specified in the list, they should also exist?","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8195645f6781714f37a3bf0c72f728e47d6eb034","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \"dest\": \"/etc/cinder/{{ file }}\","},{"line_number":13,"context_line":"            \"owner\": \"cinder\","},{"line_number":14,"context_line":"            \"perm\": \"0600\","},{"line_number":15,"context_line":"            \"optional\": {{ (not cinder_backend_huawei | bool) | string | lower }}"},{"line_number":16,"context_line":"        },{% endfor%}{% endif %}{% if cinder_backend_ceph | bool %}"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph\","}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"a23836bd_9fa494ed","line":15,"in_reply_to":"95b95a6b_553fb9a8","updated":"2024-09-25 18:45:44.000000000","message":"another one safecheck. if them doesn\u0027t exist its ok for cinder.","commit_id":"8dccbeee1f85c6f9584b451617aac736d0cdfaff"}]}